Commit graph

74 commits

Author SHA1 Message Date
Dipen Patel
1e7897dcaa Bug 1468225 - remove method nsICertificateDialogs.viewCert and its uses. r=Gijs,keeler
- Remove the viewCert method from nsICertificateDialogs
- Remove all associated C++ code
- Directly invoke UI window where it was previous called.
- Update tests

MozReview-Commit-ID: 9b62Go0DjE9

Differential Revision: https://phabricator.services.mozilla.com/D3358

--HG--
extra : moz-landing-system : lando
2018-08-22 17:38:33 +00:00
Dipen Patel
7641beb1f8 Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI.  This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates

MozReview-Commit-ID: Dzy6t2zYljL

--HG--
extra : rebase_source : 9c400bed3c9d29a186fc987c9bd0ffceb37bfd94
2018-07-13 11:48:55 -07:00
Andreea Pavel
d0f6470c17 Backed out changeset c235d6f86c22 (bug 1475647) for breaking firefox ui at testing/firefox-ui/tests/puppeteer/test_tabbar.py on a CLOSED TREE 2018-07-25 19:34:58 +03:00
Dipen Patel
8670057dd5 Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI.  This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates

MozReview-Commit-ID: Dzy6t2zYljL

--HG--
extra : rebase_source : fbfbcf7608efbfb35c9be4018ff0f4e70b2768d2
2018-07-13 11:48:55 -07:00
shindli
70ab23ecd2 Backed out changeset d126a6593e8f (bug 1475647) for mozmake.exe bustage on a CLOSED TREE 2018-07-24 02:55:53 +03:00
Dipen Patel
b0259a189f Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI.  This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates

MozReview-Commit-ID: Dzy6t2zYljL

--HG--
extra : rebase_source : b15f75e39d04c8485b4eb63416fd1f1e4175fafe
2018-07-13 11:48:55 -07:00
Johann Hofmann
4bf2617e6f Bug 1348223 - Part 3 - Show and clear all site data in page info (not just cookies). r=florian
This commit changes the way that the page info security section works
to not only consider cookies when answering the question "Is this website
storing information about me?".

The associated button used to open the cookie manager. We would like to
reduce the storage management UI surface (in the interest of having one
great central location for managing storage), so that button was replaced
with a simple "clear data" button that clears site data for all origins of
the base domain of the site.

Clearing for the entire range of that base domain is a trade off between
(implicit) user privacy and the risk that the user accidentally
deletes too much data. I prefer to choose increased privacy.

MozReview-Commit-ID: BUgxJHBeFcQ

--HG--
extra : rebase_source : f88772b2275c97d30480a626e23a9d1875339b2b
2018-03-22 17:26:52 +01:00
kanika
a481a5c2e9 Bug 1444901 - Simplify setText() function in security.js. r=prathiksha
MozReview-Commit-ID: HDKEz80aGCM

--HG--
extra : rebase_source : 234a54fa7d502443649e2792e06f0485af93b725
2018-03-18 00:46:58 +05:30
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Arjun Krishna Babu
554e1160ae Bug 1430060 - Hide Security tab in Page Info when you are on about: pages r=johannh
The contents in Security tab when you're in about: pages is useless or wrong.

MozReview-Commit-ID: Eq5tdKyvuho

--HG--
extra : rebase_source : 683f46ccb43030a4def1ca3c68b1ee732b9e085e
2018-02-13 09:38:55 -07:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Francesco Lodolo (:flod)
f69be29ece Bug 1195196 - Use proper plural form for number of visits in Page Info r=johannh
MozReview-Commit-ID: 4k17YyjjSac

--HG--
extra : rebase_source : 40337928398e8ba17450d15e05c7d5254cc09381
2018-01-21 08:39:17 +01:00
Ian Moody
1fee2c4e61 Bug 872910 - Remove obsolete mapIssuerOrganization function from Page Info security. r=johannh
MozReview-Commit-ID: AlEyIJwNhSy

--HG--
extra : rebase_source : cce8fa45ddbe6024e57b9dd43044d3eb4dcc148c
2017-12-05 23:48:37 +00:00
Mark Banner
f99ae4c2a9 Bug 1421376 - Change various instances of manually calling getService to use Services.jsm in browser/. r=mossop
MozReview-Commit-ID: FW3X2fkOwK2

--HG--
extra : rebase_source : f71e053e18017d675d4ea4d758e2552adcf5adc6
2017-11-28 19:21:33 +00:00
Valentin Gosu
1bd153659e Bug 1407720 - Merge nsICookieManager and nsICookieManager2 r=nwgh
MozReview-Commit-ID: HuzeeB43YZZ

--HG--
extra : rebase_source : 3924170ce50126dbbae7c97cae601b69d0ab95af
2017-10-31 13:02:28 +01:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Prathiksha
b4e18c04d9 Bug 1354297 - Certificate expiry date is displayed in the page info dialog. r=johannh
MozReview-Commit-ID: K0Rg6QMNNZ2

--HG--
extra : rebase_source : 120d51879bd75a201aa242db0c3fde1f14dae6cc
2017-07-18 13:44:44 +05:30
Mark Banner
1087fc1884 Bug 1352969 - Fix various ESLint no-undef issues in browser/base (no-undef is not enabled yet). r=mossop
MozReview-Commit-ID: BuTyJAfUoWR

--HG--
extra : rebase_source : 482bdc039362347f35aec9fd15e07a143dccb860
2017-02-22 17:02:59 +00:00
Jared Wein
a54eda04ca Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx

--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Florian Quèze
9d62681259 Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
Sergei Chernov
b3b80907d0 Bug 1320566 - Certificate Transparency - implement CT Policy. r=Dolske,keeler
MozReview-Commit-ID: LcMdKcgBStG

--HG--
extra : rebase_source : 38b2531e9abb8a84d32c437d13fab881f2c49f18
2017-01-09 08:22:28 +02:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Mark Banner
09ab00a94f Bug 1313998 - Turn on no-unused-vars for local variable scopes in browser/base/content. r=mossop
MozReview-Commit-ID: IyFGBotfd11

--HG--
extra : rebase_source : aa43e5aea9e7fd7223fc59e941ecdc067abdb48f
2016-10-31 10:33:38 +00:00
Sergei Chernov
8e3719b7e2 Bug 1305289 - Certificate Transparency - basic UI indicator; r=Dolske,keeler
MozReview-Commit-ID: b0SUW2WNJT

--HG--
extra : rebase_source : 2bfa8895246f862f3e49c0c9674a8e862137f8a6
2016-09-28 20:19:56 +03:00
Carsten "Tomcat" Book
401922b6ce Backed out changeset 1f6f908368e5 (bug 1305289) for gtest failures 2016-10-10 09:33:01 +02:00
Sergei Chernov
0449e02200 Bug 1305289 - Certificate Transparency - basic UI indicator; r=Dolske,keeler
MozReview-Commit-ID: b0SUW2WNJT

--HG--
extra : rebase_source : 893d9945de71004ccda3222782273ad953d8a598
2016-09-28 20:19:56 +03:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Jared Wein
871ed4e3ba Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
MozReview-Commit-ID: DYOmE6xwMJh

--HG--
extra : rebase_source : bc81b68ea5599fd1815dc34dac7106eef7044483
2016-08-03 18:54:59 -04:00
Onno Ekker
f1de083a08 Bug 1279953 - Ambiguous string usage for "not encrypted page". r=dolske
--HG--
extra : rebase_source : e6ea020d8b98e9bef2e895e5312edc47d839cc2c
2016-06-13 22:14:04 +02:00
Martin Thomson
103d3aba59 Bug 1250568 - Adding TLS 1.3 to nsISSLStatus, r=keeler
MozReview-Commit-ID: 4mLdtsdFoKN

--HG--
extra : rebase_source : 8526499c8765a14efeec22950372c738d8dc8b95
2016-04-04 16:21:19 -03:00
Dave Townsend
0a6414b898 Bug 1245649: Turn on no-trailing-spaces. r=Gijs
--HG--
extra : commitid : F2OWKTvXUO4
extra : rebase_source : ec68631342e0edc59d77b6bab1cdc975ad175327
2016-02-03 14:22:33 -08:00
Jimmy Wang
df7dcddd7e Bug 1040947 - Opening page info from a remote tab is sluggish. r=florian 2015-07-08 17:18:38 -04:00
Bernardo P. Rittmeyer
cd094ce9c9 Bug 1187529 - Factored viewPasswords function from pageinfo/security.js to LoginHelper.jsm. r=MattN
--HG--
extra : transplant_source : %EB%8A%C0%A9%F7%06%93%15%AD%8B%CA%DFv%7EP%08%8D%93%D1Q
2015-07-26 22:25:46 -07:00
Steven Englehardt
73079800c9 Bug 1153010 - Disambiguate error messages for mixed content and weak/broken cipher. r=keeler,tanvi,dolske 2015-07-08 09:04:11 +02:00
Mark Hammond
6aac9f7fb8 Bug 1144493 - wallpaper over enough cracks to make page info work with e10s. r=mconley 2015-05-04 17:38:38 +10:00
Masatoshi Kimura
35c856f796 Bug 1143082 - Fix a message in the mixed content UI. r=dolske 2015-03-17 20:34:58 +09:00
Masatoshi Kimura
c199c43026 Bug 1126413 - Part 2: UI changes to display security info on broken secure pages. r=dolske 2015-02-10 04:16:23 +09:00
Masatoshi Kimura
6a185fd3d7 Bug 1093595 - Change strings to add a description about weak encryption. r=dolske 2014-11-11 07:29:44 +09:00
Masatoshi Kimura
2b45a125ae Bug 947149 - Remove useless and even misleading word and dead code. r=keeler, dolske 2014-10-30 15:22:00 +01:00
Tom Schuster
0130a12af3 Bug 886752 - Show TLS/SSL version in page info dialog. r=dao 2014-10-24 13:53:35 +02:00
Jared Wein
7a1be70c02 Bug 1037049 - In-content preference subdialogs that contain a <resizer> need to have their <resizer> removed and passed in as a "resizable" window opening parameter. r=Gijs 2014-08-20 17:22:55 -04:00
David Keeler
235c61d9d1 bug 1029797 - remove redundant "Security information for this page" section of Page Info window r=dao 2014-06-24 14:31:06 -07:00