Commit graph

205 commits

Author SHA1 Message Date
Brian Grinstead
829d7647d3 Bug 1479538 - Rewrite non-test callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...);r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D3275

--HG--
extra : moz-landing-system : lando
2018-08-14 16:22:44 +00:00
Brian Grinstead
abf1620630 Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw

--HG--
extra : rebase_source : 186d805f7a2a56694dda9032aceac2dfe5424753
2018-08-08 15:22:53 -07:00
Boris Zbarsky
4abc5c5a25 Bug 1446940 part 2. Stop getting docshells from windows via getInterface in browser. r=gijs 2018-08-01 13:07:10 -04:00
Boris Zbarsky
270fa12c79 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Brian Grinstead
96dc530924 Bug 1476333 - Refer to AppConstants.BROWSER_CHROME_URL to get the browser URL from the frontend;r=Gijs
Before this change, we accessed the browser URL in the following ways:

- "chrome://browser/content/browser.xul"
- "chrome://browser/content/" (which redirects to chrome://browser/content/browser.xul)
- Services.prefs.getCharPref("browser.chromeURL") which returns "chrome://browser/content/"
- getBrowserURL() from utilityOverlay.js

MozReview-Commit-ID: I5vtRke1x9t

--HG--
extra : rebase_source : c525350a1954740873e85b045cbb14a8b43aa89d
2018-07-24 08:12:50 -07:00
Gijs Kruitbosch
b40ddc17c4 Bug 1438490 - move overflow/underflow event handling out of toolbar.xml, r=jaws
MozReview-Commit-ID: CwkCOIm9wNk

--HG--
extra : rebase_source : a746c9dc190e3309d9368083ce08c36f222a3407
2018-05-01 15:44:19 +01:00
Gijs Kruitbosch
9654bc99a1 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian
MozReview-Commit-ID: BFGRssWb9F

--HG--
extra : rebase_source : cf6011f2ecfe78df11a6741dfa074c7d985ec294
extra : source : 1ce48405e58a609299a84192df04d340cd90de63
2018-04-20 15:09:44 +01:00
Andreea Pavel
7abcd926f5 Backed out changeset 1ce48405e58a (bug 1447619) for creating bug 1457257 and bug 1457289 on a CLOSED TREE 2018-04-28 20:46:51 +03:00
Gijs Kruitbosch
39d0e25c38 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian
MozReview-Commit-ID: BFGRssWb9F

--HG--
extra : rebase_source : e8932810584e10a1de0c1b11c1a152d2dc0f48dd
2018-04-20 15:09:44 +01:00
Tim Nguyen
92c9a958e1 Bug 1372694 - Stop making the default theme a heavyweight theme. r=kmag,aswan
MozReview-Commit-ID: 30wMauuc9oo

--HG--
rename : browser/base/content/default-theme-icon.svg => toolkit/mozapps/extensions/content/default-theme-icon.svg
extra : rebase_source : 5e4cf784135f4a8e40a2ed8357ba651e7fce9728
2018-04-01 13:53:31 +02:00
Kris Maglione
33b62eabb7 Bug 1442187: Wait until next tick after popupshown before resolving show(). r=Gijs
With the migration of Promise microtasks to the main microtask queue, promise
resolution handlers are now called immediately after any JS event listener
returns. The result of this is that in the case of the show() method, the
resolution handlers now run before the view's own popupshown handlers run and
the view is set active, which breaks handlers which expect it to act more
sensibly.

By deferring the resolution until the next tick, the resolution handlers are
called when the view is visible and in a consistent state.

MozReview-Commit-ID: C7697CBoHFt

--HG--
extra : rebase_source : a9d89920a14cc7a7c14da70bb07b35625769041a
extra : amend_source : 9439650fdc13dee24bb34c9c09d09a66697de7b6
2018-03-01 18:31:14 -08:00
Mark Banner
ae8b52cc98 Bug 1442377 - Move fillSubviewFromMenuItems/clearSubview to CustomizableUI.jsm. r=Gijs
MozReview-Commit-ID: BQ8V39C68WO

--HG--
extra : rebase_source : e6937b10849b07940cfa9b1bb48807e7edd8131e
2018-03-01 19:53:07 +00:00
Paolo Amadini
d46beaba6f Bug 1441284 - Part 3 - Remove the "showingSubView" property. r=Gijs
The value "single" for the "closemenu" attribute on panel buttons is unused, so the only consumer of the "showingSubView" property can be removed.

MozReview-Commit-ID: 2jf5YE4Uyd

--HG--
extra : rebase_source : d1940fb7a470b42e0550c0e2876ad947d1c85d9d
2018-02-27 14:08:58 +00:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Paolo Amadini
d59df3cdd5 Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs
MozReview-Commit-ID: 3VzoxJ3Ociy

--HG--
extra : source : 22c83b1d417d7c7bd21a71109f4800f5d37bbb77
extra : intermediate-source : 6de7133c267288a468804f67f91df68b10b9793e
2018-02-06 09:02:27 +00:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Gijs Kruitbosch
6f12989f12 Bug 1426250 - allow changing log preference at runtime for CUI.jsm, r=jaws
MozReview-Commit-ID: 9kYBC27wowg

--HG--
extra : rebase_source : 014c898dff8b446cbaa87e1567b644a66dfe5b53
extra : histedit_source : 9e16d035a25f195c2e67278a4ecc7ff4fe07aaab
2018-01-05 21:31:53 +00:00
Tim Nguyen
e1b673bf04 Bug 1428938 - Remove legacy toolbar customization code. r=Gijs
MozReview-Commit-ID: 1ppfxI7yYJW

--HG--
extra : rebase_source : b4a2c44dd5e244c81e479e6b43e9669cc031f349
2018-01-11 16:35:17 +00:00
Gijs Kruitbosch
b260c43755 Bug 1424452 - stop having 2 different values for the 'panel' area type, r=jaws
MozReview-Commit-ID: 3spDhRhlOTF

--HG--
extra : rebase_source : c3d39c18ed645c8023da4488704ed186a405ffda
2017-12-09 12:37:20 +00:00
Paolo Amadini
166ddcece1 Bug 1414244 - Part 7 - Remove unused code paths from PanelMultiview.jsm. r=Gijs
MozReview-Commit-ID: 9cwaAZXqDGO

--HG--
extra : rebase_source : 90cf1a99c2ca1a64709abfa7383462480282ba0f
2017-11-23 15:18:14 +00:00
Paolo Amadini
fc23659e93 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs
MozReview-Commit-ID: IjvSZZUHUMt

--HG--
extra : rebase_source : a94e212e8af35b77806d1d62e020a511ab62e224
2017-11-21 14:21:32 +00:00
Gijs Kruitbosch
8c1b02e3d4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws
MozReview-Commit-ID: L017kRfHfOv

--HG--
extra : rebase_source : c9dcbb76d787281ac2dcf18c59786205aeaacaf9
2017-11-07 12:15:18 +00:00
Gijs Kruitbosch
d01a2b63d7 Bug 1388029 - remove notion of 'wide' widget and panel columns from the tree, r=jaws
MozReview-Commit-ID: IrCB3zn1BIT

--HG--
extra : rebase_source : efb192e8c82a4272078bd7754ef453113166b81c
2017-11-07 12:00:18 +00:00
Gijs Kruitbosch
f98c738db9 Bug 1388029 - remove useless param from PanelUI.showSubView, r=jaws
MozReview-Commit-ID: 9hkYtLxAOtQ

--HG--
extra : rebase_source : 76f0f2acb9c785e9497fccb493e5c158d9d35eb4
2017-11-07 11:54:47 +00:00
Gijs Kruitbosch
b8a8802972 Bug 1411011 - stop offering context menu (re)move options on skipintoolbarset items, r=jaws
Giving all these nodes ids doesn't seem like the right fix. `buildArea` already ignores skipintoolbarset
items before doing anything else with nodes, so bailing out early seemed like the right solution here.

MozReview-Commit-ID: H3EyqoospNR

--HG--
extra : rebase_source : 6dc06d18c82e2af5024be0aba271c270f7403839
2017-11-06 14:49:37 +00:00
Johann Hofmann
2807fe98d1 Bug 1410352 - Make the overflow menu adhere to touchmode sizing. r=nhnt11
MozReview-Commit-ID: JhMIp65wuaq

--HG--
extra : rebase_source : b786a695a954ef72eb08bf7ea5710fee7f3ead42
2017-10-25 13:07:46 +02:00
Sebastian Hengst
fabade716b Backed out changeset cc55d4e3d13d (bug 1410352) for eslint failure at browser/components/customizableui/CustomizableUI.jsm:4339: 'aEvent' is already declared in the upper scope. r=backout
--HG--
extra : rebase_source : 29fad97f166d57cc9b192874f0ec82ea8b6c044c
2017-10-25 16:53:27 +02:00
Johann Hofmann
ad3fb07012 Bug 1410352 - Make the overflow menu adhere to touchmode sizing. r=nhnt11
MozReview-Commit-ID: JhMIp65wuaq

--HG--
extra : rebase_source : f18647cf4631e489ef2787884d69b08ceabfee4d
2017-10-25 13:07:46 +02:00
Felipe Gomes
43ee76c5ed Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 2qNWebBpsMY

--HG--
extra : rebase_source : b30a4492f839186584c074b82a1969973cda48e0
2017-10-17 13:39:50 -02:00
Ryan VanderMeulen
e8cd5f653b Backed out 5 changesets (bug 1407351) for causing bug 1409395 and breaking nightlies.
Backed out changeset e6ee25ad6a9f (bug 1407351)
Backed out changeset 8e04412824b5 (bug 1407351)
Backed out changeset effeee94316e (bug 1407351)
Backed out changeset a53f34a45f9b (bug 1407351)
Backed out changeset 86a360e12b8a (bug 1407351)
2017-10-17 10:07:55 -04:00
Felipe Gomes
4346cedc0e Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 8wbjdYIC3gb

--HG--
extra : rebase_source : 2ea1b77d4a9fd9c3eb17853c8ec655b309a3fa8c
2017-10-16 14:00:30 -02:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Gijs Kruitbosch
d25b8d71e5 Bug 1406738 - do not set the 'overflowing' attribute if the overflow menu only contains 'special' widgets (like flexible spaces), r=jaws
MozReview-Commit-ID: 1C5XaTCIUKA

--HG--
extra : rebase_source : e8cbfd944c7085ef1a821e346c6ea022a3bb851b
2017-10-11 12:05:15 +01:00
Dão Gottwald
8fa6f14905 Bug 1406625 - Remove leftover code and styling for <toolbarbutton type="menu-button"> r=mikedeboer
MozReview-Commit-ID: 8wBsluIMZHq

--HG--
extra : rebase_source : 8733868d1afc6a34b6e9050b6bd80f01097a66f3
2017-10-07 20:10:24 +02:00
Sam Foster
f933fa62ca Bug 1395674 - Adding subviewbutton-nav class to menu-type toolbarbuttons and display the '>' in the overflow list. r=Gijs
MozReview-Commit-ID: I1pGXA3ecxT

--HG--
extra : rebase_source : ebfd4dbc2191a921ea04f0fcf56270ad945c3e37
2017-09-25 19:29:04 -07:00
Gijs Kruitbosch
bad4eae2ab Bug 1399517 - remove CustomizableUI placements for old buttons to avoid saved state corruption, r=mikedeboer
MozReview-Commit-ID: 3XKPuz9KwlD

--HG--
extra : rebase_source : d3f6bc2bbb815158c78909ed83a6f7f15c7b43c0
2017-09-18 17:34:50 +01:00
Gijs Kruitbosch
b7ec7b74c5 Bug 1399517 - CustomizableUI shouldn't try to insert items next to nodes that aren't in the right container, r=mikedeboer
MozReview-Commit-ID: H9KY7YQwmlQ

--HG--
extra : rebase_source : 75f92768868003280a8e187ce6f2bbc2b88dd8ca
2017-09-18 16:36:46 +01:00
Mike de Boer
4c850e0f21 Bug 1388180 - Update the overflow panel styling in Customize Mode and show the overflow button as in the opened state, but with a disabled looking icon. r=Gijs
MozReview-Commit-ID: 387PZ2jp1SS

--HG--
extra : rebase_source : 4b6e865d725d9aeb32b0de98b2cfdbb35d8f2349
2017-09-13 19:28:45 +02:00
Johann Hofmann
c90a0e9e12 Bug 1349552 - Part 2 - Add an extra drag space setting to customize mode. r=nhnt11
MozReview-Commit-ID: IWxdOeRwDeu

--HG--
extra : rebase_source : 953c988fdaab5a7bf64ecbdd363df846020063d9
2017-09-10 20:38:19 +02:00
Gijs Kruitbosch
3f3bcb5b73 Bug 1397447 - ensure the button is in the navbar by default, r=mak
MozReview-Commit-ID: H6r3dAEg4r1

--HG--
extra : rebase_source : fdb9b8d65745a57e3ac1ffa71cce10654032b177
2017-09-08 14:07:05 +01:00
Gijs Kruitbosch
ecf2be01ab Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : 11dc3f1b98f53f5897a3185253b68d2cf7d5083b
extra : source : 97f7f5175b2fc3adfb193783f7ecb70b5b9b4562
2017-09-08 14:16:36 +01:00
Kris Maglione
e3f6c844ae Bug 1391707: Follow-up: Skip idle in more places that incorrectly expect strict timing. r=me CLOSED TREE
MozReview-Commit-ID: BbMB5qk4F4e
2017-09-11 21:26:04 -07:00
Zibi Braniecki
70e0d2b8e8 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 5e58c418f91a1802328c4128dffd2c1ab9aa067f
2017-09-09 22:17:19 -07:00
Sebastian Hengst
a4b102b6d9 Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00