nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
610906 commits 1 branch 98 tags 6.4 GiB
Commit graph

186 commits

Author SHA1 Message Date
Gijs Kruitbosch
d9dae67b93 Bug 1402929 - try to make overflow panel in customize mode easier to understand, r=mikedeboer 
This moves the explanatory text from a pseudoelement to a real element,
and keeps only the image in a pseudoelement. It then uses a transitioned
opacity to fade that image in and out.

Because we need to fade this based on dragging items over the panel when
it's empty, it adds/removes a 'draggingover' attribute to handle the fade.

To cope with the extra element in the drag/drop container in customize mode,
this also makes the following changes:
- bail out of _onDragStart if there's no actual selected item.
- pick the fixed list in the panelHolder more reliably
- add a max-width to avoid the description making the panel wider

MozReview-Commit-ID: 9PEJSoJJ0Rp

--HG--
extra : rebase_source : 0a7865fcfd11eb5baca858cde71ea4e8b30d5afc
 2017-09-29 17:55:50 +01:00
Maya Messinger
530424bf98 Bug 1396953 - fix flexible space widget disappearing when adding to toolbar r=Gijs 
MozReview-Commit-ID: BuYzvBX439p

--HG--
extra : rebase_source : 2380bf5517da3982838e4c07dbc22a06c9f38465
 2017-09-30 18:42:24 -04:00
Gijs Kruitbosch
49c8b259d5 Bug 1396423 - make it possible to drop items in what visually looks like the palette but isn't, r=mikedeboer 
MozReview-Commit-ID: AqBwn9ovTjT

--HG--
extra : rebase_source : 58dd5d79db16d56be502f70cd7e533a4093f1c39
 2017-09-29 15:40:48 +01:00
Gijs Kruitbosch
f207243be7 Bug 1402981 - add light and dark themes to the list of themes in customize mode by default, r=jaws 
MozReview-Commit-ID: 4GxPEm119Yc

--HG--
extra : rebase_source : a1a6acf06e158fd937e6b53ea65cc91c2e4d02ce
 2017-09-27 22:37:19 +01:00
Erica Wright
a9e25e23df Bug 1401152 - Disable 'add to overflow menu' in the customize mode *palette* context menu for flexible space. r=Gijs 
MozReview-Commit-ID: 5sQPsxVaVYz

--HG--
extra : rebase_source : 6eab6e7e9d65bc0b45dea6dac7daf3cd23fc6c77
 2017-09-21 18:15:02 -04:00
Mike de Boer
ecca1af556 Bug 1388422 - Remove all traces of the Customize Mode tip panel that no longer applies. r=Gijs 
MozReview-Commit-ID: IffDnXEqooR

--HG--
extra : rebase_source : 04344421e5152c1f7ba8959698ba7cff57448e15
 2017-09-20 14:37:53 +02:00
Mike de Boer
c0b0c75c02 Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs 
MozReview-Commit-ID: 44Q9NbKEJeC

--HG--
extra : rebase_source : 4895a170b403195cd1bc7023fc905deff12c2de2
 2017-09-20 14:25:58 +02:00
Gijs Kruitbosch
088853fcdf Bug 1399935 - use horizontal panel for downloads checkbox panel at all times, r=mak 
Rather than using left-hand-side at all times (which can go over the edge of the window
in some cases) this uses left or right-hand-side panels, always opening towards the
center of the window.

MozReview-Commit-ID: EvjDmKR1G5A

--HG--
extra : rebase_source : 12046edc24b564e035dff68a5e34bce3ff5fd507
 2017-09-17 23:31:06 +01:00
Gijs Kruitbosch
27050c2c34 Bug 1399486 - show downloads auto hide panel after changing the pref instead of before, r=mak 
Note that we will no longer show the panel if you use the context menu to move the item in one
window and have customize mode open in the other. I don't think that edgecase matters.

MozReview-Commit-ID: 3dzGr3cs2oQ

--HG--
extra : rebase_source : cc5f528557e35e48b0bc06e58b92fdcb7ecfa6fe
 2017-09-17 18:09:35 +01:00
Johann Hofmann
c90a0e9e12 Bug 1349552 - Part 2 - Add an extra drag space setting to customize mode. r=nhnt11 
MozReview-Commit-ID: IWxdOeRwDeu

--HG--
extra : rebase_source : 953c988fdaab5a7bf64ecbdd363df846020063d9
 2017-09-10 20:38:19 +02:00
Gijs Kruitbosch
c3acd03b82 Bug 1397447 - add UI and automatic toggles to make the auto-hide functionality more seamless, r=mak 
MozReview-Commit-ID: 9xN3N4aLwfv

--HG--
extra : rebase_source : 54333982cce1dcb7cb84331734f170d4d79fbc29
 2017-09-11 18:54:48 +01:00
Jared Wein
6c68f6b603 Bug 1387313 - Allow dragging non-removable items (url bar, back/forward buttons) within their toolbar. r=Gijs 
MozReview-Commit-ID: 1EQxMcLJn9J

--HG--
extra : rebase_source : 884ddb84896bec96b4cc05d2d067e8e3a69603c7
 2017-08-21 14:20:40 -04:00
Gijs Kruitbosch
163ee80617 Bug 1390260 - make customize mode work in popup windows, r=mkaply 
MozReview-Commit-ID: 7lokGRuqNHv

--HG--
extra : rebase_source : 0015e3c60e97f117ddf3a72410f455e648a1138e
 2017-08-15 12:02:11 +01:00
Sebastian Hengst
ad97051e47 Backed out changeset fb0d8aeff611 (bug 1390260) for failing mochitest browser_bug422590.js. r=backout 2017-08-15 17:13:15 +02:00
Gijs Kruitbosch
426e66c658 Bug 1390260 - make customize mode work in popup windows, r=mkaply 
MozReview-Commit-ID: 7lokGRuqNHv

--HG--
extra : rebase_source : 0015e3c60e97f117ddf3a72410f455e648a1138e
 2017-08-15 12:02:11 +01:00
Gijs Kruitbosch
6ff153a8b2 Bug 1388990 - avoid breaking the broadcast/listener relationships of the back/fwd buttons when customizing, r=dao 
MozReview-Commit-ID: EsH3lv8QXfJ

--HG--
extra : rebase_source : 20325d2b014abf9687c83eae3cda267eeda078eb
 2017-08-12 11:56:22 +01:00
Gijs Kruitbosch
b584e361b6 Bug 1381556 - adjust panel widths to accommodate longer/wider content, r=mikedeboer 
MozReview-Commit-ID: 6bOoRIfttEy

--HG--
extra : rebase_source : d7748809abe4ee617d0cb1a9d66a3e88728ecc63
 2017-08-09 14:04:21 +01:00
Michael Kohler
674e1b96fb Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao 
MozReview-Commit-ID: 8w1vfF2yRui

--HG--
extra : rebase_source : 222d8e9d3b9543552ff5b08967375fa46d62b896
 2017-08-08 12:09:14 +02:00
Jared Wein
76f886b972 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs 
MozReview-Commit-ID: 40TP43EKPCU

--HG--
extra : rebase_source : 203f7449e8345ed5c779dfc4fd5e9bd515b89da8
 2017-08-07 12:37:34 -04:00
Gijs Kruitbosch
31718d41ae Bug 1387182 - fix border (empty space) compensation when dragging items in customize mode in RTL, r=jaws 
MozReview-Commit-ID: AblsJGmu5zm

--HG--
extra : rebase_source : 96b595132989f4cb43986430094864289debeac1
 2017-08-07 12:14:19 +01:00
Sebastian Hengst
ca40024d84 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
45d5f35624 Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao 
MozReview-Commit-ID: CoHv9mKpAe

--HG--
extra : rebase_source : 20d6404db9f90cfcb7de03d4c527ad6ed79d49f8
 2017-08-05 20:37:40 +02:00
Dão Gottwald
ee6b05b899 Bug 1387602 - Update customize mode favicon. r=Gijs 
MozReview-Commit-ID: 7gin0zuJTN0

--HG--
extra : rebase_source : 7b1d2394e32f4ed5763bc9562a6e7e87bdbf2c74
 2017-08-04 23:00:00 +02:00
Gijs Kruitbosch
f1b0d2d8c3 Bug 1354117 - remove old panel code from customize mode and update related CSS, r=jaws 
MozReview-Commit-ID: IwKUWMTagCK

--HG--
extra : rebase_source : e6c54f3b5d6115574f22f31380a4a07601776d1c
 2017-08-02 11:51:58 +01:00
Rajesh Kathiriya
48e6bc2124 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
 2017-07-25 23:45:41 +05:30
Jared Wein
18b59c778a Bug 1383689 - Remove uninterruptible reflow at setToolbarButtonHeightProperty@resource://gre/modules/BrowserUtils.jsm. r=Gijs 
MozReview-Commit-ID: 9WoXQ1nMWTZ

--HG--
extra : rebase_source : cdee661cd33d0aa06aceda7fa3a37b0c78ee3123
 2017-08-01 15:33:01 -04:00
Sebastian Hengst
804a36e668 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
22dfa54ef4 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
 2017-07-25 23:45:41 +05:30
Jared Wein
1e2bf53f24 Bug 1381991 - Pin to Overflow animation is placed in the wrong position when using a non-default font-size. r=sfoster 
MozReview-Commit-ID: ERE1FnTuIWF

--HG--
extra : rebase_source : 7ab56c4ccaf12a1ce72801197414013bc0e70ead
 2017-07-20 12:31:06 -04:00
Dão Gottwald
2ee97c338a Bug 1383031 - Rename customization-uidensity-menu-button* classes and ids since these are menuitems. r=johannh 
MozReview-Commit-ID: 72S5zENy1gX

--HG--
extra : rebase_source : bdecd5c216638da9e83787150cffa970ae8da059
 2017-07-21 14:11:15 +02:00
Wes Kocher
6dbec35ae2 Backed out changeset 320f9642bcef (bug 1381991) because it blocks backing out 1355922 a=backout 
MozReview-Commit-ID: 7gM0DJkbVwW
 2017-07-21 00:36:04 -07:00
Jared Wein
78ddbc6ee8 Bug 1381991 - Pin to Overflow animation is placed in the wrong position when using a non-default font-size. r=sfoster 
MozReview-Commit-ID: ERE1FnTuIWF

--HG--
extra : rebase_source : 7ab56c4ccaf12a1ce72801197414013bc0e70ead
 2017-07-20 12:31:06 -04:00
Jared Wein
716e6429c4 Bug 1380815 - Fade overflow menu icon to grey after item is pinned. r=sfoster 
MozReview-Commit-ID: 2LQrWDxrTny

--HG--
extra : rebase_source : 6e0ccf341e84970d7897b2d27c23e0ea7a7361bf
 2017-07-20 10:53:45 -04:00
Gijs Kruitbosch
8e183f6784 Bug 1366813 - add a flexible space item in customize mode in photon, r=mossop 
MozReview-Commit-ID: 4k4VdBa4HCt
 2017-07-11 13:13:35 -07:00
Wes Kocher
e06435f389 Backed out changeset 051284a3564e (bug 1366813) for apparently causing autophone tests to frequently fail a=backout 
MozReview-Commit-ID: 9GUFY9VAGW3

--HG--
extra : rebase_source : 84e593e1870b9ad3559487371d0c692d63e3ad6e
 2017-07-11 12:39:26 -07:00
Gijs Kruitbosch
8681f1b118 Bug 1366813 - add a flexible space item in customize mode in photon, r=mossop 
MozReview-Commit-ID: 4k4VdBa4HCt

--HG--
extra : rebase_source : 320c57ea37c94eecf01db9220f473a256ce5ac87
 2017-07-10 23:34:12 +01:00
Gijs Kruitbosch
4a1523e31c Bug 1378427 - move context menus around, fix flickering in dynamic portion of the overflow menu for photon, r=jaws 
Apparently the hover state of the combined buttons does not interact well with the menus unless they
share the same containing popup/panel. We broke that condition in bug 1354078. The expedient thing
is to simply move the popup back, and move it back and forth if/when the photon pref is flipped.
When removing the pref, we can simplify this by always putting the menu in the overflow panel.

I also noticed that we use the toolbar context menu in the dynamic portion of the overflow panel.
This has the same problem, and to fix it I switched us to using the same (panel) context menu in
the photon case. Doing this in the non-photon case won't help because the context menu will be in
a separate panel (namely the old hamburger panel) entirely.

MozReview-Commit-ID: 4neHMukTzHA

--HG--
extra : rebase_source : e9f18996383eb7e249dc17b0dc1a84bb6ce3f11d
 2017-07-07 15:54:13 +01:00
Carsten "Tomcat" Book
8e3fa527c9 merge mozilla-inbound to mozilla-central a=merge 2017-07-04 10:48:33 +02:00
Frederik Braun
56838ddb04 Bug 1351608 - Disable warnings for existing violations to no-unsanitize rule r=Standard8. 
MozReview-Commit-ID: 7cTNL5jMtRw
 2017-07-03 20:07:02 +01:00
Jared Wein
9b5a5d0a20 Bug 1375152 - Implement animation for pinning items to the overflow menu. r=dao 
This animation can be disabled if the toolkit.cosmeticAnimations.enabled pref is set to false.

MozReview-Commit-ID: DtsrI8YflYn

--HG--
extra : rebase_source : 066dc736dc75489bf6ad787811d4ae34f03ed24f
 2017-06-28 15:32:34 -07:00
Johann Hofmann
e57999a689 Bug 1350210 - Part 1 - Add UI density settings to customize mode. r=jaws 
MozReview-Commit-ID: C0g6aFPW2pX

--HG--
extra : rebase_source : 9802bba188043c04796cf13e0741396ec1447a8d
 2017-06-27 18:50:34 +02:00
Gijs Kruitbosch
4733223aad Bug 1354123 - remove customize mode transition, r=jaws 
MozReview-Commit-ID: 7j9HWxci7oB

--HG--
extra : rebase_source : 75cbd832c8e0c8138457c47d1c8fff73c8cb3f56
 2017-06-28 13:17:46 +01:00
Gijs Kruitbosch
cab2177430 Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws 
MozReview-Commit-ID: GhQoSgPXL9q

--HG--
extra : rebase_source : 8c552cf17c081e5988bea46aa207e8578cd93273
 2017-06-28 16:55:44 +01:00
Carsten "Tomcat" Book
25f9160fc3 Backed out changeset cbf0368eea83 (bug 1373016) for unused whitelist entry: chrome://browser/skin/customizableui/customize-illustration-rtl@2x.png - 2017-06-29 16:21:39 +02:00
Gijs Kruitbosch
dba5fdab48 Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws 
MozReview-Commit-ID: GhQoSgPXL9q

--HG--
extra : rebase_source : acc57eb6347a5017077358e84c5803719f3331ef
 2017-06-28 16:55:44 +01:00
Carsten "Tomcat" Book
20d1412289 Backed out changeset 5de26737d215 (bug 1373016) for failure like missing chrome://browser/skin/customizableui/info-icon-customizeTip@2x.png referenced from chrome://browser/skin/browser.css 2017-06-29 13:36:16 +02:00
Gijs Kruitbosch
319029e2fd Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws 
MozReview-Commit-ID: GhQoSgPXL9q

--HG--
extra : rebase_source : 0041e8c8c58d67d887bd77789936a5d79f750675
 2017-06-28 16:55:44 +01:00
Carsten "Tomcat" Book
c611ab2870 Backed out changeset bdcdd4d23c77 (bug 1373016) for bustage 2017-06-29 12:34:23 +02:00
Gijs Kruitbosch
5074857da8 Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws 
MozReview-Commit-ID: GhQoSgPXL9q

--HG--
extra : rebase_source : 69e18f84fd97a47c17d0a259efc5a59d5f7868f1
 2017-06-28 16:55:44 +01:00
Gijs Kruitbosch
5ad2e194d6 Bug 1354145 - Make customize mode deal with drops in the padding around the panel contents, r=mikedeboer 
MozReview-Commit-ID: BCi7odA3sth

--HG--
extra : rebase_source : 48bb1784fe745236d3ad55f833e64c19cadf68aa
 2017-06-28 23:46:15 +01:00
Gijs Kruitbosch
ba15653cdf Bug 1374691 - don't instantiate the panelmultiview and panelview bindings until necessary, r=florian,mconley 
MozReview-Commit-ID: L0P1eKxRf3A

--HG--
extra : rebase_source : dc37f06c10b5723bc929179042e7bc4f9d663f21
 2017-06-22 09:11:45 +01:00
Florian Quèze
721c3ada5e Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Paolo Amadini
10ee6a5c4e Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian 
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P

--HG--
extra : rebase_source : 3a9ea310d3e4a8642aabbc10636c04bfe2e77070
 2017-06-19 11:32:37 +01:00
Christoph Kerschbaumer
0944826c8a Bug 1363975 - Have loadOneTab() provide the correct triggeringPrincipal. r=gijs,smaug 2017-05-31 20:59:02 +02:00
Gijs Kruitbosch
811cf5dfec Bug 1354078 - update panel/toolbar context menus to move items to the right place, with tests, r=bgrins 
MozReview-Commit-ID: DpQdvE25iqU

--HG--
rename : browser/components/customizableui/test/browser_880164_customization_context_menus.js => browser/components/customizableui/test/browser_photon_customization_context_menus.js
extra : rebase_source : 740c8f47381bd9f15e62345502871db0d098c927
 2017-05-27 12:48:36 +01:00
Ryan VanderMeulen
e239c7252a Backed out changesets 7be34fd75378 and a2edd07d05dd (bug 1354078) for browser_photon_customization_context_menus.js failures on a CLOSED TREE. 2017-05-26 13:29:10 -04:00
Gijs Kruitbosch
7c9780088e Bug 1354078 - update panel/toolbar context menus to move items to the right place, with tests, r=bgrins 
MozReview-Commit-ID: DpQdvE25iqU

--HG--
rename : browser/components/customizableui/test/browser_880164_customization_context_menus.js => browser/components/customizableui/test/browser_photon_customization_context_menus.js
extra : rebase_source : e5722a5d3380f9a9e9f36a65475012dba6bd142b
 2017-05-19 17:27:11 +01:00
Gijs Kruitbosch
cf42b18d7b Bug 1354126 - use checkbox for titlebar toggle in customize mode, r=mikedeboer 
MozReview-Commit-ID: 9bdf8uAlWCM

--HG--
extra : rebase_source : 947a7f9a37c4505cc0840d15dd96570bd3d70e4c
 2017-05-22 11:17:11 +01:00
Gijs Kruitbosch
4a7dfbc320 Bug 1354126 - allow footer to wrap underneath the panel and add a 'done' button, r=mikedeboer 
MozReview-Commit-ID: 1LbwmhfGp49

--HG--
extra : rebase_source : ebab4a6ae5550ff512f3e2cf2c1e7f9be3c8ef7a
 2017-05-22 19:34:04 +01:00
Gijs Kruitbosch
693fc8a6f8 Bug 1365294 - swap position of the fixed overflow list, r=mikedeboer 
MozReview-Commit-ID: 9LlTxRLuOkx

--HG--
extra : rebase_source : bc97a85cf5e2f1f8bc10cc5e5e8883875490c2de
 2017-05-17 15:05:36 +01:00
Florian Quèze
1d0e28a791 Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
16530fa1e3 Bug 1353542 - smaller script-generated patch converting remaining generators that are likely tasks (actual generators were identified by hand and whitelisted), r=Mossop. 2017-05-12 14:45:01 +02:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Gijs
dec20c821e Bug 1354094 - show the overflow button when there are items in the permanent overflow menu, r=mikedeboer 
This also disables the menu button and overflow button correctly in
customize mode, and fixes an issues where the overflow button state
would stay 'open' when closing the panel by clicking the button
a second time.

MozReview-Commit-ID: BNTkE6zvv9Q

--HG--
extra : rebase_source : caa6ca5376c0b0e6c5d3190ffaed0b34e5292fb4
 2017-05-10 12:36:05 -04:00
Gijs Kruitbosch
b2a18e6463 Bug 1354082 - part 2: make overflow panel show up in customize mode and make dragging work correctly, r=mikedeboer 
This reuses the logic we have for toolbar dragging and uses it for the photon panel (ie overflow panel)
to do vertical space-making animations.

It explicitly doesn't address the styling or permanently showing the overflow button (for which we have other bugs on file).


MozReview-Commit-ID: 4qrWC0H30xi

--HG--
extra : rebase_source : 57c413620aff496069b8cf371b8980a1fa432d72
extra : histedit_source : 60f65f3cb81ba0c64553bdac4dc502a6a704be90
 2017-05-05 19:26:55 +01:00
Florian Queze
4b1556a5f2 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Florian Queze
4c6a68d1c9 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
159215e6f4 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
a363fb8c8b Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Mike Conley
e7aad715c1 Bug 1347514 - Tear down customize mode in a background tab if the users sends it to a different page. r=dao 
MozReview-Commit-ID: HQ39mwAhQjS

--HG--
extra : rebase_source : e1546482c4081bc50a621b6daacd8c84b2166a64
 2017-03-20 11:08:48 -04:00
Florian Quèze
9c4d40bb54 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Florian Quèze
37bbced84d Bug 1344711 - hand cleanup of remaining useless try blocks around get*Pref calls identified by eslint, r=jaws. 
--HG--
extra : rebase_source : 18c027010838faba91f0ac699f9bde07f85500e7
 2017-03-07 15:29:48 +01:00
Florian Quèze
cd762cc83c Bug 1344711 - script-generated patch to remove try blocks around get*Pref calls, r=jaws. 
--HG--
extra : rebase_source : c6e20e6e79b0ca5de751c52712d96cbea9432d26
 2017-03-07 15:29:48 +01:00
Jared Wein
dcc9efeeac Bug 864562 - Fix the tests and move more logic from JS to CSS now that the values exist as CSS Variables. r=mikedeboer 
MozReview-Commit-ID: BuJdjtVBnin

--HG--
extra : rebase_source : 47d244f3fa2e4f8768ce803201f238f456b22ecb
 2017-02-28 12:15:04 -05:00
Jared Wein
4dad3da594 Bug 864562 - CustomizeMode should use CSS variables for setting LWT properties. r=mikedeboer 
MozReview-Commit-ID: 5ZLJ0HNbJ9w

--HG--
extra : rebase_source : 22a26649053f10c5a854d45c198e74f2c844d7fe
 2017-02-22 15:50:41 -05:00
Sebastian Hengst
249cf37b55 Backed out changeset 028a63d5008c (bug 864562) 2017-02-23 19:33:26 +01:00
Jared Wein
df85eed31c Bug 864562 - CustomizeMode should use CSS variables for setting LWT properties. r=mikedeboer 
MozReview-Commit-ID: 5ZLJ0HNbJ9w

--HG--
extra : rebase_source : c6cf32963087b3234cc4150933b1b63b7078d1b3
 2017-02-22 15:50:41 -05:00
Florian Quèze
be4dbae285 Bug 1334199 - script-generated patch to omit getComputedStyle's second argument when it's falsy, r=jaws. 2017-01-27 10:51:02 +01:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs 
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
 2017-01-17 09:48:17 -06:00
Florian Quèze
a03918c148 Bug 1330147 - automatic removal of the third boolean parameter in removeObserver calls, r=jaws. 2017-01-11 22:27:42 +01:00
Jared Wein
4b9f2e1317 Bug 1327560 - Always place the current lwtheme at the beginning of the list of recent lightweight themes to prevent it from getting truncated out. r=Gijs 
MozReview-Commit-ID: b3O3MnpmjG

--HG--
extra : rebase_source : dc68305743ca8076a7e67c18ef2bf78749a4357d
 2017-01-03 17:24:49 -05:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
 2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
 2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
 2016-12-29 15:20:47 -05:00
Jared Wein
3718f00db1 Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Mark Banner
a41b5adcb0 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop 
MozReview-Commit-ID: LdoXLniNeT7

--HG--
extra : rebase_source : d2418b8cfab0a399d0dfb5a96ea50c62fac63e70
 2016-11-03 11:51:48 +00:00
Jared Wein
5040f17e00 Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8 
MozReview-Commit-ID: 7Gx90a5y8t6

--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
 2016-10-24 13:14:19 -04:00
Dão Gottwald
3af5386475 Bug 1306584 - In customize mode, properly update the lightweight theme button icon and Restore Defaults button disabled state when selecting a theme. r=jaws 
--HG--
extra : rebase_source : 24367bea6839a72f15733b8593959e34571db672
 2016-10-06 18:45:29 +02:00
Dão Gottwald
1e2a857cff Bug 1306264 - Move chrome://browser/skin/theme-switcher-icon.png reference from CustomizeMode.jsm to theme code. r=jaws 2016-09-30 09:39:27 +02:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh 
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
 2016-08-04 03:28:58 -04:00
Pushpankar
c6670d980f Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao 
--HG--
extra : rebase_source : 72d50e73baf595840a2aade57ae782e4c40d4c27
 2016-07-16 10:20:04 +02:00
Katie Broida
1bcaca5643 Bug 1061747 - Restore Defaults should reset the current theme. r=jaws 
MozReview-Commit-ID: CRmJiOE4uYr

--HG--
extra : rebase_source : 520efbba8120084731c568c6654252ad9a80e553
 2016-05-24 13:06:25 -04:00
Jared Wein
2113b87b76 Bug 1260596 - Themes panel is empty when all default-shipped lightweight themes (lwts) are removed. r=gijs 
MozReview-Commit-ID: L1s3yxoxU33

--HG--
extra : transplant_source : %8E%90%E9%A8%00%0E%AD%0FA%9C%A5g_%A8%01M%E6/qk
 2016-05-18 11:36:14 -04:00
Katie Broida
3a08f86d74 Bug 1260595 - Clear the lightweight themes menu in popupshowing instead of popuphidden to prevent duplicates in certain scenarios. r=jaws 2016-05-10 08:49:00 -04:00
Katie Broida
6b12bb7807 Bug 1093750 - Add tooltips to icons in Customize mode. r=jaws 
MozReview-Commit-ID: HYgprjtoOcE

--HG--
extra : transplant_source : H%E5%BF%92F%7D%E2%D3%99r%18%F6%8D%D8%3A%D8y%92N%D1
 2016-05-02 11:33:07 -04:00
Gijs Kruitbosch
aed31c4eac Backed out changeset c7544b24989d (bug 1260595) for perma-oranging browser_1007336_lwthemes_in_customize_mode.js on linux with crashes 
MozReview-Commit-ID: 2GqsGs7yw9u

--HG--
extra : amend_source : 29201a5534618adc9900d74628cba31934a24430
 2016-04-22 11:31:58 +01:00