Commit graph

830 commits

Author SHA1 Message Date
Kris Maglione
80327d3561 Bug 1484496: Part 5a - Convert browser/ nsISimpleEnumerator users to use JS iteration. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3729

--HG--
extra : rebase_source : e187b8e9a6b6db7ebc762adda5e489b25c7a7e43
extra : histedit_source : 868cb99d09954a51d6be321fcb516475ef70eb33
2018-08-18 19:27:33 -07:00
Kris Maglione
2dee0aae3c Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj
This allows JS callers to automatically get the correct types during
interation, without having to explicitly specify them.

Differential Revision: https://phabricator.services.mozilla.com/D3728

--HG--
extra : rebase_source : b708f382d8ea571d199c669bfed5b5a7ca9ffac4
extra : histedit_source : 7df6feb82088c8a5ca45dc28fe4d2b852c177fee
2018-08-18 21:06:32 -07:00
Kris Maglione
65c28aa0ad Bug 1484496: Part 2 - Add common base class for all nsISimpleEnumerator implementations. r=froydnj
In order to allow JS callers to use nsISimpleEnumerator instances with the JS
iteration protocol, we'll need to additional methods to every instance. Since
we currently have a large number of unrelated implementations, it would be
best if they could share the same implementation for the JS portion of the
protocol.

This patch adds a stub nsSimpleEnumerator base class, and updates all existing
implementations to inherit from it. A follow-up will add a new base interface
to this class, and implement the additional functionality required for JS
iteration.

Differential Revision: https://phabricator.services.mozilla.com/D3725

--HG--
extra : rebase_source : ad66d7b266856d5a750c772e4710679fab9434b1
extra : histedit_source : a83ebffbf2f0b191ba7de9007f73def6b9a955b8
2018-08-18 14:22:47 -07:00
Jonathan Kingston
2f0987a202 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb r?=gijs
Summary: Depends on D2046

Reviewers: ckerschb!, Gijs!

Tags: #secure-revision

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : source : 33884d05cc94463950b31fab1fd2f37ada9becef
extra : intermediate-source : 72471adb75d5ec3dc2b0c8f972a6f1f26bfd3ae2
extra : histedit_source : f384cbab58401575afc3443c9a431b73cff806d4
2018-07-06 21:16:29 +01:00
dvarga
12f19b94e9 Backed out 2 changesets (bug 1362034) for failure at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE
Backed out changeset 1c3329958b8a (bug 1362034)
Backed out changeset f68b1b76af36 (bug 1362034)

--HG--
extra : histedit_source : 6169c5ffe856266d3bc8b2ca32f4b67054c71bbe
2018-08-08 22:11:56 +03:00
Jonathan Kingston
c15f69d427 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : rebase_source : ccded0f06a0dc4567b827f42ee29f4b8954154fe
extra : amend_source : 94da8ecc053e56958fa4137d7e497362fa2c11f1
2018-08-08 20:05:30 +03:00
Andreea Pavel
f5c1119983 Backed out 2 changesets (bug 1362034) for failing damp | inspector/cold-open.js on a CLOSED TREE
Backed out changeset 8c8925b75aa2 (bug 1362034)
Backed out changeset ff6b05c96094 (bug 1362034)
2018-08-06 20:42:44 +03:00
Jonathan Kingston
4ca581ffed Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : rebase_source : 4bb9e7feb0704239756e6e38623c0fea81669f7b
extra : amend_source : 9417f96547735fbdc55ea23666327a5cb86ac92f
2018-08-06 19:56:37 +03:00
Gijs Kruitbosch
fa65d99910 Bug 1434281 - also delete local/cache profile directory from refresh test, r=whimboo
Ensure local profile directory is also deleted in test teardown.

Differential Revision: https://phabricator.services.mozilla.com/D2671

--HG--
extra : moz-landing-system : lando
2018-08-02 18:54:28 +00:00
Mark Banner
8d235f8e45 Bug 1478305 - Remove unnecessary imports and fix ESLint warnings about unused variables for browser/. r=jaws
MozReview-Commit-ID: 1vHR6ixePkN

--HG--
extra : rebase_source : 8f9a322d1ff075ab56b81f8710df5d841839865b
2018-07-30 10:27:36 +01:00
Mark Banner
6feaa5a9c3 Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer
MozReview-Commit-ID: BYTDdLU2HoM

--HG--
extra : rebase_source : 1e31ff288280d09ae226cdc698331263ba969205
2018-07-25 09:10:07 +01:00
Narcis Beleuzu
d47c829065 Backed out 4 changesets (bug 1478308) for ESlint failure on AttributionCode.jsm. CLOSED TREE
Backed out changeset a809b45ff49b (bug 1478308)
Backed out changeset c68131530742 (bug 1478308)
Backed out changeset 0e4ba7a6dc1a (bug 1478308)
Backed out changeset 32a27f317a77 (bug 1478308)
2018-07-26 11:13:28 +03:00
Mark Banner
180233c593 Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer
MozReview-Commit-ID: BYTDdLU2HoM

--HG--
extra : rebase_source : 67dc15c0cdff0234d3274f1a8978d1f2a5b3f411
2018-07-25 09:10:07 +01:00
Brian Grinstead
96dc530924 Bug 1476333 - Refer to AppConstants.BROWSER_CHROME_URL to get the browser URL from the frontend;r=Gijs
Before this change, we accessed the browser URL in the following ways:

- "chrome://browser/content/browser.xul"
- "chrome://browser/content/" (which redirects to chrome://browser/content/browser.xul)
- Services.prefs.getCharPref("browser.chromeURL") which returns "chrome://browser/content/"
- getBrowserURL() from utilityOverlay.js

MozReview-Commit-ID: I5vtRke1x9t

--HG--
extra : rebase_source : c525350a1954740873e85b045cbb14a8b43aa89d
2018-07-24 08:12:50 -07:00
Brian Grinstead
8ceaae11ca Bug 1476030 - Part 1 - Expose xulStore through Services;r=Gijs
This lets us use Services.xulStore instead of requiring
Cc["@mozilla.org/xul/xulstore;1"].getService(Ci.nsIXULStore);

MozReview-Commit-ID: 2eXifCPhlGs

--HG--
extra : rebase_source : c65b9395cc192d05d1a348cfbf92f7f59d41dc8f
2018-07-18 09:43:38 -07:00
Venkatesh Pitta
514d9d09b5 Bug 1452490 - Remove marionetteScriptFinished. r=whimboo
MozReview-Commit-ID: CdQCmtaodww

--HG--
extra : rebase_source : a950bc89194a866c4fa27fded1d2aed707ee750f
2018-07-08 14:52:49 +10:00
Doug Thayer
c4f5b4ecdb Bug 1340498 - Update onVisits tests to use 'page-visited' r=mak
MozReview-Commit-ID: FxC3gcUF9hl

--HG--
extra : rebase_source : 126587e26e6625dee53a7e40d8a9d5bdf426978a
2018-02-14 09:17:41 -08:00
Dorel Luca
d296624690 Backed out 5 changesets (bug 1340498) for build bustage due to conflicts with bug 1470325. a=backout
Backed out changeset 28bedb658af4 (bug 1340498)
Backed out changeset f950a2310e26 (bug 1340498)
Backed out changeset 5fcd31c65fe0 (bug 1340498)
Backed out changeset 515bb5e24dd7 (bug 1340498)
Backed out changeset 79a8619bd3e2 (bug 1340498)
2018-06-27 14:05:20 +03:00
Doug Thayer
f111638b21 Bug 1340498 - Update onVisits tests to use 'page-visited' r=mak
MozReview-Commit-ID: FxC3gcUF9hl

--HG--
extra : rebase_source : 98df93506a64113d09cfd0926257dbf5f84720b5
2018-02-14 09:17:41 -08:00
Bogdan Tara
d2fb3a8812 Backed out 5 changesets (bug 1340498) for build bustages on nsDOMCSSAttrDeclaration.h CLOSED TREE
Backed out changeset 9ebcdb66ceff (bug 1340498)
Backed out changeset 63321093bb70 (bug 1340498)
Backed out changeset f8c799971f81 (bug 1340498)
Backed out changeset 21d8c1fbbbd1 (bug 1340498)
Backed out changeset fa40c179eb0d (bug 1340498)
2018-06-26 21:31:09 +03:00
Doug Thayer
421ce10d38 Bug 1340498 - Update onVisits tests to use 'page-visited' r=mak
MozReview-Commit-ID: FxC3gcUF9hl

--HG--
extra : rebase_source : eeb3a99e07e3e5a39d716760cd26795f28f9a74b
2018-02-14 09:17:41 -08:00
arthur.iakab
fc7e217166 Backed out 5 changesets (bug 1340498) for build bustages on SelectionChangeListener.h on a CLOSED TREE
Backed out changeset c89b86622d38 (bug 1340498)
Backed out changeset b270d4a01986 (bug 1340498)
Backed out changeset 8ed32495b46f (bug 1340498)
Backed out changeset df9a67c58183 (bug 1340498)
Backed out changeset a5977e0708ea (bug 1340498)
2018-06-26 07:59:01 +03:00
Doug Thayer
763d6c428f Bug 1340498 - Update onVisits tests to use 'page-visited' r=mak
MozReview-Commit-ID: FxC3gcUF9hl

--HG--
extra : rebase_source : eeb3a99e07e3e5a39d716760cd26795f28f9a74b
2018-02-14 09:17:41 -08:00
arthur.iakab
8b1be0e972 Backed out 5 changesets (bug 1340498) for build bustages on SelectionChangeListener.h on a CLOSED TREE
Backed out changeset fae677707059 (bug 1340498)
Backed out changeset 2adde1d1742a (bug 1340498)
Backed out changeset a444ab9cefde (bug 1340498)
Backed out changeset e2ac49ef2034 (bug 1340498)
Backed out changeset 6465310b3de9 (bug 1340498)
2018-06-26 03:53:21 +03:00
Doug Thayer
4ef92a21b2 Bug 1340498 - Update onVisits tests to use 'page-visited' r=mak
MozReview-Commit-ID: FxC3gcUF9hl

--HG--
extra : rebase_source : 8815ce1e4eef3bfaf25acf36faeeadacbe4a3b0c
2018-02-14 09:17:41 -08:00
Kris Maglione
7b7264f453 Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8
MozReview-Commit-ID: 9APGewiDDYB

--HG--
extra : rebase_source : 2931dd0eec0e4206414b698a9700fc20d922eb3a
2018-05-25 17:02:29 -07:00
Sylvestre Ledru
57cd040527 bug 1463425 - Fix flake8 in browser/ r=ahal,gps
MozReview-Commit-ID: 11Kil84u0TP

--HG--
extra : rebase_source : f5ec701490b52bba8b45a790812025c8ab5cf963
2018-05-21 23:13:07 +02:00
Kris Maglione
6b12d08f7d Bug 1462937: Update callers to use nsIFile::GetDirectoryEntries as a nsIDirectoryEnumerator. r=froydnj
MozReview-Commit-ID: Iv4T1MVAF5

--HG--
extra : rebase_source : 1c518883d082884db7f9323a5acc20361228c26b
extra : histedit_source : 70a73c23d1199d3bfbb5379c78930401166c094b
2018-05-19 20:17:45 -07:00
Mark Banner
55d1e986ea Bug 1461997 - Enable ESLint rule mozilla/require-expected-throws-or-rejects for browser/components. r=Gijs
MozReview-Commit-ID: JXqwIyF6v6k

--HG--
extra : rebase_source : 2220610f8facc9096c4427ff543f5fc31e6ce7b0
2018-05-16 20:23:06 +01:00
Narcis Beleuzu
f666a32b44 Backed out changeset b73e82f1a589 (bug 1425323) to re-enable test on Windows pgo/opt (whimboo`s request). a=backout 2018-05-07 16:08:20 +03:00
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Kris Maglione
a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Gijs Kruitbosch
86865a4a46 Bug 1448920 - add support for importing Edge typed URL history from its database instead, r=mak
MozReview-Commit-ID: 6AzEJluqn73

--HG--
extra : rebase_source : 79dbb73115de6a20511eb8b2cd0273f7d1f08bd5
2018-04-18 17:50:36 +01:00
Jonathan Kingston
ff73ac0338 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja

--HG--
extra : rebase_source : 29d337e111d82e9c5729b5a59e1a16d06e67774c
2018-02-21 14:28:48 +00:00
Ganesh Chaitanya Kale
e44c888947 Bug 1282770 - Convert uses of PU.asyncHistory.updatePlaces in browser/components/migration to PU.history.insertMany. r=mak
Patch originally by Ganesh, updated by Standard8

MozReview-Commit-ID: AihTLo5OyK1

--HG--
extra : rebase_source : f5a886326dd7f2fb2dba3309199ef277affe6b77
2018-03-20 12:36:31 +00:00
Tooru Fujisawa
98bed8bd01 Bug 1442465 - followup: Wait for session store update in browser/components/migration/tests/browser/browser_undo_notification.js. r=me 2018-03-19 12:40:46 +09:00
Tooru Fujisawa
1adba8c1fc Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Felipe Gomes
c4516c1ca8 Bug 1439443 - Policies: Don't create the default and smart bookmarks on the profile. r=mak
--HG--
rename : browser/components/enterprisepolicies/tests/browser/disable_developer_tools/browser.ini => browser/components/enterprisepolicies/tests/browser/disable_default_bookmarks/browser.ini
2018-03-16 21:02:05 -03:00
Kit Cambridge
0c40fa1232 Bug 1199077 - Split change sources for automatic and manual bookmark restores. r=mak
MozReview-Commit-ID: 1glcCPj2X90

--HG--
extra : rebase_source : 2d8372029df5851ecbb30a65393325442addd84c
2018-03-01 13:37:13 -08:00
Gijs Kruitbosch
56c730ca53 Bug 1438763 - fix intermittent orange in undo_notification_multiple_dismissal.js, r=ursula
When bug 1433324 made these tests run against activity stream, it made the notification
fire from the test's head.js file itself. Unfortunately, that races with the new tab / home
page actually loading, triggering an `onLocationChange` event in the tabbrowser, which
removes the notification again, meaning it is then no longer there when the test expects
it to be.

This wasn't an issue before, because the notification bar was opened via a message from
within the new tab page, which always arrived after the `onLocationChange` event.

Because the current state is temporary anyway, I'm just changing the test to open 2 tabs
first, and then opening the notification bars, which in practice guarantees this happens
after the `onLocationChange` event.

MozReview-Commit-ID: LOzgjrZBp0H

--HG--
extra : rebase_source : 10568c1ad97b03143d79b2d967ccac42550000a6
2018-03-07 16:07:41 +00:00
Daniel Marshall
d337129b4a Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I

--HG--
extra : rebase_source : ea59d03458c0e253201fd2c1476062dfb2e9a3d6
2018-02-10 21:23:19 +00:00
Mark Banner
0722fe3ee3 Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. r=florian.
MozReview-Commit-ID: IVMeZHGdVBk

--HG--
extra : rebase_source : 0705e96256baf6dc82811297058aa1d820b2f119
2018-03-06 12:01:59 +00:00
Narcis Beleuzu
34b2bf4c13 Backed out changeset a8130e46c530 (bug 1434483) for ESlint failures on browser_change_shipping.js. CLOSED TREE 2018-03-05 23:50:02 +02:00
Daniel Marshall
57b922d77c Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I

--HG--
extra : rebase_source : 379bd1db1e50ae415806713878e6b3ef36889e89
2018-02-10 21:23:19 +00:00
Gijs Kruitbosch
7dd5677adc Bug 1437940 - fix where we look for a 'Local State' file for non-release Chrome data, r=dthayer
MozReview-Commit-ID: CXghkKKhHfx

--HG--
extra : rebase_source : 8050e98033da4b265c61b7f612f906828b9241e9
2018-03-01 15:07:28 +00:00
Gijs Kruitbosch
21074e3307 Bug 1437940 - include Chrome Beta and Chrome Dev in migration list on Linux, r=dthayer
MozReview-Commit-ID: HDTkdXdYos3

--HG--
extra : rebase_source : c5e9abdd2f8c3077e38a716d26d6afa7cdc93914
2018-03-01 14:03:06 +00:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Mark Banner
6afe18b30a Bug 1440379 - Tidy up ESlint no-unused-vars definitions wrt Ci/Cu/Cr/Cc usage for varsIgnorePattern. r=florian
MozReview-Commit-ID: HmliR8iNRDq

--HG--
extra : rebase_source : 483ae0b54b9e781cceac2accdfb2255d725ace6a
2018-02-22 16:55:36 +00:00
Sebastian Hengst
e6ed14057b merge mozilla-central to autoland on a CLOSED TREE
--HG--
extra : amend_source : d88824ea9bbe5e0298f0d64fd0e4cdedcbee342c
2018-02-24 03:07:44 +02:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00