Commit graph

145 commits

Author SHA1 Message Date
Matthew Noorenberghe
487d770cc3 Bug 1485473 - Combine the borders of the name fields on the address form. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D4031

--HG--
extra : moz-landing-system : lando
2018-08-24 23:21:30 +00:00
Kris Maglione
80327d3561 Bug 1484496: Part 5a - Convert browser/ nsISimpleEnumerator users to use JS iteration. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3729

--HG--
extra : rebase_source : e187b8e9a6b6db7ebc762adda5e489b25c7a7e43
extra : histedit_source : 868cb99d09954a51d6be321fcb516475ef70eb33
2018-08-18 19:27:33 -07:00
Matthew Noorenberghe
0cf516ec70 Bug 1482220 - Listen for the autofill edit forms being appended for localization. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D3846

--HG--
extra : moz-landing-system : lando
2018-08-22 02:58:38 +00:00
prathiksha
c8c6fdba8f Bug 1475760 - Take address-fields into account for payer/contact picker dropdown labels. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D2831

--HG--
extra : rebase_source : 13304d7b7739ebb5a2b7d835ffaf088dc40afd17
2018-08-20 13:23:43 -07:00
Matthew Noorenberghe
e2d642ca25 Bug 1477100 - Scroll the country picker into view to fix browser_dropdowns.js. r=me
This new layout caused it to require scrolling to be clicked.

--HG--
extra : rebase_source : 3f1d5c54eefd3f56c5513ec2737a1883f31d91ee
2018-08-17 20:27:33 -07:00
Matthew Noorenberghe
cc5127203e Bug 1478029 - Follow-up to fix test_address_form.html default country. r=me 2018-08-17 17:40:04 -07:00
Matthew Noorenberghe
db94a77ef1 Bug 1478029 - Don't select a shipping option by default for the user. r=sfoster
Honour the .selected value provided by the merchant.

Differential Revision: https://phabricator.services.mozilla.com/D3668

--HG--
extra : rebase_source : a7ea701d875f3052dabad16ca90419f7f3f3849c
extra : amend_source : 1fe3c1ecff45d73761ae848d044911c27e1840ae
2018-08-17 17:03:29 -07:00
Jared Wein
066ed9e934 Bug 1477100 - Show the labels as placeholders inside of the fields. r=MattN
Show the labels as placeholders inside of the fields.

Differential Revision: https://phabricator.services.mozilla.com/D2955

--HG--
extra : rebase_source : 4ca24b7b6833c3c1bcd4821ec127fe07c24b44d0
2018-08-17 16:25:46 -07:00
Matthew Noorenberghe
10c07d673d Bug 1483425 - Don't mark form fields as invalid/dirty on load in an 'add' form. r=sfoster
When editing an existing record, invalid fields should be indicated on load.

Differential Revision: https://phabricator.services.mozilla.com/D3397

MozReview-Commit-ID: CbrqEyCUoyC

--HG--
extra : rebase_source : f44dc1b66d0c37d2b301a6b5c33ddde9fa7181bf
2018-08-17 16:27:21 -07:00
Matthew Noorenberghe
4249cc5a94 Bug 1483401 - Fix scrollable area for the payment request page-body. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D3374

--HG--
extra : moz-landing-system : lando
2018-08-16 16:33:05 +00:00
Matthew Noorenberghe
e4b01ff640 Bug 1465673 - Disable browser_card_edit.js on linux debug builds. r=me
--HG--
extra : rebase_source : c6c5ced06a994179f1cbf16762e085e58e9e6f9e
2018-08-15 14:21:18 -07:00
Matthew Noorenberghe
a290cf90f3 Bug 1476345 - Only enable relevant fields in address forms and update tests. r=jaws
MozReview-Commit-ID: KuPMHrF6jaM

--HG--
extra : rebase_source : f37118ff94bcb90108712dcc2f6db3d0aa5c92ef
2018-08-15 12:19:55 -07:00
Matthew Noorenberghe
eb2bfba0ba Bug 1476345 - Disable the address form save button when the form is invalid. r=jaws
Tests for this are in the next commit (e.g. test_address_form.html) because this can't be tested properly due to existing tests not filling fields in ways that fire input/change events.

MozReview-Commit-ID: 62CckFP6Ou3

--HG--
extra : rebase_source : 02a73ae78f6102e139cdca31e64d6248dc8d5281
2018-08-15 12:07:55 -07:00
Matthew Noorenberghe
f82da9f49e Bug 1476345 - Fix debugging names and add records with missing required fields. r=jaws
MozReview-Commit-ID: LaOJMF6GLuZ

--HG--
extra : rebase_source : f670bac3c1118748ec2a34e1a801c71166347d33
2018-07-24 22:14:53 -07:00
Matthew Noorenberghe
df3b18a123 Bug 1476345 - Fix console listener to not spew when .message doesn't exist. r=jaws
Sometimes .errorMessage exists without .message

MozReview-Commit-ID: D4zBJKxfJba

--HG--
extra : rebase_source : b665ab4c79a894462064662bbf8bcc49e320d7ce
2018-08-14 16:26:36 -07:00
Sam Foster
a4aca2683c Bug 1480880 - Fix exposing of payment defaults prefs object. r=MattN
MozReview-Commit-ID: DRSiGjk6wyS

--HG--
extra : rebase_source : 179cfde242c2ec965ef01c670baf26e7a06b92fb
2018-08-03 11:51:10 -07:00
Kris Maglione
25c94b46d8 Bug 1481021: Part 1 - Fix tests that rely on permissive COWs or SpecialPowers side-effects in frame script scopes. r=bz
Right now, a lot of test code relies on side-effects of SpecialPowers being
loaded into frame script globals. In particular:

- It forces permissive COWs from those scopes, which allows frame scripts to
  pass objects from those scopes to unprivileged content that they otherwise
  wouldn't.
- It imports a bunch of helper modules and WebIDL globals which would
  otherwise not be available.

Fortunately, this seems to only impact test code at this point. But there's a
real down-the-road risk of it impacting shipping code, which ends up working
in automation due to the side-effects of SpecialPowers, but failing in real
world use.

MozReview-Commit-ID: G27eSSOHymX

--HG--
extra : rebase_source : 1702e63fed719fc92def2bdbbb8a7c53572432db
extra : source : 41bedc526dd6ec6b7e8c7be1c832ac60c81d6263
2018-08-07 14:13:06 -07:00
Brindusan Cristian
16ec846afc Backed out 2 changesets (bug 1481021) for bc failures on security/sandbox/test/browser_bug1393259.js.
Backed out changeset c53c7b0249ad (bug 1481021)
Backed out changeset 41bedc526dd6 (bug 1481021)
2018-08-08 03:22:16 +03:00
Kris Maglione
c1969dbca2 Bug 1481021: Part 1 - Fix tests that rely on permissive COWs or SpecialPowers side-effects in frame script scopes. r=bz
Right now, a lot of test code relies on side-effects of SpecialPowers being
loaded into frame script globals. In particular:

- It forces permissive COWs from those scopes, which allows frame scripts to
  pass objects from those scopes to unprivileged content that they otherwise
  wouldn't.
- It imports a bunch of helper modules and WebIDL globals which would
  otherwise not be available.

Fortunately, this seems to only impact test code at this point. But there's a
real down-the-road risk of it impacting shipping code, which ends up working
in automation due to the side-effects of SpecialPowers, but failing in real
world use.

MozReview-Commit-ID: G27eSSOHymX

--HG--
extra : rebase_source : c528dffe3a54eec75ad6cb358980b783b00eb4a4
2018-08-07 14:13:06 -07:00
Jared Wein
559a6cb6d4 Bug 1476348 - Show missing field validation errors on the summary page. r=MattN
MozReview-Commit-ID: 5dOzxWH0pWp

--HG--
extra : rebase_source : 1de025d22f01c5b293355b0fe0732543769bf761
2018-08-03 18:51:31 -04:00
Sam Foster
5b22b7f2ef Bug 1480023 - Ensure input event is handled in the correct order by waiting for EditAutofillForm constructor before adding BasicCardForm's input & change handlers. r=MattN
MozReview-Commit-ID: F9hzp54hZxX

--HG--
extra : rebase_source : 5c8e588bd931070f9925da1bc8543f6f52bdf84f
2018-08-02 17:46:56 -07:00
Jared Wein
b5298bb1f5 Bug 1477699 - Show a generic error message when a merchant-supplied error message isn't present. r=MattN
MozReview-Commit-ID: Dn4mnvzunVd

--HG--
extra : rebase_source : b606aa2717febdf7d014c5254bd28148ebfc64be
2018-07-31 15:09:58 -04:00
Bogdan Tara
f2cb75b28c Merge inbound to mozilla-central. a=merge 2018-08-03 13:16:27 +03:00
Jared Wein
9849e2000e Bug 1472278 - Localize the required form asterisk on the address-form, basic-card-form, and CVV entry field. r=MattN
MozReview-Commit-ID: 7VN1VY7QziT

--HG--
extra : rebase_source : b28017164a32758271059b0337e295ca4883f14b
2018-07-30 21:13:36 -04:00
prathiksha
0dd94f929f Bug 1463547 - Hide the edit link in the pickers when no options are selected. r=MattN
MozReview-Commit-ID: DcTcmV2v6N1

--HG--
extra : rebase_source : bcf49fc9159db8ad8a8cc38e7ce298af55c1b8cb
extra : amend_source : 3092cfd628b768952e3887f42165b167605b095b
2018-08-02 17:21:44 -04:00
Jared Wein
f9f97a19b6 Bug 1477114 - Add an asterisk to the required fields of the credit card form as well as the CVV placeholder. r=sfoster
MozReview-Commit-ID: 2zg5HOZVtxN

--HG--
extra : rebase_source : 88eff9da5e84abf8ee726ceb7fcf338ecc1f50ee
2018-07-30 17:52:24 -04:00
Brindusan Cristian
d0b636e70f Backed out changeset d402c7b803c6 (bug 1477114) as requested by jaws. 2018-08-02 23:18:53 +03:00
Jared Wein
66c08eb74d Bug 1477114 - Add an asterisk to the required fields of the credit card form as well as the CVV placeholder. r=sfoster
MozReview-Commit-ID: 2zg5HOZVtxN

--HG--
extra : rebase_source : e2ed448ec2e82a5c874e5186ee318773f3250c09
2018-07-30 17:52:24 -04:00
Sam Foster
30473eb88f Bug 1477106 - Use a pref to set default checkedness for "Save card to Firefox" and "Save address to Firefox" checkboxes. r=jaws
* Get default checkedness for the card persist checkbox from a new pref: dom.payments.defaults.saveCreditCard
* Get default checkedness for the address persist checkbox from a new pref: dom.payments.defaults.saveAddress
* Remember checked state from card page (only) so it doesnt change back when returning from add/edit address page
* Fix up card form tests to verify behavior in private/not-private windows, pref value, user opt-in for persisting the card
* Fix up address form tests to not conflate private/not-private windows with expected address persisting behaviour

MozReview-Commit-ID: GXMjqStlnlu

--HG--
extra : rebase_source : e267187766d221e4f865cb84065ea18231e7c012
2018-07-26 15:36:07 -07:00
Andreea Pavel
e3d83161a1 Backed out changeset d69e19bad6c1 (bug 1477106) for eslint failure at builds/worker/checkouts/gecko/browser/components/payments/content/paymentDialogFrameScript.js 2018-08-02 02:11:57 +03:00
Sam Foster
5275a24aca Bug 1477106 - Use a pref to set default checkedness for "Save card to Firefox" and "Save address to Firefox" checkboxes. r=jaws
* Get default checkedness for the card persist checkbox from a new pref: dom.payments.defaults.saveCreditCard
* Get default checkedness for the address persist checkbox from a new pref: dom.payments.defaults.saveAddress
* Remember checked state from card page (only) so it doesnt change back when returning from add/edit address page
* Fix up card form tests to verify behavior in private/not-private windows, pref value, user opt-in for persisting the card
* Fix up address form tests to not conflate private/not-private windows with expected address persisting behaviour

MozReview-Commit-ID: GXMjqStlnlu

--HG--
extra : rebase_source : eb5931bff4ba348503144139d3f7f625e0a4af91
2018-07-26 15:36:07 -07:00
Jared Wein
b891ceac20 Bug 1478175 - Implement the branding in the lower left corner of the payment-summary page. r=sfoster
MozReview-Commit-ID: Dp8SdEzlrG3

--HG--
extra : rebase_source : d7144c0c83a1574bba6f85d7aae123cf5fdecb24
2018-07-30 17:24:16 -04:00
Mark Banner
8d235f8e45 Bug 1478305 - Remove unnecessary imports and fix ESLint warnings about unused variables for browser/. r=jaws
MozReview-Commit-ID: 1vHR6ixePkN

--HG--
extra : rebase_source : 8f9a322d1ff075ab56b81f8710df5d841839865b
2018-07-30 10:27:36 +01:00
Jared Wein
6ecd2e45dd Bug 1468153 - Update the edit strings (Add/Update) and the failure strings to use the hostname. r=sfoster
MozReview-Commit-ID: HcOMsP5zWBg

--HG--
rename : browser/components/payments/test/mochitest/test_labelled_checkbox.html => browser/components/payments/test/mochitest/test_completion_error_page.html
extra : rebase_source : a5e2ed74badabed047e707620f977081ae99247b
2018-07-30 14:22:52 -04:00
Sam Foster
417a086f25 Bug 1470584 - Send PAYMENT_REJECTED response if window is unexpectedly closed. r=MattN
* Use onWindowClose to spot closing windows associated with live payment requests and send a reject response
* Test to verify expected show() promise rejection behavior when closing the PR dialog

MozReview-Commit-ID: 2TJYN5NMrE6

--HG--
extra : rebase_source : 83cdfbe760f5df7e4786ac277e1ecabd3a4b08d8
2018-07-16 17:21:51 -07:00
Jared Wein
55494981b1 Bug 1475521 - Payments shouldn't be processed without selecting a shipping address. r=MattN
MozReview-Commit-ID: CXxqYB3iOy

--HG--
rename : browser/components/payments/test/mochitest/test_payment_dialog.html => browser/components/payments/test/mochitest/test_payment_dialog_required_top_level_items.html
extra : rebase_source : dfd5f1d345231acc6684453ed8b6564c5664790c
2018-07-27 12:03:46 -04:00
Matthew Noorenberghe
90bfe1f77f Bug 1478321 - Fix the 'TypeError: docShell is null' exception to the Payments console listener. r=sfoster
`errorMessage` only contains 'TypeError: docShell is null' whereas `message` contains the file path and line.

MozReview-Commit-ID: 7Tuqph1b3lV

--HG--
extra : rebase_source : fdf20be275adaac41f25ebeee67d142456f4da8b
2018-07-26 16:11:24 -07:00
Matthew Noorenberghe
b0560084b3 Bug 1476204 - Handle autofill record update state changes in the unpriv. PR forms. r=jaws
This is easier to understand as we don't have to round-trip the whole success and error states to the privileged wrapper which could potentially lead to stale state changes.
This is also much simpler for the basic-card-form as it doesn't need a lot of the complexity of the previous implementation.

* Move selectedStateKey from page to address-page since it doesn't apply to basic-card-page

MozReview-Commit-ID: B4kiZNWElGI

--HG--
extra : rebase_source : bcca13bbdc506961834e2e3cc078dad7d6ee7ca7
2018-07-25 12:37:51 -07:00
Matthew Noorenberghe
97013686ad Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3

--HG--
extra : rebase_source : e80fd0a269f4565300e3923223a2ac483f4cf33e
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
84558567ed Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs

--HG--
extra : rebase_source : 07cc1137c4f925a4f5554c2680c624d59da5fcd8
2018-07-23 20:34:40 -07:00
Matthew Noorenberghe
07463fbd62 Bug 1476204 - Check Luhn algorithm in the basic-card-form and in storage and disable save button when invalid. r=jaws
* Provide an cc-exp-year option to match cc-exp-month
* Make cc-number and cc-name required in the basic-card-form
* Disable the basic-card-page save button when the form is invalid.

MozReview-Commit-ID: LjzsnAKJp6R

--HG--
extra : rebase_source : 4dcbee371cd0e30b5823b803c4f4734f897ec786
2018-07-26 13:40:22 -07:00
Matthew Noorenberghe
8253243a9f Bug 1476204 - Make the basic-card-option field order and alignment match the <option>. r=sfoster
MozReview-Commit-ID: 4YA8Ff7Irc3

--HG--
extra : rebase_source : 9980f4f0fc57cccdbee3b248a94666f3e288be63
2018-07-20 14:59:56 -07:00
prathiksha
5e20dc8929 Bug 1476571 - Auto-select selectedShippingAddress as billing address when it is not null. r=MattN
MozReview-Commit-ID: 8qPIbHn7cKk

--HG--
extra : rebase_source : 023450976a481767923700f8e2ec7deb3538f4f8
2018-07-24 15:50:54 -07:00
Cosmin Sabou
80a830bce7 Backed out 5 changesets (bug 1476204) for browser chrome failures on browser_editCreditCardDialog. CLOSED TREE
Backed out changeset 10f3d1014592 (bug 1476204)
Backed out changeset a88879ea32e8 (bug 1476204)
Backed out changeset 001f13f2dd21 (bug 1476204)
Backed out changeset f0f464e3c27c (bug 1476204)
Backed out changeset ed92000eca20 (bug 1476204)
2018-07-26 04:12:56 +03:00
Matthew Noorenberghe
46813c4815 Bug 1476204 - Handle autofill record update state changes in the unpriv. PR forms. r=jaws
This is easier to understand as we don't have to round-trip the whole success and error states to the privileged wrapper which could potentially lead to stale state changes.
This is also much simpler for the basic-card-form as it doesn't need a lot of the complexity of the previous implementation.

* Move selectedStateKey from page to address-page since it doesn't apply to basic-card-page

MozReview-Commit-ID: B4kiZNWElGI

--HG--
extra : rebase_source : 183a3bd44ed33566fccdc024eabdccef83554d50
2018-07-25 12:37:51 -07:00
Matthew Noorenberghe
ae5eb48179 Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3

--HG--
extra : rebase_source : 0bb5a17967092d89f63f96c240ac78c0df671bce
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
6cad3245bb Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs

--HG--
extra : rebase_source : 80eeed03264f000b97572fa03c1c322540cd554e
2018-07-23 20:34:40 -07:00
Matthew Noorenberghe
f5f3467e63 Bug 1476204 - Check Luhn algorithm in the basic-card-form and in storage and disable save button when invalid. r=jaws
* Provide an cc-exp-year option to match cc-exp-month
* Make cc-number and cc-name required in the basic-card-form
* Disable the basic-card-page save button when the form is invalid.

MozReview-Commit-ID: LjzsnAKJp6R

--HG--
extra : rebase_source : 467fa09ea07c0234e1839b6dfd7e53375c118104
2018-07-25 16:38:25 -07:00
Matthew Noorenberghe
286bd79241 Bug 1476204 - Make the basic-card-option field order and alignment match the <option>. r=sfoster
MozReview-Commit-ID: 4YA8Ff7Irc3

--HG--
extra : rebase_source : 3131de1d4bffde60ea2c468a55e65c917d96584a
2018-07-20 14:59:56 -07:00
Sebastian Hengst
bd900ee36a Merge mozilla-inbound to mozilla-central. a=merge 2018-07-25 17:16:53 +03:00