Commit graph

219 commits

Author SHA1 Message Date
Marco Bonardo
ce1cee2324 Bug 1338083 - Restore full year in Library date columns. r=jfkthame
MozReview-Commit-ID: GIp7xzdAC9C

--HG--
extra : rebase_source : 61510a9b0b661ca18046049480f386c51f58b444
2017-02-09 10:38:51 +01:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Jared Wein
3718f00db1 Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Mark Banner
a41b5adcb0 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop
MozReview-Commit-ID: LdoXLniNeT7

--HG--
extra : rebase_source : d2418b8cfab0a399d0dfb5a96ea50c62fac63e70
2016-11-03 11:51:48 +00:00
Jonathan Kew
4d16a0f88a Bug 1301655 - pt 3 - Replace use of nsIScriptableDateFormat with Intl API methods in browser/components/places code. r=gandalf 2016-10-28 12:04:07 +01:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
gasolin
aa79932ce4 Bug 1262639 - Fix NS_ERROR_ILLEGAL_VALUE spam by not run getLivemark without valid node id; r=mak
MozReview-Commit-ID: HgLHJ1vdYVi

--HG--
extra : rebase_source : 8200cd1c3f1c8c2db9f6193b3b5c28f23a3c272e
2016-04-20 17:38:54 +08:00
Dave Townsend
0a6414b898 Bug 1245649: Turn on no-trailing-spaces. r=Gijs
--HG--
extra : commitid : F2OWKTvXUO4
extra : rebase_source : ec68631342e0edc59d77b6bab1cdc975ad175327
2016-02-03 14:22:33 -08:00
simplyblue
34af26c5b6 Bug 1228976 - Remove array comprehensions from Places .r=mak 2015-12-03 16:26:58 +05:30
simplyblue
499e992e6a Bug 1228975 - Remove Array generics usage from Places code. r=mak 2015-12-01 15:40:30 +05:30
Marco Bonardo
c647f9c6b1 Bug 1190350 - Bookmarks sidebar displays regular folder icons for livemarks. r=gijs 2015-10-14 18:49:23 +02:00
Hassen ben tanfous
45492f28fb Bug 1074804 - Replace arrays .indexOf with .includes in Places. r=mak 2015-10-11 20:24:32 +02:00
Seth Fowler
9933832135 Bug 1118926 (Part 2) - Remove remnants of -moz-resolution in JavaScript code. r=dolske 2015-09-30 17:00:56 -07:00
Tooru Fujisawa
3fc2581f0c Bug 1207491 - Part 10: Remove use of expression closure from browser/components/places/content/. r=Gijs
--HG--
extra : commitid : LlW5LSkRgzy
extra : rebase_source : 1b1038758a0c4b83fe8e00ebe397065def10cf7c
2015-09-23 18:36:21 +09:00
Marco Bonardo
27836eca10 Bug 1095411 - PlacesUtils.wrapNode is using synchronous getKeywordForBookmark. r=ttaubert 2015-05-22 19:02:41 +02:00
Tim Taubert
1f6ae32b94 Bug 1145063 - Remove the keywords column from the Library r=mak 2015-05-04 14:22:32 +02:00
Asaf Romano
3e864279a2 Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak 2015-04-23 16:34:55 +03:00
Carsten "Tomcat" Book
113727c6bc Backed out changeset 7f9114a84892 (bug 951651) for bc2 test bustage on a CLOSED TREE 2015-04-23 08:52:56 +02:00
Asaf Romano
7f68adcfa1 Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak. 2015-04-23 08:15:21 +03:00
Tom Schuster
6847f14b74 Bug 783829 - Make PlacesUtils.nodeAncestors a new generator. r=mak 2014-12-17 00:28:39 +01:00
Asaf Romano
d83f8d60e1 Bug 1068671 - folderReadOnly doesn't pertain to bookmarks or results. r=mak 2014-10-14 17:03:28 +03:00
Carsten "Tomcat" Book
459781f902 Backed out changeset b30d47d94a85 (bug 1068671) for bc1 test failures 2014-10-01 13:14:06 +02:00
Carsten "Tomcat" Book
29fad8f0d6 Backed out changeset 5a6b95c47b55 (bug 1068671) 2014-10-01 13:12:13 +02:00
Asaf Romano
eb24352288 Bug 1068671 - Fix review comment (comment 15 on the bug) and a couple of typos. r=mak 2014-10-01 12:59:11 +03:00
Asaf Romano
896f516dd7 Bug 1068671 - Remove 'read-only' folders support from places. r=mak 2014-10-01 12:19:06 +03:00
Asaf Romano
00c2d6bc3f Bug 1067956 - Async Places Transactions: Drop functionality. r=mak. 2014-09-19 17:04:51 +03:00
Asaf Romano
0493c2157b Bug 1067954 - Async Places Transactions: Paste functionality. r=mak 2014-09-19 16:53:27 +03:00
Roberto A. Vitillo
fdac6a31e3 Bug 1058599 - Use string instead of nsIURI when calling xulstore. r=enn 2014-08-27 06:08:00 -04:00
Roberto A. Vitillo
0538a1f855 Bug 1056796 - Use documentURIObject to retrieve document uri. r=enndeakin 2014-08-21 06:42:00 -04:00
Roberto A. Vitillo
3eb77a08ed Bug 559505 - Deprecate localstore.rdf and replace it with xulstore. r=enn, sr=bsmedberg
CLOSED TREE
2014-08-19 10:31:00 -04:00
Ed Morley
5b13b797b8 Backed out changeset 143ae44587b2 (bug 559505) for xperf failures 2014-08-20 17:10:05 +01:00
Roberto A. Vitillo
94f55c9aaa Bug 559505 - Deprecate localstore.rdf and replace it with xulstore. r=enn, sr=bsmedberg 2014-08-19 10:31:00 -04:00
Bernardo P. Rittmeyer
e5c228e808 Bug 1052174 - Applied -moz-resolution fragment to favicons to enable support for high resolution throughout the UI. r=MattN 2014-08-18 14:42:00 -07:00
Marco Bonardo
784031cd19 Bug 969318 - Mute "A promise chain failed to handle a rejection" error from the livemarks service. r=mano 2014-03-12 16:24:23 +01:00
Marco Bonardo
05e6b87a72 Bug 435851 - dragging a folder shortcut drags the concrete folder instead. r=mano 2014-03-04 21:44:21 +01:00
Marco Bonardo
cd76afe24d Bug 874407 - new visits are inserted incorrectly in the Library and the sidebar treeviews.
r=Mano
2013-06-03 12:17:36 +02:00
Ed Morley
8e8247ca4f Backed out changeset 8c37f4a3e488 (bug 874407) for failures in test_bug549192.xul 2013-06-03 13:21:41 +01:00
Marco Bonardo
60e9ef48f0 Bug 874407 - new visits are inserted incorrectly in the Library and the sidebar treeviews.
r=Mano
2013-06-03 12:17:36 +02:00
Trevor Saunders
254bffb739 bug 407956 - make nsITreeView not take a nsISupportsArray* r=neil, bz sr=neil 2013-01-06 19:54:42 -05:00
Marco Bonardo
ed84888317 Bug 831094 - Avoid replacing nodes in Places query results.
r=Mano sr=gavin
2013-02-06 20:48:09 +01:00
Asaf Romano
d97abefe07 Bug 760940 - Bookmarks and history menus behave incorrectly due to non-node weak map keys. r=mak 2012-07-24 17:20:57 +03:00
Asaf Romano
8c4f7239bf Bug 761494 - Cannot open all Bookmarks in tabs by Middle clicking a folder in Sidebar. r=mak 2012-06-28 21:14:45 +03:00
Asaf Romano
7ba8f62ee7 Bug 730340 - Bug 730340 - Don't use expando properties for storing data on places nodes. Don't use an expando to mark cut nodes. r=mak. 2012-06-03 15:01:15 +03:00
Asaf Romano
e9836a3ee8 Bug 730340 - Don't use expando properties for storing data on places nodes. Part 3 - cache livemark-info object in the controller for each view instead of setting _feedURI and _siteURI exapndos on livemark nodes. Also fix a bug I introduced in the previous check for this bug, in PVB_nodeHistoryDetailsChanged. r=mak 2012-06-02 16:54:25 +03:00
Asaf Romano
a41ee513d9 Bug 730340 - Don't use expando properties for storing data on places nodes. part 1 - use a WeakMap for mapping places nodes to DOM nodes. part 2 - use a WeakMap for cellProperties in treeView.js; stop caching _plainContainer. r=mak 2012-06-01 23:03:00 +03:00
Serge Gautherie
dc023738a3 Bug 741064. (Av1) Fix "function PTV__buildVisibleSection does not always return a value". r=mano. 2012-04-01 18:13:44 +02:00
Marco Bonardo
baf76b6247 Bug 731274 - Make reloadLivemarks optionally force reloads and use it to speed up livemarks population.
r=dietrich sr=gavin
2012-03-08 11:14:59 +01:00
OHZEKI Tetsuharu
2e1dd2c937 Bug 580814 - Avoid accessing rows that don't exist in treeviews for Places. r=mak 2012-03-04 12:36:14 -05:00
OHZEKI Tetsuharu
79626124b2 Bug 575955 - Replace internal usage of old transactions shim, add a new toolkit test. r=mak
--HG--
rename : browser/components/places/tests/unit/test_placesTxn.js => toolkit/components/places/tests/unit/test_placesTxn.js
rename : browser/components/places/tests/unit/test_txnGUIDs.js => toolkit/components/places/tests/unit/test_txnGUIDs.js
2012-02-28 18:40:38 -05:00
Marco Bonardo
d20e75ed38 Bug 613588 (Frontend) - Load-on-demand livemarks.
r=dietrich,mano
2012-02-24 13:42:26 +01:00
Thomas Prip Vestergaard
92fcb2e91e Bug 705043 - Avoid cutting off Places URI titles unnecessarily. r=mak 2011-12-07 16:44:00 -05:00
Marco Bonardo
f7acf28c3d Bug 696159 - Remove some deprecated Places code.
r=dietrich sr=rstrong
2011-10-27 11:11:43 +02:00
Marco Bonardo
309f2be51a Bug 416459 - Implement proper cut action for bookmarks.
r=dietrich
2011-06-30 15:34:02 +02:00
Asaf Romano
ba812eb7d9 Bug 636924 - Copied livemarks appear as folders in sidebar; r=dietrich 2011-03-22 10:55:47 -04:00
Marco Bonardo
e8af7e9d58 Bug 628258 - inverted method arguments in treeView.js::_buildVisibleSection.
r+a=dietrich
2011-01-27 12:18:17 +01:00
Marco Bonardo
674977bf4b Bug 620198 - Right pane tree of Library is not updated when i delete a selected folder in left pane tree.
r=dietrich a=blocker
2011-01-18 15:01:12 +01:00
Marco Bonardo
865d1cfcb3 Bug 472343 (part 2) - Make Places views aware of batches.
r=dietrich sr=vlad a=blocking
2010-11-12 22:20:00 +01:00
Robert Kaiser
6c816884ba bug 570788 - Incorporate improvements from SeaMonkey places review into Firefox code, round 4 (tree), r=mak a=gavin 2010-08-11 18:05:10 +02:00
Asaf Romano
c0d6725ddb Bug 549491 - "The root node is never visible" exception when details of the root node are modified. r=mak 2010-06-22 14:44:38 +02:00
Asaf Romano
0545f4d847 Bug 549192 - History view not updated after deleting entry. r=mak. 2010-06-04 22:48:04 +03:00
Robert Kaiser
4897cfe53d bug 566613 - fix typo wasVisbile in treeView.js and use nodeAncestors in invisible node lookup, r=Mano 2010-05-27 15:06:27 +02:00
Marco Bonardo
96b1a35cc4 Bug 556739 - Part4: PlacesUIUtils should be a module instead. r=dietrich
--HG--
rename : browser/components/places/content/utils.js => browser/components/places/src/PlacesUIUtils.jsm
rename : browser/components/places/tests/chrome/test_bug510634.xul => browser/components/places/tests/chrome/test_0_bug510634.xul
rename : browser/components/places/tests/chrome/test_multiple_left_pane.xul => browser/components/places/tests/chrome/test_0_multiple_left_pane.xul
2010-04-17 12:07:19 +02:00
Marco Bonardo
679fecd861 Bug 556739 - Part 1: Expose more from PlacesUtils. r=dietrich 2010-04-16 23:51:04 +02:00
Drew Willcoxon
9f2f035eda Bug 536893 - Asynchronous API for opening nsNavHistoryFolderResultNodes (part 2), r=mano 2010-04-09 11:30:35 -07:00
Asaf Romano
1347890116 Bug 555293 - MLFB: Port bug 547815 to Firefox. r=the-one-who-likes-filing-bugs. 2010-03-27 00:15:02 +03:00
Asaf Romano
f62b88bc41 Bug 543444 - Replace single-view API with multiple observers. r=mak sr=rstrong 2010-03-12 12:14:47 +01:00
Marco Bonardo
7522fa3186 backout bug 543444 due to leaks 2010-03-09 17:23:32 +01:00
Asaf Romano
309a26a9cb Bug 543444 - Replace single-view API with multiple observers. r=mak sr=rstrong 2010-03-09 14:43:09 +01:00
Robert O'Callahan
616b7eed72 Backed out changeset 79f299fc10d6 2010-03-05 20:10:20 +13:00
Asaf Romano
fe8fdd5f03 Relanding bug 543444 - Replace single-view API with multiple observers. r=mak. sr=rstrong. 2010-03-04 13:23:41 -08:00
Asaf Romano
eb72e43829 Backing out bug 543444 due to orange. 2010-03-03 17:23:51 -08:00
Asaf Romano
79c992514c Bug 543444 - Replace single-view API with multiple observers. r=mak, sr=rstrong. 2010-03-03 14:45:16 -08:00
Asaf Romano
40a2a590a8 Bug 520659 - Lazily build places trees when possible. r=mak. 2010-02-25 20:30:09 +02:00
Marco Bonardo
7ddb95dce2 Bug 544047 - Remove Places dependency on nsDragAndDrop.js. Use the new drag and drop API everywhere. r=mano 2010-02-23 16:20:36 +01:00
Paul O’Shannessy
4ef6775f0a Backed out changeset 2c60006b6c1f (bug 520659) because of resulting orange. 2010-02-22 14:58:09 -08:00
Asaf Romano
9373a85130 Bug 520659 - Lazily build places trees when possible. r=mak. 2010-02-22 23:37:52 +02:00
Marco Bonardo
38109b9c22 Bug 525739 - test_treeview_date.xul fails for the rest of the day when DST changes, r=dietrich 2009-11-06 16:24:56 +01:00
Dietrich Ayala
8f8c161f85 Bug 498130 - Reduce places-views overhead (RELAND) 2009-10-01 09:53:26 -07:00
Dietrich Ayala
d1261351b1 Backout bug 498130 due to persistent startup crash on Windows Mobile (bug 519854) 2009-09-30 17:21:39 -07:00
Asaf Romano
8675f1e5ad Bug 498130 - Reduce places-views overhead. r=mak. sr=mconnor. 2009-09-26 11:23:17 +03:00
Marco Bonardo
68483ca91d Bug 324430 - Allow stopping Places results updates when they are unused, r=dietrich 2009-06-15 13:09:40 +02:00
Dietrich Ayala
f54de06119 Bug 492796 - isLivemark should use the livemark cache, instead of the db (r=marco) 2009-06-12 15:39:42 -07:00
Dietrich Ayala
b8f1511e0a Bug 493636 - when possible, use cached left pane query ids instead of the anno service directly (r=marco) 2009-06-12 15:21:47 -07:00
Dietrich Ayala
ba4f4fec8d Bug 492804 - remove hasAnno check for bookmark description, r=mak77 2009-05-19 01:06:55 +02:00
Pardal Freudenthal
b2868dca86 Bug 482235 - instead of exposing bookmarklets attribute, expose scheme in uri nodes, r=mak77 2009-03-12 14:05:48 +01:00
Marco Bonardo
3f86a4a9e3 Bug 481765 - test_treeview_date.xul fails at certain times. Fix code and reactivate the test, report any failure please, r=dietrich 2009-03-10 15:53:34 +01:00
Pardal Freudenthal
e3afda92d6 Bug 397263 - No way to set an icon for javascript bookmarklets on toolbar and menupopups, r=mak77 2009-03-09 14:15:46 +01:00
Marco Bonardo
210065158a Bug 435322 - Places History Visit Date doesn't show _date_ portion properly, r=dietrich 2009-03-05 13:08:24 +01:00
Ehsan Akhgari
02d925b1c1 Bug 477902 - [RTL] URLs are not left-to-right in the list pane of the Library; r=enndeakin 2009-02-27 22:07:59 +03:30
Marco Bonardo
60717f8c85 Bug 435322 - Places History Visit Date doesn't show _date_ portion properly, r=dietrich 2009-01-13 11:48:26 +01:00
Marco Bonardo
316c08cc98 Bug 458022 - Correct persist selection on still valid nodes in treeView.js, r=mano 2008-12-16 11:04:08 +01:00
Daniel Holbert
5492039225 Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe 2008-10-01 23:49:45 -07:00
Marco Bonardo
5ca634dfa3 Bug 418671 - Clean up places views drag and drop code, r=mano 2008-09-19 17:47:45 +02:00
Marco Bonardo
75efb771b3 Bug 432832 - "aNode is null" error hovering history sidebar, r=mano 2008-09-02 01:26:41 +02:00
Asaf Romano
43b7526969 Bug 446664 - Organizer: Cannot open a query by double clicking on it or pressing enter while it's selected in the right pane. r=dietrich. 2008-07-24 00:14:23 +03:00
dietrich@mozilla.com
2ffdf7ec50 Bug 431817 - Special folders (Tags, Recent Tags) are not expandable/collapsible (no-more containers) (for mak77@supereva.it, r=dietrich, a=beltzner) 2008-05-05 11:16:56 -07:00