nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
610906 commits 1 branch 98 tags 6.4 GiB
Commit graph

2552 commits

Author SHA1 Message Date
Mark Banner
7ed82100ce Bug 1423896 - Make the new All Bookmarks folder query only update on the mobile folder status change for better performance. r=mak 
MozReview-Commit-ID: 4sIR6d0ZabJ

--HG--
extra : rebase_source : d33eaf982c469128ed4a9ac8e27079426426ab2c
 2018-02-05 17:19:26 +00:00
Mark Banner
362505f227 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak 
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
 2017-12-07 14:15:39 +00:00
Mark Banner
e23bde49fe Bug 1423896 - Rewrite browser_library_panel_leak.js to use async & await. r=mak 
MozReview-Commit-ID: 4HuGbt814i0

--HG--
extra : rebase_source : d572a7994e917ce6cfb7708f5ca9a10f74720a1e
 2018-01-08 17:27:41 +00:00
Mark Banner
6b5ca88208 Bug 1423896 - Rename PlacesOrganizer.selectLeftPaneQuery to selectLeftPaneBuiltIn to better reflect what it is actually selecting. r=mak 
MozReview-Commit-ID: 6RJW5kWL82g

--HG--
extra : rebase_source : 983d5f3d90461f7dc3bd543de55d518fe0890aed
 2017-12-20 13:26:51 +00:00
Mark Banner
7785b2e489 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak 
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
 2017-12-07 14:15:39 +00:00
Mark Banner
706772488c Bug 1423896 - Rewrite browser_library_panel_leak.js to use async & await. r=mak 
MozReview-Commit-ID: 4HuGbt814i0

--HG--
extra : rebase_source : d572a7994e917ce6cfb7708f5ca9a10f74720a1e
 2018-01-08 17:27:41 +00:00
Mark Banner
948c129e39 Bug 1423896 - Rename PlacesOrganizer.selectLeftPaneQuery to selectLeftPaneBuiltIn to better reflect what it is actually selecting. r=mak 
MozReview-Commit-ID: 6RJW5kWL82g

--HG--
extra : rebase_source : 983d5f3d90461f7dc3bd543de55d518fe0890aed
 2017-12-20 13:26:51 +00:00
Marco Bonardo
dea921edee Bug 406371 - Make PlacesUtils a lazy module getter in placesOverlay.xul. r=standard8 
MozReview-Commit-ID: 3ILjGZYA5v0

--HG--
extra : rebase_source : ff0efb75354de29bf89e0a8230382c43c10928e4
 2018-02-07 09:52:02 +01:00
Andrew McCreight
754a4bcd3c Bug 1432992, part 2 - Manually remove some empty blocks. r=florian 
Also, remove a now-obsolete comment from placesOverlay.xul and remove
some now-empty XPCShell test head files.

MozReview-Commit-ID: 6kKVQu8FAL3

--HG--
extra : rebase_source : 7dd05818d68a15bd170af734078db4ba45029d80
 2018-01-25 16:52:25 -08:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian 
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
 2018-02-06 09:36:57 -08:00
hemant
5aa2697d2f Bug 1432403 - Remove PlacesUtils._uri r=standard8 
MozReview-Commit-ID: C59FOBe80KJ

--HG--
extra : rebase_source : a866e14aa1e3037fe3f2f6704a67aa11c0fef1b3
 2018-02-06 15:19:14 +05:30
Ioana Crisan
6605f20fc4 Bug 1431382 - Add a test for checking that tags can be added to bookmarks using the star-shaped button, the library and the sidebar. r=standard8 2018-01-31 10:19:34 +02:00
Gurzau Raul
b304596a50 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-02-01 23:58:51 +02:00
Florian Quèze
fcd9a3a0c8 Bug 1339461 - add an eslint rule to detect when indexOf should be replaced with includes, r=Standard8. 2018-02-01 20:47:23 +01:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Marco Bonardo
9645d23bf4 Bug 1434241 - showEditBookmarkPopup should stop accepting itemIds. r=standard8 
MozReview-Commit-ID: 8doEkhc8Wyd

--HG--
extra : rebase_source : a08336ea1442752b76132c60af62d41b78b1c01e
 2018-01-31 13:49:35 +01:00
hemant
64d45d0cb9 Bug 1417937 - Remove unnecessary LoadContextInfo.jsm r=standard8 
MozReview-Commit-ID: EnY0uKD4UD1

--HG--
extra : rebase_source : c968b273a8a05fb211e0fb1e1601ac1b968ca045
 2018-01-31 23:16:46 +05:30
Mark Banner
0bd55b8ddd Bug 1433979 - Remove deprecated code from PlacesBackups.jsm as it is no longer necessary. r=mak 
MozReview-Commit-ID: 5bNYJZvRInk

--HG--
extra : rebase_source : 782ac84bb6314d6905d5d5c989fa27695d6a1e7e
 2018-01-29 18:20:24 +00:00
Kris Maglione
19a956c2c6 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian 
MozReview-Commit-ID: 7bVI1iM6hor

--HG--
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
extra : amend_source : 09a90b29837e339eec7bdf8504f86c28e74ca3dd
extra : intermediate-source : a1eca62826a1341ca24d4d2a93d4884d4fc7ad51
extra : histedit_source : eb26e73b531f9a34d3401d39f60b533b27b78540
 2018-01-18 16:27:26 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
 2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE 
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
 2018-01-30 07:17:48 +02:00
Kris Maglione
e050496c59 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian 
MozReview-Commit-ID: 7bVI1iM6hor

--HG--
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
extra : amend_source : d0515fe4eb13b59cc490ca9d964ad9ee15ef3cd3
extra : intermediate-source : 6e56f4c8843ed134b2dba34fb007298fd55be966
extra : histedit_source : 88abf9f4ea4e740a9391278625ef07395205c3f5%2Cc14bc7a71eb413fcb573ed0d030fd7f99a1468f0
 2018-01-18 16:27:26 -08:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
 2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE 
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
 2018-01-30 02:32:43 +02:00
Kris Maglione
e70d01a9e9 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian 
MozReview-Commit-ID: 7bVI1iM6hor

--HG--
extra : rebase_source : 6286dcfd1a7c970272ac6befaccd3e47e90d2f6b
extra : intermediate-source : d48657228a0b84cf3a37a35227ca3b3d0bd2a017
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
 2018-01-18 16:27:26 -08:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
 2018-01-29 15:20:18 -08:00
Paul Silaghi
6cb6f9bf4d Bug 1431390 - Add a test for checking that specific tags can be removed from a bookmark r=standard8 2018-01-23 12:36:40 +02:00
Mark Banner
dd6c928ffd Bug 1433492 - Remove remaining instances of PlacesUtils.asyncHistory.isURIVisited being called directly. r=mak 
MozReview-Commit-ID: B1sqEtJcq4L

--HG--
extra : rebase_source : 62a7c91e06f28712e9ba29a2e3ef73fa7dd9a0e1
 2018-01-26 16:40:25 +00:00
Mark Banner
d40ab69bb9 Bug 801391 - Set clickSelectsAll depending on the preference for the Bookmarks Library search box. r=mak 
MozReview-Commit-ID: 3IhkODtMpr7

--HG--
extra : rebase_source : a84082e456b3b31d4b7729e44a624552a5641640
 2018-01-26 14:46:30 +00:00
Mark Banner
aa95c289e7 Bug 1432407 - Merge loops in PlacesController.onDrop now that sync transactions have been removed. r=mak 
MozReview-Commit-ID: JXaxRv10HQs

--HG--
extra : rebase_source : a161a002ebc2baf241e26badad295db3aeac8046
 2018-01-25 21:00:34 +00:00
Mark Banner
22a702ba40 Bug 1432520 - Fix a double separator in the Places Organize menu. r=mak 
MozReview-Commit-ID: IVRls70hJSX

--HG--
extra : rebase_source : d62f8d26e3bf93601d075125a05496d7b78eea4a
 2018-01-23 20:39:24 +00:00
hemant
df042c21a8 Bug 1370881 - Replace calls to asyncHistory.isURIVisited and promiseIsURIVisited with PlacesUtils.history.hasVisits r=standard8 
MozReview-Commit-ID: BHWkJpdYA0g

--HG--
extra : rebase_source : 927cd89c69ed2cdbf6ebf8e954c38238ebbdd273
 2018-01-24 20:58:57 +05:30
Mark Banner
412e825e77 Bug 1131491 - Remove browser.places.useAsyncTransactions preference - async transactions are now the only version. r=mak 
MozReview-Commit-ID: 9EKNvA8Q9jo

--HG--
extra : rebase_source : 289082be4a1f086620bf0fe3008c2eacbdc6a9fa
 2018-01-22 13:36:41 +00:00
Gurzau Raul
9801931bda Merge inbound to mozilla-central. a=merge 2018-01-23 02:21:47 +02:00
Marco Bonardo ext:(%20%3Cmbonardo%40mozilla.com%3E)
bed8d88705 Bug 1428342 - Make Places queries directly inherit options from their parent. r=standard8 
Rather then trying to guess options from the parent or the root node, make query nodes directly
inherit some options from their parent.

MozReview-Commit-ID: 1YgDjrrMqGY

--HG--
extra : rebase_source : 5714e6243b0080c977cf6ab454c3f624990414dd
 2017-12-14 10:06:37 -06:00
Mark Banner
00db51f54b Bug 517719 - Remove unnecessary nsINavHistoryResultTreeViewer interface. r=mak 
MozReview-Commit-ID: E7TyD4o8dSK

--HG--
extra : rebase_source : edafcc6d28b1175ed05050cb8f030396b8aeaf9d
 2018-01-19 17:27:48 +00:00
Mark Banner
a52122f988 Bug 1432112 - Remove the Move Bookmarks dialog as it doesn't work properly and has alternatives. r=mak 
MozReview-Commit-ID: LRqyjJeuoVt

--HG--
extra : rebase_source : 6f5d225f124fc0ecd3ed3fbeab46f951bd405a89
 2018-01-22 13:48:14 +00:00
Thom Chiovoloni
35250bb05a Bug 1384856 - Fix sync menu items showing incorrect state on mac r=eoger 
MozReview-Commit-ID: Ipu7HXeZGZG

--HG--
extra : rebase_source : e322f0b633f77bcb0fa785f532414e25d3604ab7
 2018-01-17 13:09:22 -05:00
Tim Nguyen
6071f20f6c Bug 1430374 - Remove support for progressmeter tree cells. r=bz,dao 
MozReview-Commit-ID: 3hydkeoneC0

--HG--
extra : rebase_source : eca404511d1fc2d9d7e9711fbd1accefd3781b16
 2018-01-18 10:36:05 +00:00
Marco Bonardo
aa65d5c84c Bug 1420811 - Rename bookmark tag to empty will cause issue. r=standard8 
MozReview-Commit-ID: HcgDlC2qlCM

--HG--
extra : rebase_source : 99e499314e403e417ebc09663b8221dd0b9967d0
 2018-01-11 14:59:26 +01:00
Ciure Andrei
f7400ad72e Merge inbound to mozilla-central r=merge a=merge 2018-01-11 11:54:56 +02:00
Doug Thayer
1e3446b9cc Bug 1421703 - Fix tests to use onVisits r=mak 
Fairly straightforward. Fixes the tests that were broken due to
the changes introduced in part 1.

MozReview-Commit-ID: GbZ9ZpmG9nE

--HG--
extra : rebase_source : ebb2088288718631a941139d5a4d945259aaa0c6
 2017-12-14 16:55:31 -06:00
Mark Banner
ab31f33d7d Bug 1428760 - Tidy up browser_bookmarkProperties_*.js tests and stop using some obsolete APIs. r=mak 
MozReview-Commit-ID: 40PbcRNNPH6

--HG--
extra : rebase_source : 06b888bd56bb2cbdbef871e7babd029dc61e4747
 2018-01-08 13:42:53 +00:00
Zibi Braniecki
1a111ee852 Bug 1428172 - Align mozIntl with Intl when working with constructors. r=nalexander 
MozReview-Commit-ID: 5jGk1jXKkay

--HG--
extra : rebase_source : fc5445104a6d14cbacd417ce9b9b4b0bd0ea8212
 2018-01-04 13:01:43 -08:00
Mark Banner
85b029c2ae Bug 1428040 - Allow PlacesUtils.isRootItem to take guids as well as ids. r=mak 
MozReview-Commit-ID: 9ZMA2A879O8

--HG--
rename : toolkit/components/places/tests/bookmarks/test_protectRoots.js => toolkit/components/places/tests/legacy/test_protectRoots.js
extra : rebase_source : d386b6e8b9e1bfc4568032d094a48d7d9a3b3a48
 2017-12-21 09:16:48 +00:00
Ioana Crisan
9baf9bb6f6 Bug 1427701 - Add a test for checking that tags can be added to bookmarks using the star-shaped button. r=Standard8 2018-01-10 12:56:08 +02:00
Florian Quèze
0f55cd45be Bug 1421992 - script-generated patch to replace do_execute_soon, do_print and do_register_cleanup with executeSoon, info and registerCleanupFunction, rs=Gijs. 2017-12-21 11:10:23 +01:00
Florian Quèze
032c961e0a Bug 1421992 - script-generated patch to replace do_check_* functions with their Assert.* equivalents, rs=Gijs. 2017-12-21 11:08:17 +01:00
Ioana Crisan
5ba913ea91 Bug 1423137 - Add a test for checking that bookmarks can be removed from the library window. r=Standard8 2017-12-18 18:55:21 +02:00
Florian Quèze
9b41dbed41 Bug 592653 - remove gPrefService from browser.js, r=Standard8. 2017-12-19 23:46:32 +01:00
Florian Quèze
1158645bdd Bug 592653 - script-generated patch to replace gPrefService with Services.prefs, r=Standard8. 2017-12-19 23:45:10 +01:00
Mark Banner
c0dcb9675d Bug 1425339 - Allow Places tree's selectItems() function to handle guids as well as ids. r=mak 
MozReview-Commit-ID: LmZ7AYXBsJ4

--HG--
extra : rebase_source : 0c238470a32341e32db928a0c9b726c7f60f8a5a
 2017-12-14 13:56:26 -06:00
Mark Banner
eb29a6ebba Bug 1425437 - Improve view batching when dropping/pasting to tags, use the actual bookmarks count, not the count of transactions. r=mak 
MozReview-Commit-ID: B6Bt8bHhh3e

--HG--
extra : rebase_source : 88e9fe36acb672bbfb92c24c844fb1f3171584b4
 2017-11-08 15:32:51 +00:00
Gijs Kruitbosch
a18c8b5531 Bug 1424672 - stop removing the header in the recently closed places views, r=mak,Paolo 
MozReview-Commit-ID: J5HlyA8nxe2

--HG--
extra : rebase_source : c153742eb5e5179f5af917a1ad1b73e5c381e06d
 2017-12-12 16:20:49 -06:00
Ioana Crisan
62d7a2f07f Bug 1423118 - Add a test for checking that tags can be added to bookmarks using the library window. r=Standard8 
--HG--
extra : amend_source : d19fc15afddc933dcf51af75446a56b83807dd4c
 2017-12-06 16:01:15 +02:00
Ryan VanderMeulen
d945b2a059 Bug 1423667 - Disable some tests that fail on Windows Code Coverage builds with clang-cl r317840. rs=marco 
--HG--
extra : histedit_source : d2f4b4d59301469c4cabb7198f0f98c5247eab84
 2017-12-06 20:40:46 -05:00
Ioana Crisan
1f9875ccdb Bug 1419390 - Searching for bookmarks from the Bookmarks Sidebar works properly r=adw 2017-12-04 17:38:50 +02:00
Mark Banner
b0a7a885a6 Bug 1422724 - Remove unused constants in Places' controller.js. r=mak 
MozReview-Commit-ID: AWTTksnPUp8

--HG--
extra : rebase_source : 74747cd754f89ef42579d6f13884fa91db4ac641
 2017-12-04 12:09:03 +00:00
Tooru Fujisawa
c517b45ace Bug 1421119 - Wait for the next event tick before resolving promise in browser_check_correct_controllers.js. r=mak 2017-12-01 10:05:47 +09:00
Tooru Fujisawa
fe53b6f0ac Bug 1421115 - Wait for the next event tick before resolving promise in places tests. r=mak 2017-12-01 10:05:47 +09:00
Tawny Hoover
a33fa6a1f2 Bug 1398992 = Make 'Recently Bookmarked' in Photon panels support browser.bookmarks.openInTabClosesMenu pref. r=jaws 
MozReview-Commit-ID: 3Rio9EjwilT

--HG--
extra : rebase_source : dde522b0eb65b22ee74d8dfb6d5f1d1a5489237f
 2017-11-24 21:54:54 -05:00
Gijs Kruitbosch
59ffe6e6ca Bug 1408044 - fix miscellaneous tests that depended on about: existing, r=dao 
MozReview-Commit-ID: EKsaFbRoBc4

--HG--
extra : rebase_source : 3c22ed909437a7fa98e2126b4eb8b9c669f98173
 2017-11-15 17:19:33 +00:00
Dan Banner
b2e847755c Bug 1367704 - Enable the semi ESLint rule across the tree. r=standard8 
MozReview-Commit-ID: GrlcOI9K2hJ

--HG--
extra : rebase_source : 6574cf3c67eb11733ffd9999c260f71c8551abc4
 2017-05-28 19:57:46 +01:00
Ciure Andrei
a8907fc95a Backed out 5 changesets (bug 1408044) for failing Android test: TestAboutPagesPreparer.java:24: cannot find symbol. r=backout on a CLOSED TREE 
Backed out changeset 5c5152ad910d (bug 1408044)
Backed out changeset c9a062838c12 (bug 1408044)
Backed out changeset 9ceaa645f2a9 (bug 1408044)
Backed out changeset 10fc0a581606 (bug 1408044)
Backed out changeset 513140019014 (bug 1408044)
 2017-11-17 12:19:30 +02:00
Gijs Kruitbosch
03f7acbb5c Bug 1408044 - fix miscellaneous tests that depended on about: existing, r=dao 
MozReview-Commit-ID: EKsaFbRoBc4

--HG--
extra : rebase_source : 36497c95be10e307805a304e811a5b7a6bebebce
 2017-11-15 17:19:33 +00:00
Mark Banner
eeb3c2a9bd Bug 1415877 - Merge transaction handling into one function for onDrop/paste. r=mak 
MozReview-Commit-ID: AMhuLyc98WO

--HG--
extra : rebase_source : c899e2804f016ac0629de7075537c3e5c5ac28d9
 2017-11-08 14:48:45 +00:00
Mark Banner
b71430bdda Bug 1415877 - Rework PlacesControllerDragHelper#onDrop and PlacesController#paste to make the transaction handling parts similar. r=mak 
MozReview-Commit-ID: BInw5oT0Ja5

--HG--
extra : rebase_source : ff7d351f4bb251a0bb75670704f806102114394c
 2017-11-08 12:02:30 +00:00
Mark Banner
a518974a10 Bug 1415877 - Remove unused type parameter to PlacesUIUtils#getTransactionForData. r=mak 
MozReview-Commit-ID: 3kZQ4vnCk3b

--HG--
extra : rebase_source : 2f3b2d190806ecd9d7cba40a0fed96f6b6b46b12
 2017-11-08 11:25:26 +00:00
Mark Banner
9d83a5222d Bug 1402707 - Rewrite browser_library_*_middleclick.js to use Places' async APIs. r=mak 
MozReview-Commit-ID: 8PtFO00yqJv

--HG--
extra : rebase_source : e31057be3d12d11220ef52197b883acee95016b0
 2017-09-24 19:34:41 +01:00
Dão Gottwald
e57bb9cb2e Bug 464450 - Get rid of the padded class and clean up related styling. r=mak 
MozReview-Commit-ID: KYKqH9vLQ3x

--HG--
extra : rebase_source : 6242214b0c8efd8fde15714d53dd7fd63c082835
 2017-11-07 14:15:19 +01:00
Mark Banner
3c55451f9e Bug 1413843 - Improve speed of operations when pasting to the left-hand library pane by getting the right-hand pane to use for batching. r=mak 
MozReview-Commit-ID: 2Q1rIpIhmmM

--HG--
extra : rebase_source : 77239ba65f050a4272e58bf7d5d16bfd54ca6933
 2017-11-02 10:37:14 +00:00
Phil Ringnalda
202bbba5f7 Backed out changeset aa14c955261c (bug 464450) for Win10 debug non-e10s failures in editor reftests 
MozReview-Commit-ID: J83gCo2oGUh
 2017-11-06 19:55:01 -08:00
Dão Gottwald
7ca44028ae Bug 464450 - Get rid of the padded class and clean up related styling. r=mak 
MozReview-Commit-ID: 5uPRgLiSu0Q

--HG--
extra : rebase_source : 4a271f0eb515546586918412c062c3ea853c3844
 2017-10-18 14:49:00 +02:00
Mark Banner
899903b124 Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak 
This also fixes inserting bookmarks on paste at the right insertion points.

MozReview-Commit-ID: Km93oZt1UHm

--HG--
extra : rebase_source : 1623c4e5402383f0189800bcb2e70c74703aff59
 2017-10-23 18:18:00 +01:00
Mark Banner
4af8c94122 Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak 
MozReview-Commit-ID: EEFizNPmKpr

--HG--
extra : rebase_source : 9edd8bf17586e994e67959404c739e2f8ee57477
 2017-10-23 15:50:52 +01:00
Sebastian Hengst
46d4f832b2 Backed out 2 changesets (bug 1410940) for failing browser-chrome's browser/components/places/tests/browser/browser_controller_onDrop_tagFolder.js. r=backout 
Backed out changeset 1c78029ded02 (bug 1410940)
Backed out changeset 37ceb314b2b3 (bug 1410940)

--HG--
extra : rebase_source : af00f68a156b90ab4be05a3a283df450604daeaa
 2017-11-03 11:52:54 +01:00
Mark Banner
b4fcc3b3f9 Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak 
This also fixes inserting bookmarks on paste at the right insertion points.

MozReview-Commit-ID: Km93oZt1UHm

--HG--
extra : rebase_source : f37574dc8b38d3a39862735f4278eda4112ef2f3
 2017-10-23 18:18:00 +01:00
Mark Banner
4f75b383de Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak 
MozReview-Commit-ID: EEFizNPmKpr

--HG--
extra : rebase_source : 7494eb65cdd422703a9a329e3b819cc7d41794a2
 2017-10-23 15:50:52 +01:00
Mark Banner
0e947c9d32 Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak 
MozReview-Commit-ID: GL9nKfypie1

--HG--
extra : rebase_source : 5cd1c4d848dc32611349e25eb7297ba50890f0a9
 2017-10-26 10:14:14 +01:00
Margareta Eliza Balazs
1d0ba383ae Backed out changeset e17a2bca5391 (bug 1411891) for failing xpcshell in toolkit/modules/tests/xpcshell/test_NewTabUtils.js r=backout on CLOSED TREE 2017-10-31 14:19:52 +02:00
Mark Banner
d059b763bb Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak 
MozReview-Commit-ID: GL9nKfypie1

--HG--
extra : rebase_source : ca8ec95e51899bc1fb18e7a39f42a96569a2d4d1
 2017-10-26 10:14:14 +01:00
Mark Banner
4de6bf22b1 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop 
MozReview-Commit-ID: H5YVp3rnzGo

--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
 2017-10-26 11:47:01 +01:00
Sebastian Hengst
443416f881 Merge mozilla-central to autoland. r=merge a=merge 2017-10-26 00:39:55 +02:00
Oriol Brufau
4235fc5881 Bug 1394824 - Do not hide "Forget About This Site" in private browsing r=jdm 
MozReview-Commit-ID: C1TfYMG48fm

--HG--
extra : rebase_source : 4629721540dbeae257c7b1d4bc74c5c243514042
 2017-10-25 15:51:30 +02:00
Geoff Brown
b47b29116e Bug 1400323 - Disable test browser_stayopenmenu.js on osx/debug for on-going intermittent failures; r=me,test-only 
As suggested - thanks :mak!
 2017-10-25 09:53:58 -06:00
Mark Banner
795ffb3905 Bug 1409363 - Fix moving bookmarks to a top-level folder via the move bookmarks dialog - use concreteItemGuid to get the correct guid. r=mak 
MozReview-Commit-ID: E3nTqr9SPWr

--HG--
extra : rebase_source : 22fbac65741a87ddbcaae638f80093f669aafb96
 2017-10-20 14:43:02 +01:00
Mark Banner
1d50512637 Bug 1409771 - Switch tests from promiseBookmarksNotification to PlacesTestUtils.waitForNotification so that skipDescendantsOnItemRemoval/skipTags are handled correctly. r=mak 
MozReview-Commit-ID: 2dg44HRdD00

--HG--
extra : rebase_source : ea833baa47e5cd9f75831f339c87a771580881e1
 2017-10-18 16:20:43 +01:00
Mark Banner
42cb2dc6a3 Bug 1230373 - Enable mozilla/use-services for browser/components/ r=mossop 
MozReview-Commit-ID: 9m9iss3jUJJ

--HG--
extra : rebase_source : e6a6f9dec168ab1d0e0343236db65f3dd1b44aeb
 2017-10-11 15:43:51 +01:00
Sebastian Hengst
32e7816c14 Backed out changeset 824ed2525081 (bug 464450) for failing reftest editor/reftests/xul/autocomplete-1.xul on Linux builds with stylo disabled and frequently asserting in crashtests, e.g. in docshell/base/crashtests/914521.html. r=backout 
--HG--
extra : amend_source : 5819dd1419760fb402f1f4a9b923e3e20762ac71
 2017-10-17 17:59:52 +02:00
Dão Gottwald
c2d9eebe4f Bug 464450 - Get rid of the "padded" class and clean up related styling. r=mak 
MozReview-Commit-ID: GVR1I4WTgum

--HG--
extra : rebase_source : 184e0cc1b4b5d6538f4cb8286ed5050a40c8c4f3
 2017-10-13 10:59:46 +02:00
Sebastian Hengst
0fde5cb6b5 merge mozilla-central to autoland. r=merge a=merge 2017-10-17 11:46:52 +02:00
Marco Bonardo
e3fddaf049 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8 
MozReview-Commit-ID: 586IR54ggbm

--HG--
extra : rebase_source : f3d3c3e71bf92c0eecbd2e129517b7eefd70224d
 2017-10-10 12:05:19 +02:00
Neil Deakin
8c937c2917 Bug 1404999, force command updating to be enabled when a menu is opened, r=mconley 2017-10-16 11:44:59 -04:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8 
MozReview-Commit-ID: Jm8BRgt6mIv
 2017-10-15 20:50:39 +01:00
Nihanth Subramanya
4a8b35e00c Bug 1389094 - Increase height of sidebar search bar and tree items in touch mode. r=dao 
MozReview-Commit-ID: HxT3eNHImyz

--HG--
extra : rebase_source : eff12ac335b7908ded5eca9810aa41251d9eabdb
 2017-10-08 22:06:30 +05:30
Sebastian Hengst
ed86a2c11f merge mozilla-inbound to mozilla-central. r=merge a=merge 
MozReview-Commit-ID: AgDEPuT8DNK
 2017-10-11 11:41:04 +02:00
Peter Van der Beken
c705293c1c Bug 1383059 - Remove instanceof for supplemental interfaces. Part 1: add Window.isChromeWindow and switch |instanceof [nsIDOM]ChromeWindow| to use it instead. r=bz. 
--HG--
extra : rebase_source : 1efc83abae922c1a7b7eb855fd10a6333615044b
extra : source : 32277b160af4739c812ca2750a39ca111b16ea69
 2017-10-06 13:47:27 +02:00
Marco Bonardo
e5991df3ec Bug 1405687 - Remove some deprecated code from Places related code. r=standard8 
MozReview-Commit-ID: 411z07otlfN

--HG--
extra : rebase_source : 43f91cb30a7ad85f633b653d153a657ebdad1893
 2017-10-04 16:33:46 +02:00
Mark Banner
97bddec0c4 Bug 1395526 - Avoid potential race with places initialisation when clipboard tests are starting to avoid intermittents. r=mak 
MozReview-Commit-ID: 4Hr4zdZNHRp

--HG--
extra : rebase_source : 167b9158290f021c82b2c2b2a1c2fa6210e5bd63
 2017-09-21 21:21:41 +01:00
Mark Banner
430c6bd6b3 Bug 1404578 - test_async_batchUpdatesForNode.js should be under browser/ not toolkit/. r=mak 
MozReview-Commit-ID: 36doGyjaAta

--HG--
rename : toolkit/components/places/tests/unit/test_async_batchUpdatesForNode.js => browser/components/places/tests/unit/test_PUIU_batchUpdatesForNode.js
extra : rebase_source : 7275e0725f1f1228c7b48cd7dfb1d1fc1e5a0f9b
 2017-10-02 10:30:53 +01:00
Mark Banner
50a5c3faec Bug 1392533 - Make the places tree view directly communicate batch notifications to the results. r=mak 
MozReview-Commit-ID: HpN0v0jSwdK

--HG--
extra : rebase_source : 49a4810e5a85cf9f040fd544546479ad19ddf5b8
 2017-09-27 15:26:35 +01:00
Sebastian Hengst
0a305fd2d1 Backed out changeset af8fdfac66fa (bug 1405722) for failing xpcshell's browser/components/places/tests/unit/test_PUIU_livemarksCache.js, at least on OS X 10.10 opt. r=backout on a CLOSED TREE 
--HG--
extra : amend_source : 57bce00f5654ad7abca1774d2be153e95492a58b
 2017-10-17 00:55:53 +02:00
Marco Bonardo
bf0fb7d1e7 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8 
MozReview-Commit-ID: 586IR54ggbm

--HG--
extra : rebase_source : 6a714c0ab4154b219195cafee6cdfe8c3c9c5211
 2017-10-10 12:05:19 +02:00
Mark Banner
7d1e1adec8 Bug 1386513 - Handle cases of pasted bookmarks not being in the database, to fix copying bookmarks across browser instances. r=mak 
MozReview-Commit-ID: Lv2DT0WQGhZ

--HG--
extra : rebase_source : 6988c10f84f93025650f118ae45e444e69b3e431
 2017-09-08 07:01:29 +01:00
Mark Banner
f26b2e0a06 Bug 1094864 - Rewrite most of browser/components/places/tests/browser to use the newer async Places APIs. r=mak 
MozReview-Commit-ID: 78NB6QgDohQ

--HG--
extra : rebase_source : f6e476deb32710b4ec0b1011c0717eac21509035
 2017-09-22 14:01:53 +01:00
Mark Banner
fb9f7782fe Bug 1094864 - Remove unnecessary checks from browser/components/places. r=mak 
MozReview-Commit-ID: 46I7XUrmN9V

--HG--
extra : rebase_source : f9cb38c6ed0920773ced845f146e587800dd2728
 2017-09-22 10:29:26 +01:00
Mark Banner
da50499b6d Bug 1402059 - Don't import editBookmarkOverlay.js in places.xul on Mac because it is imported elsewhere. r=florian 
MozReview-Commit-ID: 5e32dMnLdik

--HG--
extra : rebase_source : 75807e91816e5e1fc583db25889b5d1de78558e4
 2017-09-21 19:35:04 +01:00
Wes Kocher
a7fe048680 Merge inbound to central, a=merge 
MozReview-Commit-ID: E7k4xViLm4V
 2017-09-21 17:03:29 -07:00
Kershaw Chang
3ccf2143f7 Bug 1247843 - Part 2: Set request context ID for the channel used to load favicon. r=mak 
This patch covers two cases when loading a favicon:
1. Get the request context ID of the document load group, when <link rel="icon"> is found in the page.
2. Use the top level document's request context ID when using the default favicon.
 2017-09-20 20:09:00 -04:00
Jared Wein
91f61f1115 Bug 1400975 - Add specific placeholders for the sidebar search boxes. r=adw 
MozReview-Commit-ID: KtIFalMLw0B

--HG--
extra : rebase_source : 2f3dffe8e7c20b645f1ebd4a4f59a3a7c6401d3a
 2017-09-19 17:02:07 -04:00
Mark Banner
8332d2278d Bug 1401242 - Fix removing bookmarks from tag groups - when getting the tagGuid from the node, we must get it async, rather than using the concrete guid. r=mak 
MozReview-Commit-ID: 7fGS6jFNVPl

--HG--
extra : rebase_source : 67306adaa925b32bae8fe928b77692842304be9a
 2017-09-19 20:47:26 +01:00
Gijs Kruitbosch
40de26eb54 Bug 1401238 - remove recent bookmarks from the bookmarks menu button and toplevel bookmarks menu, r=mak 
MozReview-Commit-ID: 7JT9xCq9zcS

--HG--
extra : rebase_source : b6dca5a110636a66181c6843aba616192288fa92
 2017-09-20 00:38:39 +01:00
Mark Banner
83d88f0a96 Bug 1400846 - Fix ordering of bookmarks with Async Transactions when dropping into different folders. r=mak 
MozReview-Commit-ID: GjnehR5PumZ

--HG--
extra : rebase_source : a913bf0584803993f9c5ecd061acdc1b40264254
 2017-09-19 06:54:16 +01:00
Nan Jiang
dcc9a5e00a Bug 1352459 - Collect rich icons in ContentLinkHandler. r=mak,Mardak 
MozReview-Commit-ID: GrjpuyvY7nm

--HG--
extra : rebase_source : a1800ae9f1626aeeea311ea85c81e50b5dd2094c
 2017-09-12 09:47:51 -04:00
Tawny Hoover
2415e21cbc Bug 260611 - Introduce pref browser.bookmarks.openInTabClosesMenu to optionally leave menu open for single bookmark menuitem clicks that open in new tab. r=mak 
MozReview-Commit-ID: HreM02pdzWP

--HG--
extra : rebase_source : aa9934418fbc55a66848e5e7757b0885ac3be275
 2017-09-11 12:12:21 -04:00
Michael Layzell
c24551af0d Bug 1398471 - Read data from DataTransfer before yielding, r=gijs 
Previously the code looped and yielded between each loop. This caused the
DataTransfer to be cleared before the read completed.

This splits the loop into 2 sections such that we read all important data from
the DataTransfer before it is cleared.
 2017-09-13 11:45:48 -04:00
Marco Bonardo
1e78e32502 Bug 1398019 - Favicons missing in Bookmarks toolbar on startup. r=past 
This is due to the fact now we set the icons only when the nodes visibility is updated.
The patch always updates nodes visibility when we rebuild the toolbar.
updateChevron() is being renamed accordingly and acts regardless of chevron.collapsed.

MozReview-Commit-ID: Cz1U710J42M

--HG--
extra : rebase_source : eec1608c106b56b7ef090c52d6b57bedf948741d
 2017-09-08 11:43:08 +02:00
Mark Banner
a16d4003dc Bug 1397387 - Move async actions out of the opening/closing cycles of the bookmarks dialog to ensure they finish. r=mak 
MozReview-Commit-ID: 9H5hPfTNv0S

--HG--
extra : rebase_source : 7012972cb2e4af14500ca7a3376effdb7b1fd7e0
 2017-09-06 21:53:08 +01:00
Mark Banner
3d92d0e6d3 Bug 1397545 - Don't update the recently bookmarks item list when it is hidden and a bookmark is deleted. r=mak 
MozReview-Commit-ID: CnbFMONaRil

--HG--
extra : rebase_source : 93fb1713b1ad74f52b9945f71c267f0a27e39426
 2017-09-07 10:49:03 +01:00
Marco Bonardo
8fe846e658 Bug 1392081 - Mochitest browser test for bookmarks toolbar overflow. r=Gijs 
MozReview-Commit-ID: DwDZl2AELXC

--HG--
extra : rebase_source : 129a8fb0ba0cd62c70e4d53bbd7dd84523bb149d
 2017-08-28 14:43:59 +02:00
Marco Bonardo
1297cc49c2 Bug 1392081 - Only build a subset of the buttons that may become visible on the bookmarks toolbar. r=Gijs 
MozReview-Commit-ID: GOlQzUKw2go

--HG--
extra : rebase_source : f35df9b3c379ac9121b404cecac45cfec3ef2105
 2017-08-25 17:14:31 +02:00
Marco Bonardo
9561583630 Bug 1392081 - Set the image attribute on bookmarks toolbar buttons only when they are visible. r=Gijs 
MozReview-Commit-ID: HIalcxcCBsv

--HG--
extra : rebase_source : a5e6107f63d4a16005852511ab3b15cbb9771015
 2017-08-25 15:31:06 +02:00
Marco Bonardo
a1dcd5bfcb Bug 1392081 - Use a document fragment to populate toolbar and menu Places views. r=Gijs 
MozReview-Commit-ID: 1Q4U3xXfF4Y

--HG--
extra : rebase_source : 2cd7816f9b61a3099b3ea5e81c61e14413a048ae
 2017-08-25 15:20:00 +02:00
Mark Banner
087ed06f51 Bug 1396888 - Handle async moving of bookmarks in the caller for the move dialog, to avoid going out of scope whilst async actions are happening. r=mak 
MozReview-Commit-ID: JhETMnmxNOD

--HG--
extra : rebase_source : ff7b201900d06c7d9feafb791dea03d19ec4bdcd
 2017-09-05 17:15:58 +01:00
Sebastian Hengst
0d5b7f84bb Backed out changeset 2b76c3b079d9 (bug 1392081) for failing browser/components/places/tests/browser/browser_toolbar_overflow.js. r=backout 2017-09-05 23:12:13 +02:00
Sebastian Hengst
e87e851526 Backed out changeset ecd61b92f9b3 (bug 1392081) 2017-09-05 23:11:25 +02:00
Sebastian Hengst
93bc0189bb Backed out changeset 8998e0bed6ff (bug 1392081) 2017-09-05 23:11:20 +02:00
Sebastian Hengst
f2cb170d58 Backed out changeset 882a40327e5a (bug 1392081) 2017-09-05 23:11:14 +02:00
Marco Bonardo
97831f5b2c Bug 1392081 - Mochitest browser test for bookmarks toolbar overflow. r=Gijs 
MozReview-Commit-ID: DwDZl2AELXC

--HG--
extra : rebase_source : 2668e6d8dc1b227992b632dacc1c6bb501a1bdee
 2017-08-28 14:43:59 +02:00
Marco Bonardo
d81ea2a51e Bug 1392081 - Only build a subset of the buttons that may become visible on the bookmarks toolbar. r=Gijs 
MozReview-Commit-ID: GOlQzUKw2go

--HG--
extra : rebase_source : b721087519e686f256e86308b8fcecec2afc7f47
 2017-08-25 17:14:31 +02:00
Marco Bonardo
c2d287bf75 Bug 1392081 - Set the image attribute on bookmarks toolbar buttons only when they are visible. r=Gijs 
MozReview-Commit-ID: HIalcxcCBsv

--HG--
extra : rebase_source : a5e6107f63d4a16005852511ab3b15cbb9771015
 2017-08-25 15:31:06 +02:00
Marco Bonardo
2168017f1d Bug 1392081 - Use a document fragment to populate toolbar and menu Places views. r=Gijs 
MozReview-Commit-ID: 1Q4U3xXfF4Y

--HG--
extra : rebase_source : 2cd7816f9b61a3099b3ea5e81c61e14413a048ae
 2017-08-25 15:20:00 +02:00
Mark Banner
e98740d9e0 Bug 1391393 - Cancelling the bookmarks properties dialog shouldn't undo when no changes have been made. r=mak 
MozReview-Commit-ID: 7supBHcrpdu

--HG--
extra : rebase_source : 83947eae2c31253659a9acb0a924fcee48d11871
 2017-08-24 12:51:38 +01:00
Mark Banner
d47cfbe9b8 Bug 1395784 - Skip browser_controller_onDrop.js when async places transactions are turned off. r=mak 
MozReview-Commit-ID: FFJLRIvOfZX

--HG--
extra : rebase_source : 850b0cafd6319d5af8f3dcd63c135544ec6b48bc
 2017-09-04 11:23:07 +01:00
Mark Banner
54aa7112b3 Bug 1391166 - Fix the order of bookmarks via drag and drop when moving a bookmark down in the list. r=mak 
MozReview-Commit-ID: 7Adz2Et0NQn

--HG--
extra : rebase_source : 5354b6c0799d84562e49f26225ecfdd47be29782
 2017-08-23 12:24:53 +01:00
Mark Banner
0fb1ade5d2 Bug 1393771 - Fix issues in tests that cause failures when they are re-ordered. r=mak 
MozReview-Commit-ID: 8PUTruIRPK8
 2017-08-30 17:57:19 +01:00
Mark Banner
9d43fdf934 Bug 1393771 - Rename some tests in browser/components/places/tests/browser/ to avoid bug numbers in filenames. r=mak 
MozReview-Commit-ID: JSZiOJ3vDo3

--HG--
rename : browser/components/places/tests/browser/browser_423515.js => browser/components/places/tests/browser/browser_bookmark_folder_moveability.js
rename : browser/components/places/tests/browser/browser_555547.js => browser/components/places/tests/browser/browser_check_correct_controllers.js
rename : browser/components/places/tests/browser/browser_425884.js => browser/components/places/tests/browser/browser_copy_folder_tree.js
rename : browser/components/places/tests/browser/browser_435851_copy_query.js => browser/components/places/tests/browser/browser_copy_query_without_tree.js
rename : browser/components/places/tests/browser/browser_416459_cut.js => browser/components/places/tests/browser/browser_cutting_bookmarks.js
rename : browser/components/places/tests/browser/browser_410196_paste_into_tags.js => browser/components/places/tests/browser/browser_paste_into_tags.js
rename : browser/components/places/tests/browser/browser_475045.js => browser/components/places/tests/browser/browser_toolbar_drop_text.js
 2017-08-30 17:57:14 +01:00
Mark Banner
a1ca1b7842 Bug 1394801 - Ensure livemarks are removed from the PlacesUIUtils livemark cache with async PlacesTransactions turned on. r=mak 
MozReview-Commit-ID: B6ubzDhReCE

--HG--
extra : rebase_source : b22b0b878b2a5b5d1a588512e2729a3a9d3989f1
 2017-08-29 17:06:34 +01:00
Hector Zhao
eb2fe0e37f Bug 658245 - Part 2: add a browser mochitest for loadBookmarksInTabs. r=mak 
MozReview-Commit-ID: JoFvDl5uLxD

--HG--
extra : rebase_source : 771cbee645fdad07adf909ad3923e4fd525b4d3e
 2017-08-22 19:02:14 +08:00
Hector Zhao
d506417ae0 Bug 658245 - Part 1: pref to open bookmark in a new tab. r=mak 
MozReview-Commit-ID: A8nhmBjbNGh

--HG--
extra : rebase_source : 53d3c57bf6e894b46e99163b951d521191439363
 2017-08-10 18:21:40 +08:00
Phil Ringnalda
771ebe8f36 Backed out changeset 894a3b7efcdd (bug 1393771) for failures in the renamed browser_bookmark_folder_moveability.js and browser_toolbar_drop_text.js 
MozReview-Commit-ID: 5VdpE9FYVLW

--HG--
rename : browser/components/places/tests/browser/browser_paste_into_tags.js => browser/components/places/tests/browser/browser_410196_paste_into_tags.js
rename : browser/components/places/tests/browser/browser_cutting_bookmarks.js => browser/components/places/tests/browser/browser_416459_cut.js
rename : browser/components/places/tests/browser/browser_bookmark_folder_moveability.js => browser/components/places/tests/browser/browser_423515.js
rename : browser/components/places/tests/browser/browser_copy_folder_tree.js => browser/components/places/tests/browser/browser_425884.js
rename : browser/components/places/tests/browser/browser_copy_query_without_tree.js => browser/components/places/tests/browser/browser_435851_copy_query.js
rename : browser/components/places/tests/browser/browser_toolbar_drop_text.js => browser/components/places/tests/browser/browser_475045.js
rename : browser/components/places/tests/browser/browser_check_correct_controllers.js => browser/components/places/tests/browser/browser_555547.js
 2017-08-26 12:54:54 -07:00
Mark Banner
1a648d444b Bug 1393771 - Rename some tests in browser/components/places/tests/browser/ to avoid bug numbers in filenames. r=mak 
MozReview-Commit-ID: JSZiOJ3vDo3

--HG--
rename : browser/components/places/tests/browser/browser_423515.js => browser/components/places/tests/browser/browser_bookmark_folder_moveability.js
rename : browser/components/places/tests/browser/browser_555547.js => browser/components/places/tests/browser/browser_check_correct_controllers.js
rename : browser/components/places/tests/browser/browser_425884.js => browser/components/places/tests/browser/browser_copy_folder_tree.js
rename : browser/components/places/tests/browser/browser_435851_copy_query.js => browser/components/places/tests/browser/browser_copy_query_without_tree.js
rename : browser/components/places/tests/browser/browser_416459_cut.js => browser/components/places/tests/browser/browser_cutting_bookmarks.js
rename : browser/components/places/tests/browser/browser_410196_paste_into_tags.js => browser/components/places/tests/browser/browser_paste_into_tags.js
rename : browser/components/places/tests/browser/browser_475045.js => browser/components/places/tests/browser/browser_toolbar_drop_text.js
extra : rebase_source : 92e3683e3dd23dcbb30ec26c0d08c516182aa325
 2017-08-25 14:23:35 +01:00
Mark Banner
a74cac68c6 Bug 1388687 - Change the recent bookmarks object to only update the menu items when really necessary, and only do a database query when the recent bookmarks need updating. r=mak 
MozReview-Commit-ID: J4WxNoTPxkc

--HG--
extra : rebase_source : d4c014b2e1b77bc761a62de49a767f539689ee29
 2017-08-21 16:05:30 +01:00
Mark Banner
516c36bad2 Bug 1388687 - Add tests for the recently bookmarked menu items. r=mak 
MozReview-Commit-ID: 1DwqcXenwuK

--HG--
extra : rebase_source : 942c676f122a067ca399ab5d658e933dd03bdeb0
 2017-08-09 16:50:59 +01:00
Dan Banner
f1eb5aaa84 Bug 1392119 - Enable the ESLint no-caller rule across mozilla-central r=standard8 
MozReview-Commit-ID: JOC1330iFnh

--HG--
extra : rebase_source : 2afcb219d4a0d78f996bdc2c841456d2dccff605
 2017-08-23 13:38:24 +01:00
Mark Banner
e83b03bdda Bug 1392189 - Fix deleting bookmark tags from the Library view with Places Transactions enabled. r=mak 
MozReview-Commit-ID: unNGjPpTX6

--HG--
extra : rebase_source : 21fee324ede6d516b0ae4dccc093644c2f738b8b
 2017-08-23 13:40:44 +01:00
Mark Banner
a53020d022 Bug 1392098 - Enable the new ESLint no-useless-run-test rule across the tree. r=mossop 
MozReview-Commit-ID: 35MaseieNUk

--HG--
extra : rebase_source : 98eaec6a67fd3b30ea6b0be641f26c3911012fab
 2017-08-20 18:52:05 +01:00
Mark Banner
144f004df2 Bug 885246 - Remove usage of the sync history.getPageTitle API from BookmarkProperties.js. r=adw 
MozReview-Commit-ID: KXhWKebkdvz

--HG--
extra : rebase_source : 44fcdacb2fd031f14634b6f3033f8230e9a183ce
 2017-08-08 19:46:28 +01:00
Mark Banner
f6b7398a66 Bug 885246 - Delay enabling the accept button on the bookmarks properties dialog until after init is complete. r=adw 
The initialisation can sometimes take a long time. To avoid data gathering being incomplete, we disable the accept button
until it has completed.

MozReview-Commit-ID: 3gnROdZkYae

--HG--
extra : rebase_source : 2f65a1eae19fbb725380a5fa3ffa906c64888c18
 2017-08-08 14:01:57 +01:00
Nihanth Subramanya
e8a2947c16 Bug 1377003 - [Photon] Update sidebar tree styling on Linux. r=dao 
MozReview-Commit-ID: 4ZR3bdN3qFX

--HG--
extra : rebase_source : c2ca1fd95f554d18718decf3df7fa9344af67fc5
 2017-07-18 19:06:10 +05:30
Gijs Kruitbosch
fcb33eb27c Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer 
MozReview-Commit-ID: VQUuQHyCXi

--HG--
extra : rebase_source : e76167b317c19993b23a9e869146a2201c3ff5ef
 2017-08-10 23:05:33 +01:00
Gijs Kruitbosch
ad0e178cad Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer 
MozReview-Commit-ID: 1vjP6IeIiPz

--HG--
extra : rebase_source : e3ef4468299adfd0b874ba2f44a034c2655ecd6f
 2017-08-10 23:04:54 +01:00
Andrew Halberstadt
d2109610fb Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8 
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : 8607b3964da207a6076c79b6f1d75b40503cdd7d
 2017-08-10 14:48:21 -04:00
Phil Ringnalda
0ff5a4285d Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland 
MozReview-Commit-ID: 3HDE2C3wSU0
 2017-08-10 20:21:19 -07:00
Wes Kocher
cff9e9b197 Merge m-c to autoland, a=merge 
MozReview-Commit-ID: 2YvHbITn9w3
 2017-08-10 18:25:34 -07:00
Sebastian Hengst
6081d7a11e Backed out changeset bf603affd1e0 (bug 1388753) for failing browser-chrome's browser_947914_button_history.js. r=backout a=merge 
MozReview-Commit-ID: AHOsaTvCWms

--HG--
extra : source : 5475c7748903350a91842046eeb614880738b83e
 2017-08-10 20:02:44 +02:00
Sebastian Hengst
3cb6b7715c Backed out changeset e4d1389a96ca (bug 1377967) because it blocks the backout of bug 1388753. r=backout 
MozReview-Commit-ID: JMozgGI7pWY

--HG--
extra : source : f5c973874a8cc631cf06f3edaf38c8a363398b81
 2017-08-10 20:01:44 +02:00
Gijs Kruitbosch
e105c93b98 Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer 
MozReview-Commit-ID: VQUuQHyCXi

--HG--
extra : rebase_source : 75e148a49ed86e1c979991daa43d31cfbf9511e0
 2017-08-09 21:04:27 +01:00
Gijs Kruitbosch
12b877d713 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer 
MozReview-Commit-ID: 1vjP6IeIiPz

--HG--
extra : rebase_source : 1bf36537326b86fff6e3db814908cb64aaad3e57
 2017-08-09 18:02:36 +01:00
Gijs Kruitbosch
2de2d3a7e9 Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer 
MozReview-Commit-ID: VQUuQHyCXi

--HG--
extra : rebase_source : 8f2edec2e0de448d4814b254f5c2458aa645be32
 2017-08-10 23:05:33 +01:00
Gijs Kruitbosch
35bd3646b1 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer 
MozReview-Commit-ID: 1vjP6IeIiPz

--HG--
extra : rebase_source : 9d07a961de011395366f2736eab62e5bbcbcd19d
 2017-08-10 23:04:54 +01:00
Andrew Halberstadt
f625fd5c37 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8 
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : d72a88962ec8d843e7be99e25f710887f01b6e1a
 2017-08-10 14:48:21 -04:00
Sebastian Hengst
e5aac1d087 Backed out changeset bf603affd1e0 (bug 1388753) for failing browser-chrome's browser_947914_button_history.js. r=backout 2017-08-10 20:02:44 +02:00
Sebastian Hengst
c3b5851db2 Backed out changeset e4d1389a96ca (bug 1377967) because it blocks the backout of bug 1388753. r=backout 2017-08-10 20:01:44 +02:00
Gijs Kruitbosch
ce10833235 Bug 1383009 - add flexible spacers and library button to the navbar by default, r=jaws 
Because we generate IDs for special nodes, we should update the inDefaultState getter to actually consider
these nodes to match even when the ids differ. This wasn't an issue before because specials weren't in the
default set for any nodes.

MozReview-Commit-ID: AI85yt2LuJD

--HG--
extra : rebase_source : 819e27885148deb588c057c4e811371a87f1d2fc
 2017-08-07 19:10:40 +01:00
Mark Banner
17760ce731 Bug 1388250 - Remove old sync isBookmarked and getBookmarkedURIFor APIs from nsINavBookmarksService. r=Paolo 
Also remove IsBookmarkedInDatabase(), mItemCount, RecursiveFindRedirectedBookmark(), UpdateKeywordsForRemovedBookmark() from nsNavBookmarks as they aren't used anywhere.

MozReview-Commit-ID: 4cZXAdRuVoF

--HG--
extra : rebase_source : 2c08a09de48cfb06c3e8db261dfe7ea1b1526e10
 2017-08-08 07:58:59 +01:00
Michael Kohler
674e1b96fb Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao 
MozReview-Commit-ID: 8w1vfF2yRui

--HG--
extra : rebase_source : 222d8e9d3b9543552ff5b08967375fa46d62b896
 2017-08-08 12:09:14 +02:00
Mark Banner
0b94d0fe3e Bug 1385733 - Improve the performance of async transactions when bookmarking all tabs. r=adw 
Optimise adding a folder with child bookmarks for transactions by allowing PlacesTransactions.NewFolder to take children details and use insertTree rather than needing separate NewFolder and then multiple NewBookmark transactions.

MozReview-Commit-ID: 6s9j0pbsiUB

--HG--
extra : rebase_source : 0b4029905dc76a0ca49d16a7e71c85f1f07b8e2d
 2017-08-03 18:32:42 +01:00
Gijs Kruitbosch
768b0621d1 Bug 1385083 - history panel should actually list history, r=mikedeboer 
MozReview-Commit-ID: G98QMcmASv0

--HG--
extra : rebase_source : 4a8e533d21d0a4a1d464f1e5f546c82c81fce37f
 2017-08-07 15:24:49 +01:00
Masatoshi Kimura
8b713b2b0f Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj 
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.

MozReview-Commit-ID: 4ecl3RZhOwC

--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
 2017-08-04 17:49:22 +09:00
Sebastian Hengst
ca40024d84 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
45d5f35624 Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao 
MozReview-Commit-ID: CoHv9mKpAe

--HG--
extra : rebase_source : 20d6404db9f90cfcb7de03d4c527ad6ed79d49f8
 2017-08-05 20:37:40 +02:00
Sebastian Hengst
8c82624aa1 merge mozilla-central to autoland. r=merge a=merge 2017-08-05 11:59:12 +02:00
Sebastian Hengst
39ccebaf18 merge mozilla-inbound to mozilla-central. r=merge a=merge 
MozReview-Commit-ID: 9IxbB2vCH4S
 2017-08-05 11:55:25 +02:00
Dão Gottwald
c2876c7355 Bug 1387084 - Use instant scroll behavior when doing pixel scrolling. r=Gijs 
Touchmove and wheel events are sent frequently enough that smooth scroll behavior
prevents the expected pixel distance from being reached before the next event.

Also replace aSmoothScroll parameters with aInstant to better reflect how this
works: its purpose is to force instant scrolling, whereas omitting it falls back
to "auto" (which may mean instant or smooth depending on different factors).

The ensureElementIsVisible call from browser-customization.js can go away as
customize mode doesn't add padding around the window anymore.

Finally, remove the unused scrollPosition and scrollPaddingRect properties.

MozReview-Commit-ID: 3Ac7g6zZ0hW

--HG--
extra : rebase_source : e43d0bcab82c74e65d01a0fd79bfaec96952b35a
 2017-08-05 10:12:38 +02:00
Sam Foster
bae82564b3 Bug 1352075 - Implement new animation for opening/closing the arrow panels. r=dao,mossop 
* Use new panel animation when opening arrow-panels (including bookmarks menu) to fade in and drop into position
* Linux/GTK is (still) excluded
* New animation is non-directional (i.e. LTR vs. RTL)

This was landed then backed out due to test failures. New since last review:

* Make opacity & transform transition durations equal - ensuring popup is not still moving when popupshown is fired
* Fix missing comma in transition-duration values
* Add animating attribute to the arrowpanel binding to disable pointer-events during the opening transition (via :jaws)
* Wait for popupshown rather than transitionend in bookmark reparenting test
* Fix specificity of CSS rules for panels/bookmarks-menu on edges other than the top (via :jaws)

MozReview-Commit-ID: DTnvyMryf5Y

--HG--
extra : rebase_source : 77895818356b1b366e93c6a8c508ae2b74dbca5c
 2017-07-27 11:07:23 -07:00
Sebastian Hengst
d9f6b67320 merge mozilla-central to mozilla-inbound. r=merge a=merge 2017-08-04 19:32:45 +02:00
Paolo Amadini
a0fc00495b Bug 1381411 - Implement the DownloadHistoryList object. r=mak 
This also changes the Library window to use the newly added back-end object. The only user-visible change should be how the selection behaves when retrying downloads.

MozReview-Commit-ID: 7CQr1m21rcB

--HG--
extra : rebase_source : e36faf63dadeba0c897b769cb7e14a2d01d0f628
extra : amend_source : 2c7a88b6e3d6de50b37c34a5579b3ab6fb0c10dd
 2017-08-04 14:48:53 +01:00
Gijs Kruitbosch
1409e6926f Bug 1354117 - stop relying on gPhotonStructure in bookmarks/history code, r=adw 
MozReview-Commit-ID: FqUFNrSufvQ

--HG--
extra : rebase_source : 91e20d260e2fc227b153366aab09e37fbe99ef57
 2017-08-01 19:55:41 +01:00
Marco Bonardo
f32ef43797 Bug 1382991 - Cleanup Places controller InsertionPoint. r=standard8 
MozReview-Commit-ID: 2pSbYtPGtYx

--HG--
extra : rebase_source : a66e444f03ad45ff9d9a0e622d1951cff5964082
 2017-08-03 12:16:36 +02:00
Masatoshi Kimura
f143125cc2 Bug 1326520 - Rename nsIURI.path to pathQueryRef. r=valentin.gosu 
MozReview-Commit-ID: DqJdTGopR9G

--HG--
extra : rebase_source : e8c9eb03468c075b79013b6e0bd8b367229c24cd
 2017-07-29 20:50:21 +09:00
Rajesh Kathiriya
48e6bc2124 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
 2017-07-25 23:45:41 +05:30
Marco Bonardo
7f236c3765 Bug 1094818 - Use Bookmarks.jsm in controller.js. r=standard8 
MozReview-Commit-ID: 7vli02K19bt

--HG--
extra : rebase_source : a28bfe52ea3672b5342b44890198703c455e92cb
 2017-07-18 19:18:02 +02:00
Sebastian Hengst
804a36e668 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
22dfa54ef4 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
 2017-07-25 23:45:41 +05:30
Marco Bonardo
8bab7e1d1f Bug 1383138 - 'Bookmark all tabs' dialog is broken with async Places transactions. r=adw 
MozReview-Commit-ID: IERtEaCCbjA

--HG--
extra : rebase_source : 75b2ad7b1bdaa57ee038b2d98ec08709fdb51596
 2017-07-25 22:24:05 +02:00
Marco Bonardo
4a6d03679e Bug 1382291 - Intermittent browser/components/places/tests/browser/browser_markPageAsFollowedLink.js. r=adw 
MozReview-Commit-ID: KBukQFU9WPn

--HG--
extra : rebase_source : bcad7bf7011f510f574c49b168bb4b4ccf5cc8f2
 2017-07-26 13:52:24 +02:00
Mike de Boer
9c16099969 Bug 1354533 - Update the History panelview when it's shown inside the new Library panel. r=mak 
This patch changes the history-panelmenu widget with the following:
 - Move the Recently Closed Tabs and Recently Closed Windows lists into their own
   respective (nested) subview,
 - Add a Recent History header to list of history items,
 - Extend the list of Recent History items to be max 42 items long,
 - Share more code with Bookmarks panel,
 - Generalizes panelview event dispatching to always support customizable widgets.

MozReview-Commit-ID: 4sBR6llIvxG

--HG--
extra : rebase_source : 2758dd643cd504448ee1f19296670a588bf56069
 2017-07-21 15:07:23 +02:00
Marco Bonardo
3a8adcdf32 Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker. r=adw 
MozReview-Commit-ID: A2sn2OreX4K

--HG--
extra : rebase_source : 6c9dd729c2aad0b5870f0cbf1e565a33376c4f56
 2016-05-19 23:50:27 +02:00
Florian Quèze
c41a960d40 Bug 1381853 - lazy load browserPlacesViews.js into the browser window, r=mconley. 2017-07-23 00:17:56 +02:00
Mark Banner
7564d07c58 Bug 1381027 - Remove unnecessary async definitions for functions in editBookmarkOverlay.js. r=mak 
MozReview-Commit-ID: HvSotonXYJM

--HG--
extra : rebase_source : 990675e01c0da9f4c98f3a1708f308409100fa40
 2017-07-14 15:42:05 +01:00
Mark Banner
9651d46673 Bug 1378711 - Ensure that current places transactions have completed before clearing batch processing mode to avoid messing up the undo queue. r=mak 
MozReview-Commit-ID: 7k0sgZIaUyB

--HG--
extra : rebase_source : 36a599395a13374550644dd5a2c63f8938de8d6d
 2017-07-06 11:57:44 +01:00
Marco Bonardo
1c6157f76f Bug 1379611 - Avoid GetItemTitle() synchronous API in editBookmarkOverlay.js. r=standard8 
MozReview-Commit-ID: 9Ig63XHcEIE

--HG--
extra : rebase_source : 8a1ff8778f00075c8741bf3a8ee3367ddf848260
 2017-07-10 16:13:55 +02:00
Marco Bonardo
a3c91674b9 Bug 1379611 - Avoid GetBookmarkURI() synchronous API in editBookmarkOverlay.js. r=standard8 
MozReview-Commit-ID: 1LmJqSj1xnw

--HG--
extra : rebase_source : 195a97b6139a8fd3b24e55d83f8e9e5136ae222e
 2017-07-10 16:21:01 +02:00
Marco Bonardo
c4a765574b Bug 1379611 - Avoid GetFolderIdForItem() synchronous API in editBookmarkOverlay.js. r=standard8 
MozReview-Commit-ID: LLikbxfAN4u

--HG--
extra : rebase_source : b16980fdfee12533355acc63d16944882ed64870
 2017-07-10 15:37:55 +02:00
Ioana Crisan
b0cb99a7a1 Bug 1427755 - Add a test for checking that the title of a bookmark can be changed from the bookmark star, toolbar, and sidebar. r=Standard8 2018-01-22 10:45:11 +02:00
Mark Banner
35f3666937 Bug 1380009 - Enable the ESLint no-return-await call to avoid unnecessary intermediate promise creation. r=mossop 
MozReview-Commit-ID: EnhSBHMjurr

--HG--
extra : rebase_source : 74ba4c10e369067629af95bf705a9acd0df1089b
 2017-07-11 22:49:55 +01:00
Marco Bonardo
bfc44708bc Bug 1371677 - Delay the database connection in the history service as far as possible. r=adw 
Makes initing Places services cheaper, by delaying the connection creation to the first time
it's actually needed.
Same way, delays reading the bookmark roots at the first time they are requested.
Deprecates the concept of lazy observers, since they are no more needed, we can just use addObserver.
Simplifies the startup path: always sends "places-init-complete" (both as a category and a topic) when
the connection starts and adds a "locked" database state when we can't get a working connection.
Makes PlacesCategoriesStarter register for the new category, since it's cheaper than being a bookmarks
observer.
Fixes a couple race conditions in keywords and expiration due to new startup timings.
Removes a test in test_keywords.js that is no more easily feasible, since it'd requires a pre-build
places.sqlite that should be kept up-to-date at every version.

MozReview-Commit-ID: 6ccPUZ651m0

--HG--
extra : rebase_source : 07376076eb42c84caaedeffd75f133d83a6c3d70
 2017-06-09 18:51:09 +02:00
Mark Banner
2cab05d5b9 Bug 1376925 - In the bookmarks folder tree of the edit dialog, don't invalidate elements whilst we are editing. Also improve the stability of browser_bookmarksProperties.js. r=mak 
MozReview-Commit-ID: IRDgLVACMxG

--HG--
extra : rebase_source : ddf398073334602cce60d0ff4d04f870351d5674
 2017-07-04 14:27:44 +01:00
Mark Banner
5ef90cd6f6 Bug 1376925 - Avoid some warnings about this._paneInfo being undefined in editBookmarkOverlay.js when an event happens during closing the dialog. r=mak 
MozReview-Commit-ID: GZKe4z6kpGP

--HG--
extra : rebase_source : 2a06e543de79054946f97b3f3474dbb1316ef942
 2017-07-04 14:18:11 +01:00
Mark Banner
4780146c53 Bug 1376925 - Modernise browser_bookmarksProperties.js to use async functions and assert. r=mak 
MozReview-Commit-ID: 26PBBgP9tSf

--HG--
extra : rebase_source : 606290789574efc71a85fa132655fd6b7b116669
 2017-07-04 13:20:53 +01:00
Rajesh Kathiriya
881bce09ea Bug 1374670 - Enabled the ESLint no-tabs rule across mozilla-central r=standard8 
MozReview-Commit-ID: RT5QTipaOW

--HG--
extra : rebase_source : 84bccaeba083bc430316d3c80d5c8f56494f1950
 2017-07-04 21:30:18 +05:30
Mark Banner
d26285da29 Bug 1378132 - Update browser_bookmarkProperties_addKeywordForThisSearch.js to wait for keywords in an async situation, also ensure the remove notifications happen before finishing the test. r=mak 
MozReview-Commit-ID: 2gA5NhmslHv

--HG--
extra : rebase_source : 7c5a3268f704a25000881e93623925aa7b498676
 2017-06-30 07:48:32 -07:00
Marco Bonardo
d3bad38937 Bug 1376929 - Fix places-related mochitests in chrome/ for async-transactions. r=standard8 
MozReview-Commit-ID: ILrvOGzu1zo

--HG--
extra : rebase_source : de00f7f734711e2d2c8521626ad8857ab858bb97
 2017-07-03 15:46:56 +02:00
Mark Banner
b9a583c5cc Bug 1211092 - Wait for the editItemOverlay to be initialised before continuing with browser_bookmarksProperties.js to avoid intermittents. r=mak 
MozReview-Commit-ID: AvTCWGFGuqf

--HG--
extra : rebase_source : 6bdae5887b5f5d475d3ec0f0d249be45347133a3
 2017-07-03 16:36:47 +01:00
Carsten "Tomcat" Book
8e3fa527c9 merge mozilla-inbound to mozilla-central a=merge 2017-07-04 10:48:33 +02:00
Frederik Braun
56838ddb04 Bug 1351608 - Disable warnings for existing violations to no-unsanitize rule r=Standard8. 
MozReview-Commit-ID: 7cTNL5jMtRw
 2017-07-03 20:07:02 +01:00
Kit Cambridge
31ccf3dc94 Bug 1360872 - Return empty strings for null bookmark titles. r=mak 
MozReview-Commit-ID: Dd2sEfYvnBt

--HG--
extra : rebase_source : 963b09955610d099b1acb508472a2a3c24202d73
 2017-06-06 14:37:22 -07:00
Mike de Boer
702aa1332c Bug 1354159 - Part 3 - Add a Bookmarks button to the Library panel that shows a subview with a list of most recent bookmarks. r=Gijs,mak 
This patch changes the Recent Bookmarks flow in browser-places.js to use the new
PlacesPanelview to provide a rich view that support drag and drop and context
actions.
A new button 'Search Bookmarks' was added, which prefills the urlbar with '* ',
which is a shortcut for searching bookmarks using the Awesomebar.

MozReview-Commit-ID: 1XlO8HMKEJs

--HG--
extra : rebase_source : 59cdf8a24341eb5df55511c5be83ebee8787aad5
 2017-06-29 17:57:25 -07:00
Mike de Boer
b4756f63f5 Bug 1354159 - Part 2 - Introduce a new Places view type, PlacesPanelview, which can visualize query results inside panelview nodes. r=Gijs,mak 
MozReview-Commit-ID: Ft1RC7dsqKD

--HG--
extra : rebase_source : e9448ee073b5341efc63496ae6504a764ee43f30
 2017-06-29 17:57:24 -07:00
Mike de Boer
0da1ebf2ab Bug 1354159 - Part 1 - Remove the unneeded third 'view' argument from PlacesUIUtils.openNodeWithEvent(). r=mak 
MozReview-Commit-ID: Jema2qMYEdX

--HG--
extra : rebase_source : 9cd5850e7c306ff62f9751ce419a278e8978b04e
 2017-06-29 17:57:22 -07:00
Sebastian Hengst
2cfb02f19d Backed out changeset c0fd6c0590be (bug 1360872) for unused parentId at toolkit/components/places/Bookmarks.jsm:461. r=backout 2017-06-30 00:16:35 +02:00
Kit Cambridge
e80441db92 Bug 1360872 - Return empty strings for null bookmark titles. r=mak 
MozReview-Commit-ID: Dd2sEfYvnBt

--HG--
extra : rebase_source : bea2d2589b2a09ba70a5c8e2b50ceee21acf3f0b
 2017-06-06 14:37:22 -07:00
Mark Banner
63bd606b32 Bug 1119282 - Update most browser/components/places browser mochitests to pass with async Places transations and fix some async transaction issues. r=mak 
MozReview-Commit-ID: Lc5oWCx1onJ

--HG--
extra : rebase_source : 6272b9cc6bc5907e3d022d647a9dd33c41db23a5
 2017-06-27 15:08:31 -07:00
Mark Banner
daf0164cf9 Bug 1119282 - Update browser_library_batch_delete.js to use more modern test constructs. r=mak 
MozReview-Commit-ID: I6ANFjUTSOl

--HG--
extra : rebase_source : 080a1dec4678dbd243be7cc027b5d22e05af49f1
 2017-06-27 17:04:21 -07:00
Sebastian Hengst
5949e620e5 Backed out changeset ca16ed38806f (bug 1119282) for test_engine_changes_during_sync.js, at least on Windows 7 VM. r=backout 2017-06-29 04:02:21 +02:00
Sebastian Hengst
c880c0301d Backed out changeset 5659f6c9a7c5 (bug 1119282) 2017-06-29 04:00:21 +02:00
Mark Banner
c4048deb35 Bug 1119282 - Update most browser/components/places browser mochitests to pass with async Places transations and fix some async transaction issues. r=mak 
MozReview-Commit-ID: Lc5oWCx1onJ

--HG--
extra : rebase_source : 6272b9cc6bc5907e3d022d647a9dd33c41db23a5
 2017-06-27 15:08:31 -07:00
Mark Banner
4e3e96409a Bug 1119282 - Update browser_library_batch_delete.js to use more modern test constructs. r=mak 
MozReview-Commit-ID: I6ANFjUTSOl

--HG--
extra : rebase_source : 080a1dec4678dbd243be7cc027b5d22e05af49f1
 2017-06-27 17:04:21 -07:00
Gijs Kruitbosch
dd070a9e91 Bug 1352120 - move the bookmarks star into the url bar, r=mak 
MozReview-Commit-ID: Ka5Wn2hrb1P

--HG--
extra : rebase_source : e22d25295066386c4becc1a430b78aaa9c40ae4f
 2017-06-23 17:35:59 +01:00
Mark Banner
10e375a830 Bug 1376531 - Fix some issues when enabling async places transactions - updating bookmarks names and pasting bookmarks. r=mak 
MozReview-Commit-ID: 4sqbSMtMkDD

--HG--
extra : rebase_source : a227a56c8da60c748cd5543dae37bc95bb07923e
 2017-06-27 12:54:16 -07:00
Carsten "Tomcat" Book
259377b6ab merge mozilla-inbound to mozilla-central a=merge 2017-06-26 13:25:51 +02:00
Carsten "Tomcat" Book
7af37a52bd Merge mozilla-central to mozilla-inbound 2017-06-23 11:44:21 +02:00
Florian Quèze
2924991bf6 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Marco Bonardo
a60ccaff04 Bug 1263378 - Intermittent leaks from browser_bug461710.js. r=standard8 
MozReview-Commit-ID: FQQkGaiE0xZ

--HG--
extra : rebase_source : 5cdb8a0de4cdc5afd923ab596f9c01ebf344bc9f
 2017-06-21 13:30:13 +02:00
Florian Quèze
7375dcec46 Bug 1374282 - script generated patch to remove generators from add_task in browser/ and toolkit/, r=Mossop. 2017-06-22 12:51:43 +02:00
MilindL
9cd6e1d046 Bug 1107364 - remove findNodeByDetails and maintain a map to fetch a node by details speedily, r=mak 
This patch removes the interface/header/implementation.

This adds a Map to PlacesTreeView to maintain the relation between node
details and the nodes, based on changes in `this._rows` or on
node details changed events. The Map exists from node details
to nodes (not rows).

MozReview-Commit-ID: EUNiXNIB5rN

--HG--
extra : rebase_source : 5391d9240e1f871c53d8aa26ae951b440b7280ad
 2017-06-08 20:51:51 +05:30
Paolo Amadini
10ee6a5c4e Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian 
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P

--HG--
extra : rebase_source : 3a9ea310d3e4a8642aabbc10636c04bfe2e77070
 2017-06-19 11:32:37 +01:00
Rajesh Kathiriya
fafb858b26 Bug 1370225 - Enabled the ESLint comma-style rule across mozilla-central. r=standard8 
MozReview-Commit-ID: 9OhLgBpYS4L

--HG--
extra : rebase_source : 5155e715934e7acd2ffadb4856eb91f481cbf56c
 2017-06-15 18:24:17 +01:00
Rajesh Kathiriya
6d3eb2c851 Bug 1370232 - Enabled the ESLint no-unneeded-ternary rule across mozilla-central. r=standard8 
MozReview-Commit-ID: AH9ArRkjh78

--HG--
extra : rebase_source : bdd4c4f8a4779ea373479a9cba772c036e00e816
 2017-06-13 00:23:54 +05:30
Nihanth Subramanya
ea349131ca Bug 1367242 - Part 1: Search bar should not be compact; should have a placeholder. r=dao 
MozReview-Commit-ID: B6eZsZrzo7W

--HG--
extra : rebase_source : 367ba5ca8f1827fbf05845d65f344d90adc8b657
 2017-05-30 01:39:41 +05:30
milindl
cc3623f4b7 Bug 1368754 - fix consumers which wait for NodeHistoryDetailsChanged/NodeURIChanged to be called to use node for new values, r=mak 
Updated time, access count and uri can be accessed using the node passed to the method.
There is no need to access the other arguments, which contain the old values of the
quantities changed.

MozReview-Commit-ID: 3WEwAs8gQ0w

--HG--
extra : rebase_source : 4f6f8bb9d9747cb9cfacf0a5ee5ed58dfca41c0d
 2017-05-30 23:51:09 +05:30
Gijs Kruitbosch
3062765b29 Bug 1359137 - fix bookmarks menu context test to not rely on AREA_PANEL, r=mikedeboer 
MozReview-Commit-ID: Dy0IzQKVazu

--HG--
extra : rebase_source : d27766938e6159aaf074342f34721f8f921e7dd6
 2017-05-31 14:21:27 +01:00
Ryan VanderMeulen
af691573d4 Merge m-c to autoland. a=merge 2017-05-30 12:59:41 -04:00
Christoph Kerschbaumer
3fc12a8c6e Bug 1363977 - Have loadTabs() provide the correct triggeringPrincipal. r=gijs,smaug 2017-05-29 21:32:21 +02:00
Carsten "Tomcat" Book
bdfe9a25bf Backed out changeset 2b92af4575ae (bug 1357386) 2017-05-30 08:51:22 +02:00
Christoph Kerschbaumer
74a7c96cd0 Bug 1357386: Have loadTabs() provide the correct triggeringPrincipal. r=gijs,smaug 2017-05-30 08:31:08 +02:00
Dan Banner
ea09f270ab Bug 1368041 - Enable no-array-constructor across mozilla-central r=standard8 
MozReview-Commit-ID: EXJNufdKKhJ

--HG--
extra : rebase_source : 66d17c7981c4b0987c482ce092b25990b42c07fb
 2017-05-27 15:17:29 +01:00
milindl
39f69b4ab0 Bug 1350377 - Remove getPlacesInfo and change associated files and tests, r=mak 
Files which make use of `getPlacesInfo` have been replaced with `History.fetch`.
The code for `GetPlacesInfo` has been deleted from the cpp and idl files.
The test for `getPlacesInfo` has been suitably rewritten and moved alongside the
other History.jsm tests.

There were 2 places where the fact that `getPlacesInfo` takes an array as opposed
to a single uri mattered, in `test_getPlacesInfo.js` and `test_refresh_firefox.py`.

MozReview-Commit-ID: KQSMHCvvlrQ

--HG--
extra : rebase_source : 78a4381587e040bec8ba5e51d1c5b5a67e70897e
 2017-05-17 16:02:21 +05:30
Mark Banner
4fb45e5b8c Bug 1365412 - Clean up various ESLint global definitions in browser/. r=mossop 
MozReview-Commit-ID: JqAm9x1XGCM

--HG--
extra : rebase_source : e9215288195f1fe683832db53d87dbe77c697b4c
 2017-05-16 22:22:42 +01:00
Brian Grinstead
5bf51d8dd7 Bug 1355324 - Create a popup to switch between sidebars from the sidebar header;r=Gijs 
MozReview-Commit-ID: HBwIfmtKybi

--HG--
rename : browser/base/content/test/general/browser_bug409481.js => browser/base/content/test/sidebar/browser_bug409481.js
extra : rebase_source : ae9d07e61e997c60b9633126296f20b9c3bed7f4
 2017-05-16 10:31:00 -07:00
Christoph Kerschbaumer
e4f38c8d7c Bug 1362993 - Rewrite gBrowser.addTab() to use BrowserTestUtils.addTab(). r=florian 2017-05-15 21:49:50 +02:00
Florian Quèze
97f401c644 Bug 1362882 - script-generated patch to switch from Promise.defer() to new Promise() where it's straightforward, rs=Mossop. 2017-05-12 14:55:27 +02:00
Florian Quèze
4e937e42a2 Bug 1353542 - Cleanup the script output and fix tests, r=Mossop. 2017-05-12 14:54:05 +02:00
Florian Quèze
1d0e28a791 Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
16530fa1e3 Bug 1353542 - smaller script-generated patch converting remaining generators that are likely tasks (actual generators were identified by hand and whitelisted), r=Mossop. 2017-05-12 14:45:01 +02:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Kit Cambridge
5fc76a861d Bug 1361171 - Remove CloudSync. r=markh 
MozReview-Commit-ID: CjBsEZa6oIP

--HG--
extra : rebase_source : 965db37197242acf63e77dbcca74a2984532b4ff
 2017-05-01 14:43:00 -07:00
Marco Bonardo
5292f017eb Bug 1343256 - Bookmark keywords disappear from one bookmark when adding a keyword to another bookmark. r=standard8 
MozReview-Commit-ID: Av8pDQi6Yyp

--HG--
extra : rebase_source : e2b4c5e2bd9baa8a30717c010bc63fb1ef2ae12c
 2017-04-29 15:15:06 +02:00
Kit Cambridge
dcce7ae769 Bug 1348699 - Add test to ensure we don't track left pane queries. r=mak,markh 
MozReview-Commit-ID: LFoCpvz2rAn

--HG--
extra : rebase_source : c2e927100899b5856d0fc2350efdf0e1ffb52e77
 2017-03-20 19:22:15 -07:00