Commit graph

27 commits

Author SHA1 Message Date
Jared Wein
382ec3f85e Bug 1371142 - Confirm that the page loaded is about:blank before continuing with the test. r=Gijs
This matches the behavior that is implemented in subdialogs.js where the load event handler is not removed until the new location is about:blank.

MozReview-Commit-ID: FZHW6Z63M2M

--HG--
extra : rebase_source : 010d884fb3bfc6dca63035c0125f3c2223847fcc
2018-07-18 15:40:37 -04:00
Kris Maglione
313b707b2e Bug 1443964: Part 3 - Remove no-cpows-in-tests rule. r=mconley
The shims that this rule tests for no longer exist.

MozReview-Commit-ID: DMgP7Hczavc

--HG--
extra : rebase_source : 765ddd5c62c9449c07ed050e44d86a3bd5c0ae64
extra : amend_source : 627a7694ac07182200f876901ded7a34721cd228
2018-03-07 19:31:28 -08:00
Tooru Fujisawa
54f00e33b9 Bug 1420310 - Part 0: Fix browser_subdialogs.js to wait for events in correct order and timing. r=felipe 2017-12-01 10:05:46 +09:00
Tooru Fujisawa
9ba78afd7a Bug 1420576 - Clarify that browser_subdialogs.js fails depending on screen resolution. r=Gijs 2017-11-29 19:59:12 +09:00
Ed Lee
2791b99bc9 Bug 1417017 - Check for content. usage at global and within add_task for no-cpows-in-tests. r=standard8
MozReview-Commit-ID: Asz6dM29uRJ

--HG--
extra : rebase_source : 4f5b67cc5ff48cbdb9afddc24f5842ecaeff0b15
2017-11-14 02:17:57 -08:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Scott Wu
61e99c74bd Bug 1340987 - (Part 5) Apply changes for subdialogs.js to in-content and fix tests. r=MattN
MozReview-Commit-ID: D729DVbZw9I

--HG--
extra : rebase_source : ef1adc4a610fb2305deff45e4e8e27f133b19115
2017-06-05 17:00:47 +08:00
Timothy Guan-tin Chien
de00d490e0 Bug 1363850 - Part II, Move old about:preferences from in-content-old/ to in-content/, r=jaws,mconley
MozReview-Commit-ID: DPLJT1adO1c

--HG--
rename : browser/components/preferences/in-content-old/content.js => browser/components/preferences/in-content/content.js
rename : browser/components/preferences/in-content-old/content.xul => browser/components/preferences/in-content/content.xul
rename : browser/components/preferences/in-content-old/search.js => browser/components/preferences/in-content/search.js
rename : browser/components/preferences/in-content-old/search.xul => browser/components/preferences/in-content/search.xul
rename : browser/components/preferences/in-content-old/security.js => browser/components/preferences/in-content/security.js
rename : browser/components/preferences/in-content-old/security.xul => browser/components/preferences/in-content/security.xul
rename : browser/components/preferences/in-content-old/tests/browser_advanced_siteData.js => browser/components/preferences/in-content/tests/browser_advanced_siteData.js
extra : rebase_source : 57611e32dba47a2238a5e0573c25478a96cfb8fd
2017-05-31 08:20:26 +08:00
Timothy Guan-tin Chien
f9eb2ed08a Bug 1363850 - Part I, Move new about:preferences from in-content/ to in-content-new/, r=jaws,mconley
MozReview-Commit-ID: ButUfsGP7lS

--HG--
rename : browser/components/preferences/in-content/advanced.js => browser/components/preferences/in-content-new/advanced.js
rename : browser/components/preferences/in-content/advanced.xul => browser/components/preferences/in-content-new/advanced.xul
rename : browser/components/preferences/in-content/applications.js => browser/components/preferences/in-content-new/applications.js
rename : browser/components/preferences/in-content/applications.xul => browser/components/preferences/in-content-new/applications.xul
rename : browser/components/preferences/in-content/containers.js => browser/components/preferences/in-content-new/containers.js
rename : browser/components/preferences/in-content/containers.xul => browser/components/preferences/in-content-new/containers.xul
rename : browser/components/preferences/in-content/findInPage.js => browser/components/preferences/in-content-new/findInPage.js
rename : browser/components/preferences/in-content/jar.mn => browser/components/preferences/in-content-new/jar.mn
rename : browser/components/preferences/in-content/main.js => browser/components/preferences/in-content-new/main.js
rename : browser/components/preferences/in-content/main.xul => browser/components/preferences/in-content-new/main.xul
rename : browser/components/preferences/in-content/moz.build => browser/components/preferences/in-content-new/moz.build
rename : browser/components/preferences/in-content/preferences.js => browser/components/preferences/in-content-new/preferences.js
rename : browser/components/preferences/in-content/preferences.xul => browser/components/preferences/in-content-new/preferences.xul
rename : browser/components/preferences/in-content/privacy.js => browser/components/preferences/in-content-new/privacy.js
rename : browser/components/preferences/in-content/privacy.xul => browser/components/preferences/in-content-new/privacy.xul
rename : browser/components/preferences/in-content/searchResults.xul => browser/components/preferences/in-content-new/searchResults.xul
rename : browser/components/preferences/in-content/subdialogs.js => browser/components/preferences/in-content-new/subdialogs.js
rename : browser/components/preferences/in-content/sync.js => browser/components/preferences/in-content-new/sync.js
rename : browser/components/preferences/in-content/sync.xul => browser/components/preferences/in-content-new/sync.xul
rename : browser/components/preferences/in-content/tests/.eslintrc.js => browser/components/preferences/in-content-new/tests/.eslintrc.js
rename : browser/components/preferences/in-content/tests/browser.ini => browser/components/preferences/in-content-new/tests/browser.ini
rename : browser/components/preferences/in-content/tests/browser_advanced_update.js => browser/components/preferences/in-content-new/tests/browser_advanced_update.js
rename : browser/components/preferences/in-content/tests/browser_applications_selection.js => browser/components/preferences/in-content-new/tests/browser_applications_selection.js
rename : browser/components/preferences/in-content/tests/browser_basic_rebuild_fonts_test.js => browser/components/preferences/in-content-new/tests/browser_basic_rebuild_fonts_test.js
rename : browser/components/preferences/in-content/tests/browser_bug1018066_resetScrollPosition.js => browser/components/preferences/in-content-new/tests/browser_bug1018066_resetScrollPosition.js
rename : browser/components/preferences/in-content/tests/browser_bug1020245_openPreferences_to_paneContent.js => browser/components/preferences/in-content-new/tests/browser_bug1020245_openPreferences_to_paneContent.js
rename : browser/components/preferences/in-content/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.js => browser/components/preferences/in-content-new/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.js
rename : browser/components/preferences/in-content/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.xul => browser/components/preferences/in-content-new/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.xul
rename : browser/components/preferences/in-content/tests/browser_bug410900.js => browser/components/preferences/in-content-new/tests/browser_bug410900.js
rename : browser/components/preferences/in-content/tests/browser_bug705422.js => browser/components/preferences/in-content-new/tests/browser_bug705422.js
rename : browser/components/preferences/in-content/tests/browser_bug731866.js => browser/components/preferences/in-content-new/tests/browser_bug731866.js
rename : browser/components/preferences/in-content/tests/browser_bug795764_cachedisabled.js => browser/components/preferences/in-content-new/tests/browser_bug795764_cachedisabled.js
rename : browser/components/preferences/in-content/tests/browser_change_app_handler.js => browser/components/preferences/in-content-new/tests/browser_change_app_handler.js
rename : browser/components/preferences/in-content/tests/browser_checkspelling.js => browser/components/preferences/in-content-new/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content/tests/browser_connection.js => browser/components/preferences/in-content-new/tests/browser_connection.js
rename : browser/components/preferences/in-content/tests/browser_connection_bug388287.js => browser/components/preferences/in-content-new/tests/browser_connection_bug388287.js
rename : browser/components/preferences/in-content/tests/browser_cookies_exceptions.js => browser/components/preferences/in-content-new/tests/browser_cookies_exceptions.js
rename : browser/components/preferences/in-content/tests/browser_defaultbrowser_alwayscheck.js => browser/components/preferences/in-content-new/tests/browser_defaultbrowser_alwayscheck.js
rename : browser/components/preferences/in-content/tests/browser_engines.js => browser/components/preferences/in-content-new/tests/browser_engines.js
rename : browser/components/preferences/in-content/tests/browser_healthreport.js => browser/components/preferences/in-content-new/tests/browser_healthreport.js
rename : browser/components/preferences/in-content/tests/browser_homepages_filter_aboutpreferences.js => browser/components/preferences/in-content-new/tests/browser_homepages_filter_aboutpreferences.js
rename : browser/components/preferences/in-content/tests/browser_layersacceleration.js => browser/components/preferences/in-content-new/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content/tests/browser_masterpassword.js => browser/components/preferences/in-content-new/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content/tests/browser_notifications_do_not_disturb.js => browser/components/preferences/in-content-new/tests/browser_notifications_do_not_disturb.js
rename : browser/components/preferences/in-content/tests/browser_performance.js => browser/components/preferences/in-content-new/tests/browser_performance.js
rename : browser/components/preferences/in-content/tests/browser_permissions_urlFieldHidden.js => browser/components/preferences/in-content-new/tests/browser_permissions_urlFieldHidden.js
rename : browser/components/preferences/in-content/tests/browser_privacypane_1.js => browser/components/preferences/in-content-new/tests/browser_privacypane_1.js
rename : browser/components/preferences/in-content/tests/browser_privacypane_3.js => browser/components/preferences/in-content-new/tests/browser_privacypane_3.js
rename : browser/components/preferences/in-content/tests/browser_privacypane_4.js => browser/components/preferences/in-content-new/tests/browser_privacypane_4.js
rename : browser/components/preferences/in-content/tests/browser_privacypane_5.js => browser/components/preferences/in-content-new/tests/browser_privacypane_5.js
rename : browser/components/preferences/in-content/tests/browser_privacypane_8.js => browser/components/preferences/in-content-new/tests/browser_privacypane_8.js
rename : browser/components/preferences/in-content/tests/browser_proxy_backup.js => browser/components/preferences/in-content-new/tests/browser_proxy_backup.js
rename : browser/components/preferences/in-content/tests/browser_sanitizeOnShutdown_prefLocked.js => browser/components/preferences/in-content-new/tests/browser_sanitizeOnShutdown_prefLocked.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content/tests/browser_search_within_preferences.js => browser/components/preferences/in-content-new/tests/browser_search_within_preferences.js
rename : browser/components/preferences/in-content/tests/browser_searchsuggestions.js => browser/components/preferences/in-content-new/tests/browser_searchsuggestions.js
rename : browser/components/preferences/in-content/tests/browser_security.js => browser/components/preferences/in-content-new/tests/browser_security.js
rename : browser/components/preferences/in-content/tests/browser_siteData.js => browser/components/preferences/in-content-new/tests/browser_siteData.js
rename : browser/components/preferences/in-content/tests/browser_siteData2.js => browser/components/preferences/in-content-new/tests/browser_siteData2.js
rename : browser/components/preferences/in-content/tests/browser_subdialogs.js => browser/components/preferences/in-content-new/tests/browser_subdialogs.js
rename : browser/components/preferences/in-content/tests/browser_telemetry.js => browser/components/preferences/in-content-new/tests/browser_telemetry.js
rename : browser/components/preferences/in-content/tests/head.js => browser/components/preferences/in-content-new/tests/head.js
rename : browser/components/preferences/in-content/tests/offline/manifest.appcache => browser/components/preferences/in-content-new/tests/offline/manifest.appcache
rename : browser/components/preferences/in-content/tests/offline/offline.html => browser/components/preferences/in-content-new/tests/offline/offline.html
rename : browser/components/preferences/in-content/tests/privacypane_tests_perwindow.js => browser/components/preferences/in-content-new/tests/privacypane_tests_perwindow.js
rename : browser/components/preferences/in-content/tests/site_data_test.html => browser/components/preferences/in-content-new/tests/site_data_test.html
rename : browser/components/preferences/in-content/tests/subdialog.xul => browser/components/preferences/in-content-new/tests/subdialog.xul
rename : browser/components/preferences/in-content/tests/subdialog2.xul => browser/components/preferences/in-content-new/tests/subdialog2.xul
rename : browser/themes/linux/preferences/in-content/dialog.css => browser/themes/linux/preferences/in-content-new/dialog.css
rename : browser/themes/linux/preferences/in-content/preferences.css => browser/themes/linux/preferences/in-content-new/preferences.css
rename : browser/themes/osx/preferences/in-content/dialog.css => browser/themes/osx/preferences/in-content-new/dialog.css
rename : browser/themes/osx/preferences/in-content/preferences.css => browser/themes/osx/preferences/in-content-new/preferences.css
rename : browser/themes/windows/preferences/in-content/dialog.css => browser/themes/windows/preferences/in-content-new/dialog.css
rename : browser/themes/windows/preferences/in-content/preferences.css => browser/themes/windows/preferences/in-content-new/preferences.css
extra : rebase_source : a7accd26847f9b3d5ee0acc9442ef65edeadb5bf
2017-05-25 18:31:41 +08:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Chris Peterson
a8e2bb1720 Bug 1358645 - Close the preference dialog when the user clicks the overlay background. r=jaws
We close the dialog using the same code path as when the user presses the ESC key.

MozReview-Commit-ID: LNMDTgMl2L

--HG--
extra : rebase_source : 0f2144523dc1ec2009638f8e6efe3340541d989f
2017-04-29 19:43:50 -07:00
Frederik Braun
cd1cbcef0f Bug 1359350: Add no-eval rule to eslint config (and whitelist failures in tests) r=standard8
MozReview-Commit-ID: 4nYlX4sSdbF

--HG--
extra : rebase_source : cf610e7d8bf2b8dbd5a0d40c5b835bc6620c3bba
2017-05-08 14:50:50 +02:00
Florian Quèze
be4dbae285 Bug 1334199 - script-generated patch to omit getComputedStyle's second argument when it's falsy, r=jaws. 2017-01-27 10:51:02 +01:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Jared Wein
3718f00db1 Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Eric Rahm
ac86f7f542 Bug 1299613 - Grab ref to closingButton name prior to closing. r=Gijs
In order to avoid poking a potentially dead wrapper we grab a ref to the
button name prior to being destroyed.
2016-09-01 13:33:52 -07:00
Jared Wein
e1991e575b Bug 1238065 - Fix the todo in escape_should_close_dialog by using synthesizeKey instead of sendChar. r=mikedeboer
MozReview-Commit-ID: 7Kp1B7RCLKH

--HG--
extra : rebase_source : 11c31ab6386abf24276a7b90716533520d6cdcd8
2016-08-13 23:28:46 -04:00
Gijs Kruitbosch
012b95a196 Bug 1130411 - deal with opening dialogs when the previous dialog is not unloaded yet, r=jaws
MozReview-Commit-ID: IY0W3UfYTdc

--HG--
rename : browser/components/preferences/in-content/tests/subdialog.xul => browser/components/preferences/in-content/tests/subdialog2.xul
extra : rebase_source : b843e77866d9c50cfb91263d3a2d1439977b3e40
2016-04-02 20:09:16 +01:00
Mike de Boer
df7e3c059a Bug 1241930: Part 2 - convert all assertion methods used inside content tasks to the Assert.* family in browser tests. r=mconley 2016-03-04 14:32:24 +01:00
Jared Wein
981ad17cfd Bug 1087114 - Run browser_subdialogs.js in e10s. r=gijs
--HG--
extra : commitid : 2TYCjDLjshd
extra : rebase_source : f5c0bab6fd010239d46d04d38a2f67f5d74c8360
2016-01-08 13:08:34 -05:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Ehsan Akhgari
1a03395848 Bug 1154275 - Remove ise() in favor of is(); r=Ms2ger 2015-05-13 14:31:58 -04:00
Gijs Kruitbosch
0430b12ca6 Bug 1141031 - fix in-content prefs dialogs overflowing, r=jaws
--HG--
extra : rebase_source : 57bf8e310b3ed8b1db472ec24f5bd9ff60b106dd
2015-04-16 19:51:04 +01:00
Jared Wein
0714ebbd67 Bug 1044600 - Close subdialogs when the back button is used in the in-content preferences. r=Gijs 2015-02-02 16:00:00 +00:00
Ryan VanderMeulen
766abc1ebc Backed out changeset 09a43afd57b2 (bug 1044600) for making bug 1130411 fail frequently. 2015-02-18 14:42:27 -05:00
Jared Wein
96be378b31 Bug 1044600 - Close subdialogs when the back button is used in the in-content preferences. r=Gijs 2015-02-02 16:00:00 +00:00
Matthew Noorenberghe
1afd30fc5a Bug 1021618 - Create the foundation for converting preference dialogs to be in-content. r=jaws a11y=MarcoZ f=Paenglab,davidb 2014-06-26 13:17:17 -04:00