Commit graph

240 commits

Author SHA1 Message Date
Brian Grinstead
4995c61b0f Bug 1482667 - Migrate mochitest-browser tests in browser/ to use element variations of firstChild, etc;r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D3530

--HG--
extra : moz-landing-system : lando
2018-08-17 16:45:52 +00:00
Kris Maglione
f99ee35b82 Bug 1480244: Part 5 - Run most framescripts in shared scope. r=mconley
Creating non-shared scopes for frame scripts is fairly expensive. After these
changes it's even more expensive. However, many frame scripts have no use for
the shared scopes at all. Run-once scripts which execute in closures, for
instance, make no use of them. And after bug 1472491, neither do most of our
default frame scripts.

MozReview-Commit-ID: 9PK7bYdQ0yh

--HG--
extra : rebase_source : db2516d2f00a75e233e1957649f2b62a9299b7cd
2018-08-10 13:58:18 -07:00
Mark Banner
6feaa5a9c3 Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer
MozReview-Commit-ID: BYTDdLU2HoM

--HG--
extra : rebase_source : 1e31ff288280d09ae226cdc698331263ba969205
2018-07-25 09:10:07 +01:00
Narcis Beleuzu
d47c829065 Backed out 4 changesets (bug 1478308) for ESlint failure on AttributionCode.jsm. CLOSED TREE
Backed out changeset a809b45ff49b (bug 1478308)
Backed out changeset c68131530742 (bug 1478308)
Backed out changeset 0e4ba7a6dc1a (bug 1478308)
Backed out changeset 32a27f317a77 (bug 1478308)
2018-07-26 11:13:28 +03:00
Mark Banner
180233c593 Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer
MozReview-Commit-ID: BYTDdLU2HoM

--HG--
extra : rebase_source : 67dc15c0cdff0234d3274f1a8978d1f2a5b3f411
2018-07-25 09:10:07 +01:00
Ed Lee
2aadee7874 Bug 1439840 - Activity Streams search bar is displayed behind the Tour notification. r=k88hudson
Increase the min width now that activity stream responsively switches to a wide layout (which increases the width of the search box).

MozReview-Commit-ID: v3mbcRZGQh

--HG--
extra : rebase_source : e72510b3e459339520de565025f8678f782e9bf0
2018-07-06 15:45:40 -07:00
Emilio Cobos Álvarez
e0ca8be691 Bug 1464782: Update references to offset-* properties in the rest of the tree. r=xidorn
MozReview-Commit-ID: AOMoLSJKySy
2018-06-27 16:12:02 +02:00
Erica Wright
dc93192a58 Bug 1448918 - Create about:welcome page in preparation for firstrun migration. r=dmose
MozReview-Commit-ID: L34uRsOeziS

--HG--
extra : rebase_source : 9e783e9ba1a8473c8867aa9c2a87337005acbab2
2018-04-23 15:47:57 -04:00
Ricky Rosario
bc11c02d45 Bug 1456496 - dark theme for onboarding snippets r=k88hudson
MozReview-Commit-ID: CqprUlxd2IZ

--HG--
extra : rebase_source : c7647cee02de5f4cc7fad425b09b901c4f0269d7
2018-04-26 12:51:42 -04:00
Kris Maglione
a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Ricky Rosario
e87b457eae Bug 1449651 - Apply dark theme style to onboarding overlay and icon r=Mardak
MozReview-Commit-ID: Dr1pnNhocuy

--HG--
extra : rebase_source : 802f742d4f7817779ac8a76c18e4cbbb05853fd3
2018-04-17 18:14:59 -04:00
Kris Maglione
1c91714d38 Bug 1440747: Don't load onboarding frame script into every frameloader. r=Gijs
Loading this script into every frameloader wasts a massive amount of memory in
every content process, even though it's only needed when we load about:home or
about:newtab.

MozReview-Commit-ID: 5YtEKLGVX4

--HG--
rename : browser/extensions/onboarding/content/onboarding.js => browser/extensions/onboarding/content/Onboarding.jsm
extra : rebase_source : 6592a7ce188cbab5682242d6783883726788130b
extra : amend_source : 6da2cfd3c630e20a7e8b089bbff1403378f5acc3
2018-02-23 13:53:19 -05:00
Kris Maglione
5edc701bb6 Bug 1446585: Remove support for resource entries in bootstrapped chrome.manifest files. r=aswan,MattN,k88hudson
MozReview-Commit-ID: EjymzU6koYX

--HG--
extra : rebase_source : 7b4fc250b5be0f2c16f3797eafb61e7c3955309d
2018-03-16 20:18:46 -07:00
Tooru Fujisawa
1adba8c1fc Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Kris Maglione
313b707b2e Bug 1443964: Part 3 - Remove no-cpows-in-tests rule. r=mconley
The shims that this rule tests for no longer exist.

MozReview-Commit-ID: DMgP7Hczavc

--HG--
extra : rebase_source : 765ddd5c62c9449c07ed050e44d86a3bd5c0ae64
extra : amend_source : 627a7694ac07182200f876901ded7a34721cd228
2018-03-07 19:31:28 -08:00
Kris Maglione
83957914cc Bug 1445551: Part 1b - Whitelist unsafe CPOW use in existing tests. r=mconley
MozReview-Commit-ID: 4ojwvjw9XGT

--HG--
extra : rebase_source : f7b79ad5998f1138266e89767ee1b434e4797b30
2018-03-14 14:35:05 -07:00
Matthew Noorenberghe
d868f6b1b1 Bug 1443632 - Change screenshots tour action button back to an <a>. r=kitcambridge
MozReview-Commit-ID: DeEWxnurLty

--HG--
extra : rebase_source : fb3fefac449644b8b83286c92d13ebd677a41055
2018-03-09 17:58:18 -08:00
Masayuki Nakano
bce749c8e1 Bug 1441144 - Make browser/extensions/onboarding/content/onboarding.js handle non-printable keys with "keydown" event listener rather than "keypress" event listener r=mossop
We'll stop dispatching "keypress" event for non-printable keys and key
combinations in the default event group of web content.  Therefore,
onbording.js needs to stop handling some keys with "keypress" event listener.

This patch makes add a "keydown" event listener, handleKeydown(), and make it
handle only non-printable keys.  Note that we'll keep dispatching "keypress"
event for " " and "Enter".  So, we can keep handling them in "keypress"
event listener.

MozReview-Commit-ID: 1jFIv9N03fa

--HG--
extra : rebase_source : 8acabac7ae5c06b527a9fad0fb0fb7b3a2cc5a61
2018-02-26 22:37:11 +09:00
arthur.iakab
bc464b37ba Merge mozilla-central to mozilla-inbound 2018-02-27 12:05:43 +02:00
Frederik Braun
bb0f2d490f Bug 1433929 - Replace all innerHTML usage in the onboarding extension. r=Gijs
MozReview-Commit-ID: HY9JsBb7sFQ

--HG--
extra : rebase_source : b542037aa54cd652a3a24b2ee04e156ddfdd3141
2018-02-16 12:34:27 +01:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Edouard Oger
25db2f7ed6 Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s

--HG--
extra : rebase_source : 706d6a9a1187e9b666074d0dd68d03eda3fb448b
2018-02-15 11:24:44 +08:00
Csoregi Natalia
c8a2d994c8 Backed out changeset 22901b9f9199 (bug 1434706) for browser-chrome failures browser_contextmenu_sendtab.js. CLOSED TREE 2018-02-26 21:16:01 +02:00
Edouard Oger
7c03ced862 Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s

--HG--
extra : rebase_source : 7a19b04f9df52ff58f9837d9d45be54fd3190ec9
2018-02-15 11:24:44 +08:00
Edouard Oger
837528baa3 Bug 1438451 - Query UIState.jsm instead of FxAccounts in sync onboarding code. r=markh
MozReview-Commit-ID: 4pXFTqDiIbS

--HG--
extra : rebase_source : 3501ccf91946c4ea4ef9fc4b63864c88e77097c0
2018-02-21 16:15:05 +08:00
Ed Lee
6497dc1292 Bug 1433324 - Part 3. Assume true for browser.newtabpage.activity-stream.enabled. r=ursula
MozReview-Commit-ID: KMgNw5QsMIX

--HG--
extra : rebase_source : b3f3e2dbd568e88c0e8461fb4bfadbbdd9baaa99
2018-02-13 16:53:50 -08:00
Michael Kohler
fd2cb7bd5b Bug 1419996 - remove NEW_TABLE flag and legacy code for the onboarding telemetry r=Fischer,francois
MozReview-Commit-ID: Lb8G8DXRdeh

--HG--
extra : rebase_source : 50dcf42ac157efaca54f3d2e0cbc2d78323da562
2018-01-31 19:48:56 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Fred Lin
2a707190e1 Bug 1413830 - Data schema change for onboarding telemetry;r=fischer,francois
Implement new processPings and _sendPing, handle sessions via registerNewOnboardingSession
This patch covers all new events except onboarding-noshow-smallscreen and overlay-disapear-resize events will be implemented in bug 1417769

MozReview-Commit-ID: 3jNAmOcrvEa
2018-01-15 15:32:46 +08:00
Gurzau Raul
549b685a71 Backed out changeset b78d2b24b741 (bug 1413830) for leaking test/about/browser_aboutHome_search_telemetry.js r=backout 2018-01-10 12:02:53 +02:00
Fred Lin
ffd413a47c Bug 1413830 - Data schema change for onboarding telemetry;r=Fischer,francois
Implement new processPings and _sendPing, handle sessions via registerNewOnboardingSession
This patch covers all new events except onboarding-noshow-smallscreen and overlay-disapear-resize events will be implemented in bug 1417769

MozReview-Commit-ID: 3jNAmOcrvEa

--HG--
extra : rebase_source : f95ab7f6cf894700412acbc92bcea77345a1406c
2017-10-31 12:01:30 +08:00
Dorel Luca
9f61025cee Backed out changeset 8ba13ef1fec4 (bug 1413830) for failing Browser-chrome on accessible/tests/browser/events/browser_test_focus_browserui.js r=backout on a CLOSED TREE
--HG--
extra : amend_source : 3cfcc7b5b53d200deec501e180b10b7a0b8079ea
2018-01-08 16:15:38 +02:00
Fred Lin
4e10bc7360 Bug 1413830 - Data schema change for onboarding telemetry;r=Fischer,francois
Implement new processPings and _sendPing, handle sessions via registerNewOnboardingSession
This patch covers all new events except onboarding-noshow-smallscreen and overlay-disapear-resize events will be implemented in bug 1417769

MozReview-Commit-ID: 3jNAmOcrvEa

--HG--
extra : rebase_source : 58f1deea02ff6a07c25a0dce1c291ca1ecfa17e8
2017-10-31 12:01:30 +08:00
Florian Quèze
0f55cd45be Bug 1421992 - script-generated patch to replace do_execute_soon, do_print and do_register_cleanup with executeSoon, info and registerCleanupFunction, rs=Gijs. 2017-12-21 11:10:23 +01:00
Florian Quèze
032c961e0a Bug 1421992 - script-generated patch to replace do_check_* functions with their Assert.* equivalents, rs=Gijs. 2017-12-21 11:08:17 +01:00
Edouard Oger
275e1b753f Bug 1420193 - Add Connect Another Device button to Sync onboarding panel. r=markh,mossop
MozReview-Commit-ID: 7M6JMJALz2j

--HG--
extra : rebase_source : 171ace5252f1b750f96494b739d9e8fcafea9d7c
2017-11-23 12:17:37 -05:00
Bill McCloskey
9f4d083047 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-07 12:55:24 -08:00
Andreea Pavel
89531e8dc3 Backed out 9 changesets (bug 1412456) for crashing talos g2 and unexpected network connections in browser-chrome's browser_searchEngine_behaviors.js r=backout a=backout on a CLOSED TREE
Backed out changeset 0c01a98f4fd5 (bug 1412456)
Backed out changeset 27077db47231 (bug 1412456)
Backed out changeset f35ec2a884f8 (bug 1412456)
Backed out changeset 602b30ac3c69 (bug 1412456)
Backed out changeset b1ff1050c589 (bug 1412456)
Backed out changeset f100d953f9eb (bug 1412456)
Backed out changeset d85af60fe259 (bug 1412456)
Backed out changeset 736f38486832 (bug 1412456)
Backed out changeset 13a637602dc2 (bug 1412456)
2017-12-07 12:20:21 +02:00
Bill McCloskey
bef7c122df Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 21:17:05 -08:00
Dorel Luca
eb65c24c7b Backed out 8 changesets (bug 1412456) for ESlint failure on browser_urlbarKeepStateAcrossTabSwitches.js:13:49 r=backout on a CLOSED TREE
Backed out changeset 0e88de036c55 (bug 1412456)
Backed out changeset 49b93f807db0 (bug 1412456)
Backed out changeset 039e980b7dc6 (bug 1412456)
Backed out changeset c7698410ddbd (bug 1412456)
Backed out changeset e56a1ba26b7c (bug 1412456)
Backed out changeset 0c4506e124ac (bug 1412456)
Backed out changeset a7aec2ce903b (bug 1412456)
Backed out changeset 3e9fb71f1e8e (bug 1412456)
2017-12-07 07:09:33 +02:00
Bill McCloskey
be77cf4a01 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 20:46:58 -08:00
Fred Lin
a3f82de698 Bug 1418167 - validate data before send for onboarding telemetry;r=Fischer
Implement basic validation for new table events and columns, report the incorrect fields.
The change is protected by NEW_TABLE flag so not effect the current telemetry.

MozReview-Commit-ID: 78K551g0nRj

--HG--
extra : rebase_source : 318c3f30154b7e58be17a16d8f8ddf7ad6045143
2017-11-17 10:53:46 +08:00
Ed Lee
2791b99bc9 Bug 1417017 - Check for content. usage at global and within add_task for no-cpows-in-tests. r=standard8
MozReview-Commit-ID: Asz6dM29uRJ

--HG--
extra : rebase_source : 4f5b67cc5ff48cbdb9afddc24f5842ecaeff0b15
2017-11-14 02:17:57 -08:00
Fred Lin
c14fee40ff Bug 1418191 - not send the CTA telemetry event ping when instant complete;r=Fischer
MozReview-Commit-ID: 9KJazfZqviT

--HG--
extra : rebase_source : cd50d2889f4a18a6ae20170433851a243b484ee9
2017-11-21 13:12:56 +08:00
Fischer.json
245f04b821 Bug 1414721 - Colors of Onboarding nav icons are inconsistent, r=gasolin
Previously we used background images to display tour icons on the nav list and on the tour notification. This caused two pitfalls: First, if fill colors were different inside svg icons, we would see inconsistent tour icon colors. Second, for one tour icon there would need two svg files.

This patch switches to the mask-image approach, which makes a icon svg as a mask filtering the background color beneath, so we can unify icon colors by the external css and remove extra colored svg files.

MozReview-Commit-ID: ErXexz15y8F

--HG--
extra : rebase_source : 7146b5d902ce9b8cd5b73d46a8eb338301907cc7
2017-11-09 11:11:50 +08:00