Commit graph

81 commits

Author SHA1 Message Date
Mark Banner
6feaa5a9c3 Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer
MozReview-Commit-ID: BYTDdLU2HoM

--HG--
extra : rebase_source : 1e31ff288280d09ae226cdc698331263ba969205
2018-07-25 09:10:07 +01:00
Narcis Beleuzu
d47c829065 Backed out 4 changesets (bug 1478308) for ESlint failure on AttributionCode.jsm. CLOSED TREE
Backed out changeset a809b45ff49b (bug 1478308)
Backed out changeset c68131530742 (bug 1478308)
Backed out changeset 0e4ba7a6dc1a (bug 1478308)
Backed out changeset 32a27f317a77 (bug 1478308)
2018-07-26 11:13:28 +03:00
Mark Banner
180233c593 Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer
MozReview-Commit-ID: BYTDdLU2HoM

--HG--
extra : rebase_source : 67dc15c0cdff0234d3274f1a8978d1f2a5b3f411
2018-07-25 09:10:07 +01:00
Kris Maglione
a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Marco Bonardo
dbde0c7df9 Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp

--HG--
extra : rebase_source : 6f5ec9404f12eb988501df56c7ee264ade2b054c
2018-04-16 18:24:06 +02:00
Dorel Luca
c4fec6222b Backed out changeset 897bbf35e781 (bug 1453580) for XPCShell failure on services/sync/tests/unit/test_syncedtabs.js. CLOSED TREE 2018-04-18 14:06:34 +03:00
Marco Bonardo
b00d20562d Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp

--HG--
extra : rebase_source : e8a1adb7c1004eaefddc42d12048d445eecd6530
2018-04-16 18:24:06 +02:00
Dão Gottwald
de08cb1cdb Bug 1441788 - Expose Reader View shortcut in the address bar button's tooltip. r=mikedeboer
MozReview-Commit-ID: 88p5xYUrefQ

--HG--
extra : rebase_source : 5c7d4e8067e6c570d6c04fd9758febb098768be2
2018-02-28 11:45:54 +01:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
arthur.iakab
c4dd80eca3 Merge mozilla-central to autoland 2018-01-31 00:41:58 +02:00
Gijs Kruitbosch
1c557b83fe Bug 1420714 - fix favicon fetching in reader mode, r=mak
MozReview-Commit-ID: KZFoKNqVPPy

--HG--
extra : rebase_source : 802b0140f3069013130d042167c7f08d615730b7
2018-01-30 15:13:23 +00:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
James Teh
5eb8d03cc5 Bug 1425541: Expose reader mode state on the browser accessible using a "reader" object attribute. r=eeejay,Gijs
This makes it easy for accessibility clients to retrieve the reader mode state programmatically.

There are three possibilities:
1. Reader mode is available for the current page (reader:available).
2. Reader mode is being used now (reader:active).
3. Reader is not available (the reader attribute is not present).

We do this by setting/removing the aria-reader attribute on the node.
This is not a real ARIA attribute, but it causes Gecko to expose it as an object attribute.

MozReview-Commit-ID: B38G3AYyBnS

--HG--
extra : rebase_source : 9c66389037c34a6a433af514bc81ed4ee040bfe0
2017-12-15 14:47:01 -06:00
Dorel Luca
e50f082eb3 Backed out changeset 196006c746bd (bug 1425541) for failing Mochitest on intl/l10n/test/dom/test_domloc_overlay.html on a CLOSED TREE
--HG--
extra : amend_source : dc8797c9ac74f89bfd38a4886497fd44e8a6d116
2018-01-16 03:11:38 +02:00
James Teh
19e0b360a1 Bug 1425541: Expose reader mode state on the browser accessible using a "reader" object attribute. r=eeejay,Gijs
This makes it easy for accessibility clients to retrieve the reader mode state programmatically.

There are three possibilities:
1. Reader mode is available for the current page (reader:available).
2. Reader mode is being used now (reader:active).
3. Reader is not available (the reader attribute is not present).

We do this by setting/removing the aria-reader attribute on the node.
This is not a real ARIA attribute, but it causes Gecko to expose it as an object attribute.

MozReview-Commit-ID: B38G3AYyBnS

--HG--
extra : rebase_source : 9c66389037c34a6a433af514bc81ed4ee040bfe0
2017-12-15 14:47:01 -06:00
Gijs Kruitbosch
fede8c406c Bug 1396565, make reader mode fetch the article from within the content process on desktop, r=jaws
MozReview-Commit-ID: 11uTaQYwz2Y

--HG--
extra : rebase_source : 211b23a9f1e56e8573ef68062ad6135a0ce70775
2017-11-14 16:53:55 +00:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Mark Banner
35f3666937 Bug 1380009 - Enable the ESLint no-return-await call to avoid unnecessary intermediate promise creation. r=mossop
MozReview-Commit-ID: EnhSBHMjurr

--HG--
extra : rebase_source : 74ba4c10e369067629af95bf705a9acd0df1089b
2017-07-11 22:49:55 +01:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Kris Maglione
aeb060de85 Bug 1358921: Lazily load ReaderParent.jsm when first needed. r=florian
MozReview-Commit-ID: 5UkSnU5sJsm

--HG--
extra : rebase_source : 08d1a24ca158cd91bd1691f1c230e4bfbacf149b
2017-04-23 13:27:35 -07:00
Mike Conley
365f4e988a Bug 1352501 - Remove Reader Mode promotion panel. r=jaws,MattN
Note that the UITour library can still show a panel in the event that we want to
promote the feature that way.

MozReview-Commit-ID: FzKSzO987h7

--HG--
extra : rebase_source : 8c129106478559f011a3a4e311331851939ab408
2017-04-19 16:42:10 -04:00
Sebastian Hengst
3c89f1e0f5 Bug 1344211 - Reader view shortcut should be shown in 'View' menu. r=Gijs
MozReview-Commit-ID: FKKTlRZhVHT

--HG--
extra : rebase_source : 9b458591f6ff80977db4e7a1c42bb6093c31c2b5
2017-03-04 19:01:19 +01:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Jared Wein
e6276ea7f5 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Horatiu
1a07f5562d Bug 1144749 - Add keyboard shortcut to open ReaderView. r=markh 2016-07-29 22:13:56 -04:00
Pushpankar
c6670d980f Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao
--HG--
extra : rebase_source : 72d50e73baf595840a2aade57ae782e4c40d4c27
2016-07-16 10:20:04 +02:00
Timothy Guan-tin Chien
f99c08a81a Bug 1260276 - Replace the dead reader page in history when we are being redirected, r=gijs
MozReview-Commit-ID: ChSCHuBKT1l

--HG--
extra : rebase_source : ce65eef72769abe2cc90cec9592e819ededa8f16
2016-07-13 16:14:34 +08:00
Timothy Guan-tin Chien
66f6b8a43b Bug 1184950 - Use goBack to leave the reader view when possible, r=margaret, r=gijs
MozReview-Commit-ID: G9wn4OyUL5q

--HG--
extra : transplant_source : %5Cw%B1%F5X%9A%95N%93i%91%9B%BA%CC%BBr%F2%E1%A0%99
2016-04-19 05:46:58 +08:00
Carsten "Tomcat" Book
7036c2b542 Backed out changeset 3c369626af41 (bug 1184950) for bc7 test failures 2016-04-15 10:43:28 +02:00
Timothy Guan-tin Chien
bc7a52a981 Bug 1184950 - Use goBack to leave the reader view when possible, r=margaret
MozReview-Commit-ID: G9wn4OyUL5q

--HG--
extra : transplant_source : %A6Edr%F4r%DC%05%A9%D1%CC%3D%16%ED%FD%D9%95%D8%B4%9A
2016-04-14 15:54:53 -07:00
Gijs Kruitbosch
6be7372f93 Bug 1252855 - make reader mode use AsyncPrefs, r=margaret
MozReview-Commit-ID: U6ZTyQQSHG

--HG--
extra : rebase_source : bf2aa2f40777611f2b89e9d2f57d2f4f2544f53b
2016-03-15 20:40:14 +00:00
Margaret Leibovic
3a66695ff2 Bug 1226238 - (Part 4) Remove reading list toggle button from reader view. r=ahunt,Gijs
MozReview-Commit-ID: 3pwOV5BjwC9

--HG--
extra : rebase_source : 66c2afd658320c5e5bd05e4b2a3278f2c871fee2
2016-02-22 10:35:32 -05:00
Margaret Leibovic
8db3f1faa4 Bug 1226238 - (Part 1) Remove share button from reader view. r=ahunt,Gijs
MozReview-Commit-ID: 3TFzz809KcM

--HG--
extra : rebase_source : 3cf003c5cbbe02e03bcf6f5f96843ccbc4a26a09
2016-02-22 10:09:07 -05:00
Paolo Amadini
a34896b82e Bug 1236229 - The showInfo API in UITour.jsm should accept JavaScript callbacks rather than callback IDs. r=MattN
--HG--
extra : commitid : KrQccNb7qO4
extra : rebase_source : 7fa489d00a4781cb6fd2fab15bd2c4006d673386
2016-01-05 14:04:49 +00:00
Shane Caraveo
eabb5f6400 Bug 1215694 move pocket to a system addon, r=Gijs, r=glandium
part 1: reorganize file locations, r=Gijs
  part 2: remove built-in pocket code, r=Gijs
  part 3: l10n support, r=glandium
  part 4: move code/functionality from part 2 into the addon, r=Gijs
  part 5: remove dead code, r=Gijs
  part 6: create a simple api for addons to add to reader mode, r=Gijs
  part 7: various test fixes related to cui behaviour and pocket, r=me

--HG--
rename : browser/components/pocket/Pocket.jsm => browser/extensions/pocket/content/Pocket.jsm
rename : browser/components/pocket/main.js => browser/extensions/pocket/content/main.js
rename : browser/components/pocket/panels/css/firasans.css => browser/extensions/pocket/content/panels/css/firasans.css
rename : browser/components/pocket/panels/css/normalize.css => browser/extensions/pocket/content/panels/css/normalize.css
rename : browser/components/pocket/panels/css/saved.css => browser/extensions/pocket/content/panels/css/saved.css
rename : browser/components/pocket/panels/css/signup.css => browser/extensions/pocket/content/panels/css/signup.css
rename : browser/components/pocket/panels/fonts/FiraSans-Regular.woff => browser/extensions/pocket/content/panels/fonts/FiraSans-Regular.woff
rename : toolkit/themes/shared/reader/pocket.svg => browser/extensions/pocket/content/panels/img/pocket.svg
rename : browser/components/pocket/panels/img/pocketerror@1x.png => browser/extensions/pocket/content/panels/img/pocketerror@1x.png
rename : browser/components/pocket/panels/img/pocketerror@2x.png => browser/extensions/pocket/content/panels/img/pocketerror@2x.png
rename : browser/components/pocket/panels/img/pocketlogo@1x.png => browser/extensions/pocket/content/panels/img/pocketlogo@1x.png
rename : browser/components/pocket/panels/img/pocketlogo@2x.png => browser/extensions/pocket/content/panels/img/pocketlogo@2x.png
rename : browser/components/pocket/panels/img/pocketlogosolo@1x.png => browser/extensions/pocket/content/panels/img/pocketlogosolo@1x.png
rename : browser/components/pocket/panels/img/pocketlogosolo@2x.png => browser/extensions/pocket/content/panels/img/pocketlogosolo@2x.png
rename : browser/components/pocket/panels/img/pocketmenuitem16.png => browser/extensions/pocket/content/panels/img/pocketmenuitem16.png
rename : browser/components/pocket/panels/img/pocketmenuitem16@2x.png => browser/extensions/pocket/content/panels/img/pocketmenuitem16@2x.png
rename : browser/components/pocket/panels/img/pocketsignup_button@1x.png => browser/extensions/pocket/content/panels/img/pocketsignup_button@1x.png
rename : browser/components/pocket/panels/img/pocketsignup_button@2x.png => browser/extensions/pocket/content/panels/img/pocketsignup_button@2x.png
rename : browser/components/pocket/panels/img/pocketsignup_devices@1x.png => browser/extensions/pocket/content/panels/img/pocketsignup_devices@1x.png
rename : browser/components/pocket/panels/img/pocketsignup_devices@2x.png => browser/extensions/pocket/content/panels/img/pocketsignup_devices@2x.png
rename : browser/components/pocket/panels/img/pocketsignup_hero@1x.png => browser/extensions/pocket/content/panels/img/pocketsignup_hero@1x.png
rename : browser/components/pocket/panels/img/pocketsignup_hero@2x.png => browser/extensions/pocket/content/panels/img/pocketsignup_hero@2x.png
rename : browser/components/pocket/panels/img/signup_firefoxlogo@1x.png => browser/extensions/pocket/content/panels/img/signup_firefoxlogo@1x.png
rename : browser/components/pocket/panels/img/signup_firefoxlogo@2x.png => browser/extensions/pocket/content/panels/img/signup_firefoxlogo@2x.png
rename : browser/components/pocket/panels/img/signup_help@1x.png => browser/extensions/pocket/content/panels/img/signup_help@1x.png
rename : browser/components/pocket/panels/img/signup_help@2x.png => browser/extensions/pocket/content/panels/img/signup_help@2x.png
rename : browser/components/pocket/panels/img/signup_or@1x.png => browser/extensions/pocket/content/panels/img/signup_or@1x.png
rename : browser/components/pocket/panels/img/signup_or@2x.png => browser/extensions/pocket/content/panels/img/signup_or@2x.png
rename : browser/components/pocket/panels/img/tag_close@1x.png => browser/extensions/pocket/content/panels/img/tag_close@1x.png
rename : browser/components/pocket/panels/img/tag_close@2x.png => browser/extensions/pocket/content/panels/img/tag_close@2x.png
rename : browser/components/pocket/panels/img/tag_closeactive@1x.png => browser/extensions/pocket/content/panels/img/tag_closeactive@1x.png
rename : browser/components/pocket/panels/img/tag_closeactive@2x.png => browser/extensions/pocket/content/panels/img/tag_closeactive@2x.png
rename : browser/components/pocket/panels/js/messages.js => browser/extensions/pocket/content/panels/js/messages.js
rename : browser/components/pocket/panels/js/saved.js => browser/extensions/pocket/content/panels/js/saved.js
rename : browser/components/pocket/panels/js/signup.js => browser/extensions/pocket/content/panels/js/signup.js
rename : browser/components/pocket/panels/js/tmpl.js => browser/extensions/pocket/content/panels/js/tmpl.js
rename : browser/components/pocket/panels/js/vendor/handlebars.runtime.js => browser/extensions/pocket/content/panels/js/vendor/handlebars.runtime.js
rename : browser/components/pocket/panels/js/vendor/jquery-2.1.1.min.js => browser/extensions/pocket/content/panels/js/vendor/jquery-2.1.1.min.js
rename : browser/components/pocket/panels/js/vendor/jquery.tokeninput.min.js => browser/extensions/pocket/content/panels/js/vendor/jquery.tokeninput.min.js
rename : browser/components/pocket/panels/license.txt => browser/extensions/pocket/content/panels/license.txt
rename : browser/components/pocket/panels/saved.html => browser/extensions/pocket/content/panels/saved.html
rename : browser/components/pocket/panels/signup.html => browser/extensions/pocket/content/panels/signup.html
rename : browser/components/pocket/panels/tmpl/saved_premiumextras.handlebars => browser/extensions/pocket/content/panels/tmpl/saved_premiumextras.handlebars
rename : browser/components/pocket/panels/tmpl/saved_premiumshell.handlebars => browser/extensions/pocket/content/panels/tmpl/saved_premiumshell.handlebars
rename : browser/components/pocket/panels/tmpl/saved_shell.handlebars => browser/extensions/pocket/content/panels/tmpl/saved_shell.handlebars
rename : browser/components/pocket/panels/tmpl/signup_shell.handlebars => browser/extensions/pocket/content/panels/tmpl/signup_shell.handlebars
rename : browser/components/pocket/panels/tmpl/signupstoryboard_shell.handlebars => browser/extensions/pocket/content/panels/tmpl/signupstoryboard_shell.handlebars
rename : browser/components/pocket/pktApi.js => browser/extensions/pocket/content/pktApi.jsm
rename : browser/locales/en-US/chrome/browser/browser-pocket.properties => browser/extensions/pocket/locales/en-US/pocket.properties
2015-12-29 15:40:52 -08:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Gijs Kruitbosch
127aeefe17 Bug 1182778, r=margaret,f=bz
--HG--
extra : commitid : ATLsconKiIq
extra : rebase_source : 4e6c3207ce438c4429dc32695dcbc4fbf5a2c022
2015-07-17 13:30:42 +01:00
Mark Hammond
4cc97da765 Bug 1184005 - Remove readinglist. r=MattN,jaws,adw 2015-08-04 12:00:43 +10:00
Matthew Noorenberghe
e0462894d4 Bug 1134507 - Implement infopanel to promote Reader View when first available. r=jaws/Gijs
Based on a patch by Jared Wein (:jaws).

--HG--
extra : rebase_source : fc9399a9acb2bb36831df1f5b99b3f9da02b1dbb
2015-04-30 13:43:47 -07:00
Jared Wein
feb88bb13a Bug 1158960 - Reader view is broken in e10s mode. r=Gijs
--HG--
extra : rebase_source : c1eaa648dc02f7d6991bd72b157ff7c7e5b32539
2015-04-27 18:29:18 -04:00
Jared Wein
33ebd558f5 Bug 1155523 - Implement Pocket toolbarbutton and subview. r=gijs 2015-04-24 14:29:05 -04:00
Jared Wein
6222fd05b3 Bug 1155304 - Right-clicking the reading list + button (in URL bar), shouldn't add the page to the reading list. r=gijs 2015-04-16 14:40:18 -04:00
Jared Wein
5ac5ee9fcf Bug 1134501 - UITour: Force page into Reader View automatically whenever the ReaderView/ReadingList tour page is loaded. r=gijs 2015-04-15 23:45:50 -04:00