Commit graph

165 commits

Author SHA1 Message Date
Sylvestre Ledru
01abd7ce40 Bug 1447480 - Add a MOZ_ASSERT to make it clear that it can never fall through r=hsivonen
MozReview-Commit-ID: Hq9jG1CVwRK

--HG--
extra : rebase_source : 4c548c1ad0c74b2c810b435701b91bd4f7893cb1
2018-04-03 13:40:59 +02:00
Tiberius Oros
1d7575065c Backed out 2 changesets (bug 1447480) for build bustages at dist/include/mozilla/Assertions.h:60 a=backout on a CLOSED TREE
Backed out changeset 5dfbd42ce515 (bug 1447480)
Backed out changeset a454ed4489f2 (bug 1447480)
2018-04-05 13:36:46 +03:00
Sylvestre Ledru
599ea080ac Bug 1447480 - Add a MOZ_ASSERT to make it clear that it can never fall through r=hsivonen
MozReview-Commit-ID: Hq9jG1CVwRK

--HG--
extra : rebase_source : 4c548c1ad0c74b2c810b435701b91bd4f7893cb1
2018-04-03 13:40:59 +02:00
Margareta Eliza Balazs
a06f511cc5 Backed out changeset fa109105e4ea (bug 1447480) for B failures in /build/build/src/parser/html/nsHtml5TreeBuilder.cpp(402) on a CLOSED TREE 2018-04-04 16:05:06 +03:00
Sylvestre Ledru
40fe59d2a8 Bug 1447480 - Add a MOZ_ASSERT to make it clear that it can never fall through r=hsivonen
MozReview-Commit-ID: Hq9jG1CVwRK

--HG--
extra : rebase_source : 4c548c1ad0c74b2c810b435701b91bd4f7893cb1
2018-04-03 13:40:59 +02:00
Boris Zbarsky
4e402f9b99 Bug 1445983. <bdi> should be an HTMLElement, not HTMLUnknownElement. r=hsivonen
MozReview-Commit-ID: 9eJ45uXRDfR
2018-03-16 11:26:09 -04:00
Boris Zbarsky
46fc331568 Bug 1446097. Switch to "set" as the canonical nsGkAtoms name of the string "set", so it matches the actual tag name "set" in SVG. r=hsivonen,njn
Most of the noise is from the fact that clang-format on parser/html/*.{h,cpp}
reformatted all sorts of stuff.  Not running it caused lots of format changes
from the generator... I guess we changed the format rules since the last time
this got run?

MozReview-Commit-ID: IA2G87zUIKN
2018-03-16 11:26:06 -04:00
Sylvestre Ledru
9e661550b7 Bug 1426997 - Add MOZ_FALLTHROUGH_ASSERT to make it clear that it can never fall through r=hsivonen
MozReview-Commit-ID: KZvVGnlJZtr

--HG--
extra : rebase_source : 0596528de97d4ae42c13f56d264099c7654d90f1
2018-01-29 09:11:08 +01:00
Henri Sivonen
71f07dccfb Bug 1424220 - Set mCurrentHtmlScriptIsAsyncOrDefer to false when restoring tree builder state. r=smaug
MozReview-Commit-ID: 9gsFme52mOG

--HG--
extra : rebase_source : d71040069ff4b3db476bf4cf3c08258def019f5a
2018-01-15 20:07:28 +02:00
Chris Peterson
5b8dabf526 Bug 1424548 - Part 11: Regenerate HTML parser code with MOZ_FALLTHROUGH annotations. r=hsivonen
And stop suppressing -Wimplicit-fallthrough warnings. We no longer need to suppress these clang warnings because the generated parser code now includes MOZ_FALLTHROUGH annotations.

--HG--
extra : rebase_source : d766c9b17de878138df6d949ee720dfaf0ed370a
2017-12-01 01:05:26 -08:00
Chris Peterson
946cc287a2 Bug 1424548 - Part 9a: clang-format generated HTML parser code. r=hsivonen
--HG--
extra : rebase_source : 67a0555475dbce49c689d27510dca252089a4a7b
2017-12-21 00:02:43 -08:00
Nicholas Nethercote
d225f7151b Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.
(Path is actually r=froydnj.)

Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.

MozReview-Commit-ID: 91U22X2NydP

--HG--
rename : xpcom/ds/nsIAtom.h => xpcom/ds/nsAtom.h
extra : rebase_source : ac3e904a21b8b48e74534fff964f1623ee937c67
2017-10-03 09:05:19 +11:00
Sebastian Hengst
5573e8270f Backed out changeset 0ce8d073a16e (bug 256180) 2017-09-28 11:30:33 +02:00
Henri Sivonen
b245e01efe Bug 256180 parser part - Insert elements as siblings instead of children at the Blink-defined magic depth for compatibility. r=smaug
MozReview-Commit-ID: K8fgv3rgklt

--HG--
extra : rebase_source : 3ad91a01805afcd1aeac89a5f2d5ac38dac1797b
2017-09-12 16:57:05 +03:00
Henri Sivonen
2607c163b1 Bug 1375701 - Atomize class attribute value in the parser in the innerHTML case. r=Ehsan
MozReview-Commit-ID: CKyGlzYS15e

--HG--
extra : rebase_source : 9ece88d9c85d98665413a7f9d730d7ff149d8486
2017-08-11 09:22:57 +03:00
Sebastian Hengst
14cf46a41a Backed out changeset fabf345eec6e (bug 1375701) for bustage at parser/html/nsHtml5String.h:143:3: bad implicit conversion constructor for 'nsHtml5String'. r=backout on a CLOSED TREE 2017-08-15 16:28:10 +02:00
Henri Sivonen
6815b2d2c7 Bug 1375701 - Atomize class attribute value in the parser in the innerHTML case. r=Ehsan
MozReview-Commit-ID: CKyGlzYS15e

--HG--
extra : rebase_source : a66d3d1659aec509c50f3ca641c0eb1d87151104
2017-08-11 09:22:57 +03:00
Henri Sivonen
3d387ac082 Bug 483155 - Put content creator function pointers onto nsHtml5ElementName. r=smaug
MozReview-Commit-ID: E2AAx7Zz2UF

--HG--
extra : rebase_source : 1b85ba3b1c699e71e6ecacf4d1dc4271f3416b08
2017-07-04 11:00:03 +03:00
Sebastian Hengst
56587adeab Backed out changeset 5b706cd241cb (bug 483155) for Valgrind failure on Linux x64 opt. r=backout 2017-08-11 10:48:10 +02:00
Henri Sivonen
dacb0e05f1 Bug 483155 - Put content creator function pointers onto nsHtml5ElementName. r=smaug
MozReview-Commit-ID: E2AAx7Zz2UF

--HG--
extra : rebase_source : 989c11459e16076a043aa7311c95941686e86ef7
2017-07-04 11:00:03 +03:00
Sylvestre Ledru
7c0ae251cd Bug 1381253 - Remove redundant control flow declarations rs=ehsan
MozReview-Commit-ID: FFxP4aMCbOL

--HG--
extra : amend_source : 3aec108430b11048f47ffe19d5da7ac5034770a9
2017-07-15 19:03:04 +02:00
Henri Sivonen
217ac88f04 Bug 1266495 - Remove <isindex>. r=wchen
MozReview-Commit-ID: KM0sTMM1GaD

--HG--
extra : rebase_source : 013069be4191e2ad50b5af879b690a6760e8429a
2017-07-05 11:42:04 +03:00
William Chen
17c14a6258 Bug 1355441 - Reuse StackNode in TreeBuilder to avoid malloc. r=hsivonen.
MozReview-Commit-ID: 4QwQwISCKPk
2017-05-15 17:18:20 +03:00
Iris Hsiao
cdb9631de8 Backed out changeset 2e7615b554ee (bug 1355441) for crashing at nsHtml5TreeBuilder::getUnusedStackNode() intermittent failures 2017-05-09 17:11:28 +08:00
William Chen
5e9c898c8f Bug 1355441 - Reuse StackNode in HTML parser TreeBuilder to avoid malloc. r=hsivonen 2017-05-01 17:25:05 -07:00
Henri Sivonen
c18a3863eb Bug 1269490 - Merge nsHtml5Atoms into nsGkAtoms. r=wchen
MozReview-Commit-ID: EcfnXkFuJy3

--HG--
extra : rebase_source : eb4ba2c1b95a9ccabdcdecf65f3b757691f033b8
2017-04-20 11:47:02 +03:00
Henri Sivonen
1eb6516385 Bug 1358037 - Inline the methods of nsHtml5ElementName and nsHtml5AttributeName. r=wchen
Moving methods that refer to constant to the header that defines the
constants makes it infeasible to #define the constants at the end
of the header. To avoid introducing a new pass over the Java AST,
this patch turns the primitive constants that were
previously #defined into C++ contants, which, according to
Stroustrup 3rd ed., are handled at compile-time and don't consume
storage.

MozReview-Commit-ID: JnaDgW2OM7t

--HG--
extra : rebase_source : 3678d8db967e83d8b7e265a5ef926050cc20d770
2017-04-20 10:34:32 +03:00
Henri Sivonen
b94c082c37 Bug 1355479 - Flatten attribute storage in the HTML parser to AutoTArray to avoid malloc. r=wchen
MozReview-Commit-ID: 77Hqo24F2nB

--HG--
extra : rebase_source : 9829c4ce7561e3a1d64d79884af6a8f72326021d
2017-04-13 11:14:48 +03:00
Henri Sivonen
8de02e50f5 Bug 1355769 - Avoid malloc for nsHtml5ElementName when processing a non-interned element name. r=wchen
MozReview-Commit-ID: 4In5wo0flOB

--HG--
extra : rebase_source : 912c5be12ab9ef96bacdf4ef84905f7056addecb
2017-04-12 13:21:03 +03:00
Henri Sivonen
2dfbad67f6 Bug 1347737 - Introduce a new non-heap-allocated type for holding nsStringBuffer* in the HTML parser. r=wchen.
MozReview-Commit-ID: Gn9fXroxQhY

--HG--
extra : rebase_source : 70bc539e80ce0b2372569a194366cfe559614fd1
2017-03-20 14:45:15 +02:00
Henri Sivonen
93fd0a00c1 Bug 1322938 - Make the HTML tree builder aware of <dialog>. r=wchen
Original patch by :hsivonen

MozReview-Commit-ID: C8UK7m7V9tn
2016-12-22 11:30:41 +02:00
Henri Sivonen
eea6b5c9c8 Bug 1288084 - Expose a line number for each attribute, v2; r=wchen 2016-09-20 16:31:57 +02:00
Boris Zbarsky
49a90cb122 Bug 1268852. Change <label> elements to not be form-associated anymore. r=bkelly,hsivonen,surkov
The web platform tests changes are just a cherrypick of
https://github.com/w3c/web-platform-tests/pull/2926 so I don't have to add
failure annotations until the next test uplift.

I've audited our uses of nsIFormControl, and this patch looks to me like it
preserves existing behavior in all but the following cases:

1)  nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space
is pressed while something inside a <label> is focused.  We used to not scroll
in this situation; I think this is a bug, so I'm changing that behavior to
scroll instead.

2)  In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case,
when mContent is a <label> we used to return its form's default submit element.
Now we will just return Relation().
2016-05-26 19:39:03 -04:00
Henri Sivonen
b3deac953d Bug 1270381. r=wchen. 2016-05-15 17:03:06 +03:00
Henri Sivonen
7a0b1d45ab Bug 1246014. r=wchen. 2016-02-10 12:39:06 +02:00
Henri Sivonen
a00a469bb6 Bug 1176698 - Use fallible allocator for attribute values in the HTML parser. r=wchen. 2015-08-25 18:05:46 +03:00
Henri Sivonen
02d517f7ac Bug 489820 part 2 - Grow buffers to the worst-case size before tokenizing; fix comments. r=wchen. 2015-08-25 18:05:45 +03:00
Ehsan Akhgari
2db568c042 Bug 1109311 - Fix the -Wundefined-bool-conversion warning in nsHtml5TreeBuilder.cpp resulting from checking the value of this; r=hsivonen
Clang gives the following warning for this code:

'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true

--HG--
extra : rebase_source : cd9bc242d22b0a5aa6767ce442368638d6186400
2014-12-18 10:33:28 -05:00
William Chen
b55e2cb1a3 Bug 1091425 - Use the correct document when creating nodes in the HTML5 parser. r=hsivonen 2014-11-09 22:50:18 -08:00
Henri Sivonen
c4548f78b5 Bug 886390 part 2 - Disable foreign content breakout in the fragment case. r=wchen. 2014-10-27 11:48:11 +02:00
Henri Sivonen
84b0db5e32 Bug 886390 part 1 - Implement behavior equivalent to the adjusted current node concept by changing the first node on the stack. r=wchen. 2014-10-27 11:48:11 +02:00
Yuki Sekiguchi
17994bd47b Bug 1042885 - Part 1: A rp element should not auto close a rtc element. r=wchen 2014-08-18 22:33:45 -07:00
William Chen
ff0d13434e Bug 1044118 - Fix inverted check for unclosed children in ruby tag. r=hsivonen 2014-08-04 15:54:20 -07:00
Yuki Sekiguchi
839050976b Bug 664104 - Part 1: Implement new ruby model in HTML parser. r=wchen 2014-06-20 17:08:31 -07:00
Olli Pettay
08774e4ba4 Bug 902618 - Parser notifies about subtree roots, but not their descendants, r=hsivonen,bz 2014-06-17 02:01:22 +03:00
William Chen
507c29aa81 Bug 1005580 - Fix "after after frameset" insertion mode in HTML parser for handling characters. r=hsivonen 2014-05-06 13:29:31 -07:00
William Chen
c21aececdb Bug 982285 - Update active formatting element list indices in HTML parser adoption agency algorithm. r=hsivonen 2014-03-17 17:34:47 -07:00
William Chen
c1faf91a37 Bug 884795 - HTML parser AAA algorithm should only pop when the current node is not in the list of active formatting elements. r=hsivonen 2014-03-07 15:48:19 -08:00
Henri Sivonen
d4b6f7d8d5 Bug 959150 part 5 - Avoid reallocating the attribute holder when parsing with nsHtml5StringParser. r=smaug. 2014-03-05 21:38:50 +02:00
Henri Sivonen
2fc6c1b93a Bug 959150 part 4 - Avoid using tree ops when parsing with nsHtml5StringParser. r=smaug. 2014-03-05 21:38:50 +02:00