Commit graph

286 commits

Author SHA1 Message Date
Kris Maglione
6adf9223ce Bug 1484496: Part 5b - Convert toolkit/ nsISimpleEnumerator users to use JS iteration. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3730

--HG--
extra : rebase_source : 935f166ec2c6581ba6f3fffe912404e81c8dc3d6
extra : histedit_source : ba701801de5205dcce6cfdccabe7b26aa7c7859c
2018-08-18 19:27:50 -07:00
Boris Zbarsky
e4b74becff Bug 1479569 part 2. Use the new messageManager getter on docshell. r=kmag
I generally tried to preserve the behavior of consumers where they treated an
exception from getInterface(Ci.nsIContentFrameMessageManager) as a signal to use
some sort of fallback.

I did change the behavior of consumers that walked up to the root same-type
docshell before getting the message manager to just get it directly from the
docshell they have.  Please review those parts carefully, and let me know if you
want me to ask some subject area experts to review those.
2018-08-02 23:49:09 -04:00
Csoregi Natalia
08c950712e Backed out 3 changesets (bug 1479569) for devtools/client/responsive.html failures. CLOSED TREE
Backed out changeset e123d0aa911c (bug 1479569)
Backed out changeset b828a58404e5 (bug 1479569)
Backed out changeset 97041ef8f311 (bug 1479569)
2018-08-03 10:39:12 +03:00
Boris Zbarsky
0197de77c0 Bug 1479569 part 2. Use the new messageManager getter on docshell. r=kmag
I generally tried to preserve the behavior of consumers where they treated an
exception from getInterface(Ci.nsIContentFrameMessageManager) as a signal to use
some sort of fallback.

I did change the behavior of consumers that walked up to the root same-type
docshell before getting the message manager to just get it directly from the
docshell they have.  Please review those parts carefully, and let me know if you
want me to ask some subject area experts to review those.
2018-08-02 23:49:09 -04:00
Boris Zbarsky
0fcb24c18d Bug 1446940 part 1. Stop getting docshells from windows via getInterface in toolkit. r=gijs
The change to test_hiddenPrivateWindow.xul is to make sure we pass windows, not
docshells, to an API that expects windows.
2018-08-01 13:07:09 -04:00
Mark Banner
29ebe3f3a8 Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer
MozReview-Commit-ID: 45Tfs2ZZ06r

--HG--
extra : rebase_source : f76738612cb5f78787e9fae8f8c563d5ff5f33d1
2018-07-25 11:00:35 +01:00
Narcis Beleuzu
d47c829065 Backed out 4 changesets (bug 1478308) for ESlint failure on AttributionCode.jsm. CLOSED TREE
Backed out changeset a809b45ff49b (bug 1478308)
Backed out changeset c68131530742 (bug 1478308)
Backed out changeset 0e4ba7a6dc1a (bug 1478308)
Backed out changeset 32a27f317a77 (bug 1478308)
2018-07-26 11:13:28 +03:00
Mark Banner
d95c1526b8 Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer
MozReview-Commit-ID: 45Tfs2ZZ06r

--HG--
extra : rebase_source : 10f2f734c883a1ac85b5dee21df119a4c6ae2898
2018-07-25 11:00:35 +01:00
Boris Zbarsky
6e84b66899 Bug 1476145 part 6. Stop using getInterface(nsIDOMWindowUtils) in toolkit. r=mossop
This is not quite a mechanical change, because some places have a .top or
whatnot snuck in there, so please review carefully!
2018-07-24 19:47:42 -04:00
Paolo Amadini
8adbeb4164 Bug 1475916 - Use em instead of px for list heights to keep font scaling into account. r=bgrins
MozReview-Commit-ID: FDMwrHg27ad

--HG--
extra : rebase_source : 66c957f2516e4cded7c6e73da5ea30080ab2d37b
2018-07-23 10:07:38 +01:00
Brindusan Cristian
4d556d4962 Backed out changeset 97d4a22307ac (bug 1473910) for browser-chrome failures on browser/components/places/tests/browser/browser_toolbar_overflow.js. CLOSED TREE 2018-07-11 17:46:08 +03:00
Paolo Amadini
3e9249538d Bug 1473910 - Load "tabprompts.css" as a document stylesheet in the browser window. r=bgrins,dao
MozReview-Commit-ID: HEf70HtNiqQ

--HG--
extra : rebase_source : 8a81b8da19e5506629626c34dd17a2032d4fcafe
2018-07-09 10:09:17 +01:00
Paolo Amadini
6e680744e4 Bug 1472750 - Convert simple "listbox" instances to "richlistbox". r=bgrins
These simple lists are converted to normal layout by setting a fixed height that isn't a multiple of the row height, which is already the case for most other lists in the user interface.

MozReview-Commit-ID: 1tV4MIoRp0d

--HG--
rename : toolkit/themes/windows/global/richlistbox.css => toolkit/themes/linux/global/richlistbox.css
extra : rebase_source : d6c53aa341bc5711f6ecf16485b5bd03d4f9caf2
extra : intermediate-source : 1355778929be17234ca3ced4f9930f05fb2cf20a
extra : source : 2e4527da76bba52492353aa5a40c128b09f389f1
2018-07-09 10:38:42 +01:00
Mark Banner
b30ac6aacd Bug 1456762 - Remove now unnecessary import-globals-from statements in html files. r=mossop
Depends on D1643

MozReview-Commit-ID: 84M50HDg0wl

Differential Revision: https://phabricator.services.mozilla.com/D1644
2018-06-16 08:21:33 +00:00
Joel Maher
50b91c0a14 Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Andreas Farre
8c7728b05e Bug 1440262 - Enter/exit modal state on scriptable top window. r=smaug
If inner windows are torn down before modal dialog close messages have
propagated fully we loose the possibility of getting a hold of an
windows's scriptable top, which is needed to leave modal state. By
making sure that the prompt fetches top on its own we guarantee that
we have the correct window to suspend/resume.

--HG--
extra : rebase_source : 35beea07fefe791e034f585bd1caba1a507e1145
2018-04-26 05:44:00 +03:00
Kris Maglione
219ed0cc06 Bug 1454813: Part 2b - Rename SpawnTask.js to AddTask.js. r=florian
The old name no longer makes sense, since it no longer exports an spawn_task
symbol, and add_task is what we really care about.

MozReview-Commit-ID: IE7B8Czv8DH

--HG--
rename : testing/mochitest/tests/SimpleTest/SpawnTask.js => testing/mochitest/tests/SimpleTest/AddTask.js
extra : rebase_source : 03bca5aa69a7625a49b4455a6c96ce4c59de3a5a
2018-04-18 11:43:45 -07:00
Boris Zbarsky
d32ec123dc Bug 1453487 part 2. Remove useless implements="nsIDOMEventListener" from XBL bindings. r=smaug
MozReview-Commit-ID: 4OjGuYkpXMM
2018-04-12 00:05:49 -04:00
Boris Zbarsky
a4c5e65aa3 Bug 1449631 part 1. Remove JS uses of nsIDOMEventTarget. r=smaug
MozReview-Commit-ID: CCHCZjMgInu
2018-04-05 13:42:40 -04:00
Florian Quèze
f3ee8dd20b Bug 1433175 - more aggressive scripted patch to replace remaining Components.classes, Components.interfaces, Components.utils and Components.results uses with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:35 +01:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Masayuki Nakano
8917ac460f Bug 1436926 - part 2: Remove unnecessary KeyboardEvent.code specification of callers of EventUtils.synthesizeKey() r=smaug
Now, callers of EventUtils.synthesizeKey() don't need to specify
KeyboardEvent.code value anymore if they assume that active keyboard layout
is US keyboard layout.

Note that this patch changes the meaning of only test_bug551434.html.
Some callers in it don't match the key value and code value but that looks
like that they don't checking such odd keyboard events.  So, they must be
bug of the test.

MozReview-Commit-ID: Itxo7yZ9rkK

--HG--
extra : rebase_source : 856ef3715c924ca16e993ea57d92d1243b5cc6be
2018-02-09 19:17:26 +09:00
Mark Banner
4cd77e3a20 Bug 1436389 - Switch xbl related files to a different method for determining their environment. r=mossop
MozReview-Commit-ID: JLqFrKZykw

--HG--
extra : rebase_source : 34628f4ead954ba9642b3814bb5692a1bebafb39
2018-02-07 16:02:25 +00:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
19a956c2c6 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor

--HG--
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
extra : amend_source : 09a90b29837e339eec7bdf8504f86c28e74ca3dd
extra : intermediate-source : a1eca62826a1341ca24d4d2a93d4884d4fc7ad51
extra : histedit_source : eb26e73b531f9a34d3401d39f60b533b27b78540
2018-01-18 16:27:26 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
e050496c59 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor

--HG--
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
extra : amend_source : d0515fe4eb13b59cc490ca9d964ad9ee15ef3cd3
extra : intermediate-source : 6e56f4c8843ed134b2dba34fb007298fd55be966
extra : histedit_source : 88abf9f4ea4e740a9391278625ef07395205c3f5%2Cc14bc7a71eb413fcb573ed0d030fd7f99a1468f0
2018-01-18 16:27:26 -08:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
e70d01a9e9 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor

--HG--
extra : rebase_source : 6286dcfd1a7c970272ac6befaccd3e47e90d2f6b
extra : intermediate-source : d48657228a0b84cf3a37a35227ca3b3d0bd2a017
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
2018-01-18 16:27:26 -08:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Andrea Marchesini
2ced31c722 Bug 1425559 - nsPrompter must use nsIThreadManager::spinEventLoopUntilOrShutdown, r=smaug 2018-01-28 08:41:36 +01:00
gorovoja
76b56b8d23 Bug 1416875 - Renamed prompt IDs from the form of info.body to InfoBody so they won't need escaping. r=jaws
--HG--
extra : rebase_source : cd932973a6b675ff45c4a4c9eadc68e3303f6d11
2017-11-17 13:59:30 -05:00
dluca
3f1926865e Backed out 1 changesets (bug 1413522) for failing a11y on OS X accessible/tests/mochitest/relations/test_ui_modalprompt.html r=backout on a CLOSED TREE.
Backed out changeset a74c645411e7 (bug 1413522)
2017-11-09 19:02:26 +02:00
Jared Wein
09cd077245 Bug 1413522 - Use HiDPI icons on Windows for the toolkit warning and question icons, and lower the size of the icons on OSX so the HiDPI versions are not shown blurry. r=nhnt11
MozReview-Commit-ID: 8u3zxE9HiSx

--HG--
extra : rebase_source : 1ec2263fc97831e2d314ed7b6ab98ecfe8ebcb9a
2017-11-02 12:11:42 -04:00
Mark Banner
99e91ded27 Bug 1412893 - Change instances of using getService to Services.jsm where possible in toolkit/components - Part 2. r=florian
MozReview-Commit-ID: 44oBXPP88Lc

--HG--
extra : rebase_source : 6625ac73eca1fa63d474eda3d1146baf910eac8c
2017-10-30 17:22:17 +00:00
Mark Banner
422a012285 Bug 1410362 - Merge nsIPromptService and nsIPromptService2. r=enndeakin+6102
MozReview-Commit-ID: 5gKiuWF4LeA

--HG--
extra : rebase_source : fa8471b07a69433e8ff47dc195b1d7e671450a21
2017-10-24 21:40:59 +01:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
steveck-chung
5200298e6c Bug 1388238 - Implement waitForMasterPasswordDialog helper which handles open dialogs. r=MattN
MozReview-Commit-ID: A8jx8s37f1k
2017-08-16 18:45:11 +08:00
Kris Maglione
e2676b4811 Bug 1375490: Part 1 - Correctly support alerts in OOP popups. r=mixedpuppy
MozReview-Commit-ID: KgqAKMLmuTI

--HG--
extra : rebase_source : db2e5eeb8e839bb7b1212d7829b66813b9fd15bd
extra : source : c0ab60d3c1f833116d1d9d3b5ef37825726c8ec5
2017-08-02 12:49:25 -07:00
Sebastian Hengst
0fa7bded36 Backed out changeset c0ab60d3c1f8 (bug 1375490) for failing browser_ext_popup_corners.js on OSX and Windows. r=backout on a CLOSED TREE 2017-08-02 13:12:55 +02:00
Kris Maglione
e5655d2234 Bug 1375490: Part 1 - Correctly support alerts in OOP popups. r=mixedpuppy
MozReview-Commit-ID: KgqAKMLmuTI

--HG--
extra : rebase_source : 82ec2b3a8380fac8355009720dbd20c7a6c7dbb6
2017-08-01 15:28:25 -07:00
Luciano Italiani
dd592719c1 Bug 1374671 - Enable the ESLint no-whitespace-before-property rule across mozilla-central. r=standard8
MozReview-Commit-ID: 4WkNg0YrgHx

--HG--
extra : rebase_source : 2c32028e81c388406455004c2adcdb4a01942b95
2017-07-27 23:01:13 -03:00
Rajesh Kathiriya
881bce09ea Bug 1374670 - Enabled the ESLint no-tabs rule across mozilla-central r=standard8
MozReview-Commit-ID: RT5QTipaOW

--HG--
extra : rebase_source : 84bccaeba083bc430316d3c80d5c8f56494f1950
2017-07-04 21:30:18 +05:30
Gijs Kruitbosch
64929762a4 Bug 1365875, r=smaug
MozReview-Commit-ID: 9CaAliVQwYe

--HG--
extra : amend_source : da6341f0642b76b6ce38f296384526de9a83a89d
2017-06-06 19:57:49 +01:00
Nathan Froyd
27c58cf89f Bug 1372670 - part 3 - add spinEventLoopUntil to nsIThreadManager; r=erahm,florian 2017-06-21 12:59:28 -04:00
Florian Quèze
16530fa1e3 Bug 1353542 - smaller script-generated patch converting remaining generators that are likely tasks (actual generators were identified by hand and whitelisted), r=Mossop. 2017-05-12 14:45:01 +02:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00