Commit graph

55 commits

Author SHA1 Message Date
Boris Zbarsky
0fcb24c18d Bug 1446940 part 1. Stop getting docshells from windows via getInterface in toolkit. r=gijs
The change to test_hiddenPrivateWindow.xul is to make sure we pass windows, not
docshells, to an API that expects windows.
2018-08-01 13:07:09 -04:00
Mark Banner
29ebe3f3a8 Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer
MozReview-Commit-ID: 45Tfs2ZZ06r

--HG--
extra : rebase_source : f76738612cb5f78787e9fae8f8c563d5ff5f33d1
2018-07-25 11:00:35 +01:00
Narcis Beleuzu
d47c829065 Backed out 4 changesets (bug 1478308) for ESlint failure on AttributionCode.jsm. CLOSED TREE
Backed out changeset a809b45ff49b (bug 1478308)
Backed out changeset c68131530742 (bug 1478308)
Backed out changeset 0e4ba7a6dc1a (bug 1478308)
Backed out changeset 32a27f317a77 (bug 1478308)
2018-07-26 11:13:28 +03:00
Mark Banner
d95c1526b8 Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer
MozReview-Commit-ID: 45Tfs2ZZ06r

--HG--
extra : rebase_source : 10f2f734c883a1ac85b5dee21df119a4c6ae2898
2018-07-25 11:00:35 +01:00
Boris Zbarsky
6e84b66899 Bug 1476145 part 6. Stop using getInterface(nsIDOMWindowUtils) in toolkit. r=mossop
This is not quite a mechanical change, because some places have a .top or
whatnot snuck in there, so please review carefully!
2018-07-24 19:47:42 -04:00
Boris Zbarsky
c4000f8b65 Bug 1377980 part 3. Remove nsIDOMRange use in JS. r=mccr8 2018-05-17 12:01:38 -04:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Boris Zbarsky
5d7b053f45 Bug 1418076 part 10. Get rid of JS uses of Ci.nsIDOMHTMLDocument. r=mystor
MozReview-Commit-ID: IT2OEbCODTX
2018-01-26 01:01:38 -05:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Mike de Boer
4efa2baf29 Bug 1302470 Part 6: Properly check for a frame's visibility, do not abuse isRangeVisible() for that purpose. r=mikedeboer
MozReview-Commit-ID: ErviFQrJR1u

--HG--
extra : rebase_source : 491013f2aa60ebf41c3198a022d136f7abd2a19c
2017-04-28 19:06:35 +02:00
Mike de Boer
2dcd3790e0 Bug 1302470 Part 5: Connect up FinderHighlighter.jsm with the new isRangeVisible function. r=mikedeboer
MozReview-Commit-ID: ABfAoZ4CBjP

--HG--
extra : rebase_source : d46fd3205481c0715e0f4ffde71ed056a648fadf
2017-01-23 17:39:07 +01:00
Steve Armand
e46ff00709 Bug 1368967 - Enable the ESLint generator-star-spacing rule across mozilla-central. r=standard8
MozReview-Commit-ID: 5do3eoCEAMR

--HG--
extra : rebase_source : 5f692e474e1d7d173fcb4c9c08617f0fe489e443
2017-09-04 00:49:32 -04:00
Phil Ringnalda
b8183bc0b4 Backed out 6 changesets (bug 1302470) for mochitest-chrome failures
CLOSED TREE

Backed out changeset 3aab8b1494ef (bug 1302470)
Backed out changeset fdd40abac611 (bug 1302470)
Backed out changeset a67bc2f1b624 (bug 1302470)
Backed out changeset 160522290018 (bug 1302470)
Backed out changeset 6b948c533944 (bug 1302470)
Backed out changeset 399011313b3c (bug 1302470)

MozReview-Commit-ID: 2B3uMAkzNGv
2017-08-31 20:04:24 -07:00
Mike de Boer
d6a298908c Bug 1302470 Part 6: Properly check for a frame's visibility, do not abuse isRangeVisible() for that purpose. r=mikedeboer
MozReview-Commit-ID: ErviFQrJR1u

--HG--
extra : rebase_source : 80a5560585f03c25020a7a70dc124877c1ce58d2
2017-04-28 19:06:35 +02:00
Mike de Boer
b1b4d0cc5e Bug 1302470 Part 5: Connect up FinderHighlighter.jsm with the new isRangeVisible function. r=mikedeboer
MozReview-Commit-ID: ABfAoZ4CBjP

--HG--
extra : rebase_source : fe4a1673a80b37b2507b930f356f31866c0509ae
2017-01-23 17:39:07 +01:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Phil Ringnalda
b9b730fd1f Backed out 7 changesets (bug 1302470) for mochitest-chrome failures
CLOSED TREE

Backed out changeset de9f42b512c8 (bug 1302470)
Backed out changeset 2394e63f50ff (bug 1302470)
Backed out changeset 3542d7bacbdc (bug 1302470)
Backed out changeset 22793139a866 (bug 1302470)
Backed out changeset cc6ff95187d0 (bug 1302470)
Backed out changeset 033fce5ecd39 (bug 1302470)
Backed out changeset 0bb3e70e5f46 (bug 1302470)

MozReview-Commit-ID: 5DmpbQp335X
2017-04-28 20:12:06 -07:00
Mike de Boer
eac670041e Bug 1302470 Part 7: Properly check for a frame's visibility, do not abuse isRangeVisible() for that purpose. r=mikedeboer
MozReview-Commit-ID: ErviFQrJR1u

--HG--
extra : rebase_source : 5b4dc3f6df1df97f1bef6187ff5a9da4ab0b01cb
2017-04-28 19:06:35 +02:00
Mike de Boer
ab63baf3ba Bug 1302470 Part 6: Connect up FinderHighlighter.jsm with the new isRangeVisible function. r=mikedeboer
MozReview-Commit-ID: ABfAoZ4CBjP

--HG--
extra : rebase_source : ee8773fd33327410584240db2a35b80cab5d7733
2017-01-23 17:39:07 +01:00
Sebastian Hengst
4608be37d8 Backed out changeset 726e98cd071e (bug 1302470) 2017-04-21 19:09:11 +02:00
Mike de Boer
5d0044b89a Bug 1302470 Part 6: Connect up FinderHighlighter.jsm with the new isRangeVisible function. r=mikedeboer
MozReview-Commit-ID: ABfAoZ4CBjP

--HG--
extra : rebase_source : 5099f8cd35e3f293bf8a6e791929ddbc054f7c31
2017-01-23 17:39:07 +01:00
Carsten "Tomcat" Book
b6ae5cfccc Backed out changeset eb2930fc7c59 (bug 1302470)
--HG--
extra : rebase_source : b7ea38492e4d956798e3dd94230674f1aece0d47
2017-04-21 17:10:35 +02:00
Mike de Boer
0b8a2bd88b Bug 1302470 Part 6: Connect up FinderHighlighter.jsm with the new isRangeVisible function. r=mikedeboer
MozReview-Commit-ID: ABfAoZ4CBjP

--HG--
extra : rebase_source : 24d59c8d804771a5c6d65cc6246dfb457b0f10aa
2017-01-23 17:39:07 +01:00
Florian Quèze
b11907c7aa Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Mike de Boer
6e5d62a6f2 Bug 1316514 - if we attempt to make the 'Highlight All' toggle a global setting, then we need to set the pref when toggled. r=Gijs
What you see first is the removal of the line `this._highlightAll = aHighlight;`, which is repeated in the `_setHighlightAll` method.
This line was put here initially to make the test_findbar_events.xul test pass but in fact makes it so that the pref is never set in `_setHighlightAll`!
In other words, we never actually persisted the 'Highlight All' state properly.
Reading further: the `_dispatchFindEvent` attaches some findbar state flags to the event details, including the value of `_highlightAll`.
Even though none of our consumers use it currently (haven't checked if TB does, though), you can cancel further execution of highlighting all ranges.
Since the `_setHighlightAll` doesn't do that kind of processing, but merely makes sure the internal state is up to snuff, is persisted properly and the buttons are updated, I moved it up to be invoked before dispatching the event.

MozReview-Commit-ID: 4BBy4FR1r5c

--HG--
extra : rebase_source : 204e77aaef3cd55886daeb2e0fdef84da1159c68
2017-01-13 17:27:18 +01:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Wes Kocher
1b3fc382aa Backed out 5 changesets (bug 1302470) for causing bug 1323200 a=backout
Backed out changeset 005adbf78cd2 (bug 1302470)
Backed out changeset 113f7b13475c (bug 1302470)
Backed out changeset 3d2569996ebc (bug 1302470)
Backed out changeset b92b78271941 (bug 1302470)
Backed out changeset 5b92678afff8 (bug 1302470)


MozReview-Commit-ID: FgeA5OQV8WP

--HG--
extra : histedit_source : 4513cf8271a0bf4d2ca373b5b87aac2c5beeddf9%2C489053b6db62d02f62b4f240fcd9a40fee09dbfb
2016-12-16 16:45:09 -08:00
Mark Banner
4f94e4bd68 Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop
MozReview-Commit-ID: CiIsUjQzp4D

--HG--
extra : rebase_source : 1b98e88673625a52ef82c1fad5d56aec3e2e8e80
2016-11-09 22:06:32 +00:00
Mike de Boer
b272d59f6c Bug 1302470 Part 3: Call the new isRangeVisible function to determine whether or not to draw a highlight rect. r=mikedeboer
MozReview-Commit-ID: ExO6zdjHGVO
2016-11-10 09:03:58 -08:00
Mike de Boer
d0a0fb4fcf Bug 1302470 Part 2: Use a hit-test method to determine if the rect of a range is visible on the page or not to the eye, for use in find-in-page. r=mstange,smaug
MozReview-Commit-ID: 9P7gf0GcREv
2016-11-09 15:09:36 -08:00
Sebastian Hengst
705e3df40e Backed out changeset cc04b61c9f23 (bug 1302470) 2016-11-20 20:31:31 +01:00
Mike de Boer
87e7094923 Bug 1302470 Part 2: Use a hit-test method to determine if the rect of a range is visible on the page or not to the eye, for use in find-in-page. r=mstange,smaug
MozReview-Commit-ID: 9P7gf0GcREv

--HG--
extra : rebase_source : 498fbc14d6b2e09b8dc7cfb6962b7698a6b38c52
2016-11-09 15:09:36 -08:00
Sebastian Hengst
9a38c0010b Backed out changeset 8243da10a171 (bug 1302470) 2016-11-17 17:49:46 +01:00
Mike de Boer
7ee955cbdc Bug 1302470 Part 2: Use a hit-test method to determine if the rect of a range is visible on the page or not to the eye, for use in find-in-page. r=mstange,smaug
MozReview-Commit-ID: 9P7gf0GcREv

--HG--
extra : rebase_source : b3565372bf9ab52a126f91795d54a2a22231f150
2016-11-09 15:09:36 -08:00
Mike de Boer
fa5057ff91 Bug 1309207 - the finder iterator doesn't find occurrences properly in links-only mode. r=jaws
MozReview-Commit-ID: 4kdxyX9zrKl

--HG--
extra : rebase_source : c3bfa0bb06d6c37615ac5e382de227788000dbe6
2016-11-02 13:38:59 +01:00
Mike de Boer
da36d08c94 Bug 1305194 - wait a little longer when the finder iterator is requested to find a query of only one or two characters, which improves usability due to less flickering of highlighter results and performance due to avoiding the most costly nsFind operations there are on a page. r=jaws
Single and double character find operations cause a big hit on nsFind, because
it usually yields many more occurrences than other queries. But most importantly,
it needs to keep iterating each text node much longer than other queries, because
there is much less escapes/ loop exits happening.
This also fixes the FinderIterator infinite-depth call-stack due to unresolved
promises that remain active during the lifetime of the FinderIterator. Unwinding
the call-stack properly should save us bytes from the heap.

MozReview-Commit-ID: 4K19X0yngC7

--HG--
extra : rebase_source : 1801dc16736d0ff9c7534bdaf3ec5a73b326f244
2016-10-12 15:46:44 +02:00
Mike de Boer
ec296b4f2e Bug 1303874 - make the active window object part of the iterator params to make sure that similar iterator runs for different runs are not treated as the same, thus potentially yielding incorrect results. r=jaws
MozReview-Commit-ID: H6gB2IMndM8
2016-10-11 13:08:00 +02:00
Mike de Boer
d826244682 Bug 1295759 - make sure selected ranges in iframes are cleared when the findbar is hidden as well. Adds a test to guard against regressions. r=jaws
MozReview-Commit-ID: 5rudNSNK8GK

--HG--
extra : rebase_source : 03dc19bc9ba83f7601d4d57d2bd9b78d312fda1b
2016-08-29 16:22:29 +02:00
Mike de Boer
56661a22a9 Bug 1294392 - consolidate the highlight and counter timers into one iterator timer. r=jaws
This introduces a new NLP (Natural Language Processing) module with only one
method: 'levenstein'. We're using it to allow the highlighter to keep running
when the it starts the iterator with a word that's one edit distance behind the
value in the findField.

MozReview-Commit-ID: K8oeiXoiLUe
2016-08-25 20:11:44 +02:00
Mike de Boer
8a56860e70 Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws
MozReview-Commit-ID: 1j0C0BUfT8r
2016-08-19 17:18:41 +02:00
Sebastian Hengst
8505f067f2 Backed out changeset bc160abe215b (bug 1282070) for docshell leakage in browser_visibleFindSelection.js. r=backout 2016-08-16 16:05:45 +02:00
Mike de Boer
010418133a Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws
MozReview-Commit-ID: JKzUehP4pyP
2016-08-16 12:16:29 +02:00