Commit graph

64 commits

Author SHA1 Message Date
Andrew Halberstadt
c288f18538 Bug 1666809 - Insert decision task indexes directly via taskluster API rather than index-task, r=taskgraph-reviewers,aki
We started using the "backstop" index added by bug 1660506 to determine whether
a push should be a backstop based on a time interval. The problem is that this
index gets added by an index-task that runs after the decision task has
completed.  Therefore, if two pushes land at roughly the same time (i.e, the
second decision task starts before the first completes), then they can both
determine themselves as backstops.

This patch gets around the problem by inserting the "backstop" index as early
as possible (immediately after resolving parameters), so the chances of this
happening become very low. It's still theoretically possible that it could
happen again, but we don't need this to be 100% perfect. As long as it is rare,
it's good enough.

Depends on D91191

Differential Revision: https://phabricator.services.mozilla.com/D91192
2020-09-24 19:19:36 +00:00
Andrew Halberstadt
da707c8ee1 Bug 1666809 - Allow HTTP methods other than GET and POST in taskgraph/util/taskcluster.py, r=taskgraph-reviewers,aki
Some taskcluster APIs use the PUT method.

Differential Revision: https://phabricator.services.mozilla.com/D91191
2020-09-23 21:01:14 +00:00
Andrew Halberstadt
c8cae8562c Bug 1636271 - [taskgraph] Create utility function for listing all tasks in a task group, r=tomprince
Creates a new utility function in 'taskgraph.util.taskcluster' to return task
definitions from a task group. Also refactors the existing
'list_task_group_incomplete_tasks' function to use it.

Differential Revision: https://phabricator.services.mozilla.com/D74407
2020-07-28 13:19:32 +00:00
Narcis Beleuzu
ef290a86e8 Backed out 3 changesets (bug 1636271) for breaking the Gecko Decision Task. CLOSED TREE
Backed out changeset 4b0f13fcf941 (bug 1636271)
Backed out changeset 4250f49877ba (bug 1636271)
Backed out changeset d3f93bd6b1f9 (bug 1636271)
2020-07-22 23:40:32 +03:00
Andrew Halberstadt
2d5688e974 Bug 1636271 - [taskgraph] Create utility function for listing all tasks in a task group, r=tomprince
Creates a new utility function in 'taskgraph.util.taskcluster' to return task
definitions from a task group. Also refactors the existing
'list_task_group_incomplete_tasks' function to use it.

Differential Revision: https://phabricator.services.mozilla.com/D74407
2020-07-22 15:09:56 +00:00
Armen Zambrano G.
bcdae74a2f Bug 1639873 - Fix new backfill issue r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D82420
2020-07-06 20:41:11 +00:00
Armen Zambrano G.
9425bdc44a Bug 1639873 - New backfill action r=tomprince
This backfill action schedules a secondary action per push. This secondary action
schedules the intended task on behalf of the primary action.

This introduces logic on how to trigger a hook by an action.

Differential Revision: https://phabricator.services.mozilla.com/D79351
2020-07-03 13:45:21 +00:00
Tom Prince
98dd864200 No bug: Don't use proxy for accessing taskcluster index; r=Callek
The index is not protected by scopes, so don't use the proxy to access it

Differential Revision: https://phabricator.services.mozilla.com/D77537
2020-05-29 21:37:46 +00:00
Andrew Halberstadt
b395876bc4 Bug 1603459 - [taskgraph] Add an optimizer that queries the bugbug /push/schedules endpoint, r=tomprince
Creates an optimizer that queries https://bugbug.herokuapp.com/push/<branch>/<rev>/schedules
to determine which tasks to run.

Differential Revision: https://phabricator.services.mozilla.com/D65585

--HG--
extra : moz-landing-system : lando
2020-03-13 20:30:34 +00:00
Ricky Stewart
0fa8a98bdb Bug 1524639: [taskgraph] Enforce unicode strings in schemas r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18376

--HG--
extra : moz-landing-system : lando
2020-01-21 17:12:08 +00:00
Razvan Maries
ffc90b2ec8 Backed out changeset a57aed49dc58 (bug 1524639) for beetmover bustages. a=backout 2020-01-16 14:04:31 +02:00
Ricky Stewart
fecc988cc6 Bug 1524639: [taskgraph] Enforce unicode strings in schemas r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18376

--HG--
extra : moz-landing-system : lando
2020-01-15 20:33:20 +00:00
Tom Prince
10c8c9240d Bug 1546801: [firefox-ci] Update default taskcluster; r=Callek a=tomprince CLOSED TREE
MANUAL PUSH: Initial push to test new firefox-ci taskcluster cluster.

Differential Revision: https://phabricator.services.mozilla.com/D52453

--HG--
extra : histedit_source : 4bcac76e95d5566db7bb892d44830c03a615f78f
2019-11-09 12:53:40 -07:00
Tom Prince
2d2ddbfc12 Bug 1576707: [taskgraph] Add a better error message when trying to get artifact prefix; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D49776

--HG--
extra : moz-landing-system : lando
2019-10-18 17:51:39 +00:00
Dustin J. Mitchell
1fded4473e Bug 1508381 - use rootUrl style with taskcluster-proxy r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18023

--HG--
extra : moz-landing-system : lando
2019-03-12 20:38:42 +00:00
Tom Prince
9fff567bdd Bug 1524639: [taskgraph] Force yaml to be loaded as unicode; r=dustin
Differential Revision: https://phabricator.services.mozilla.com/D18375

--HG--
extra : moz-landing-system : lando
2019-02-04 22:18:57 +00:00
arthur.iakab
c152ccec1d Backed out 4 changesets (bug 1508381) for multiple Windows build bustages CLOSED TREE
Backed out changeset f01cec6f712e (bug 1508381)
Backed out changeset ba69e59924de (bug 1508381)
Backed out changeset 97fe4e5a665e (bug 1508381)
Backed out changeset 0c3065c12bef (bug 1508381)
2019-01-31 23:14:11 +02:00
Dustin J. Mitchell
22fcbfc133 Bug 1508381 - use rootUrl style with taskcluster-proxy r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18023

--HG--
extra : moz-landing-system : lando
2019-01-30 18:58:09 +00:00
Dustin J. Mitchell
1b3c1d1b1d Bug 1517645 - fix lint issues in previous push; a=bustage CLOSED TREE
--HG--
extra : amend_source : 302098ef24e29399b896c0f6bc379fdbcfce6f64
2019-01-15 18:57:20 +00:00
Dustin J. Mitchell
96c6e859ad Bug 1517645 - fix list_task_group and rename it
Reviewers: bstack

Subscribers: tomprince

Tags: #secure-revision

Bug #: 1517645

Differential Revision: https://phabricator.services.mozilla.com/D15855

--HG--
extra : rebase_source : 16d17f800297ad3cde68d1981964f16fc7a7f44d
2019-01-07 17:52:14 +00:00
Dustin J. Mitchell
33e06bbbb5 Bug 1517645 - always use a highly concurrent requests session
Reviewers: bstack

Subscribers: tomprince

Tags: #secure-revision

Bug #: 1517645

Differential Revision: https://phabricator.services.mozilla.com/D15853

--HG--
extra : rebase_source : 44ffd0aaeeea9d4294e998027c7977a0a595f582
2019-01-04 21:42:57 +00:00
Dustin J. Mitchell
bc68c63ae0 Bug 1492664 - move list_task_group to taskgraph.taskcluster.util; r=bstack
--HG--
extra : rebase_source : 2ceef629af09aa6264e30977426a527b234c43db
extra : source : 870c8cec99e5f81814a8064a785c4c96f5f1aeca
2018-10-02 14:19:11 +00:00
Dustin J. Mitchell
0a5ad02fff Bug 1492664 - use taskcluster-urls to create taskcluster URLs; r=tomprince
--HG--
extra : rebase_source : 94fc30f53f75e67f221f15db1945640edf69537a
extra : source : 29f33f22fd8b6998276e10c10aac2e36e64af4bb
2018-09-25 20:31:44 +00:00
Tom Prince
e58a5b2a19 Bug 1492664: Replace uses of get_taskcluster_artifact_url with artifact-reference; r=dustin
--HG--
extra : rebase_source : c08110089030074cf4a831ce8e94678da03704a6
extra : source : e7f30540870849cf6ba49957d37190fbd89b5f0d
2018-12-18 15:35:18 +00:00
Dustin J. Mitchell
1516eb0435 Bug 1492664 - set TASKCLUSTER_ROOT_URL and TASKCLUSTER_PROXY_URL; r=tomprince,glandium
Eventually, workers will provide these variables directly
(https://bugzilla.mozilla.org/show_bug.cgi?id=1460015).  But for now, this
ensures that TASKCLUSTER_ROOT_URL is set everywhere in production, and
TASKCLUSTER_PROXY_URL is set wherever the proxy is active.

The taskgraph Taskcluster utils module gets a `get_root_url()` that gets the
root URL for the current run, either from an environment variable in production
or, on the command line, defaulting to https://taskcluster.net for user
convenience.  When the production instance's URL changes, we can simply change
that default.

Other changes to use this function are reserved for later commits.

This changes the docker build process propagate TASKCLUSTER_ROOT_URL into the
docker images where necessary (using %ARG), specifically to create URLs for
debian repo paths.

--HG--
extra : rebase_source : 4f50e9d066da62a1887baabd8603844c85a32ee6
extra : source : 5ea6f03f845e49d503f5d0283557f54561c41654
2018-09-25 20:18:19 +00:00
Sebastian Hengst
767c971623 Backed out 21 changesets (bug 1492664) for breaking cron task for nightlies. a=backout
Backed out changeset a7d50dbb2c8e (bug 1492664)
Backed out changeset 2d876c4ece8b (bug 1492664)
Backed out changeset c82285d253de (bug 1492664)
Backed out changeset bf6d089640eb (bug 1492664)
Backed out changeset d9a7f2ce49c3 (bug 1492664)
Backed out changeset 06c466ab4323 (bug 1492664)
Backed out changeset c1ea4a10cc8d (bug 1492664)
Backed out changeset 4c63a04fdd47 (bug 1492664)
Backed out changeset 742b038bb1dd (bug 1492664)
Backed out changeset 911b4b0fb683 (bug 1492664)
Backed out changeset 870c8cec99e5 (bug 1492664)
Backed out changeset 77699b51336b (bug 1492664)
Backed out changeset 29f33f22fd8b (bug 1492664)
Backed out changeset e7f305408708 (bug 1492664)
Backed out changeset 335a92b1f424 (bug 1492664)
Backed out changeset c566f1c8dcdf (bug 1492664)
Backed out changeset c77ae59aba41 (bug 1492664)
Backed out changeset 9c35dd209c6b (bug 1492664)
Backed out changeset a972d6b4434e (bug 1492664)
Backed out changeset 5ea6f03f845e (bug 1492664)
Backed out changeset 0699d3873e44 (bug 1492664)

--HG--
extra : histedit_source : 5cb1f7e50f25d4a875c1a58c86b7dce902e1a89c%2C20f1ab1a843b612cfcc67cf5c6ff745d65abf076
2018-12-20 12:43:22 +02:00
Dustin J. Mitchell
f29de7ef42 Bug 1492664 - fix list_task_group to use GET; r=Callek
--HG--
extra : rebase_source : 647d605f19a1952ce0174a942efdf2a109cdb05f
extra : source : dda1907540672396df035e84df87e54e2290bf68
2018-12-19 04:19:38 +00:00
Dustin J. Mitchell
4f02813428 Bug 1492664 - move list_task_group to taskgraph.taskcluster.util; r=bstack
--HG--
extra : rebase_source : 13a1a6c7208d1fefb23e94d05d599bd89b695f1c
2018-10-02 14:19:11 +00:00
Dustin J. Mitchell
fd1ab4ccca Bug 1492664 - use taskcluster-urls to create taskcluster URLs; r=tomprince
--HG--
extra : rebase_source : a8150fc08be0afda55d5d6d2b9e32b712e20fabf
2018-09-25 20:31:44 +00:00
Tom Prince
c8f83a0068 Bug 1492664: Replace uses of get_taskcluster_artifact_url with artifact-reference; r=dustin
--HG--
extra : rebase_source : 47b3f49611f72586d45aebd772baa20e57a38bff
2018-12-18 15:35:18 +00:00
Margareta Eliza Balazs
2e5e28f518 Backed out 16 changesets (bug 1492664) for breaking developer artifact builds, requested by standard8 a=backout
Backed out changeset 31e500489665 (bug 1492664)
Backed out changeset f4945658d45f (bug 1492664)
Backed out changeset 6d17291b8b92 (bug 1492664)
Backed out changeset 90f3faa36137 (bug 1492664)
Backed out changeset 0b229b00818a (bug 1492664)
Backed out changeset 5eb2c77d70a9 (bug 1492664)
Backed out changeset e1ebad5d89c5 (bug 1492664)
Backed out changeset 3017e5890739 (bug 1492664)
Backed out changeset c8b7e620eabf (bug 1492664)
Backed out changeset d3dfbd848236 (bug 1492664)
Backed out changeset 5c92bb5ac895 (bug 1492664)
Backed out changeset fb7cfca6ebc3 (bug 1492664)
Backed out changeset 0c4101230d4d (bug 1492664)
Backed out changeset b93a0fcc86f3 (bug 1492664)
Backed out changeset 6dc9522ee0bf (bug 1492664)
Backed out changeset 85d7f8b330eb (bug 1492664)
2018-12-19 11:45:29 +02:00
Dustin J. Mitchell
ca40021360 Bug 1492664 - move list_task_group to taskgraph.taskcluster.util r=bstack
Differential Revision: https://phabricator.services.mozilla.com/D14203

--HG--
extra : moz-landing-system : lando
2018-12-18 17:26:07 +00:00
Dustin J. Mitchell
b0b2a623fc Bug 1492664 - use taskcluster-urls to create taskcluster URLs r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D14201

--HG--
extra : moz-landing-system : lando
2018-12-18 17:24:02 +00:00
Tom Prince
67b6439dde Bug 1492664: Replace uses of get_taskcluster_artifact_url with artifact-reference; r=dustin
Differential Revision: https://phabricator.services.mozilla.com/D14812

--HG--
extra : moz-landing-system : lando
2018-12-18 17:23:10 +00:00
Dustin J. Mitchell
1be6f07ed6 Bug 1491186: sanity check action scopes r=aki,tomprince
This provides a modicum of assurance that, for example, a non-generic action is
not being run with generic scopes. While scopes would prevent any serious
damage from such an action, this provides an extra layer of security to prevent
such abuse.

Differential Revision: https://phabricator.services.mozilla.com/D6271

--HG--
extra : moz-landing-system : lando
2018-09-19 19:13:45 +00:00
Dustin J. Mitchell
91f4fe8c61 Bug 1398277: special-case retriggering of tasks not in the taskgraph; r=bstack
This will apply to cron tasks, action tasks, and decision tasks.  It is a
distinct retrigger implementation because (a) we do not want to follow
dependencies, and (b) it takes a lot of scopes to create a decision task, so we
need to limit access to this action.

MozReview-Commit-ID: 21DVSiagcrO

--HG--
extra : rebase_source : 6f027e349e245e4aa4dbed81145a0a5d75218cb1
extra : histedit_source : eff99aee5a0e7496b0734748b29739480eb0e3fb
2018-07-04 02:46:59 +00:00
Dustin J. Mitchell
9ea31e05b6 Bug 1472777: add create-interactive action; r=bstack
The resulting action task isn't useful to the user, so instead we send an email
containing a link to the interaction console.

MozReview-Commit-ID: 5uHnQo9WTF6

--HG--
extra : rebase_source : ec52a333582a2778c2cec12d612d681e1a9b1976
2018-07-02 20:24:16 +00:00
Ciure Andrei
24b60272b0 Backed out 1 changesets (bug 1472777) for linting failures create_interactive.py CLOSED TREE 2018-07-03 04:25:03 +03:00
Dustin J. Mitchell
f5ba8d33f9 Bug 1472777: add create-interactive action; r=bstack
The resulting action task isn't useful to the user, so instead we send an email
containing a link to the interaction console.

MozReview-Commit-ID: 5uHnQo9WTF6

--HG--
extra : rebase_source : 1213afa7c53a0bcc4a07c4c2970c7bf21ab3b7f1
2018-07-02 20:24:16 +00:00
Gregory Szorc
3f4ac974d3 Bug 1469999 - Use yaml.safe_load() in taskgraph; r=dustin
yaml.load() can evaluate arbitrary Python code via syntax such as
`!!python/object/apply:os.system`. Seriously.

Let's switch taskgraph to yaml.safe_load(), which is reasonable
about limiting magic.

Differential Revision: https://phabricator.services.mozilla.com/D1736
2018-06-25 21:34:30 +00:00
Tom Prince
eda1a9a23c Bug 1442545: Allow forcing artifact access to be via private URLs; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D976

--HG--
extra : rebase_source : 2c2c861ded410ca4d311ee2ec77010daffef6a62
extra : histedit_source : d0725429fa267be465f796ab85f356861bd91e71
2018-04-16 20:43:50 -06:00
Aki Sasaki
839bed1924 bug 1442793 - generate_taskcluster_artifact_prefix. r=bhearsum
MozReview-Commit-ID: 2zRqm5C9ZZQ

--HG--
extra : rebase_source : 859141b77f0fc52e4d84d4b476354dc5689fcec9
2018-03-21 12:07:01 -07:00
Aki Sasaki
b82a129bd2 bug 1442793 - get_artifact_prefix and get_artifact_path. r=bhearsum
MozReview-Commit-ID: E1VBN88h03M

--HG--
extra : rebase_source : bef288876aaecf452d989c32508c23084698321f
2018-03-07 10:37:33 -08:00
Aki Sasaki
043b1389dc bug 1450012 - add rerun task. r=bstack
--HG--
extra : rebase_source : cc80b2fdc541d098050ab046142916739b08e28e
2018-04-03 16:00:07 -07:00
Brian Stack
d2c0e62e07 Bug 1401000- Add a purge-cache action r=dustin
MozReview-Commit-ID: CaEizD3jYmc

--HG--
extra : rebase_source : 7916ab82b5a92376b15980cf5bd6a213ee40c4ae
2017-10-13 11:22:42 -07:00
Nick Alexander
405aa2b564 Bug 1405408 - Post: Use taskcluster-proxy /bewit endpoint to download private toolchains. r=dustin
This is a work-around until Bug 1405889 is deployed.  Using the /bewit
endpoint does have the advantage of avoiding another issue in
taskcluster-proxy, namely that the /bewit approach streams.  Fetching
through the proxy does not stream from the upstream resource; the
upstream resource is fetched and stored in taskcluster-proxy's memory,
increasing operational costs.

MozReview-Commit-ID: 8yS7zKLALhd

--HG--
extra : rebase_source : 23e1bc683248f69f6e4c90204e9bc0701f4a778a
2017-10-05 16:17:58 -07:00
Brian Stack
68903cd4e9 Bug 1405740 - Add a cancel-all action task r=garndt,jonasfj
MozReview-Commit-ID: 2V8ztB5Pdkc

--HG--
extra : rebase_source : c9badef0654a9e2f24471cba34c866b681503580
2017-10-05 13:31:56 -07:00
Brian Stack
17f6f5f45c Bug 1400223 - Merge tasks added by action tasks into graphs used for subsequent tasks r=dustin
MozReview-Commit-ID: 7ZTbS5h0vPA

--HG--
extra : rebase_source : c1acea26ac526c672f6630504ae69bbe7dbd6677
2017-09-20 12:52:29 -07:00
Dustin J. Mitchell
3dd5e9419e Bug 1401183: raise KeyError from list_artifacts when none is found; r=glandium
MozReview-Commit-ID: TqON8joEd6

--HG--
extra : rebase_source : c075a609ac5d0a0ecc91997922e98fde537f9822
extra : source : 19b510af2b7a6fe8b71f55fbb3d51d0a7696b54c
2017-09-14 23:30:58 +00:00
Simon Fraser
8ad84443f2 Bug 1342392 Migrate partial update generation in-tree r=rail
MozReview-Commit-ID: G6EFXY0UzSa

--HG--
extra : rebase_source : dbea33ec8d96cc9a0e016e4828f9f989fca7131b
2017-09-18 13:36:36 +01:00