We don't check for pkg-config on some platforms (Windows, OSX, Android).
On those platforms, calling 'pkg_check_modules' will not work. Adding
the same 'when' used for the 'pkg_config' check to all the options that
end up calling 'pkg_check_modules' effectively disables them, and prevents
'pkg_check_modules' from being called.
Differential Revision: https://phabricator.services.mozilla.com/D150649
We don't check for pkg-config on some platforms (Windows, OSX, Android).
On those platforms, calling 'pkg_check_modules' will not work. Adding
the same 'when' used for the 'pkg_config' check to all the options that
end up calling 'pkg_check_modules' effectively disables them, and prevents
'pkg_check_modules' from being called.
Differential Revision: https://phabricator.services.mozilla.com/D150649
Now that WGPU has upgraded its dependency on `libloading`, we can
finally remove our fake `libloading` 0.7 crate! 🙌
I found this audit and review easiest to do by generating a diff. that
ignores whitespace-only differences. In my case, I did the following:
```
git diff --ignore-space-at-eol --ignore-space-change --ignore-all-space --ignore-blank-lines
```
Differential Revision: https://phabricator.services.mozilla.com/D209290
Get read of -pthreads because (according to gcc info page) it's only
there on solaris and as an alias to -pthread.
-D_REENTRANT is always defined by gcc and clang when -pthreads is on.
-D_THREAD_SAFE is only defined on AIX by clang
so get rid of the related actions.
libpthreads is an AIX thing, I assume we can remove it too.
c/cxx flags are always added to the linker flags, so don't do any
linker-related addition.
Differential Revision: https://phabricator.services.mozilla.com/D203687
The location of the built libraries was changed by bug 1459764.
Additionally update the search paths in the .lldbinit file that gets
put in the objdir during build.
Differential Revision: https://phabricator.services.mozilla.com/D210667
Actually remove the check for demangle, no supported target need that
check.
Also make library dependencies explicit instead of relying on "$LIBS".
Differential Revision: https://phabricator.services.mozilla.com/D203637
We can't add the flag to EXE files unless we do either
* Make the CRT an SxS assembly (bug 1733734) or
* Ship the redistributable installer to install the CRT to System32.
Because otherwise firefox.exe will no longer be able to find the CRT.
Differential Revision: https://phabricator.services.mozilla.com/D210639
The -ldl flag was previously set globally, it's now set for the libs
that use it.
Also rationalize the difference between HAVE_DLOPEN and HAVE_DLFCN_H.
Differential Revision: https://phabricator.services.mozilla.com/D203594
Actually remove the check for demangle, no supported target need that
check.
Also make library dependencies explicit instead of relying on "$LIBS".
Differential Revision: https://phabricator.services.mozilla.com/D203637
The -ldl flag was previously set globally, it's now set for the libs
that use it.
Also rationalize the difference between HAVE_DLOPEN and HAVE_DLFCN_H.
Differential Revision: https://phabricator.services.mozilla.com/D203594
The only use of this type used to be carrying around an owning reference
to a thread-local. However, since bug 1577439 we're leaking the
allocation intentionally, so we can simplify the code to explicitly use
`Box::leak()`, which in turn removes all unsafe usage around these, and
allows us to drop the owning_ref dependency altogether.
Differential Revision: https://phabricator.services.mozilla.com/D209912
