Commit graph

531 commits

Author SHA1 Message Date
Gijs Kruitbosch
c7a51be34d Bug 1402929 - add header to overflow panel in customize mode, r=mikedeboer
MozReview-Commit-ID: 7Z8Xk2X707J

--HG--
extra : rebase_source : 6422413079a4aeb0bf1e44ff39aaea58a2711166
2017-09-29 23:10:38 +01:00
Gijs Kruitbosch
d9dae67b93 Bug 1402929 - try to make overflow panel in customize mode easier to understand, r=mikedeboer
This moves the explanatory text from a pseudoelement to a real element,
and keeps only the image in a pseudoelement. It then uses a transitioned
opacity to fade that image in and out.

Because we need to fade this based on dragging items over the panel when
it's empty, it adds/removes a 'draggingover' attribute to handle the fade.

To cope with the extra element in the drag/drop container in customize mode,
this also makes the following changes:
- bail out of _onDragStart if there's no actual selected item.
- pick the fixed list in the panelHolder more reliably
- add a max-width to avoid the description making the panel wider

MozReview-Commit-ID: 9PEJSoJJ0Rp

--HG--
extra : rebase_source : 0a7865fcfd11eb5baca858cde71ea4e8b30d5afc
2017-09-29 17:55:50 +01:00
Mike de Boer
882fa06e25 Bug 1401991 - Ensure that we don't hide panelviews that are already reparented to another multi-view and ensure to hide other panels consistently. r=Gijs
* Harden the new `hideAllViewsExcept()` to not do erroneous things if called when
   the binding is already gone.
 * Generalize things into `hideAllViewsExcept(thisOne)`:
    - Clear `_viewShowing` in there and do the descriptionHeightWorkaround thing
      in there too,
    - For Photon panels, do all the 'current' attribute setting in there. To show
      a panel during transition, I introduced the 'in-transition' attribute.
 * I had to make sure not to over-eagerly dispatch 'ViewShowing' events, because
   that confuses some,
 * Move the temporary panel handling, which contains an ephemeral panelmultiview
   instance, internally. This cleans up the hacky, duplicate PanelUI.js code nicely.
 * Keep a local copy of `_transitionDetails` to ensure it's still there after transition,
 * Harden `_cleanupTransitionPhase()` to only clear the phase that belongs to a
   specific transition, _if_ that's passed in as an argument. This resolves any
   potential raciness that might occur when `showSubView()` is called again mid-transition.
 * Skip the UITour element visibility check when it's inside a panelview, because
   too many things need to happen and that check is too simple to be useful in
   that case.

MozReview-Commit-ID: 5HpJKs1Ny5j

--HG--
extra : rebase_source : b810e1de2dbd75932a42d68e751fdaecd9fee69a
2017-09-29 13:51:51 +02:00
Erica Wright
a9e25e23df Bug 1401152 - Disable 'add to overflow menu' in the customize mode *palette* context menu for flexible space. r=Gijs
MozReview-Commit-ID: 5sQPsxVaVYz

--HG--
extra : rebase_source : 6eab6e7e9d65bc0b45dea6dac7daf3cd23fc6c77
2017-09-21 18:15:02 -04:00
Mike de Boer
352843986a Bug 1402023 - Limit the 'Recent Activity' list in the Library to a maximum of 6 items. r=Gijs
MozReview-Commit-ID: AVHRKvAJjWe

--HG--
extra : rebase_source : 388488c561e6b8f180c918a25e43b7501a37e408
2017-09-21 18:25:41 +02:00
Doug Thayer
cb1a8fb21a Bug 1399177 - Pull label out of description in update popups r=Gijs
The margin rules for labels mean that if the See what's new link
starts its own line, the alignment looks off. We could override this,
but matching the styling for "Learn more" links, which get their own
line, seemed the better option.

MozReview-Commit-ID: 4WK9QtRMUQs

--HG--
extra : rebase_source : d24d83094d5b4ca400fe77358a3c1c2635e033d0
2017-09-20 15:58:25 -07:00
Gijs Kruitbosch
fda48d1b3f Bug 1401754 - print in the hamburger panel should open preview on Windows/Linux but not suggest its shortcut is ctrl-p, r=dao
MozReview-Commit-ID: K4yQB6ejGRv

--HG--
extra : rebase_source : cdd730f7777ed609386469762f7620d6d4805d7e
2017-09-20 22:54:38 +01:00
Mike de Boer
ecca1af556 Bug 1388422 - Remove all traces of the Customize Mode tip panel that no longer applies. r=Gijs
MozReview-Commit-ID: IffDnXEqooR

--HG--
extra : rebase_source : 04344421e5152c1f7ba8959698ba7cff57448e15
2017-09-20 14:37:53 +02:00
Mike de Boer
f716107bf8 Bug 1354536 - Part 3 - When the Library view is shown, populate a new 'Recent Highlights' section with at most 12 items as in about:newtab. r=Gijs
MozReview-Commit-ID: Bs1RzL0uewH

--HG--
extra : rebase_source : 5efd60f237f9123ecf57e2da820851b703c2045e
2017-09-19 16:17:16 +02:00
Drew Willcoxon
de32f1dce3 Bug 1400024 - Clicks on Zoom label in Photon app menu shouldn't close the menu. r=Gijs
MozReview-Commit-ID: 6zHRb27RBGw

--HG--
extra : rebase_source : 8713582d948b81a5558c539ad1d910d1139fea2d
2017-09-18 13:13:13 -07:00
Maya Messinger
1710134422 Bug 1387846 change print button command to print instead of print preview on all platforms r=Gijs
MozReview-Commit-ID: IIxhCx4N362

--HG--
extra : rebase_source : b920e3c9333df0b2ee9cda92880b5effb4922e45
2017-09-17 17:23:00 -04:00
Maya Messinger
11ffb95321 Bug 1398305 - reorder library dropdown items to spec r=Gijs
MozReview-Commit-ID: 912yc4MB5Ap

--HG--
extra : rebase_source : 8393ffa21314fc67784119b319abd0a73b6b3bcd
2017-09-14 11:37:22 -04:00
Doug Thayer
c06b48b5e7 Bug 1399172 - Add buttonhighlight to update doorhangers r=johannh
The highlight styling was recently added, causing update notification
buttons to both be styled as grey. This fixes that to style them as
blue again.

MozReview-Commit-ID: HDSA9NWBmIA

--HG--
extra : rebase_source : f9bbe50bb7115b1a2be6aff8fe930bf6c9844dbb
2017-09-12 10:08:01 -07:00
Johann Hofmann
c90a0e9e12 Bug 1349552 - Part 2 - Add an extra drag space setting to customize mode. r=nhnt11
MozReview-Commit-ID: IWxdOeRwDeu

--HG--
extra : rebase_source : 953c988fdaab5a7bf64ecbdd363df846020063d9
2017-09-10 20:38:19 +02:00
Mike de Boer
aa0c3dc278 Bug 1374749 - Animate the panelviews differently to make it look as if the view to show is pushing the previous view out of the panel. r=jaws
MozReview-Commit-ID: Dy6UppV3xDH

--HG--
extra : rebase_source : 1c970efaa0b7162450d79f37633afacaadc8d19e
2017-09-12 21:33:25 +02:00
Gijs Kruitbosch
c3acd03b82 Bug 1397447 - add UI and automatic toggles to make the auto-hide functionality more seamless, r=mak
MozReview-Commit-ID: 9xN3N4aLwfv

--HG--
extra : rebase_source : 54333982cce1dcb7cb84331734f170d4d79fbc29
2017-09-11 18:54:48 +01:00
Sebastian Hengst
22c06f3a4b Backed out changeset f09b2b387751 (bug 1374749) for frequently failing browser-chrome's browser/components/extensions/test/browser/test-oop-extensions/browser_ext_browserAction_popup_resize.js on macOS. r=backout 2017-09-11 18:45:35 +02:00
Mike de Boer
bdb3034789 Bug 1374749 - Animate the panelviews differently to make it look as if the view to show is pushing the previous view out of the panel. r=jaws
MozReview-Commit-ID: Dy6UppV3xDH

--HG--
extra : rebase_source : 28e14f7e5764490c3a0a550cb230eb8a800647bf
2017-09-11 16:28:06 +02:00
Zibi Braniecki
70e0d2b8e8 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 5e58c418f91a1802328c4128dffd2c1ab9aa067f
2017-09-09 22:17:19 -07:00
Sebastian Hengst
a4b102b6d9 Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
923420c64a Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 9aeed150b6106210bbe06e8a98ae602e5471851b
2017-09-09 22:17:19 -07:00
Sebastian Hengst
5c5d753509 Backed out changeset 20f6207757f3 (bug 1374749) for failing browser-chrome's browser/base/content/test/urlbar/browser_page_action_menu.js. r=backout 2017-09-08 19:42:22 +02:00
Mike de Boer
dcde014112 Bug 1374749 - Animate the panelviews differently to make it look as if the view to show is pushing the previous view out of the panel. r=jaws
MozReview-Commit-ID: Dy6UppV3xDH

--HG--
extra : rebase_source : b473714a3de9ff34da8c936770d335b7e2ee01bd
2017-09-08 18:02:10 +02:00
Mike de Boer
02e344af23 Bug 1390336 - Disable panelview keyboard navigation using arrow keys in the overflow panel, because input boxes can be in there. r=Gijs
MozReview-Commit-ID: DxZv8JDp2Q2

--HG--
extra : rebase_source : b3bf90e60540a1b115a3bf2321fd4396863b5cce
2017-09-08 11:53:11 +02:00
Sebastian Hengst
8eb249afcc merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00
Gijs Kruitbosch
8ec70a2c1b Bug 1393574 - fix flexible spacers not being removable in some circumstances, r=jaws
The goal of this patch is to ensure that:
- in default placements, specials have no unique ids
- in actual placements as stored by CUI, they do
- we reset the counter for those unique ids on reset.
- we re-number specials when building an area (like on startup, or when resetting),
  ensuring that the actual nodes always match the placements for a given area.
- we force saves after resetting, to ensure that the gNewElementCount is always persisted correctly.

This last part will also fix bug 1393661

MozReview-Commit-ID: HAS5J5ZSgB5

--HG--
extra : rebase_source : df62441169e07fb94e39f68a2b3e43f6ed7f464c
2017-09-06 10:02:44 +01:00
Mike de Boer
0fcde6db9c Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Sebastian Hengst
c3dc29271d Backed out changeset f1d18c741b2c (bug 1354532) for eslint failure at browser/components/downloads/DownloadsCommon.jsm:671: Expected property shorthand. r=backout 2017-09-06 16:48:00 +02:00
Mike de Boer
bfdabc36cf Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Gijs Kruitbosch
fd7064ce6b Bug 1374315 - fix CSS overflow:hidden in overflow panel and page action panel to fix rounded corners, r=mikedeboer
MozReview-Commit-ID: B5lHCaAMvyu

--HG--
extra : rebase_source : 4b0995e4ef6558ad418c8782f4bdfdf5cba1f91d
2017-08-15 13:03:33 +01:00
Gijs Kruitbosch
50b63100b8 Bug 1393343 - move 'restore previous session' item into main menu and hide when auto-restore is enabled, r=mikedeboer
MozReview-Commit-ID: B3J9c936RL

--HG--
extra : rebase_source : 8c30211e59c40774c72f039eda515724cb193c0d
2017-08-25 11:40:49 +01:00
Edouard Oger
d0c4b71df2 Bug 1380377 part 2 - Make sure sync-illustration.svg doesn't get loaded on startup. r=markh
MozReview-Commit-ID: KWWCniJPU44

--HG--
extra : rebase_source : ff733d8d04150d464d68ef0d03420fef8908f28b
2017-08-16 14:12:42 -04:00
Robert Strong
07b5b84c71 bug 1390032 - make it clear in the update doorhanger text that private browser windows and tabs are not restored. r=dothayer 2017-09-06 10:36:22 -07:00
Florian Quèze
48761699cf Bug 1391704 - Avoid flickering while moving tabs across windows, r=mconley. 2017-09-01 00:42:31 +02:00
Gijs Kruitbosch
c6da57415c Bug 1389625 - clean up subview headers now that we use the title of the view instead, r=adw
The panel-subview-header is always hidden in photon (sub)panels, and so we now never show it.
Removing it avoids having to readd the old label for the bookmarks view, remove some unused
strings, and I noticed that we accidentally left the PanelUI-sidebar container which is
unused since bug 1360282.

MozReview-Commit-ID: 4ProWA1sUUs

--HG--
extra : rebase_source : e887b156f450a62cf04228db13b8584810fdf5a0
2017-08-24 14:03:15 +01:00
Gijs Kruitbosch
3699f166ad Bug 1389625 - change bookmarks menu button label, r=adw
MozReview-Commit-ID: CNNbbfJTnlG

--HG--
extra : rebase_source : ade3148178c99955ba007ff341b4d0e997191aa2
2017-08-24 13:54:55 +01:00
Edouard Oger
5aca028c2c Bug 1392280 - Backout bug 1380377. r=mconley
MozReview-Commit-ID: AOD2ol0yzaC

--HG--
extra : rebase_source : f55cf56275ceb4dc5872e05dd2819dc46ed7f8bb
2017-08-22 11:07:47 -04:00
Gijs Kruitbosch
fea0af94d3 Bug 1382145 - update customize mode header to be clearer, r=abenson
MozReview-Commit-ID: ag8hELX4Zo

--HG--
extra : rebase_source : d315bc47fd10a6f99025c5853549f4a7c36d90de
2017-08-18 12:41:58 +01:00
Sebastian Hengst
e8c36327cd Backed out changeset 1e7bcce37cfc (bug 1374315) for frequently failing browser-chrome's browser_ext_browserAction_popup_resize.js. r=backout a=backout on a CLOSED TREE
MozReview-Commit-ID: 4jM1IqGW8u5
2017-08-17 19:31:10 +02:00
Edouard Oger
c2a083e14a Bug 1380377 - Make sure sync-illustration.svg doesn't get loaded on startup. r=markh
MozReview-Commit-ID: KWWCniJPU44

--HG--
extra : rebase_source : c33dcd253c1c00c85f42063fc84d1b6ef2b871ee
2017-08-16 14:12:42 -04:00
Shane Caraveo
1fe5a3a13e Bug 1388902 remove socialapi share, r=florian
MozReview-Commit-ID: Kcjugf3Ql6y

--HG--
extra : rebase_source : 8f82fa6beabfa89916bbc97ec799c6e5d6b3ff18
2017-08-16 08:54:21 -07:00
Gijs Kruitbosch
8aa9c66d0c Bug 1374315 - fix CSS overflow:hidden in overflow panel and page action panel to fix rounded corners, r=mikedeboer
MozReview-Commit-ID: B5lHCaAMvyu

--HG--
extra : rebase_source : 0eb5ac61a7eb2082d501a95919d06c49bcbb1c08
2017-08-15 13:03:33 +01:00
Mike de Boer
25583e0eda Bug 1377968 - Add a tools section and subview to the Bookmarks subview inside the Library widget. r=Gijs
MozReview-Commit-ID: GqbUMbuvYoO

--HG--
extra : rebase_source : 09f489b9b558a9b8dfc0aecbf1ab863d816ee43b
2017-08-15 13:34:41 +02:00
Gijs Kruitbosch
b584e361b6 Bug 1381556 - adjust panel widths to accommodate longer/wider content, r=mikedeboer
MozReview-Commit-ID: 6bOoRIfttEy

--HG--
extra : rebase_source : d7748809abe4ee617d0cb1a9d66a3e88728ecc63
2017-08-09 14:04:21 +01:00
Dão Gottwald
2c29c9f69a Bug 956731 - Remove legacy add-on bar and statusbar shims. r=Gijs
MozReview-Commit-ID: 2deeujcHYUM

--HG--
extra : rebase_source : 90e8c1f1c90655d3e38560b588af82da64fdc2a5
2017-08-10 09:17:48 +02:00
Michael Kohler
674e1b96fb Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao
MozReview-Commit-ID: 8w1vfF2yRui

--HG--
extra : rebase_source : 222d8e9d3b9543552ff5b08967375fa46d62b896
2017-08-08 12:09:14 +02:00
Sebastian Hengst
ca40024d84 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
45d5f35624 Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao
MozReview-Commit-ID: CoHv9mKpAe

--HG--
extra : rebase_source : 20d6404db9f90cfcb7de03d4c527ad6ed79d49f8
2017-08-05 20:37:40 +02:00
Gijs Kruitbosch
2b8e704244 Bug 1354117 - remove old panel code from panelUI and CSS, r=jaws
MozReview-Commit-ID: G6a9ybDxqki

--HG--
extra : rebase_source : 6b2ec759d40d120842de9be9945fb27cda494745
2017-08-01 19:59:38 +01:00
Gijs Kruitbosch
f1b0d2d8c3 Bug 1354117 - remove old panel code from customize mode and update related CSS, r=jaws
MozReview-Commit-ID: IwKUWMTagCK

--HG--
extra : rebase_source : e6c54f3b5d6115574f22f31380a4a07601776d1c
2017-08-02 11:51:58 +01:00