Commit graph

842 commits

Author SHA1 Message Date
Andi-Bogdan Postelnicu
c8e0f87391 Bug 1519636 - First reformat with clang-format 13.0.0. r=firefox-build-system-reviewers,sylvestre,mhentges
Updated with clang-format version 13.0.0 (taskcluster-OgjH5lasS5K_fvefdRcJVg)

Depends on D131114

Differential Revision: https://phabricator.services.mozilla.com/D129119
2021-11-16 08:07:30 +00:00
Dimi
56505f3e46 Bug 1729640 - P1. Extend AddHighValuePermission to support 'highValueHasSavedLogin' and 'highValueIsLoggedIn' permission. r=necko-reviewers,farre,kershaw
This patch:
1. adds two 'highValueHasSavedLogin' and 'highValueIsLoggedIn' permission
2. moves 'AddHighValuePermission' from HttpBaseChannel to ProcessIsolation
   to support more high-value permission type.

Differential Revision: https://phabricator.services.mozilla.com/D127101
2021-11-05 17:11:31 +00:00
Csoregi Natalia
d2f8488b6a Backed out 7 changesets (bug 1729640) for causing permafailures on browser_web_process_isolation.js. a=backout
Backed out changeset 5b2a1799ce4e (bug 1729640)
Backed out changeset fcd4b833ad73 (bug 1729640)
Backed out changeset 5ff8d3adc6eb (bug 1729640)
Backed out changeset b8fd0343ca42 (bug 1729640)
Backed out changeset fbd6928e34ef (bug 1729640)
Backed out changeset 4ce2eebab0c4 (bug 1729640)
Backed out changeset c7c50c85f911 (bug 1729640)
2021-11-04 23:44:26 +02:00
Dimi
3718fbdc11 Bug 1729640 - P1. Extend AddHighValuePermission to support 'highValueHasSavedLogin' and 'highValueIsLoggedIn' permission. r=necko-reviewers,farre,kershaw
This patch:
1. adds two 'highValueHasSavedLogin' and 'highValueIsLoggedIn' permission
2. moves 'AddHighValuePermission' from HttpBaseChannel to ProcessIsolation
   to support more high-value permission type.

Differential Revision: https://phabricator.services.mozilla.com/D127101
2021-11-04 11:17:03 +00:00
Norisz Fay
47a4e47af2 Backed out 7 changesets (bug 1729640) for causing Bp-hybrid bustages on LoginDetectionService.o CLOSED TREE
Backed out changeset 4d3532da5652 (bug 1729640)
Backed out changeset 9ec5346cf9d9 (bug 1729640)
Backed out changeset 43dd05680186 (bug 1729640)
Backed out changeset f44a8f37d84c (bug 1729640)
Backed out changeset 66376bee8cef (bug 1729640)
Backed out changeset c7ffe85380d7 (bug 1729640)
Backed out changeset ae9c5de3902a (bug 1729640)
2021-11-02 16:33:01 +02:00
Dimi
fc57da5280 Bug 1729640 - P1. Extend AddHighValuePermission to support 'highValueHasSavedLogin' and 'highValueIsLoggedIn' permission. r=necko-reviewers,farre,kershaw
This patch:
1. adds two 'highValueHasSavedLogin' and 'highValueIsLoggedIn' permission
2. moves 'AddHighValuePermission' from HttpBaseChannel to ProcessIsolation
   to support more high-value permission type.

Differential Revision: https://phabricator.services.mozilla.com/D127101
2021-11-02 13:47:47 +00:00
Sean Feng
5283aecc5d Bug 1468476 - Make soft reload only force validates top level document r=necko-reviewers,nika,dragana,asuth
Currently, soft reload uses the `VALIDATE_ALWAYS` flag to not only
force revalidate the top level document, but also subresources.
This causes content to be refetched from the web even if there
are caches that are still valid and can be used.

Chrome already has such behaviour to not revalidate all resources.

Differential Revision: https://phabricator.services.mozilla.com/D122270
2021-10-28 16:11:56 +00:00
Alexandru Michis
363dc1e112 Backed out 3 changesets (bug 1732792, bug 1733481) for causing talos crashes in ConditionVariableImpl and xpcshell failures in test_remote_settings_utils.js.
CLOSED TREE

Backed out changeset 309190b4a49d (bug 1732792)
Backed out changeset 600e6dfd7436 (bug 1732792)
Backed out changeset 834441a08cc0 (bug 1733481)
2021-10-27 22:37:07 +03:00
Shane Caraveo
b683ebea88 Bug 1733481 retry telemetry requests when a proxy fails r=chutten,robwu,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D127170
2021-10-27 16:16:50 +00:00
Marian-Vasile Laza
84fc0a136f Backed out changeset 3882acd862fc (bug 1733481) for causing build bustages on HttpBaseChannel.cpp. CLOSED TREE 2021-10-27 01:37:32 +03:00
Shane Caraveo
863c48338b Bug 1733481 retry telemetry requests when a proxy fails r=chutten,robwu,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D127170
2021-10-26 20:32:52 +00:00
Narcis Beleuzu
331a8b2a4f Backed out changeset 054e0b5325a3 (bug 1733481) for xpcshell failures on /test_failover_retry.js CLOSED TREE 2021-10-26 21:57:33 +03:00
Shane Caraveo
5b177fc77d Bug 1733481 retry telemetry requests when a proxy fails r=chutten,robwu,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D127170
2021-10-26 18:16:38 +00:00
Sandor Molnar
799be2330b Backed out changeset 5a4d9d296d42 (bug 1733481) for causing xpc failures in unit/test_failover_retry. CLOSED TREE 2021-10-26 18:39:07 +03:00
Shane Caraveo
15e1356e3b Bug 1733481 retry telemetry requests when a proxy fails r=chutten,robwu,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D127170
2021-10-26 14:41:11 +00:00
Valentin Gosu
44e308670b Bug 1733274 - Skip CORP check for TYPE_SAVEAS_DOWNLOAD r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D129395
2021-10-25 14:03:20 +00:00
Valentin Gosu
cc8b1ac579 Bug 1735299 - Use fewer NS_ADDREF in netwerk/ r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D128176
2021-10-19 13:44:24 +00:00
Valentin Gosu
4cd661b6a5 Bug 1733356 - Fix non-unified build errors in netwerk/protocol/http/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D127407
2021-10-14 12:58:01 +00:00
Cosmin Sabou
8d444b25a5 Backed out 10 changesets (bug 1733356, bug 1733922) for causing windows hybrid bustages. CLOSED TREE
Backed out changeset 85b747a60e73 (bug 1733922)
Backed out changeset 4af7a3a697ad (bug 1733356)
Backed out changeset 3b2e02c99090 (bug 1733356)
Backed out changeset b481b801250e (bug 1733356)
Backed out changeset 88c33cdcb8aa (bug 1733356)
Backed out changeset 3d31e8c8e194 (bug 1733356)
Backed out changeset 616f676e8f94 (bug 1733356)
Backed out changeset 3f8e9b14879d (bug 1733356)
Backed out changeset 241c7cdb3f6b (bug 1733356)
Backed out changeset 7f9e266070c6 (bug 1733356)
2021-10-14 01:54:30 +03:00
Valentin Gosu
a549c09e13 Bug 1733356 - Fix non-unified build errors in netwerk/protocol/http/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D127407
2021-10-13 19:39:08 +00:00
Sean Feng
d275bc2c1f Bug 1722759 - Make devtools network panel to display images that are loaded by the image cache r=necko-reviewers,dragana,tnikkel,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D121122
2021-10-12 22:30:46 +00:00
Kershaw Chang
40dab11b6b Bug 1544127 - Always release load info on main thread, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D127675
2021-10-12 14:20:41 +00:00
Cristian Tuns
2be2d6077e Backed out 10 changesets (bug 1733922, bug 1733356) for causing hybrid build bustages on nsAboutProtocolHandler.cpp. CLOSED TREE
Backed out changeset 293ff1a22c98 (bug 1733922)
Backed out changeset b640749ee844 (bug 1733356)
Backed out changeset d2e3dc1b492a (bug 1733356)
Backed out changeset cd6c19829601 (bug 1733356)
Backed out changeset ef8145f88447 (bug 1733356)
Backed out changeset 366e2d375980 (bug 1733356)
Backed out changeset 14563275a25b (bug 1733356)
Backed out changeset 7700cd82bdf2 (bug 1733356)
Backed out changeset 4e198c3d5ef3 (bug 1733356)
Backed out changeset c26481d0f689 (bug 1733356)
2021-10-11 10:02:20 -04:00
Valentin Gosu
d837d118aa Bug 1733356 - Fix non-unified build errors in netwerk/protocol/http/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D127407
2021-10-11 10:40:08 +00:00
Gijs Kruitbosch
dd394d57a2 Bug 1733558 - stop duplicating append redirect history entry logic everywhere, r=ckerschb,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D127251
2021-10-04 13:24:15 +00:00
Shane Caraveo
efe27c108e Bug 1732388 support proxyBypass flag on http channels r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D126550
2021-09-27 21:01:53 +00:00
Sean Feng
a1b9c83581 Bug 1731831 - Rename timedChannel to timedChannelInfo for ReplacementChannelConfig r=dragana,necko-reviewers
`timedChannel` is wrong because it implies it is a channel, however it
is in fact a `TimedChannelInfo`.

Differential Revision: https://phabricator.services.mozilla.com/D126254
2021-09-22 19:07:56 +00:00
Valentin Gosu
72c414923b Bug 1730494 - Add error codes for COOP and COEP errors r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D125671
2021-09-16 08:31:04 +00:00
Nika Layzell
3211ad72e0 Bug 1723797 - Add a separate pref to control process isolation strategy when fission.autostart is enabled, r=farre,johannh,necko-reviewers,dragana
This new pref will be used on android to enable high-value-only process
isolation. An initial version of high-value-only process isolation is
also implemented in this bug, using the permission manager to track
whether a site is high-value due to having served a
`Cross-Origin-Opener-Policy` header.

Future high-value permissions due to things like logging into a site and
OAuth flows can be tracked in the same way, by adding the permission to
the permissions database.

In the future, it might be valuable to provide UI for visualizing what
sites are considered high-value at any point in time, but this works
fine for now.

Differential Revision: https://phabricator.services.mozilla.com/D123127
2021-09-08 17:45:31 +00:00
Kershaw Chang
ad767f9fe2 Bug 1721303 - Avoid exposing Alt-Used to service workers, r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D122608
2021-08-17 14:48:04 +00:00
Kershaw Chang
32f8d51ddb Bug 1721781 - Make HTTP3 work when we use DIRECT proxy connection, r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D120805
2021-08-09 12:25:54 +00:00
Tim Huang
4cca7fc573 Bug 1720869 - Part 1: Add a telemetry probe for referrer policy. r=ckerschb,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D121344
2021-08-02 19:24:54 +00:00
Gijs Kruitbosch
99251553e0 Bug 1717314 - do not force a dialog for https-redirect-to-external-protocol links from external sources, r=nika,pbz,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D120879
2021-08-02 12:14:23 +00:00
Sandor Molnar
9a31129771 Backed out changeset bb055da29523 (bug 1717314) for causing bc failures in browser_protocol_ask_dialog_external. CLOSED TREE 2021-07-31 01:14:15 +03:00
Gijs Kruitbosch
e83ab3f744 Bug 1717314 - do not force a dialog for https-redirect-to-external-protocol links from external sources, r=nika,pbz,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D120879
2021-07-30 21:24:33 +00:00
Nika Layzell
e620d25a35 Bug 1715167 - Part 6: Use the unsandboxed result principal as precursor for sandbox principals, r=ckerschb,ngogge
This change stores a generated nsID directly on the LoadInfo, rather
than the full SandboxedLoadingPrincipal. This allows for the sandboxed
principal to be constructed from GetChannelResultPrincipal using the
unsandboxed result principal as a precursor, rather than the loading
principal.

The nsID is reset by HttpChannelBase whenever a non-internal redirect
occurs to reduce the chance of multiple null result principals during a
redirect with the same nsID, but different precursors.

Depends on D119692

Differential Revision: https://phabricator.services.mozilla.com/D119693
2021-07-15 21:09:15 +00:00
Nika Layzell
dd4aed4589 Bug 1715167 - Part 4: Set precursor for redirect principal to inherit, r=ckerschb,necko-reviewers,ngogge,kershaw
When a navigation redirects, the principalToInherit is reset back to a null
principal for security reasons. This helps prevent a redirect from loading
attacker controlled content with the wrong principal. This patch gives this new
principalToInherit a precursor origin based on the resource which is being
redirected.

One time when this may come up is when an extension redirects a http: request
to a `data:` URI through the request API. Before this change, the load would
complete with a precursorless null principal, but after this change the
precursor refers to the redirected-from URL.

Depends on D119690

Differential Revision: https://phabricator.services.mozilla.com/D119691
2021-07-15 21:09:14 +00:00
Eden Chuang
4ce2d06b79 Bug 1714299 - Correct the opaque response judgment for opaque response blocking. r=necko-reviewers,annevk,dragana
An opaque response should be not only cross-origin but also be request with no_cors request mode.

To filter out the request with mode Same_origin, navigate, and cors. This patch reuses the algorithm in InternalRequest/FetchDriver to decide whether a response is an opaque response.

https://searchfox.org/mozilla-central/rev/da5d08750e504f3710f7ea051327d9c311c39902/dom/fetch/InternalRequest.cpp#331
https://searchfox.org/mozilla-central/rev/da5d08750e504f3710f7ea051327d9c311c39902/dom/fetch/FetchDriver.cpp#1153,1157

Differential Revision: https://phabricator.services.mozilla.com/D117086
2021-07-02 23:11:55 +00:00
Matt Woodrow
f0372c521b Bug 1717163 - Remove stream converter service usage for decompressing HTTP responses. r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D118421
2021-06-22 21:19:43 +00:00
Christoph Kerschbaumer
fdcd24393c Bug 1715253: Break endless upgrade downgrade loops within https-first r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D118204
2021-06-22 14:56:44 +00:00
Csoregi Natalia
55047317f1 Backed out changeset 5e9693e4d6b7 (bug 1714299) for causing high frequency failures on browser_opaque_response_blocking_telemetry.js. CLOSED TREE 2021-06-22 18:15:31 +03:00
Eden Chuang
ef08c8d49b Bug 1714299 - Correct the opaque response judgment for opaque response blocking. r=necko-reviewers,annevk,dragana
An opaque response should be not only cross-origin but also be request with no_cors request mode.

To filter out the request with mode Same_origin, navigate, and cors. This patch reuses the algorithm in InternalRequest/FetchDriver to decide whether a response is an opaque response.

https://searchfox.org/mozilla-central/rev/da5d08750e504f3710f7ea051327d9c311c39902/dom/fetch/InternalRequest.cpp#331
https://searchfox.org/mozilla-central/rev/da5d08750e504f3710f7ea051327d9c311c39902/dom/fetch/FetchDriver.cpp#1153,1157

Differential Revision: https://phabricator.services.mozilla.com/D117086
2021-06-22 13:11:08 +00:00
Kershaw Chang
d8811704f9 Bug 1714506 - Force a transaction to wait for HTTPS RR, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D117234
2021-06-17 14:17:48 +00:00
Valentin Gosu
8e040a6163 Bug 1710045 - Static analysis auto fixes r=necko-reviewers,kershaw
Depends on D114718

Differential Revision: https://phabricator.services.mozilla.com/D115987
2021-06-01 07:24:02 +00:00
Valentin Gosu
3b09f173e0 Bug 1710045 - Use DataMutex in nsHttp::sAtomTable r=necko-reviewers,dragana
- Make nsHttp::ResolveAtom lazily initialize the static atom table if empty
- Use a DataMutex to ensure locked access to the atom table
- Use nsCString in nsHttpAtom so strings can be shared/reference counted
- Add atomic sTableDestroyed so we don't reinit the atom table during shutdown

Depends on D114717

Differential Revision: https://phabricator.services.mozilla.com/D114718
2021-06-01 07:24:02 +00:00
Sebastian Hengst
544a953b13 Backed out 3 changesets (bug 1710045) for failing GTest TestHttpResponseHead.atoms on Windows. CLOSED TREE
Backed out changeset b4f466ca314e (bug 1710045)
Backed out changeset 66364f605471 (bug 1710045)
Backed out changeset 84c30435445b (bug 1710045)
2021-05-27 14:41:22 +02:00
Valentin Gosu
2fdf31f593 Bug 1710045 - Static analysis auto fixes r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D115987
2021-05-27 09:12:36 +00:00
Valentin Gosu
6cdbc0a967 Bug 1710045 - Use DataMutex in nsHttp::sAtomTable r=necko-reviewers,dragana
- Make nsHttp::ResolveAtom lazily initialize the static atom table if empty
- Use a DataMutex to ensure locked access to the atom table
- Use nsCString in nsHttpAtom so strings can be shared/reference counted
- Add atomic sTableDestroyed so we don't reinit the atom table during shutdown

Depends on D114717

Differential Revision: https://phabricator.services.mozilla.com/D114718
2021-05-27 09:12:35 +00:00
Valentin Gosu
89f95f4942 Bug 1694662 - Remove nsICachingChannel.LOAD_CHECK_OFFLINE_CACHE flag r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D106439
2021-04-30 07:20:17 +00:00
Valentin Gosu
87d676a1e4 Bug 1694662 - Remove appcache logic from http channels r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D106430
2021-04-30 07:20:14 +00:00