nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
861976 commits 1 branch 98 tags 6.4 GiB
Commit graph

5886 commits

Author SHA1 Message Date
Pushpanjali
235f25ea9c Bug 1822010 - Convert toolkit/components/url-classifier to ES modules. r=perftest-reviewers,webcompat-reviewers,geckoview-reviewers,devtools-reviewers,twisniewski,valentin,m_kato,anti-tracking-reviewers,timhuang,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D173390
 2023-05-18 12:21:12 +00:00
Abhishek Madan
ba1d4a0dfc Bug 1831363 - Converted SitePermissions.jsm to ES modules and all of its corresponding references. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D177380
 2023-05-17 14:45:26 +00:00
Gijs Kruitbosch
9ecca59317 Bug 1833585 - don't try to search for whitespace-only clipboard contents when middle-clicking new tab, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D178292
 2023-05-17 13:18:36 +00:00
John Schanck
53e2e3ea9b Bug 1831392 - add an excluded WebAuthn credential prompt. r=keeler 
Depends on D177944

Differential Revision: https://phabricator.services.mozilla.com/D178113
 2023-05-15 23:26:24 +00:00
John Schanck
ecfd04a749 Bug 1828206 - clarify WebAuthn user presence prompts. r=keeler 
Differential Revision: https://phabricator.services.mozilla.com/D177944
 2023-05-15 23:26:24 +00:00
Eemeli Aro
feea556fc5 Bug 1832186 - Migrate popup warning strings to Fluent. r=mconley,fluent-reviewers,flod 
The Fluent migration will show a diff for two en-US messages:

- `popup-warning-message` singular variant does not include `{ $popupCount }`, so is more appropriately using `1` rather than `one` as its key.
- `popup-warning-exceeded-message` has only one variant in English, but using the plural selector forces its use for new locales.

Differential Revision: https://phabricator.services.mozilla.com/D177666
 2023-05-15 10:52:25 +00:00
Karandeep
3efcb85a15 Bug 1824609 convert consumers of toolkit/components/thumbnails/ to import ES modules directly. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D177197
 2023-05-10 20:00:58 +00:00
Brice Laurencin
1c8c333cb5 Bug 1418462 - Middleclick on new tab button launch clipboard r=Gijs 
Original code from bruntonross@protonmail.com,
adapted to current Firefox version.

Differential Revision: https://phabricator.services.mozilla.com/D170097
 2023-05-10 10:08:24 +00:00
Stanca Serban
692d727b5e Backed out changeset 50c9a0bea4c6 (bug 1418462) for causing mochitests failures in browser_middleClick.js. CLOSED TREE 2023-05-10 02:50:36 +03:00
John Schanck
8b761c0a6d Bug 1831394 - omit the retries left counter from the invalid PIN prompt when it is large. r=keeler,fluent-reviewers,flod 
The PIN for a user's security key will be temporarily blocked after three
failed PIN entry attempts, but the "retries left" counter in the invalid PIN
prompt is the (typically larger) number of attempts left before the PIN is
permanently blocked. This patch makes it so that the retries left counter is
only shown when it is equal to 1, 2, or 3.

Differential Revision: https://phabricator.services.mozilla.com/D177294
 2023-05-09 21:29:37 +00:00
Jonathan Sudiaman
a911f374bc Bug 1820979 - Remove instant apply bookmarks panels code r=mak 
Remove the `browser.bookmarks.editDialog.delayedApply.enabled` pref, and for all usages in conditional branches, assume that it is `true`. (Since we want to be using delayed apply logic going forward.)

`delayed_apply` spinoffs of tests are removed and merged with their instant apply counterparts. The only test removed without a corresponding spinoff is `browser_editBookmark_tags_liveUpdate.js`. That test is checking whether tags are updated in the edit dialog, if they are updated from a different place. The problem is that we don't really want this behavior anymore. It was previously set to only run with `browser.bookmarks.editDialog.delayedApply.enabled` set to `false`, but now that it's no longer configurable, it made most sense to simply get rid of this test.

https://treeherder.mozilla.org/jobs?revision=c0741eca62212a75a9dd52fc2c5c2b6c34f9f2d7&repo=try

Differential Revision: https://phabricator.services.mozilla.com/D176370
 2023-05-09 21:03:19 +00:00
Brice Laurencin
3bdbccf607 Bug 1418462 - Middleclick on new tab button launch clipboard r=Gijs 
Original code from bruntonross@protonmail.com,
adapted to current Firefox version.

Differential Revision: https://phabricator.services.mozilla.com/D170097
 2023-05-09 20:50:04 +00:00
Katherine Patenio
485f34bf93 Bug 1830421 - convert CustomizableWidgets, CustomizeMode, DragPositionManager and SearchWidgetTracker in browser/components/customizableui to ESMs r=Standard8,ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D176825
 2023-05-03 18:05:26 +00:00
John Schanck
92fb6d7ad4 Bug 1830944 - vendor authenticator-rs v0.4.0-alpha14. r=keeler,supply-chain-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176938
 2023-05-03 16:37:45 +00:00
Alexandre Lissy
2f64b53c68 Bug 1830251 - Remove unused leftover PluginCrashReporter reference r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D175858
 2023-04-27 10:07:59 +00:00
Dão Gottwald
bee9890293 Bug 1828935 - Bump up conformation hint duration to improve a11y. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D175909
 2023-04-20 11:58:39 +00:00
Bilal
5379509f30 Bug 1817002 - ESMified browser/components/pocket/content. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175700
 2023-04-19 19:18:57 +00:00
Abhishek Tiwari
a0830c7eed Bug 1820878 - Convert toolkit/mozapps/downloads to ESmodules . r=Standard8,extension-reviewers,application-update-reviewers,bytesized,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D172245
 2023-04-12 17:32:30 +00:00
Greg Tatum
2d5cb34041 Bug 1826437 - Implement the full page translations panel; r=nordzilla,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D174682
 2023-04-12 16:13:24 +00:00
Ebilite Uchenna
8c931cb313 Bug 1824611 - Convert consumers of toolkit/components/passwordmgr to import ES modules directly. r=Standard8,credential-management-reviewers,settings-reviewers,fxview-reviewers,sclements,sgalich,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D174446
 2023-04-11 19:06:24 +00:00
Ed Lee
583cdaf897 Bug 1826920 - Remove/graduate experimentation capability for about:welcome skipFocus r=pdahiya 
Experimentation confirmed years ago that about:welcome shoudln't be treated as blank for urlbar focus, and no need for additional experimentation. Also fix a bug where about:welcome was treated as a blank/empty page resulting in about:preferences incorrectly replacing it.

Differential Revision: https://phabricator.services.mozilla.com/D174940
 2023-04-07 14:28:09 +00:00
Barret Rennie
a85bf46599 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D172850
 2023-03-30 20:51:58 +00:00
Bilal
3a0a9908fa Bug 1816994 - ESMified UITour JSMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D173571
 2023-03-29 17:32:27 +00:00
Greg Tatum
944d80a008 Bug 1820229 - Stub out a button in the URL bar for translations; r=nordzilla,desktop-theme-reviewers,flod,Itiel 
This code is untested since it's stubbing out functionality, which will
eventually use PageActions to open up a popup. The final code with the
popup will get tested, but for now rely on the existing test behavior,
without asserting new behavior.

Differential Revision: https://phabricator.services.mozilla.com/D173196
 2023-03-24 18:27:30 +00:00
Butkovits Atila
137691f3bf Backed out 12 changesets (bug 1813781, bug 1815343, bug 1820229, bug 1823925, bug 1813779, bug 1823702) for causing failures at browser_full_page.js. CLOSED TREE 
Backed out changeset 841d7b8b856b (bug 1823925)
Backed out changeset a62d77bfac0b (bug 1823925)
Backed out changeset 2590940e3b67 (bug 1815343)
Backed out changeset 807a38bb5ad4 (bug 1813781)
Backed out changeset b1d2cbba17a2 (bug 1813781)
Backed out changeset e83c3f386ef1 (bug 1813781)
Backed out changeset 18cf612336be (bug 1820229)
Backed out changeset d3ae326dcdf7 (bug 1820229)
Backed out changeset 793ba36c54b5 (bug 1813779)
Backed out changeset bbf9177668dc (bug 1823702)
Backed out changeset 1cc80a5cbcdb (bug 1823702)
Backed out changeset 22a87b7171d4 (bug 1823702)
 2023-03-24 06:36:15 +02:00
Greg Tatum
5fbf34f20b Bug 1820229 - Stub out a button in the URL bar for translations; r=nordzilla,desktop-theme-reviewers,flod,Itiel 
This code is untested since it's stubbing out functionality, which will
eventually use PageActions to open up a popup. The final code with the
popup will get tested, but for now rely on the existing test behavior,
without asserting new behavior.

Differential Revision: https://phabricator.services.mozilla.com/D173196
 2023-03-23 22:00:36 +00:00
Mark Banner
4ff8f9cf26 Bug 1823763 - Convert consumers of toolkit/components/reader/ to import ES modules directly. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D173184
 2023-03-23 12:11:44 +00:00
Niklas Baumgardner
39d1882677 Bug 1811318 - Urlbar entry point for PiP. r=cmkm,pip-reviewers,desktop-theme-reviewers,dao,mconley,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D170899
 2023-03-22 19:22:44 +00:00
James Teow
34cbd31c4c Bug 1815971 - Count number of times persisted search is viewed and reverted due to Popups - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D172690
 2023-03-22 13:59:06 +00:00
Csoregi Natalia
07dc85057a Backed out changeset 31492838d6cb (bug 1811318) for failures on browser_urlbar_toggle.js. CLOSED TREE 2023-03-22 12:26:32 +02:00
Niklas Baumgardner
afd2db475b Bug 1811318 - Urlbar entry point for PiP. r=cmkm,pip-reviewers,desktop-theme-reviewers,dao,mconley,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D170899
 2023-03-21 16:26:05 +00:00
Cristina Horotan
dd2fe65d79 Backed out changeset 1eee1fa2d9dd (bug 1811318) for causing bc failures at browser_preferences_usage.js CLOSED TREE 2023-03-21 16:31:56 +02:00
Niklas Baumgardner
d7b26c11fa Bug 1811318 - Urlbar entry point for PiP. r=cmkm,pip-reviewers,desktop-theme-reviewers,dao,mconley,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D170899
 2023-03-21 12:55:18 +00:00
Barret Rennie
f004218156 Bug 1818738 - Make the feature update event API more ergonomic r=aminomancer,settings-reviewers,search-reviewers,Gijs,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D172035
 2023-03-16 22:20:14 +00:00
John Schanck
f40aea4a99 Bug 1813982 - XPCOM interface to authenticator-rs. r=keeler,geckoview-reviewers,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D171269
 2023-03-16 21:42:21 +00:00
William Durand
266814d72f Bug 1821288 - Remove "addon-install-complete" event. r=rpl 
This is not used anymore.

Differential Revision: https://phabricator.services.mozilla.com/D172102
 2023-03-15 17:37:42 +00:00
Francesco Lodolo (:flod)
962126e608 Bug 1822388 - Move brandings.ftl from browser to toolkit, r=eemeli,settings-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sgalich,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D172643
 2023-03-15 17:00:48 +00:00
Mark Banner
4b26aa84d7 Bug 1821898 - Remove RFPHelper definition from the browser window, import where used. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D172374
 2023-03-14 15:45:55 +00:00
James Teow
4feaf446ef Bug 1815769 - Add optional anchor lookup to PopupNotifications - r=Gijs,adw 
Differential Revision: https://phabricator.services.mozilla.com/D169814
 2023-03-14 14:29:58 +00:00
Gijs Kruitbosch
c20f7ae2a1 Bug 1718082 - make updating apptab and usercontext information solely tabbrowser's responsibility, r=mconley 
I'm removing the apptab bits completely in one of the later commits,
but trying to keep this modular so it's easy to figure out regressions,
should there be any.

Differential Revision: https://phabricator.services.mozilla.com/D171411
 2023-03-13 17:32:07 +00:00
Gijs Kruitbosch
65dba4bcc4 Bug 1718082 - move listening to initial paint in a browser content window into the parent process, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D171409
 2023-03-13 17:32:06 +00:00
Emilio Cobos Álvarez
566f0c7a63 Bug 1821657 - Remove BrowserUIUtils.setToolbarButtonHeightProperty and related code. r=Gijs,desktop-theme-reviewers,dao 
I don't see any visible issue on the reload / stop buttons without this.

Differential Revision: https://phabricator.services.mozilla.com/D172238
 2023-03-13 11:56:55 +00:00
DJ
f08805f5f4 Bug 1816980 - remove copy experiment code and implement finalize copy. r=fluent-reviewers,omc-reviewers,flod,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D172158
 2023-03-10 14:24:32 +00:00
Iulian Moraru
983c039377 Backed out changeset eed7574265d1 (bug 1816980) for causing bc failures on browser_sma_enable_cbh.js. CLOSED TREE 2023-03-09 23:18:28 +02:00
DJ
0b9f64694e Bug 1816980 - remove copy experiment code and implement finalize copy. r=fluent-reviewers,omc-reviewers,flod,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D172158
 2023-03-09 18:58:28 +00:00
Mike Conley
a8027d5fb7 Bug 1423125 - Restore previous session if undoCloseTab is called with no more tabs to restore. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D171377
 2023-03-03 14:06:43 +00:00
Gijs Kruitbosch
7d2645b5a6 Bug 1818026 - move gPageStyleMenu to its own file, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D170544
 2023-02-24 21:09:36 +00:00
Cristian Tuns
55c2060892 Backed out 4 changesets (bug 1818026) for causing build bustages on Loader.cpp CLOSED TREE 
Backed out changeset 31e30c051015 (bug 1818026)
Backed out changeset 1fbedd7a8a26 (bug 1818026)
Backed out changeset a5be1aaa8f65 (bug 1818026)
Backed out changeset 1976d91a52b2 (bug 1818026)
 2023-02-24 14:32:44 -05:00
Gijs Kruitbosch
d7287b5cd7 Bug 1818026 - move gPageStyleMenu to its own file, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D170544
 2023-02-24 17:57:04 +00:00
Cosmin Sabou
fd67d5ee44 Backed out 3 changesets (bug 1818026) for causing mochitest plain failures on test_SVGStyleElement.xhtml. 
Backed out changeset 808a73bbb614 (bug 1818026)
Backed out changeset 9b7dbaeb6deb (bug 1818026)
Backed out changeset 62e5f2fd2775 (bug 1818026)
 2023-02-24 16:08:12 +02:00
Gijs Kruitbosch
e36520f140 Bug 1818026 - move gPageStyleMenu to its own file, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D170544
 2023-02-24 09:07:46 +00:00
Gijs Kruitbosch
3e5d710873 Bug 1817443 - move url loading method implementations from utilityOverlay.js into their own helper module, r=mossop 
openLinkIn would really benefit from being split up a bit, and adding more
globals to the browser window is icky. Also, the story for opening new tabs if
you're not inside a window is a nightmare right now. Moving this code
to a module is a first step to making that story nicer.

I kept wrappers for all the functions I'm moving, and added the `window` as the
first argument. In the future we can update these functions to support being
called without a `window` ref. The one exception is getTopWin, where I updated
the callers in this patch.

I had to tweak the parameter detection of the different arguments supported by
openUILinkIn because forwarding calls means arguments.length is always larger
than 3... but then also removed it in the next commit.

Differential Revision: https://phabricator.services.mozilla.com/D170210
 2023-02-23 17:02:43 +00:00
Cristina Horotan
45de4f594f Backed out 5 changesets (bug 1817443) for newtab failure CLOSED TREE 
Backed out changeset ba33c510d008 (bug 1817443)
Backed out changeset 07e3bccaeb6d (bug 1817443)
Backed out changeset 2b39dee42948 (bug 1817443)
Backed out changeset a74a52e93af4 (bug 1817443)
Backed out changeset 827855beb033 (bug 1817443)
 2023-02-23 17:30:23 +02:00
Gijs Kruitbosch
1c327d22dd Bug 1817443 - move url loading method implementations from utilityOverlay.js into their own helper module, r=mossop 
openLinkIn would really benefit from being split up a bit, and adding more
globals to the browser window is icky. Also, the story for opening new tabs if
you're not inside a window is a nightmare right now. Moving this code
to a module is a first step to making that story nicer.

I kept wrappers for all the functions I'm moving, and added the `window` as the
first argument. In the future we can update these functions to support being
called without a `window` ref. The one exception is getTopWin, where I updated
the callers in this patch.

I had to tweak the parameter detection of the different arguments supported by
openUILinkIn because forwarding calls means arguments.length is always larger
than 3... but then also removed it in the next commit.

Differential Revision: https://phabricator.services.mozilla.com/D170210
 2023-02-23 14:49:27 +00:00
John Schanck
b4a997d06e Bug 1817700 - WebAuthn prompt escAction should cancel transaction. r=keeler 
Differential Revision: https://phabricator.services.mozilla.com/D170665
 2023-02-23 05:57:33 +00:00
Mark Hammond
42a8237945 Bug 1359861 - allow reader-mode tabs to be shared. r=Gijs,skhamis 
Differential Revision: https://phabricator.services.mozilla.com/D170186
 2023-02-22 03:58:11 +00:00
Norisz Fay
a7ceb10f1f Backed out changeset d82c03e04249 (bug 1359861) for causing xpcshell failure on test_BrowserUtils.js CLOSED TREE 2023-02-22 00:05:07 +02:00
Mark Hammond
f48ea32bf5 Bug 1359861 - allow reader-mode tabs to be shared. r=Gijs,skhamis 
Differential Revision: https://phabricator.services.mozilla.com/D170186
 2023-02-21 21:04:10 +00:00
DJ
e46a10cfaf Bug 1817941 - fix incorrect service mode setting when enrolling in CBH experiment. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D170490
 2023-02-21 17:19:15 +00:00
Mark Banner
7a655466af Bug 1817183 - Update consumers of services/fxaccounts to import ES modules directly. r=markh,settings-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D170062
 2023-02-17 16:34:43 +00:00
Emilio Cobos Álvarez
e5a2ef9202 Bug 1817381 - Fix MousePosTracker in presence of OS text scale. r=Gijs 
In the past screenX etc didn't return CSS pixels properly, but now they
do and have for a while. Also the full zoom value of browser.xhtml is
always one, so this is only broken if we have OS text scale.

Depends on D170195

Differential Revision: https://phabricator.services.mozilla.com/D170196
 2023-02-17 15:38:54 +00:00
Cristian Tuns
b3bf09cc0d Backed out 6 changesets (bug 1816934, bug 1817182, bug 1817179, bug 1817183) for causing dt failures in browser_jsterm_autocomplete_null.js CLOSED TREE 
Backed out changeset 17d4c013ed92 (bug 1817183)
Backed out changeset cfed8d9c23f3 (bug 1817183)
Backed out changeset 62fe2f589efe (bug 1817182)
Backed out changeset 557bd773fb85 (bug 1817179)
Backed out changeset 7f8a7865868b (bug 1816934)
Backed out changeset d6c1d4c0d2a0 (bug 1816934)
 2023-02-17 10:51:33 -05:00
Emilio Cobos Álvarez
7b8e46d7ec Bug 1817053 - Remove translation-notification.js and co completely. r=mconley,fluent-reviewers,gregtatum,flod 
I double-checked that the extension works with this patch.

Differential Revision: https://phabricator.services.mozilla.com/D169992
 2023-02-17 09:22:47 +00:00
Mark Banner
0ba34b9422 Bug 1817183 - Update consumers of services/fxaccounts to import ES modules directly. r=markh,settings-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D170062
 2023-02-17 09:01:45 +00:00
Jared Hirsch
5f00062eb0 Bug 1816464 - Decouple pref state from Nimbus experiment state for cookie banner handling. r=barret,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D169837
 2023-02-16 19:44:45 +00:00
Gijs Kruitbosch
48f5aa84bb Bug 1810141 - fix tabbrowser.js and browser.js loadURI to match new webnavigation interfaces, r=dao 
This moves the somewhat out-of-place `_loadURI` method and its dependencies
into tabbrowser, and deals with receiving either a string or a URI.

Depends on D168391

Differential Revision: https://phabricator.services.mozilla.com/D168392
 2023-02-13 23:50:39 +00:00
Gijs Kruitbosch
9d7452a247 Bug 1810141 - update consumers of CanonicalBrowsingContext.loadURI to use fixup or pass a URI object if they have it, r=mak,webdriver-reviewers,whimboo 
Depends on D168389

Differential Revision: https://phabricator.services.mozilla.com/D168390
 2023-02-13 23:50:38 +00:00
Cristina Horotan
5f4356e527 Backed out 9 changesets (bug 1810141) for several test failures on a CLOSED TREE 
Backed out changeset 8781a0d1254d (bug 1810141)
Backed out changeset 131037295784 (bug 1810141)
Backed out changeset 3852fbe290f4 (bug 1810141)
Backed out changeset 118f131a524a (bug 1810141)
Backed out changeset ab5d76846e10 (bug 1810141)
Backed out changeset dce3aa683445 (bug 1810141)
Backed out changeset 4dc41d90dbb3 (bug 1810141)
Backed out changeset 50b57ba1a061 (bug 1810141)
Backed out changeset 569de94781e4 (bug 1810141)
 2023-02-13 16:05:30 +02:00
Gijs Kruitbosch
c7c3c6ad29 Bug 1810141 - fix tabbrowser.js and browser.js loadURI to match new webnavigation interfaces, r=dao 
This moves the somewhat out-of-place `_loadURI` method and its dependencies
into tabbrowser, and deals with receiving either a string or a URI.

Depends on D168391

Differential Revision: https://phabricator.services.mozilla.com/D168392
 2023-02-13 12:55:23 +00:00
Gijs Kruitbosch
e460aa10f3 Bug 1810141 - update consumers of CanonicalBrowsingContext.loadURI to use fixup or pass a URI object if they have it, r=mak,webdriver-reviewers,whimboo 
Depends on D168389

Differential Revision: https://phabricator.services.mozilla.com/D168390
 2023-02-13 12:55:22 +00:00
Mark Banner
cdf8548a04 Bug 1814931 - Convert services/sync imports to direct ES imports. r=markh,settings-reviewers,credential-management-reviewers,mconley,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D168837
 2023-02-13 11:44:29 +00:00
Gijs Kruitbosch
8a1165469e Bug 1815439 - remove superfluous extra global loadURI method from browser.js, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D168398
 2023-02-07 14:22:02 +00:00
Gregory Pappas
b4f9754abc Bug 1804357 - Implement browser.search.query r=robwu,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D164700
 2023-02-02 21:47:27 +00:00
Neil Deakin
9c2e7458ba Bug 1776879, replace text/unicode for clipboard and drag and drop and use text/plain directly, r=edgar,mak,stransky,geckoview-reviewers,extension-reviewers,zombie,m_kato 
Most usage is a straight replacement but gtk needs extra changes as it transfers plain text in UTF8 natively and needs to be converted into UTF16, and Windows uses single-byte characters for RTF and CF_HTML formats so we preserve this.

Differential Revision: https://phabricator.services.mozilla.com/D158587
 2023-02-01 23:30:55 +00:00
Hannah Peuckmann
cb19af7145 Bug 791594 - Gray out content behind cross origin auth requests. r=pbz,Gijs,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D164440
 2023-01-31 18:16:53 +00:00
Olivier Tilloy
6b81196ea8 Bug 1792816 - Always update the search engine placeholder name. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D165795
 2023-01-24 22:51:21 +00:00
William Durand
a1f393ad66 Bug 1799009 - Remove gUnifiedExtensions.isEnabled. r=rpl,mconley 
Depends on D166923

Differential Revision: https://phabricator.services.mozilla.com/D166934
 2023-01-23 10:39:29 +00:00
Edgar Chen
e5fe0a40c0 Bug 1796548 - Introduce a generic method to check clipboard capabilities in nsIClipboard; r=geckoview-reviewers,nika,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D166475
 2023-01-16 19:50:17 +00:00
Mark Banner
d691c51a0d Bug 1808173 - Convert prompts imports to direct ES imports. r=Gijs,webdriver-reviewers,necko-reviewers,application-update-reviewers,credential-management-reviewers,valentin,whimboo,dimi,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D165794
 2023-01-16 13:32:20 +00:00
Mark Banner
f35ab1379d Bug 1808173 - Convert SharedPromptUtils.jsm to an ES module and rename it PromptUtils.sys.mjs. r=Gijs,credential-management-reviewers,dimi 
Using shared no longer makes sense, as the non-shared parts in Prompter have been renamed as 'Utils'.

Differential Revision: https://phabricator.services.mozilla.com/D165792
 2023-01-16 13:32:19 +00:00
Gijs Kruitbosch
73a24ef2a3 Bug 1781160 - fix container context menu appearing twice as a context menu, r=sdk 
Differential Revision: https://phabricator.services.mozilla.com/D153365
 2023-01-06 17:16:47 +00:00
Jonathan Sudiaman
853cd3535f Bug 1801869 - Update Bookmarks Library panel to use editBookmark.js r=mak 
Ensure that we can safely load `editBookmark.js` as the `gEditItemOverlay` instance without breaking the library panel. As the library does not currently support OK/Cancel operation, this does not perform any "delayed apply" logic, we simply save on blur as usual.

The tricky part was getting bulk tagging to work. With the current design of the `BookmarkState` class, it only supports modifying a **single** bookmark, and it will break when trying to add a tag to multiple bookmarks at once. This is where we left off with the previous revision... I believe in this case, it makes sense to simply revert back to the logic we had in `instantEditBookmark.js` to perform the bulk tag operation.

https://treeherder.mozilla.org/jobs?repo=try&revision=a1f58a770b16edd519da6e0d55e2f3c529d8f8de

Differential Revision: https://phabricator.services.mozilla.com/D164250
 2023-01-05 18:20:13 +00:00
Gijs Kruitbosch
3762db01b9 Bug 1475606 - remove loadOneTab and switch its callers over, r=dao,perftest-reviewers,sparky 
Depends on D165774

Differential Revision: https://phabricator.services.mozilla.com/D165775
 2023-01-03 22:24:44 +00:00
Mark Banner
3a07fcf436 Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D165068
 2022-12-27 10:08:58 +00:00
Gijs Kruitbosch
c453d031f5 Bug 1738190 - allow opening inline SVG background images in a new tab, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D165454
 2022-12-23 17:23:44 +00:00
Mark Banner
8730eec697 Bug 1806359 - Convert telemetry imports to direct ES imports. r=necko-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,janerik,mconley,sgalich,bytesized,kershaw 
Differential Revision: https://phabricator.services.mozilla.com/D165002
 2022-12-23 12:37:07 +00:00
Valentin Gosu
df13492ee4 Bug 1596845 - Make DNSServices available as Services.dns r=necko-reviewers,webdriver-reviewers,kershaw 
Depends on D164347

Differential Revision: https://phabricator.services.mozilla.com/D164856
 2022-12-23 09:26:17 +00:00
Marian-Vasile Laza
56b22ee0ba Backed out 9 changesets (bug 1596845) for causing xpcshell failures on test_trr_enterprise_policy.js. CLOSED TREE 
Backed out changeset 231acfc052bb (bug 1596845)
Backed out changeset 7d02dad4d720 (bug 1596845)
Backed out changeset b0449eec2671 (bug 1596845)
Backed out changeset 5cd033c9ef7c (bug 1596845)
Backed out changeset 98d583f1d19e (bug 1596845)
Backed out changeset b78bc0049605 (bug 1596845)
Backed out changeset 88919aaff89b (bug 1596845)
Backed out changeset f4adb3e7b8e1 (bug 1596845)
Backed out changeset b171f7ac0b40 (bug 1596845)
 2022-12-23 09:21:39 +02:00
Valentin Gosu
6ca2987fe1 Bug 1596845 - Make DNSServices available as Services.dns r=necko-reviewers,webdriver-reviewers,kershaw 
Depends on D164347

Differential Revision: https://phabricator.services.mozilla.com/D164856
 2022-12-23 01:20:03 +00:00
Sandor Molnar
56d5efdcae Backed out 9 changesets (bug 1596845) for causing mochitest failures in browser/base/content/test/about/browser_aboutCertError_telemetry.js 
Backed out changeset eb1e34c3041f (bug 1596845)
Backed out changeset af6d41439c60 (bug 1596845)
Backed out changeset f1447dd8df04 (bug 1596845)
Backed out changeset a383f2bbcaae (bug 1596845)
Backed out changeset 950c66dd6133 (bug 1596845)
Backed out changeset ab300239fd69 (bug 1596845)
Backed out changeset 8e1fe024b680 (bug 1596845)
Backed out changeset 80e5048d1f35 (bug 1596845)
Backed out changeset b14a4910d73b (bug 1596845)
 2022-12-23 00:56:35 +02:00
Valentin Gosu
ff04cde9bd Bug 1596845 - Make DNSServices available as Services.dns r=necko-reviewers,webdriver-reviewers,kershaw 
Depends on D164347

Differential Revision: https://phabricator.services.mozilla.com/D164856
 2022-12-22 21:16:07 +00:00
Danny Colin
980244d030 Bug 1796797 - Convert toolkit/components/contextualidentity JSM modules to ESMs r=baku,webdriver-reviewers,extension-reviewers,settings-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D159945
 2022-12-21 08:14:05 +00:00
James Teow
bc71e1a00e Bug 1803056 - Prevent search tips from appearing when a new request is initiated - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D164459
 2022-12-20 13:37:06 +00:00
Sergey Galich
76c03dc337 Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida 
Differential Revision: https://phabricator.services.mozilla.com/D158155
 2022-12-16 18:41:58 +00:00
M. Sirringhaus
b83d2bb5c7 Bug 1804434 - Split register/sign dialog into pre- and post token selection dialog. r=jschanck,flod 
Differential Revision: https://phabricator.services.mozilla.com/D164071
 2022-12-13 20:28:59 +00:00
Stanca Serban
73745e9411 Backed out changeset ad94b64c18cb (bug 1751763) for causing mochitests failures on browser_startup_images.js. CLOSED TREE 2022-12-13 10:29:08 +02:00
Sergey Galich
d6a7a0446a Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida 
Differential Revision: https://phabricator.services.mozilla.com/D158155
 2022-12-13 03:09:18 +00:00
Mark Banner
53ce0faad1 Bug 1804661 - Convert browser/components/BrowserGlue.jsm to an ES module. r=Gijs,settings-reviewers,perftest-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D164204
 2022-12-12 14:59:18 +00:00
Iulian Moraru
ab4c6b8fed Backed out changeset 2522b2da871e (bug 1751763) as per sgalich's request. CLOSED TREE 2022-12-09 22:35:41 +02:00
Sergey Galich
e7c0cc0b8d Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida 
Differential Revision: https://phabricator.services.mozilla.com/D158155
 2022-12-09 17:41:16 +00:00
Cosmin Sabou
13d44c8586 Backed out changeset 9723d831f285 (bug 1751763) for causing geckoview failures on loginSelectAccept. 2022-12-08 01:59:56 +02:00
Sergey Galich
07a318558d Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158155
 2022-12-07 22:59:32 +00:00
M. Sirringhaus
a9c8742d84 Bug 1530373 - Support CTAP2 via USB HID r=supply-chain-reviewers,fluent-reviewers,flod,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D129814
 2022-12-06 18:09:54 +00:00
Gijs Kruitbosch
38d4b2f917 Bug 1803158 - convert session restore consumers to reference the sys.mjs files instead, r=webdriver-reviewers,perftest-reviewers,extension-reviewers,credential-management-reviewers,Standard8,sgalich,whimboo,sparky,willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D163350
 2022-12-06 16:02:03 +00:00
Cristian Tuns
885e76c15e Backed out changeset 06c98719ac0a (bug 1530373) for causing build bustages on cbindgen-metadata.json.stub CLOSED TREE 2022-12-01 17:38:12 -05:00
M. Sirringhaus
10b6997d5d Bug 1530373 - Support CTAP2 via USB HID r=supply-chain-reviewers,fluent-reviewers,flod,jschanck 
Differential Revision: https://phabricator.services.mozilla.com/D129814
 2022-12-01 21:39:52 +00:00
Nika Layzell
39cfe43333 Bug 1538028 - Part 4: Pass TriggeringRemoteType through the frontend, r=Gijs,emilio 
Propagate the ability to pass triggeringRemoteType through the desktop frontend
in various places, such that it is set when using the context menu or content
click handler.

Differential Revision: https://phabricator.services.mozilla.com/D161834
 2022-11-29 20:41:46 +00:00
Meg Viar
587bf18b52 Bug 1793453 - Prevent automatic suppression of popups on 'blank' pages when URL bar is focused r=dao,adw 
Differential Revision: https://phabricator.services.mozilla.com/D158850
 2022-11-29 01:13:08 +00:00
Niklas Baumgardner
d377cc7b85 Bug 1801360 - Use selectedBrowser URI for gScreenshots. r=cmkm 
Differential Revision: https://phabricator.services.mozilla.com/D162747
 2022-11-25 15:08:32 +00:00
Emilio Cobos Álvarez
a78ecb23eb Bug 1801840 - Go back to using .browserStack rather than .browserContainer for tab dialog box. r=Gijs,nchevobbe 
This makes alert take the same area as the status panel, partially
backing out the regressing bug.

.browserStack is also relatively-positioned, so this works too. I think
I didn't realize this while writing bug 1791972 because the rule was in
a UA sheet (all <stack>s are relatively positioned, apparently).

This restores the behavior when devtools is toggled vertically. On
responsive mode this still covers the top toolbar, but that was the
pre-existing behavior. Could be fixed in a follow-up with some z-index
tweaking...

Differential Revision: https://phabricator.services.mozilla.com/D162739
 2022-11-24 16:42:52 +00:00
Francesco Lodolo (:flod)
dd34dc2343 Bug 1801915 - Migrate confirmation hints to Fluent, r=eemeli,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D162746
 2022-11-22 20:12:55 +00:00
Eemeli Aro
c3f9c6d123 Bug 1760029 - Remove tabbrowser.properties as empty. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D159021
 2022-11-22 17:12:23 +00:00
Kagami Sascha Rosylight
f24fdbc09c Bug 1801346 - Esmify browser/modules/Sanitizer.jsm r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D162425
 2022-11-19 01:45:42 +00:00
Itiel
e547078885 Bug 1796940 - Unify bookmark-related popups r=emilio,mak,mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D158460
 2022-11-17 22:58:04 +00:00
Cosmin Sabou
b1b874a9e4 Backed out changeset 99db9921183c (bug 1796940) for bc failures on browser_parsable_css.js. CLOSED TREE 2022-11-18 00:08:28 +02:00
Itiel
7969caa64a Bug 1796940 - Unify bookmark-related popups r=emilio,mak,mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D158460
 2022-11-17 20:34:58 +00:00
Mike Conley
1f6c401024 Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D161200
 2022-11-15 16:37:23 +00:00
Stanca Serban
d7d2cc6477 Backed out 3 changesets (bug 1782203) for causing lint failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE 
Backed out changeset 50e57afebed3 (bug 1782203)
Backed out changeset d17ea376ed45 (bug 1782203)
Backed out changeset e91d51f1ce90 (bug 1782203)
 2022-11-15 17:42:22 +02:00
Mike Conley
eee9638cbe Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D161200
 2022-11-15 15:02:08 +00:00
Csoregi Natalia
f4019206c2 Backed out 4 changesets (bug 1782203, bug 1777484) for failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE 
Backed out changeset ae47d92443a7 (bug 1782203)
Backed out changeset 0c90b1d40e9f (bug 1782203)
Backed out changeset 4b4cae098ea0 (bug 1782203)
Backed out changeset 75eba3b7a626 (bug 1777484)
 2022-11-15 03:06:21 +02:00
Mike Conley
f12b95a7e7 Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D161200
 2022-11-14 22:41:09 +00:00
Iulian Moraru
b058a433c2 Backed out changeset 392451891968 (bug 1793453) for causing bc failures on browser_permissions_dismiss.js. CLOSED TREE 2022-11-10 01:57:57 +02:00
Meg Viar
8940eb0670 Bug 1793453 - Prevent automatic suppression of popups on 'blank' pages when URL bar is focused r=dao,adw 
Differential Revision: https://phabricator.services.mozilla.com/D158850
 2022-11-09 18:55:11 +00:00
James Teow
9ae4091c21 Bug 1798793 - Add search tip message for showSearchTerms feature - r=adw,fluent-reviewers,flod 
The showSearchTerms feature has a search tip that should appear
on the users default search engine results page.

The design and copy for the feature are in this Figma file:
https://www.figma.com/file/Ock0cYjzi7I1GmcctqOr9K/Search-settings-updates?node-id=352%3A9183

Differential Revision: https://phabricator.services.mozilla.com/D161186
 2022-11-09 18:36:08 +00:00
Mike Conley
42a671591b Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements 
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
 2022-11-08 14:51:40 +00:00
Mike Conley
25518bf24b Bug 1797836 - Part 1: browser.js should only call registerToolbarNode on CUI areas of TYPE_TOOLBAR. r=cmkm 
It looks like we had some kind of hard-coded assumption here that every area
in CustomizableUI was of TYPE_TOOLBAR except for AREA_FIXED_OVERFLOW_PANEL, which
was manually spliced out of the area array when initting the toolbars after
DOMContentLoaded.

A later patch in this series is adding a new area of TYPE_MENU_PANEL, and
instead of also splicing that out of the area array in DOMContentLoaded,
we now make sure to only call registerToolbarNode on areas that are
actually toolbars.

Differential Revision: https://phabricator.services.mozilla.com/D161077
 2022-11-08 14:51:39 +00:00
Mark Banner
18753bfe42 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D161013
 2022-11-07 17:56:10 +00:00
Bernard Igiri
0213ab535b Bug 1785272 - Fix Fx View Button VO Announcement r=Gijs 
Changed the aria role from tab to button to fix the VO announcement so that it correctly reports when the Fx View tab is actually selected.

Differential Revision: https://phabricator.services.mozilla.com/D159887
 2022-11-07 07:07:20 +00:00
Neil Deakin
7997a24179 Bug 1676492, show the bookmarks toolbar when a new window is opened when the preference is set to show a blank page, r=Mardak,settings-reviewers 
w

Differential Revision: https://phabricator.services.mozilla.com/D155003
 2022-11-01 20:43:02 +00:00
Neil Deakin
e96d17d38c Bug 1676492, create a special blank tab page that will show the bookmarks toolbar when 'Only Show on New Tab' is used' even when the new tab page is disabled, r=Gijs,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D154319
 2022-11-01 20:43:01 +00:00
Kelly Cochrane
5a82125b6c Bug 1793088 - Make first available tab focusable when Fx View is open r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D159766
 2022-11-01 15:45:45 +00:00
steven100695
a3f2b1c51f Bug 1788919 - Convert browser/components/migration JSM modules to ESMs. r=mconley,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D158655
 2022-10-27 23:52:49 +00:00
Noemi Erli
01a2d27871 Backed out 2 changesets (bug 1788919) for causing failures in browser_noLoginsView.js CLOSED TREE 
Backed out changeset 2f03490ec72e (bug 1788919)
Backed out changeset 449aea6fc974 (bug 1788919)
 2022-10-27 23:45:56 +03:00
steven100695
14e60b6839 Bug 1788919 - Convert browser/components/migration JSM modules to ESMs. r=mconley,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D158655
 2022-10-27 18:15:55 +00:00
Emilio Cobos Álvarez
b4e1c48671 Bug 1796972 - Fix popup container for webextension popups. r=Gijs 
Depends on D160224

Differential Revision: https://phabricator.services.mozilla.com/D160225
 2022-10-25 22:28:44 +00:00
Simon Friedberger
3c5991df13 Bug 1549057 - Rename (Gg)etCSP to (Gg)etCsp - r=freddyb 
Differential Revision: https://phabricator.services.mozilla.com/D159268
 2022-10-24 20:38:11 +00:00
Marian-Vasile Laza
51c683be62 Backed out changeset caddc49839d3 (bug 1793088) for causing bc failures on browser_firefoxview_tab.js. CLOSED TREE 2022-10-24 17:49:47 +03:00
Kelly Cochrane
22fba29900 Bug 1793088 - Make first available tab focusable when Fx View is open r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D159766
 2022-10-24 12:32:44 +00:00
Henrik Skupin
1c61d460dc Bug 1533058 - [browser] Extend BrowserOpenTab to open a custom URL. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D159424
 2022-10-24 07:46:15 +00:00
Tomislav Jovanovic
e82afd3462 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D158938
 2022-10-22 17:21:58 +00:00
Noemi Erli
9c4f5fd7bc Backed out changeset 0a1431ca8979 (bug 1793088) for causing failures browser_firefoxview_tab.js CLOSED TREE 2022-10-20 18:53:41 +03:00
Kelly Cochrane
80e600b519 Bug 1793088 - Make first available tab focusable when Fx View is open r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D159766
 2022-10-20 14:43:31 +00:00
Cosmin Sabou
acc26cd06f Backed out changeset 27a859f55fdd (bug 1793629) for causing bc failures on browser_preferences_usage.js. 2022-10-19 02:34:23 +03:00
Tomislav Jovanovic
0975a1bceb Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D158938
 2022-10-18 21:44:48 +00:00
Dana Keeler
04b2180978 Bug 1793841 - don't serialize securityInfo in browser_aboutCertError_exception.js r=pbz 
This test only needs the bytes of the server certificate, not the entire
nsITransportSecurityInfo of the connection.

Differential Revision: https://phabricator.services.mozilla.com/D157994
 2022-10-18 21:25:03 +00:00
Bernard Igiri
07dc284c09 Bug 1710092 - Back out workaround from bug 1708809 r=mconley 
Backed out workaround from bug 1708809.

Differential Revision: https://phabricator.services.mozilla.com/D159331
 2022-10-18 18:39:32 +00:00
Mark Banner
1b63e93005 Bug 1795370 - Add nsICrashReporter as an interface on nsAppRunner. r=gsvelto 
This fixes ESLint issues raised by mozilla/valid-services-properties.
This also changes follow-on issues to use Services.appinfo rather than getService.

Differential Revision: https://phabricator.services.mozilla.com/D159461
 2022-10-18 18:22:24 +00:00
James Teow
3c03da845b Bug 1788953 - Part 2: Use cached originalURI in setURI - r=adw 
Depends on D157485

Differential Revision: https://phabricator.services.mozilla.com/D157486
 2022-10-18 13:38:49 +00:00
Mark Banner
2ffde1e92f Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Noemi Erli
5a21645f73 Backed out 2 changesets (bug 1793841) for causing Gtest failures CLOSED TREE 
Backed out changeset 4d39c423b92e (bug 1793841)
Backed out changeset 5cfb5f595add (bug 1793841)
 2022-10-18 04:29:44 +03:00
Dana Keeler
f37644a281 Bug 1793841 - don't serialize securityInfo in browser_aboutCertError_exception.js r=pbz 
This test only needs the bytes of the server certificate, not the entire
nsITransportSecurityInfo of the connection.

Differential Revision: https://phabricator.services.mozilla.com/D157994
 2022-10-18 00:18:08 +00:00
Cristian Tuns
b4150d1c6f Backed out changeset f8554e4080f2 (bug 1793629) for causing mochitest failures on browser_preferences_usage.js CLOSED TREE 2022-10-15 16:14:29 -04:00
Tomislav Jovanovic
670a479833 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D158938
 2022-10-15 19:05:26 +00:00
Norisz Fay
dd7b52f2f0 Backed out changeset c5a9bca461ce (bug 1793629) for causing multiple mochitest failures CLOSED TREE 2022-10-15 01:56:26 +03:00
Tomislav Jovanovic
f136f0b270 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D158938
 2022-10-14 21:03:23 +00:00
Narcis Beleuzu
d0f14ae8ef Backed out changeset 8140f297aa36 (bug 1710092) as req by Bernard. CLOSED TREE 2022-10-14 17:45:53 +03:00
Bernard Igiri
531fd9fb0c Bug 1710092 - Back out workaround from bug 1708809 r=mconley 
Backed out workaround from bug 1708809.

Differential Revision: https://phabricator.services.mozilla.com/D159331
 2022-10-14 14:13:47 +00:00
Bernard Igiri
8e4a1cef71 Bug 1784323 - Prevent hidden Firefox View tab from triggering the closing multiple tabs warning r=dao,Gijs 
Updated the tab closing prompt logic to use the number of visible tabs open to determine if the prompt should show.

Differential Revision: https://phabricator.services.mozilla.com/D157965
 2022-10-13 16:39:41 +00:00
Emilio Cobos Álvarez
e641646909 Bug 1794630 - Use resize*=sibling for searchbar container. r=dao 
This simplifies the widget tracker code to avoid having to remove random
width attributes in all children.

Resize only the searchbar, since that's the only thing that's
effectively restored already on nightly.

Differential Revision: https://phabricator.services.mozilla.com/D159071
 2022-10-13 15:01:20 +00:00
Sarah Clements
2b04f2ef7c Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster 
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
 2022-10-12 16:39:39 +00:00
Norisz Fay
6e29272e17 Backed out changeset 9b1e2e6ceb70 (bug 1785853) for causing mochitest failures on browser_setup_state.js CLOSED TREE 2022-10-12 17:50:02 +03:00
Sarah Clements
ca8d94bc2d Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster 
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
 2022-10-12 13:26:41 +00:00
Daisuke Akatsuka
1ae5e445bd Bug 1792971: Suppress popup notification while async tab switching. r=adw,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D158480
 2022-10-11 00:10:26 +00:00
Masayuki Nakano
4ba9b4dd1c Bug 1792759 - part 1: Add nsIEditor.clearUndoRedo() to get rid of nsIEditor.transactionManager r=m_kato,NeilDeakin,Standard8 
`nsIEditor.transactionManager` is used only for some simple purposes, however,
`nsIEditor` exposes the rich API.  That makes it harder to maintain internal
code around transactions.  Instead, `nsIEditor` exposes only simple and
necessary APIs.

This patch creates a new API to clear undo/redo history and make the users in
mozilla-central use it instead of using `nsITransactionManager.clear()`.

Differential Revision: https://phabricator.services.mozilla.com/D158336
 2022-10-09 01:13:49 +00:00
Mark Banner
bbee5e7f3a Bug 1793414 - Move paste and search handling for the search bar into the search bar code itself. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D158499
 2022-10-07 07:12:18 +00:00
Sandor Molnar
d416a7b827 Backed out 2 changesets (bug 1793414) for causing browser-chrome failures in browser/components/search/test/browser/browser_searchbar_context.js CLOSED TREE 
Backed out changeset f27b2a93224e (bug 1793414)
Backed out changeset 1f011637d116 (bug 1793414)
 2022-10-06 12:03:15 +03:00
Mark Banner
496c1718fa Bug 1793414 - Move paste and search handling for the search bar into the search bar code itself. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D158499
 2022-10-06 07:44:51 +00:00
Alexandre Poirot
99b6c8357e Bug 1793573 - [devtools] Convert DevToolsSocketStatus.jsm to DevToolsSocketStatus.sys.mjs. r=Honza 
Differential Revision: https://phabricator.services.mozilla.com/D158572
 2022-10-05 16:07:25 +00:00
Angel_V129
c74a074e42 Bug 1788756 - [Themes] Convert browser/theme JSM modules to ESMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D157037
 2022-10-04 19:02:24 +00:00
Niklas Baumgardner
14b904f207 Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157355
 2022-10-04 13:23:19 +00:00
William Durand
7d12af981e Bug 1788994 - Fix test cases when the unifiedExtensions pref is enabled by default. r=rpl,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157185
 2022-10-04 08:45:57 +00:00
Sandor Molnar
fcb74829f6 Backed out changeset 45ea391514c0 (bug 1790855) for causing bc failures in browser_contextmenu CLOSED TREE 2022-10-04 06:41:48 +03:00
Niklas Baumgardner
ffa2f8034a Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157355
 2022-10-04 02:09:08 +00:00
Sandor Molnar
6d6d17465d Backed out changeset d8835c4ab04f (bug 1790855) for causing bc failures in browser/components/screenshots/tests/browser/browser_screenshots_test_toggle_pref.js CLOSED TREE 2022-10-04 04:12:42 +03:00
Niklas Baumgardner
5ffcda4977 Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157355
 2022-10-04 00:03:56 +00:00
Csoregi Natalia
13179f500d Backed out changeset d91a621a39be (bug 1785853) for multiple failures e.g.browser_setup_state.js CLOSED TREE 2022-10-03 19:48:44 +03:00
Sarah Clements
2fad8f1409 Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster 
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
 2022-10-03 16:07:54 +00:00
Dão Gottwald
68b7f1fcb0 Bug 1792814 - Don't load the home page in hidden tabs such as Firefox View. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158396
 2022-09-30 20:04:37 +00:00
Mark Banner
8d1ebcb9d6 Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Emilio Cobos Álvarez
4e978b56b5 Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin 
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.

As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).

For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.

For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.

Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.

Differential Revision: https://phabricator.services.mozilla.com/D157875
 2022-09-27 04:18:16 +00:00
Marian-Vasile Laza
f54a464c90 Backed out changeset 2f74f8f2ed19 (bug 1689816) for causing reftest failures on skip-ink-multiline-position.html. 2022-09-26 23:24:03 +03:00
Emilio Cobos Álvarez
f875681246 Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin 
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.

As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).

For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.

For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.

Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.

Differential Revision: https://phabricator.services.mozilla.com/D157875
 2022-09-26 17:40:30 +00:00
Emilio Cobos Álvarez
cb0b3ab372 Bug 1791972 - Simplify dialog stack and rdm styles. r=Gijs,devtools-reviewers,jdescottes 
.browserContainer is relatively positioned, so we can position the
tab-modal dialogs absolutely inside it instead of making them part of
the browser stack.

While at it, make the rdm toolbar part of the regular browserContainer,
just like the regular devtools toolbox is. That way there's no need to
do ResizeObserver shenanigans to be able to let it grow. Keep it also
absolutely positioned tho, because we need to overlay the whole
container when the device modal is opened. That's somewhat gross.

This should in general be simpler to understand than the current set-up,
and more performant to since it avoids the dialog stack from forming
part of the browser element's flow.

Differential Revision: https://phabricator.services.mozilla.com/D157912
 2022-09-23 22:23:37 +00:00
Brian
34064a8838 Bug 1788925 - Convert AboutReader from JSM to ESM. r=Gijs. 
Differential Revision: https://phabricator.services.mozilla.com/D157034
 2022-09-23 21:19:12 +00:00
Evan
f71e1c1af2 Bug 1788783 -Converted Picture in Picture JSM modules to ESMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D157039
 2022-09-23 18:11:48 +00:00
Daisuke Akatsuka
042de19c2e Bug 1790814: Depends on existing tabs to change the tab to open about:addons page. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D157400
 2022-09-21 22:58:47 +00:00
Ryan VanderMeulen
0109742091 Bug 1784692 - Revert focus behavior for new windows introduced by bug 1770818. a=backout 2022-09-21 14:08:31 -04:00
Niklas Baumgardner
33d42fbb13 Bug 1790823 - Firefox View button should not be open when added to toolbar. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D157662
 2022-09-19 21:54:45 +00:00
Julian Descottes
87ef6aa2ff Bug 1790753 - [devtools] Track all devtools sockets in DevToolsSocketStatus r=ochameau,Gijs 
The DevToolsSocketStatus could be misleading for any usage other than the current one from browser.js since it misses browser toolbox sockets

This patch allows the singleton to track all sockets but changes the API to allow consumers to exclude browser toolbox sockets.

Differential Revision: https://phabricator.services.mozilla.com/D157300
 2022-09-14 19:11:22 +00:00
Sarah Clements
204e4fc381 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 15:20:01 +00:00
Marian-Vasile Laza
02b993c483 Backed out changeset 9bf0a16672ec (bug 1787979) for causing bc failures on browser_sma_click_element.js. CLOSED TREE 2022-09-14 16:45:04 +03:00
Sarah Clements
20971e4d83 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 11:24:58 +00:00
Brian
b34f9afb6d Bug 1788776 - Convert screenshots component from JSM to ESM. r=niklas. 
Differential Revision: https://phabricator.services.mozilla.com/D157038
 2022-09-11 19:08:38 +00:00
Bernard Igiri
ae6f7157e4 Bug 1784054 - Enable full height scrolling in Colorway Closet modal in small windows r=dao 
Updated SubDialog.jsm's sizeTo=available to have better support for responsive layouts with the ability to specify max height and widths on the dialog.

Differential Revision: https://phabricator.services.mozilla.com/D155014
 2022-09-08 17:43:58 +00:00
Mark Banner
c9b0aa74c1 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 14:40:07 +00:00
Norisz Fay
1bb0960ae2 Backed out 3 changesets (bug 1789254) for causing bc failures on browser_xpcom_graph_wait.js CLOSED TREE 
Backed out changeset bea1e1ba4a14 (bug 1789254)
Backed out changeset 4086aaa5f3d0 (bug 1789254)
Backed out changeset 131cac1d1146 (bug 1789254)
 2022-09-08 17:14:00 +03:00
Mark Banner
5dca28c108 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 12:43:32 +00:00
Dão Gottwald
684a24a549 Bug 1787797 - Let the Firefox View menu item re-add the button to the tabs toolbar if it got previously removed. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156412
 2022-09-07 12:21:25 +00:00
Katherine Patenio
b1e0f5998c Bug 1767827: Use Nimbus feature (with pref fallback) as the condition for enabling Firefox View r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D156004
 2022-09-02 15:45:21 +00:00
Gijs Kruitbosch
ba0b238fde Bug 1787437 - close the Firefox View tab when removing the FxView toolbar item completely, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D155921
 2022-09-02 12:49:54 +00:00