Commit graph

53 commits

Author SHA1 Message Date
Dan Banner
42c8241ce0 Bug 1386684 - Enable ESLint for toolkit/components/url-classifier (manual fixes). r=hchang
MozReview-Commit-ID: JH1XDFMVd43

--HG--
extra : rebase_source : 41c83027c09e3071d3ddb929a01b5dd689109115
2017-08-02 20:09:14 +01:00
Dan Banner
436f06fda4 Bug 1386684 - Enable ESLint for toolkit/components/url-classifier (automatic fixes). r=hchang
MozReview-Commit-ID: F0Z8dRaYOku

--HG--
extra : rebase_source : 3ebc9ab6ea9f1741d8a986c9217575644411e2a1
2017-08-02 16:12:07 +01:00
Francois Marier
2286e70d51 Bug 1386013 - Log an error when Safe Browsing times out. r=hchang
MozReview-Commit-ID: A99ov9T7rtm

--HG--
extra : rebase_source : d7fd2e8a1ebdc3f9b1c9d1ecd7bec33c6deb27d3
2017-07-31 20:29:25 -07:00
Thomas Nguyen
0ed363ec89 Bug 1381718 : Dump request when receiving 400 error r=hchang
MozReview-Commit-ID: 1ZFOIRTryiV

--HG--
extra : rebase_source : b0377d006b1b190c4a77ca4b26ce9d12efc0c464
2017-07-25 14:43:11 +08:00
Thomas Nguyen
32b3145839 Bug 1377559 - Should store value of preference browser.safebrowsing.debug to reuse r=francois
MozReview-Commit-ID: 1yWe7wB0ARl

--HG--
extra : rebase_source : eed70f5a7c1ad38e8ec24a86c8f606d9a5ba3e2a
2017-07-04 16:36:31 +08:00
DimiL
9814af0253 Bug 1335943 - Use the right origin attribute in Safe Browsing completions. r=francois
MozReview-Commit-ID: 8HQHzuwE5Cf

--HG--
extra : rebase_source : d6c57eb6b4d16898ca0f067052d8e9064c24c3a5
2017-06-21 17:27:22 +08:00
Thomas Nguyen
c8d511e264 Bug 1363879 - Sort gethash prefixes to hide noise entries r=francois
In V2 we shuffled the hash entries before sending the request to obscure the real
entry from noises. We should also hide the real entry in V4. Using sort() is
enough for both V2 and V4 because the array contains exactly 5 entries in almost
all cases.

MozReview-Commit-ID: 4uOXIF83KQL

--HG--
extra : rebase_source : 97c6439965e864863dc99f194356eb1efb0235df
2017-05-17 16:11:36 +08:00
Florian Queze
4c6a68d1c9 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
37f2343b9a Bug 1356569 - Remove appendElement's last parameter when it is false, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
159215e6f4 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
9e0ecf32c5 Backed out changeset e1f191aad863 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
93a734a3ce Bug 1356569 - Remove appendElement's last parameter when it is false, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
a363fb8c8b Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
dimi
127351f6ef Bug 1311935 - P2. Process fullHashes.find response. r=francois
This patch includes following changes:

1. nsUrlClassifierHashCompleter.js
   nsUrlClassifierHashCompleter.idl
   - Add completionV4 interface for hashCompleter to pass response data to
     DB service.
   - Process response data includes negative cache duration, matched full
     hashes and cache duration for each match. Full matches are passed through
     nsIFullHashMatch interface.
   - Change _requests.responses from array contains matched fullhashes to
     dictionary so that it can store additional information likes negative cache
     duration.
2. nsUrlClassifierDBService.cpp
   - Implement CompletionV4 interface, store response data to CacheResultV4
     object. Expired duration to expired time is handled here.
   - Add CacheResultToTableUpdate function to convert V2 & V4 cache result
     to TableUpdate object.
3. LookupCache.h
   - Extend CacheResult to CacheResultV2 and CacheResultV4 so we can store
     response data in CompletionV2 and CompletionV4.
4. HashStore.h
   - Add API and member variable in TableUpdateV4 to store response data.
     TableUpdate object is used by DB service to pass update data or gethash
     response to Classifier, so we need to extend TableUpdateV4 to be able
     to store fullHashes.find response.
6. Entry.h
   - Define the structure about how we cache fullHashes.find response.

MozReview-Commit-ID: FV4yAl2SAc6

--HG--
extra : rebase_source : 02676ded9bc0580c24b4c906199a4abaf004e296
2017-04-11 11:50:48 +08:00
Iris Hsiao
3d85c0330d Backed out 4 changesets (bug 1311935) for causing assertion crash by developer's request
Backed out changeset 27e624cd9479 (bug 1311935)
Backed out changeset 4c0381ab0990 (bug 1311935)
Backed out changeset 73587838ef16 (bug 1311935)
Backed out changeset a5a6c0f79733 (bug 1311935)
2017-04-11 11:04:54 +08:00
dimi
5112db082c Bug 1311935 - P2. Process fullHashes.find response. r=francois
This patch includes following changes:

1. nsUrlClassifierHashCompleter.js
   nsUrlClassifierHashCompleter.idl
   - Add completionV4 interface for hashCompleter to pass response data to
     DB service.
   - Process response data includes negative cache duration, matched full
     hashes and cache duration for each match. Full matches are passed through
     nsIFullHashMatch interface.
   - Change _requests.responses from array contains matched fullhashes to
     dictionary so that it can store additional information likes negative cache
     duration.
2. nsUrlClassifierDBService.cpp
   - Implement CompletionV4 interface, store response data to CacheResultV4
     object. Expired duration to expired time is handled here.
   - Add CacheResultToTableUpdate function to convert V2 & V4 cache result
     to TableUpdate object.
3. LookupCache.h
   - Extend CacheResult to CacheResultV2 and CacheResultV4 so we can store
     response data in CompletionV2 and CompletionV4.
4. HashStore.h
   - Add API and member variable in TableUpdateV4 to store response data.
     TableUpdate object is used by DB service to pass update data or gethash
     response to Classifier, so we need to extend TableUpdateV4 to be able
     to store fullHashes.find response.
6. Entry.h
   - Define the structure about how we cache fullHashes.find response.

MozReview-Commit-ID: KgR1NASl7GC

--HG--
extra : rebase_source : 424db14e4af2ffd691c384414d50f64083d5d20b
2017-04-10 16:20:09 +08:00
Thomas Nguyen
f0a98a30fa Bug 1336903 - Add telemetry probes to track Safe Browsing server response time r=francois
The probes keep track of V2 and V4 server response to update and getHash
request. The probes are keyed by provider

MozReview-Commit-ID: 3Uxjm6H77lE

--HG--
extra : rebase_source : 647523a24bad8334dbb34758954a5f5db0e9b96c
2017-03-24 15:41:23 +08:00
Florian Quèze
7f1b926f29 Bug 1344711 - hand cleanup of cases that were ignored by the script to remove try blocks around get*Pref calls, r=jaws.
--HG--
extra : rebase_source : 4da1e10b87ac37de19e0ca6f79996e8a12492db9
2017-03-07 15:29:48 +01:00
Thomas Nguyen
fdfc58a406 Bug 1329558 - Implement Minimum wait duration for V4 gethash r=francois
MozReview-Commit-ID: 7i9Wz7pq0yJ

--HG--
extra : rebase_source : a02c2e3cbd5f535192f5dbaadabce16abd6bb35f
2017-02-09 16:56:44 +08:00
DimiL
46e51631a9 Bug 1331881 - Minimum wait duration and negative cache duration should be passed even if there is no match. r=francois,henry
MozReview-Commit-ID: K5RcpmiXFYR

--HG--
extra : rebase_source : 7d9c48c658fc04b0430965e93476063d3cff4a7f
2017-01-18 17:34:03 +08:00
Thomas Nguyen
2e4a2a1c26 Bug 1311926 - Add telemetry to measure gethash error and gethash timeout rate for V2 and V4. r=francois
MozReview-Commit-ID: 5mfO5zJMFyW

--HG--
extra : rebase_source : 3d1b178d42e1e084b0fa522ed90a44affe70bb8d
2017-01-16 11:22:45 +08:00
Henry Chang
758d80f10b Bug 1276826 - Part 2. Send gethash request and handle gethash response for v4. r=francois
MozReview-Commit-ID: 6fIbN6a6gHI

--HG--
extra : rebase_source : d64a2b4f85b24aac0a847a46748b3b3fdf0db749
extra : intermediate-source : c486204319c1afc158b871bad7edd2f7a565022a
extra : source : adf76dccec9d51df0d3a659ffa3dd201d8115bc4
2016-11-28 14:55:36 +08:00
Francois Marier
15e7ab840a Bug 1315387 - Cancel hash completer timeout timer when requests complete. r=gcp
MozReview-Commit-ID: 8cFc7YrxOoC

--HG--
extra : rebase_source : b7061e503cad9077a09fd65bfb20b9a5cc212471
2016-11-24 16:39:36 +13:00
Thomas Nguyen
493ff90f5c Bug 1315386 - Make Safe Browsing code more shutdown-aware. r=francois,gcp.
MozReview-Commit-ID: ATCVfh5YLZl

--HG--
extra : rebase_source : d87cfae3838f1a26dc67d2546264e47768011a63
2016-11-25 16:02:37 +08:00
Henry Chang
67a1e7c43b Bug 1273398 - Part 3: Modify "hash completer" to use RequestBackoffV4. r=francois. 2016-06-06 20:17:00 +02:00
Henry Chang
33e58f1836 Bug 1264517 - Replace sensitive info from debugging message. r=gcp. 2016-04-29 13:53:31 +08:00
Dimi Lee
9c4398499b Bug 1172688 - Add telemetry for when gethash calls timeout. r=francois, r=bsmedberg
MozReview-Commit-ID: 8GZmlhgWhmy

--HG--
extra : transplant_source : %F6%D2%9F%7B%A0%0D%F0%B8%8C%89%90%D1X%1E%AD%C5%D7%0B%07%7F
2016-04-06 11:35:26 +08:00
Francois Marier
5306fd5619 Bug 1164518 - Better logging of completions. r=gcp
MozReview-Commit-ID: JqhDC9GzB8l

--HG--
extra : rebase_source : c174046a80d128053adbcc9ca498a14c1f381ca0
2016-03-02 14:54:59 -08:00
Gian-Carlo Pascutto
effecd5ec1 Bug 1150921 - Add telemetry for response codes to SafeBrowsing requests. r=francois f=bsmedberg 2016-02-10 17:59:40 +01:00
Christoph Kerschbaumer
eb33d87f83 Bug 1239913 - Convert toolkit/ to use asyncOpen2 where loadingPrincipal is SystemPrincipal (r=sicking) 2016-01-20 12:42:09 -08:00
Nigel Babu
be124f0c87 Backed out changeset 740b66ce102b (bug 1239913) for mochitest bustage
--HG--
extra : commitid : BtrgWwDqBJe
2016-01-15 13:31:40 +05:30
Christoph Kerschbaumer
324bf331cc Bug 1239913 - Convert toolkit/ to use asyncOpen2 where loadingPrincipal is SystemPrincipal (r=sicking) 2016-01-14 21:01:56 -08:00
Francois Marier
a897a6152a Bug 1203347 - Increase Safe Browsing debug logging around gethash (JS). r=gcp 2015-09-14 18:04:02 -07:00
Christoph Kerschbaumer
fe39ce0539 Bug 1087744: Make JS callers of ios.newChannel call ios.newChannel2 in toolkit/ (r=gijs) 2014-10-24 15:25:34 -07:00
Gian-Carlo Pascutto
c1111db74b Bug 1031160 - Disable HTTP Keepalive for SafeBrowsing. r=rnewman 2014-11-14 12:55:35 -08:00
Monica Chew
d9133ed513 Bug 1024555: Cancel gethash requests after 5 seconds if they are still pending 2014-09-08 16:44:08 -07:00
Phil Ringnalda
2c98827aa5 Back out 34a02ee9896c (bug 1024555) for xpcshell bustage
CLOSED TREE
2014-09-11 21:50:39 -07:00
Monica Chew
4e94ee034f Bug 1024555: Cancel gethash requests after 5 seconds if they are still pending 2014-09-08 16:44:08 -07:00
Monica Chew
386ebd5ee3 Bug 1021419: Implement per-table update and gethash requests 2014-06-12 10:24:03 -07:00
Pin Zhang
9d3971b7fc Bug 1023767 - Fix bug: HashCompleterRequest.notifyFailure doesn't work. r=mmc 2014-06-11 02:04:00 +02:00
Gian-Carlo Pascutto
2f0246c854 Bug 783047 - Remove MAC support from SafeBrowsing code. r=mmc,dcamp 2014-01-16 09:27:58 +01:00
Gian-Carlo Pascutto
9ce11ea689 Bug 807852 - Position of real request is predictable in Completion requests. r=dcamp 2012-11-03 01:53:11 +01:00
Kyle Huey
0469a02b25 Bug 798491: Add an option to stick all chrome JSMs/JS components in the same compartment. r=mrbkap,philikon
--HG--
extra : rebase_source : 98337b6a8c07d05e8c961a452dd05a7d75c3c60b
2012-10-31 09:13:28 -07:00
Vicamo Yang
a78b5b38c7 Backout 67cb43bb8865: Breaks B2G Marionette 2012-10-31 16:35:11 +08:00
Kyle Huey
9a3674d80a Bug 798491: Add an option to stick all chrome JSMs/JS components in the same compartment. r=mrbkap,philikon 2012-10-30 12:28:11 -07:00
Ed Morley
4144129728 Backout a145ded68994, e0cf397089ec & 1545e91c658e (bug 798491) for bustage on a CLOSED TREE 2012-10-30 17:02:31 +00:00
Kyle Huey
50b5d3f681 Bug 798491: Add an option to stick all chrome JSMs/JS components in the same compartment. r=mrbkap,philikon 2012-10-30 08:26:12 -07:00