Commit graph

75 commits

Author SHA1 Message Date
Brian Grinstead
abf1620630 Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw

--HG--
extra : rebase_source : 186d805f7a2a56694dda9032aceac2dfe5424753
2018-08-08 15:22:53 -07:00
Dave Townsend
389a969138 Bug 1479050: Migrate a number of call-sites to use document.createXULElement. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D2489

--HG--
extra : moz-landing-system : lando
2018-07-31 19:13:38 +00:00
Boris Zbarsky
270fa12c79 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Dale Harvey
dc2a4a2d84 Bug 1471877 - Add link to share menu to configuration. r=Gijs,mstange
MozReview-Commit-ID: CCTO9SJJMY6

--HG--
extra : rebase_source : 23daee7ff3550b7613c03f817c2db87aecaf7ec5
2018-06-30 18:35:46 +01:00
Noemi Erli
7c4c1c603f Backed out changeset 68859b04588d (bug 1471877) for failures in browser/content/browser-pageActions.js on a CLOSED TREE 2018-07-18 13:32:50 +03:00
Dale Harvey
dbcfb245b1 Bug 1471877 - Add link to share menu to configuration. r=Gijs,mstange
MozReview-Commit-ID: CCTO9SJJMY6

--HG--
extra : rebase_source : c9ae961b87a5b40a501f72501738f70c129f6d8b
2018-06-30 18:35:46 +01:00
Dão Gottwald
cd159c76f7 Bug 1459907 - Implement new bookmark confirmation. r=mak
MozReview-Commit-ID: DsTXTKgX72y

--HG--
extra : rebase_source : 836ba1340189d22e4ee9f0fdb1c4ff339fbd266f
2018-06-23 15:28:47 +02:00
Dale Harvey
2beab3540e Bug 1455310 - Add title data and activity to sharing. r=mstange
MozReview-Commit-ID: IL4sqvRwSwu

--HG--
extra : rebase_source : ff973f92552931c725a81c177c02fcbd5c6aab63
2018-04-25 08:23:32 +01:00
Cosmin Sabou
2474ce8cde Backed out changeset 48b66743b97b (bug 1455310) for xpcshell failures on widget/tests/unit/test_macsharingservice.js. CLOSED TREE 2018-04-27 19:12:07 +03:00
Dale Harvey
b4ccd4de21 Bug 1455310 - Add title data and activity to sharing. r=mstange
MozReview-Commit-ID: IL4sqvRwSwu

--HG--
extra : rebase_source : 7179fc3e2ef112574b02b03a56f150d0e3617d4e
2018-04-25 08:23:32 +01:00
Dale Harvey
a8eb5ba151 Bug 1454705 - Fix display of share panel in Address bar. r=Gijs
MozReview-Commit-ID: 9lxU0plGqYa

--HG--
extra : rebase_source : 49e521087a4673ea87f64ec5a7be30eac3750393
2018-04-18 15:48:31 +01:00
Dale Harvey
5aeada7d94 Bug 1363168 - Add support for OSX Share feature. r=Gijs,mstange
MozReview-Commit-ID: sJXl2If9Ou

--HG--
extra : rebase_source : b88ff89e1d28bab28c3575c2f7f30c91bd584aea
2018-03-12 09:16:51 +00:00
Drew Willcoxon
03bd244a63 Bug 1450294 - Change the title of the add-search-engine page action. r=Gijs
MozReview-Commit-ID: GHDXbmkSXfM

--HG--
extra : rebase_source : e04fcca6673a94f6ede6bf6ede20136196cea725
2018-04-11 10:06:01 -07:00
Drew Willcoxon
2ee5fb33af Bug 1449947 - The "Add Search Engine" page action button doesn't respond to clicks when it's in the urlbar. r=Gijs
MozReview-Commit-ID: 5H9XfRXq8eO

--HG--
extra : rebase_source : 8d89c4605161792330e0b50d8dabe5378506a427
2018-03-30 09:34:47 -07:00
Drew Willcoxon
e5e43736bc Bug 1221539 - Add search engine discovery to the page action menu. Part 2: Add the new action. r=Gijs
MozReview-Commit-ID: DEEZBwmV0JD

--HG--
extra : rebase_source : 71b68621198d72c069f505d922e92ed357eefe8b
2018-03-28 11:28:20 -07:00
Drew Willcoxon
36b7f691ee Bug 1221539 - Add search engine discovery to the page action menu. Part 1: Page action changes. r=Gijs
MozReview-Commit-ID: DGy3sBibpRW

--HG--
extra : rebase_source : b2c60c94707a0fd950c01fc7c5976888f4481c8a
2018-03-28 11:28:13 -07:00
Kris Maglione
eb1a0bb258 Bug 1446250: Part 1 - Optimize Photon PageAction update performance. r=Gijs
The amount of computational complexity and garbage array/string/object
generation for each update to a pageAction property went up astronomically
with the migration of WebExtension page actions to the Photon API. This
resulted in non-trivial talos regression when Screenshots attempted to switch
back to the built-in pageAction API.

These changes fix most of the garbage generation, and reduce a lot of the
duplicated work for each update.

MozReview-Commit-ID: 4uPLnAesdU2

--HG--
extra : rebase_source : 3f723f3f35abf032cf12e02ce38552e21ea4827f
2018-03-15 21:34:01 -07:00
Paolo Amadini
c7bdffd735 Bug 1437512 - Part 2 - Remove the "panelmultiview" binding. r=Gijs
MozReview-Commit-ID: H9R7ahkCr2U

--HG--
extra : rebase_source : d6403d026b4539acc71325c600ee9ff3be667591
2018-02-25 18:43:55 +00:00
Paolo Amadini
d59df3cdd5 Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs
MozReview-Commit-ID: 3VzoxJ3Ociy

--HG--
extra : source : 22c83b1d417d7c7bd21a71109f4800f5d37bbb77
extra : intermediate-source : 6de7133c267288a468804f67f91df68b10b9793e
2018-02-06 09:02:27 +00:00
Cosmin Sabou
793dad7903 Backed out 3 changesets (bug 1434883) for frequent leaks in AbstractThread, AnimationTimeline, Annotators, Array, AsyncFreeSnowWhite, ... on a CLOSED TREE
Backed out changeset c8115e90ffa8 (bug 1434883)
Backed out changeset 22c83b1d417d (bug 1434883)
Backed out changeset 085796417462 (bug 1434883)
2018-02-06 16:30:56 +02:00
Paolo Amadini
5ac445ad8f Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs
MozReview-Commit-ID: 3VzoxJ3Ociy

--HG--
extra : rebase_source : 7302ce6eed5364c80b7dfe9409e5c9d28e030e38
2018-02-06 09:02:27 +00:00
Paolo Amadini
26c7b11e09 Bug 1432015 - Part 3 - Ensure that views passed to showSubView are added to the list of known views without having to reset the internal _panelViews variable. r=Gijs
MozReview-Commit-ID: Hld45ghdduv

--HG--
extra : rebase_source : e01d8facd56a4be21818879b21de75802d723db3
2018-01-17 15:04:18 +00:00
Paolo Amadini
11d708f26b Bug 1432015 - Part 2 - Remove the setMainView methods. r=Gijs
The setMainView method of PanelMultiView controls the "mainview" attribute, which is already set or removed later in the showSubView method. When called at construction time, it changes the mainViewId if there is at least one child in the "panelmultiview" element and the original mainViewId does not already reference the first child. This would be incorrect, but in practice it never happens for either ephemeral or static panels, and can be avoided for the throw-away activated page action panel.

The setMainView method of PanelUI is never called, and this makes the corresponding PanelMultiView method removable.

MozReview-Commit-ID: 5bNidHfKFTA

--HG--
extra : rebase_source : b527827d30d682d183981347c2caf3a8a5d81355
2018-01-21 15:59:41 +00:00
Paolo Amadini
1aee9c11f9 Bug 1432015 - Part 1 - Fix anchor handling for the action feedback panel. r=Gijs
Commands started from an activated action panel should not be anchored to the main button, and regression tests should simulate the case where both the main action panel and the individual action button are visible and the action is invoked from the main action panel.

MozReview-Commit-ID: Eg1wP2rRe2d

--HG--
extra : rebase_source : 6caac7368c85195c91066c6a61d3043a9fbc770f
2018-01-21 17:01:59 +00:00
Paolo Amadini
b12ae1861e Bug 1417042 - Remove the "panelview" binding. r=Gijs
MozReview-Commit-ID: 26uQb3pteQd

--HG--
extra : rebase_source : 93263ff4f1e0d38292dbfef3f7385ddd881b25ef
extra : source : bce38a7817ee39ccd38f57f73f5acf81a41e1f69
2017-12-06 10:37:25 +00:00
Edouard Oger
80589e1731 Bug 1417597 - Show a different feedback message in send tab when we're offline. r=jaws
MozReview-Commit-ID: Emsx0LwFAE1

--HG--
extra : rebase_source : a10a5795f0c4c140a5d9eea5c72821be4931bd9b
2017-11-16 16:11:46 -05:00
Paolo Amadini
fc23659e93 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs
MozReview-Commit-ID: IjvSZZUHUMt

--HG--
extra : rebase_source : a94e212e8af35b77806d1d62e020a511ab62e224
2017-11-21 14:21:32 +00:00
Drew Willcoxon
5f90902bda Bug 1417272 - The "Send Tab to Device" page action can be disabled in the page action menu but enabled in the urlbar. r=Gijs
MozReview-Commit-ID: BZ4CAqG0kkH

--HG--
extra : rebase_source : 3aaa7601b9f3f11e84d65788378c0fdb1dac9292
2017-11-15 11:25:45 -08:00
Drew Willcoxon
65176851c3 Bug 1417036 - "Save to Pocket" drop down menu glitches. r=Gijs
MozReview-Commit-ID: 1JPOmQNLn26

--HG--
extra : rebase_source : ec596c222caa916b02897cbbd36f4a9ae614e518
2017-11-15 10:44:47 -08:00
Edouard Oger
0648f86b7f Bug 1304898 - Include why in sync ping. r=tcsc
MozReview-Commit-ID: G9WnHhuWD7Z

--HG--
extra : rebase_source : 27cb3c2bdf7432e0db1e6a8431d348be50c2afd8
2017-11-15 17:10:45 -05:00
Drew Willcoxon
46c5139ac2 Bug 1413574 - Hide disabled page actions and offer a "Manage Extension" command for actions in extensions. r=Gijs
MozReview-Commit-ID: HJpu9Jfi2bB

--HG--
extra : rebase_source : ee219138b8df1744c223d81281d9525c3d7b7227
2017-11-10 11:06:02 -05:00
Drew Willcoxon
13280ee095 Bug 1412170 - Integrate WebExtension page action context menus with the Photon page action context menu: Photon page action changes. r=jaws
MozReview-Commit-ID: BOEhQEJbUNO

--HG--
extra : rebase_source : ff88d19669530269486d3441fe9cbebe6c73090b
2017-10-30 17:47:54 -04:00
Phil Ringnalda
c21a471320 Backed out 2 changesets (bug 1412170) for eslint bustage
Backed out changeset a9a646fe54ec (bug 1412170)
Backed out changeset 8b46ed411edf (bug 1412170)

MozReview-Commit-ID: Et3MnX3ieBe
2017-10-30 14:21:45 -07:00
Drew Willcoxon
cdfcd527d8 Bug 1412170 - Integrate WebExtension page action context menus with the Photon page action context menu: Photon page action changes. r=jaws
MozReview-Commit-ID: BOEhQEJbUNO

--HG--
extra : rebase_source : 4cfa98799c5b1a673efe52c37e595c88cbd71902
2017-10-30 16:53:21 -04:00
Drew Willcoxon
6d7492ef9b Bug 1395387 - Reconcile WebExtension page actions and Photon page actions: Photon page actions changes. r=Gijs
MozReview-Commit-ID: 5NOc9N2idRE

--HG--
extra : rebase_source : 17e91f9b85bfb49d6fdf29c25bfba7a7c4f86452
2017-10-27 17:39:38 -04:00
Mark Banner
4de6bf22b1 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop
MozReview-Commit-ID: H5YVp3rnzGo

--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
2017-10-26 11:47:01 +01:00
Jared Wein
2ad00e3d21 Bug 1408135 - Copy URL confirmation message should appear where user selects it. r=mikedeboer
MozReview-Commit-ID: 99hEGe7Dtgf

--HG--
extra : rebase_source : c84918920ca2791940d4daeec12cf86c2c04c1c2
2017-10-19 11:58:53 -04:00
Henrik Adolfsson
9fec5a40e2 Bug 1392536 - Add last sync date as tooltip to send to device tab
MozReview-Commit-ID: BsCoBJXm10B
2017-10-10 13:50:28 -04:00
Drew Willcoxon
9100f68edc Bug 1387141 - Pocket button does not stay red after URL pocketed and animation has finished. r=Gijs
MozReview-Commit-ID: KQVOUJUOfrx

--HG--
extra : rebase_source : 07e77c7835286c78789fc6c6ff553ae475f26e5e
2017-10-05 13:03:44 -07:00
Drew Willcoxon
91dcf7e9cf Bug 1385882 - Intermittent browser/base/content/test/urlbar/browser_page_action_menu.js | Test timed out. r=Gijs
MozReview-Commit-ID: H6BtvGNtMmQ

--HG--
extra : rebase_source : ac0bc23ebe47d9b5669036a56e0b6e39e7994ff7
2017-10-05 12:45:15 -07:00
Gijs Kruitbosch
8dea08a240 Bug 1389721 - fix page action menu to deal with not being passed an event, so the 'save link to pocket' context menu works, r=jaws
This also removes the now-obsolete onBeforeCommand method from the pocket code.

MozReview-Commit-ID: EjrMoAIv3xw

--HG--
extra : rebase_source : 0921854ff6d1110a35bb225d946cea3caa2ae3c1
2017-10-02 20:34:01 +01:00
Gijs Kruitbosch
c6ffe22372 Bug 1393843 - add telemetry for page action items and the context menu that enables/disables them, data-review=rweiss, r=adw,rweiss+418169
MozReview-Commit-ID: E52TGDLgjCC

--HG--
extra : rebase_source : 9a370490ec927bde37468295c1fb4415aa6e0212
2017-09-20 17:32:11 +01:00
Drew Willcoxon
2fa9f06a0b Bug 1402721 - Add/edit bookmark panel should open anchored on the page action (ellipsis) button instead of on the identity block (left side of the address bar) when the bookmarks star action is not pinned/visible. r=Gijs
MozReview-Commit-ID: JMviXx5ov7F

--HG--
extra : rebase_source : b205b0ae9d0e4eb7ed34b912f62e28fb2e2f9467
2017-09-25 13:30:08 -07:00
Gijs Kruitbosch
49a325326c Bug 1397790 - add 'open' active state to urlbar buttons, use a more distinct background colour for it, r=abenson+572682,adw
MozReview-Commit-ID: 7QrhAB79yNw

--HG--
extra : rebase_source : 90c3715259271bf9cb34b635ca8348acd020c51c
2017-09-19 15:13:25 +01:00
Zibi Braniecki
70e0d2b8e8 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 5e58c418f91a1802328c4128dffd2c1ab9aa067f
2017-09-09 22:17:19 -07:00
Sebastian Hengst
a4b102b6d9 Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
923420c64a Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 9aeed150b6106210bbe06e8a98ae602e5471851b
2017-09-09 22:17:19 -07:00
Drew Willcoxon
67fd8c9838 Bug 1397501 - Page actions added to the urlbar should always come before the bookmark star. r=Gijs
MozReview-Commit-ID: 6pVlr9d0crn

--HG--
extra : rebase_source : 0f83a8ea8ada71bc6ce88859d09fc93460abafa3
2017-09-07 16:44:34 -07:00
Drew Willcoxon
7fb6175d88 Bug 1396053 - Page action urlbar button ordering can get messed up for new windows. r=Gijs
MozReview-Commit-ID: 1KwrS6tsnhO

--HG--
extra : rebase_source : 05f4a7e485757ca72fb56a1116e271ad3d6241bf
2017-09-04 23:58:27 -07:00
Drew Willcoxon
e8a1dadbb5 Bug 1395410 - Page action notifications should be anchored on relevant urlbar button, not main button, if present. r=jaws
MozReview-Commit-ID: iFM0cR7zFi

--HG--
extra : rebase_source : b8d30a126227a190723ff77021ae8eea3c2c22e3
2017-08-31 15:48:19 -07:00