Commit graph

80 commits

Author SHA1 Message Date
Tooru Fujisawa
f3a8c52c53 Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Alexandre Poirot
730bff2728 Bug 1774937 - Show the debug slow script button if DevTools are opened on all releases. r=jdescottes,dthayer
Differential Revision: https://phabricator.services.mozilla.com/D150153
2022-06-30 17:18:54 +00:00
Neil Deakin
a62618baa7 Bug 1690390, change appendNotification to take a smaller number of arguments: the string type value, a dictionary containing the notification details, and the button list, r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D107755
2021-09-17 09:04:59 +00:00
Narcis Beleuzu
72152613c6 Backed out 3 changesets (bug 1690390) for mochitest failures on test_notificationbox.xhtml . CLOSED TREE
Backed out changeset e6404b7424cd (bug 1690390)
Backed out changeset a161177099af (bug 1690390)
Backed out changeset cc7e02d3d418 (bug 1690390)
2021-09-16 23:41:21 +03:00
Neil Deakin
82501df9f7 Bug 1690390, change appendNotification to take a smaller number of arguments: the string type value, a dictionary containing the notification details, and the button list, r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D107755
2021-09-16 19:11:17 +00:00
Neil Deakin
b143d2943a Bug 1714337, remove separate high and non-high notification box references, r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D121083
2021-07-28 18:24:42 +00:00
David Parks
e37ad4b27a Bug 1698959: Remove HangData union and SLOW_SCRIPT enum value r=dthayer,geckoview-reviewers,agi
HangData is the only member left in the union and SLOW_SCRIPT is the only member left in the enum.
This patch also migrates the one remaining (invalid) use of PLUGIN_HANG in testing to work as a SLOW_SCRIPT instead.

Differential Revision: https://phabricator.services.mozilla.com/D113885
2021-05-01 01:12:46 +00:00
David Parks
27e7bb9383 Bug 1698959: Clean up dead terminatePlugin references r=dthayer
PLUGIN_HANG events are no longer sent so terminatePlugin is unused.

Differential Revision: https://phabricator.services.mozilla.com/D113884
2021-05-01 01:12:45 +00:00
David Parks
2284427083 Bug 1698959: Remove NPAPI plugin telemetry references r=dthayer
PLUGIN_HANG events are no longer possible so all of these markers are already inactive.

Differential Revision: https://phabricator.services.mozilla.com/D113882
2021-05-01 01:12:45 +00:00
Francesco Lodolo (:flod)
f39ec97e9f Bug 1704315 - Change l10n IDs for "Stop" button in process hang infobar, r=florian
Only the label was changed in bug 1694229, causing issues with the existing access key (still used in <89 for "Stop it").
Changing both IDs to force retranslation.

Differential Revision: https://phabricator.services.mozilla.com/D111576
2021-04-12 13:51:01 +00:00
Doug Thayer
f75d49d54f Bug 1702516 - Remove all terminateGlobal uses r=kmag
This never actually worked, because nothing ever listened to the notification
sent in XPCJSContext (kill-content-script-sandbox). We're also removing the
"Temporarily disable extension" button in the slow addon notification, which
was the primary caller of this - however, that's in a separate patch.

Differential Revision: https://phabricator.services.mozilla.com/D110583
2021-04-05 16:00:09 +00:00
Doug Thayer
d5a34a1fb7 Bug 1702516 - Remove Temporarily disable extension button r=florian
Fairly straightforward - this removes the button from the slow add-on script
notification, as well as the functions that only it utilizes.

Differential Revision: https://phabricator.services.mozilla.com/D110582
2021-04-05 16:00:08 +00:00
Doug Thayer
14caf9713d Bug 1678411 - Ensure we show slow script notification for fission iframes r=smaug
See bug for more details, but effectively the decision is to show the same
notification which we would normally show for hung pages if an iframe hangs,
but only do so if the user is trying to interact with content hung by that
iframe. This should accomplish that.

Differential Revision: https://phabricator.services.mozilla.com/D107933
2021-03-11 17:41:19 +00:00
Doug Thayer
e39cd6c743 Bug 1696482 - Update extension-specific slow script notification text r=florian
Differential Revision: https://phabricator.services.mozilla.com/D107243
2021-03-08 16:57:27 +00:00
Doug Thayer
cd5708a26d Bug 1695734 - Remove Learn More link from content script hang infobars r=NeilDeakin
Depends on D106816

Differential Revision: https://phabricator.services.mozilla.com/D106821
2021-03-01 21:18:03 +00:00
Doug Thayer
6eb50a8a4f Bug 1695726 - Change the slow script notification priority to info r=florian
Differential Revision: https://phabricator.services.mozilla.com/D106816
2021-03-01 19:27:01 +00:00
Doug Thayer
755daa2725 Bug 1694229 - Show a different notification is selected tab is hanging r=florian
As part of this, we need to detect that the currently showing notification does
not match the one what we want to display. This also fixes the case where we
show a notification for tab A, then switch to tab B which is also hanging, and
end up listing the title for tab A as hanging in the notification.

Differential Revision: https://phabricator.services.mozilla.com/D106305
2021-02-27 18:22:33 +00:00
Doug Thayer
db50f52ea7 Bug 1694229 - Update slow script warning visuals r=florian
This patch removes the wait button on the slow script warning, on the suspicion
that it is confusing to the user since it's redundant with the close button. It
also changes the text of the notification to blame the hanging tab.

Differential Revision: https://phabricator.services.mozilla.com/D106015
2021-02-27 18:22:32 +00:00
Neil Deakin
f66ba76299 Bug 1691499, add a link field to notification bar buttons to use a link instead, convert learn more buttons in notification bars to links, r=mstriemer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D105750
2021-02-26 13:43:10 +00:00
Bogdan Tara
d53cfe7369 Backed out 5 changesets (bug 1694229) by flod's request, lint failures CLOSED TREE
Backed out changeset cb3d9e8d32e6 (bug 1694229)
Backed out changeset 877471a44509 (bug 1694229)
Backed out changeset 286b311d32b2 (bug 1694229)
Backed out changeset 42cb688eae03 (bug 1694229)
Backed out changeset d082f53d882e (bug 1694229)
2021-02-25 22:43:33 +02:00
Doug Thayer
9bcea72137 Bug 1694229 - Show a different notification if selected tab is hanging r=florian
As part of this, we need to detect that the currently showing notification does
not match the one what we want to display. This also fixes the case where we
show a notification for tab A, then switch to tab B which is also hanging, and
end up listing the title for tab A as hanging in the notification.

Differential Revision: https://phabricator.services.mozilla.com/D106305
2021-02-25 19:59:16 +00:00
Doug Thayer
05360b505e Bug 1694229 - Update slow script warning visuals r=florian
This patch removes the wait button on the slow script warning, on the suspicion
that it is confusing to the user since it's redundant with the close button. It
also changes the text of the notification to blame the hanging tab.

Differential Revision: https://phabricator.services.mozilla.com/D106015
2021-02-25 19:59:14 +00:00
Cosmin Sabou
253c39a17a Backed out changeset 36b76c196497 (bug 1691499) for bc failures on browser_decoderDoctor.js. CLOSED TREE 2021-02-25 21:47:25 +02:00
Neil Deakin
86db2fec08 Bug 1691499, add a link field to notification bar buttons to use a link instead, convert learn more buttons in notification bars to links, r=mstriemer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D105750
2021-02-25 12:00:39 +00:00
Brindusan Cristian
6f8f3d0e90 Backed out 5 changesets (bug 1694229) for geckoview failures. CLOSED TREE
Backed out changeset 5ce24c91b0c1 (bug 1694229)
Backed out changeset 7fef19f47442 (bug 1694229)
Backed out changeset a70e27ec7747 (bug 1694229)
Backed out changeset 6a5d472e1b05 (bug 1694229)
Backed out changeset d32085239f92 (bug 1694229)
2021-02-25 09:27:50 +02:00
Doug Thayer
ebf4df3b69 Bug 1694229 - Show a different notification is selected tab is hanging r=florian
As part of this, we need to detect that the currently showing notification does
not match the one what we want to display. This also fixes the case where we
show a notification for tab A, then switch to tab B which is also hanging, and
end up listing the title for tab A as hanging in the notification.

Differential Revision: https://phabricator.services.mozilla.com/D106305
2021-02-25 04:14:14 +00:00
Doug Thayer
a9fbe5527c Bug 1694229 - Update slow script warning visuals r=florian
This patch removes the wait button on the slow script warning, on the suspicion
that it is confusing to the user since it's redundant with the close button. It
also changes the text of the notification to blame the hanging tab.

Differential Revision: https://phabricator.services.mozilla.com/D106015
2021-02-25 04:14:12 +00:00
Gijs Kruitbosch
2a63dc9514 Bug 1686816 - ensure we have useful values for waitCount and deselectCount to avoid 'undefined' showing up in telemetry, r=jaws
Unfortunately a meaningful automated test here is difficult because we're dealing with shutdown.

Differential Revision: https://phabricator.services.mozilla.com/D102598
2021-01-21 16:42:21 +00:00
Gijs Kruitbosch
eabaeb4c02 Bug 1652613 - record whether the user switched away from the tab while it was hung, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D84343
2020-07-24 00:55:34 +00:00
Gijs Kruitbosch
02d23145dc Bug 1652613 - record a telemetry event when we show the slow script notification warning, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D83922
2020-07-24 00:50:12 +00:00
Dorel Luca
54d5f1c9ed Backed out 4 changesets (bug 1652613) for Browser-chrome failures in browser/browser_ProcessHangNotifications.js. CLOSED TREE
Backed out changeset 76b5a5d243d1 (bug 1652613)
Backed out changeset 6f98c9b01920 (bug 1652613)
Backed out changeset 1255237ce2e7 (bug 1652613)
Backed out changeset bdf59854c900 (bug 1652613)
2020-07-24 02:58:22 +03:00
Gijs Kruitbosch
e609c52743 Bug 1652613 - record whether the user switched away from the tab while it was hung, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D84343
2020-07-22 22:28:05 +00:00
Gijs Kruitbosch
f5fc88e2ae Bug 1652613 - record a telemetry event when we show the slow script notification warning, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D83922
2020-07-22 22:28:31 +00:00
Boris Zbarsky
a818800ec5 Bug 1568278. Remove various unnecessary QIs to nsIDOMWindow. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D39065

--HG--
extra : moz-landing-system : lando
2019-07-24 01:26:07 +00:00
Victor Porof
af7d1d3b67 Bug 1561435 - Format browser/modules/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36046

--HG--
extra : source : f3c632037a1064c41b1f8b02f477c854b2fb4362
2019-07-05 09:55:19 +02:00
Alexander Surkov
1649231cef Bug 1527495 - migrate text-link binding to CE, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D19595

--HG--
rename : toolkit/content/widgets/text.xml => toolkit/content/widgets/text.js
2019-02-12 19:14:40 -05:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Paolo Amadini
ce13039af3 Bug 1471403 - Part 2 - Lazify the creation of "notificationbox" elements. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D10892

--HG--
extra : rebase_source : f66fe90d780c3d446f4a065c0397cbb37f43cb0c
2018-11-09 14:38:49 +00:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Brendan Dahl
f6923ccc24 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265

--HG--
extra : moz-landing-system : lando
2018-08-25 00:16:27 +00:00
Kris Maglione
80327d3561 Bug 1484496: Part 5a - Convert browser/ nsISimpleEnumerator users to use JS iteration. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3729

--HG--
extra : rebase_source : e187b8e9a6b6db7ebc762adda5e489b25c7a7e43
extra : histedit_source : 868cb99d09954a51d6be321fcb516475ef70eb33
2018-08-18 19:27:33 -07:00
Jonathan Kingston
ff73ac0338 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja

--HG--
extra : rebase_source : 29d337e111d82e9c5729b5a59e1a16d06e67774c
2018-02-21 14:28:48 +00:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Dan Banner
b2e847755c Bug 1367704 - Enable the semi ESLint rule across the tree. r=standard8
MozReview-Commit-ID: GrlcOI9K2hJ

--HG--
extra : rebase_source : 6574cf3c67eb11733ffd9999c260f71c8551abc4
2017-05-28 19:57:46 +01:00