Fabrice Desré
c50cb528fc
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 16:39:41 +00:00
Andreea Pavel
3ccd75af8d
Backed out changeset b9d2965591b9 (bug 1761040) for landing with wrong author CLOSED TREE DONTBUILD
2022-08-03 18:55:00 +03:00
Andreea Pavel
fdb7cb2ecd
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 15:27:43 +00:00
Andreea Pavel
89d63c91e6
Backed out changeset a907159a482f (bug 1761040) for causing build bustages on a CLOSED TREE
2022-08-02 04:59:08 +03:00
Fabrice Desré
0f4ac7ad97
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-02 00:49:41 +00:00
Neil Deakin
6c927c11b6
Bug 1746052, add a means to get the filename that should be used for saving an image to disk, r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D135950
2022-05-06 10:00:52 +00:00
Noemi Erli
295eab376a
Backed out 14 changesets (bug 1746052) for causing build bustages in nsExternalHelperAppService.cpp CLOSED TREE
...
Backed out changeset bf46b0add531 (bug 1746052)
Backed out changeset 684b2aca10bb (bug 1746052)
Backed out changeset d4796eeeaf64 (bug 1746052)
Backed out changeset 5cf2378f6eb4 (bug 1746052)
Backed out changeset 2055ec1e9a57 (bug 1746052)
Backed out changeset 1398fc0669d2 (bug 1746052)
Backed out changeset 1f979899c843 (bug 1746052)
Backed out changeset 561a24801d4d (bug 1746052)
Backed out changeset 73e4689120f0 (bug 1746052)
Backed out changeset 9891f3b0229b (bug 1746052)
Backed out changeset 4c1ab30de0bd (bug 1746052)
Backed out changeset 108e14122e53 (bug 1746052)
Backed out changeset 1ee59c52578a (bug 1746052)
Backed out changeset 41fe77c5f4b2 (bug 1746052)
2022-05-05 23:13:33 +03:00
Neil Deakin
ffd18bceae
Bug 1746052, add a means to get the filename that should be used for saving an image to disk, r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D135950
2022-05-05 19:46:45 +00:00
Csoregi Natalia
7896e7e124
Backed out 13 changesets (bug 1746052) for causing failures on uriloader/exthandler/tests/. CLOSED TREE
...
Backed out changeset d19cc58e3cab (bug 1746052)
Backed out changeset 229edc158a2b (bug 1746052)
Backed out changeset b0ef7c68abcf (bug 1746052)
Backed out changeset 30de4b77f242 (bug 1746052)
Backed out changeset ebc6720fdab3 (bug 1746052)
Backed out changeset daccb796a093 (bug 1746052)
Backed out changeset 5b76d8d76b2b (bug 1746052)
Backed out changeset a698068d078f (bug 1746052)
Backed out changeset 73d17535d8d1 (bug 1746052)
Backed out changeset 94c95f004221 (bug 1746052)
Backed out changeset 1a389759585a (bug 1746052)
Backed out changeset c91230a8ea90 (bug 1746052)
Backed out changeset 7665f02c114e (bug 1746052)
2022-05-04 01:15:12 +03:00
Neil Deakin
976c5b23db
Bug 1746052, add a means to get the filename that should be used for saving an image to disk, r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D135950
2022-05-03 19:44:24 +00:00
Randell Jesup
12fddc66fd
Bug 1207753 - image thread-safety annotations r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D132641
2022-03-21 20:04:39 +00:00
Randell Jesup
c1b9361c0e
Bug 1207753 - gfx & image thread-safety annotations r=gfx-reviewers,aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D130600
2022-03-21 18:05:31 +00:00
Timothy Nikkel
5efd301cea
Bug 1756551. Parameter aInnerWindowId on PrepareForNewPart in imgRequest.cpp is uint64_t not uint32_t. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D139370
2022-02-24 09:40:34 +00:00
Timothy Nikkel
6846d0c094
Bug 1755032. Fix data race on imgRequest::mInnerWindowId. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D138623
2022-02-14 10:00:40 +00:00
Luca Greco
24af3febf1
Bug 1746841 - Revert Bug 1747091 temporary workaround to prevent moz-extension css from being cached. r=emilio
...
Depends on D134508
Differential Revision: https://phabricator.services.mozilla.com/D135739
2022-01-19 19:58:13 +00:00
Emilio Cobos Álvarez
ec7f948696
Bug 1747091 - Force CSS with moz-extension schemes to get revalidated temporarily. r=rpl
...
See bug 1746841 comment 11 for the right fix instead.
Differential Revision: https://phabricator.services.mozilla.com/D134424
2021-12-22 11:46:59 +00:00
Randell Jesup
7840dcdbd7
Bug 1746313: Image cleanup r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D133982
2021-12-16 14:15:32 +00:00
ssummar
b9d6fce436
Bug 1530209 - Removed context argument from various methods. r=necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D129797
2021-11-24 11:25:41 +00:00
Olli Pettay
77bb9e9b0e
Bug 1734811 - consider to use higher priority for the imglib tasks r=tnikkel
...
Depends on D127935
Differential Revision: https://phabricator.services.mozilla.com/D127936
2021-10-08 19:29:37 +00:00
Emilio Cobos Álvarez
a480cfb732
Bug 1729477 - Tweak SubresourceCacheValidationInfo to account for chrome uris. r=tnikkel
...
Turns out my patch above causes some failures because chrome:// channels
don't have cache information, so we conservatively assume they always
expire, which causes some interesting timing issues in a single test.
Fun stuff.
Tweak the code so that SubresourceCacheValidationInfo has the
pre-existing data:// URI special-case and also special-cases chrome://
URIs.
Differential Revision: https://phabricator.services.mozilla.com/D124921
2021-09-09 09:32:11 +00:00
Sandor Molnar
870ff4f480
Backed out 3 changesets (bug 1729477) for causing devtools failures in browser_webconsole_sidebar_object_expand_when_message_pruned. CLOSED TREE
...
Backed out changeset 8cbf3101ed8a (bug 1729477)
Backed out changeset 7457834fb7d0 (bug 1729477)
Backed out changeset 1259d2d1f247 (bug 1729477)
2021-09-09 03:55:31 +03:00
Emilio Cobos Álvarez
d4d9525111
Bug 1729477 - Tweak SubresourceCacheValidationInfo to account for chrome uris. r=tnikkel
...
Turns out my patch above causes some failures because chrome:// channels
don't have cache information, so we conservatively assume they always
expire, which causes some interesting timing issues in a single test.
Fun stuff.
Tweak the code so that SubresourceCacheValidationInfo has the
pre-existing data:// URI special-case and also special-cases chrome://
URIs.
Differential Revision: https://phabricator.services.mozilla.com/D124921
2021-09-08 21:03:02 +00:00
Emilio Cobos Álvarez
62550fa581
Bug 1709577 - Remove CORS_* constants from imgIRequest, use CORSMode instead. r=tnikkel
...
These don't have the same value, and is a bit confusing.
Differential Revision: https://phabricator.services.mozilla.com/D114352
2021-05-05 15:23:25 +00:00
Valentin Gosu
2756a257ad
Bug 1694662 - Remove appcache from imgRequest/imgLoader r=kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D106449
2021-04-30 07:20:21 +00:00
Simon Giesecke
971b645fe3
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Emilio Cobos Álvarez
6514cd85bf
Bug 1655933 - Allow images from non-static documents to get reused in their static clones without validation. r=tnikkel
...
This allows to print images that we'd otherwise reload.
Differential Revision: https://phabricator.services.mozilla.com/D85263
2020-07-30 08:55:24 +00:00
Emilio Cobos Álvarez
e5fe143835
Bug 1599160 - Better integration of the shared stylesheet cache with the network cache. r=tnikkel,mayhemer,heycam
...
Make the stylesheet cache respect the same headers as the image cache
does. This makes no-cache stylesheets work as they do now, which is
useful for developers that want to develop sites locally, and for
shift-reloads, etc.
Differential Revision: https://phabricator.services.mozilla.com/D78659
2020-06-12 19:06:04 +00:00
Razvan Maries
7b30d6e82e
Backed out 7 changesets (bug 1599160) for damp failures. CLOSED TREE
...
Backed out changeset edb0e17f3c98 (bug 1599160)
Backed out changeset 64b42ac358e6 (bug 1599160)
Backed out changeset ce1521b895e1 (bug 1599160)
Backed out changeset 0b0ff0ad8db7 (bug 1599160)
Backed out changeset c7ef05dae614 (bug 1599160)
Backed out changeset 466cfd0ad5db (bug 1599160)
Backed out changeset b3f28494f0e7 (bug 1599160)
2020-06-12 02:40:38 +03:00
Emilio Cobos Álvarez
5048e0ec84
Bug 1599160 - Better integration of the shared stylesheet cache with the network cache. r=tnikkel,mayhemer,heycam
...
Make the stylesheet cache respect the same headers as the image cache
does. This makes no-cache stylesheets work as they do now, which is
useful for developers that want to develop sites locally, and for
shift-reloads, etc.
Differential Revision: https://phabricator.services.mozilla.com/D78659
2020-06-11 11:42:01 +00:00
Honza Bambas
191a2becd0
Bug 1642140 - Image link-preloads: do not overprioritize, never set UrgentStart, always set LOAD_BACKGROUND, r=edgar,tnikkel+tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D77664
2020-06-02 20:28:30 +00:00
Timothy Nikkel
b1a5b829a2
Bug 1640332. Access imgRequest::mIsMultiPartChannel while holding the mutex. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D76580
2020-05-26 02:06:07 +00:00
Timothy Nikkel
821ecf5a31
Bug 1640332. Move fields out of the bitfield that is accessed off main thread. r=aosmond
...
We don't access them off main thread so just move them out of the bitfield that is protected by the mutex.
Differential Revision: https://phabricator.services.mozilla.com/D76579
2020-05-26 02:06:00 +00:00
Edgar Chen
3f250fba44
Bug 1618295 - Make imgRequestProxy implement and use PreloaderBase to support the preload as speculative load feature; r=tnikkel,smaug,mayhemer
...
Depends on D72083
Differential Revision: https://phabricator.services.mozilla.com/D69860
2020-05-11 14:43:05 +00:00
Edgar Chen
40ade72706
Bug 1628727 - Stop using nsISupports as argument type in some functions of imgLoader; r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D70387
--HG--
extra : moz-landing-system : lando
2020-04-10 21:14:49 +00:00
Noemi Erli
91e2985a09
Backed out changeset 27d94573975d (bug 1628727) for causing build bustages in imgRequest.cpp CLOSED TREE
2020-04-11 00:03:57 +03:00
Edgar Chen
4f03b7c3ce
Bug 1628727 - Stop using nsISupports as argument type in some functions of imgLoader; r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D70387
--HG--
extra : moz-landing-system : lando
2020-04-10 00:00:12 +00:00
Tom Schuster
2c4cb96468
Bug 1558915 - Use infallible nsIURI::SchemeIs everywhere. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D41367
--HG--
extra : moz-landing-system : lando
2019-08-09 15:17:06 +00:00
Tom Schuster
4e01ab1787
Bug 1558915 - Use infallible nsIURI::SchemeIs in image/ r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D40459
--HG--
extra : moz-landing-system : lando
2019-08-03 09:44:12 +00:00
Thomas Nguyen
db9e147a01
Bug 1566411 Use ReferrerInfo class in imgLoader.idl r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D38177
--HG--
extra : moz-landing-system : lando
2019-07-25 08:23:32 +00:00
Nicholas Nethercote
8b27a136fc
Bug 1561491 - Make image.* static prefs follow the naming convention. r=KrisWright
...
Differential Revision: https://phabricator.services.mozilla.com/D35977
--HG--
extra : rebase_source : 7bf85fbb4f8564969cf9c945dd0ea46002f166a6
2019-06-26 13:24:21 +10:00
Jean-Yves Avenard
04a34db033
Bug 1550422 - P12. Convert Live gfxPrefs into StaticPrefs. r=jrmuizel
...
gfxPrefs Live preferences are almost identical to StaticPrefs.
We leave aside for now those that set a custom change callback as this feature isn't yet supported in StaticPrefs.
Differential Revision: https://phabricator.services.mozilla.com/D31256
--HG--
extra : moz-landing-system : lando
2019-05-26 14:29:42 +00:00
Gurzau Raul
967bc2a754
Backed out 31 changesets (bug 1552643, bug 1550422) for xpcshell crash on a CLOSED TREE.
...
Backed out changeset e30c1aa75529 (bug 1552643)
Backed out changeset caadcd7e02d3 (bug 1552643)
Backed out changeset aa7086ab09be (bug 1552643)
Backed out changeset 0b4029671710 (bug 1550422 )
Backed out changeset a16295296035 (bug 1550422 )
Backed out changeset 3b70307c0db5 (bug 1550422 )
Backed out changeset 69df7818d4a3 (bug 1550422 )
Backed out changeset d98dfc565927 (bug 1550422 )
Backed out changeset 6f0997976944 (bug 1550422 )
Backed out changeset 0edd264464c2 (bug 1550422 )
Backed out changeset 9ea6da7a74ec (bug 1550422 )
Backed out changeset f855f9309c8b (bug 1550422 )
Backed out changeset 1033546224a7 (bug 1550422 )
Backed out changeset ade7384c6186 (bug 1550422 )
Backed out changeset 75b04de7e99c (bug 1550422 )
Backed out changeset 91c3acdb2454 (bug 1550422 )
Backed out changeset 77d2f80257d1 (bug 1550422 )
Backed out changeset e0cd10d35327 (bug 1550422 )
Backed out changeset 097091082423 (bug 1550422 )
Backed out changeset 2f328853c1ab (bug 1550422 )
Backed out changeset f92f2cc29cb1 (bug 1550422 )
Backed out changeset 6dc82f88333d (bug 1550422 )
Backed out changeset c20f66494d69 (bug 1550422 )
Backed out changeset 2ba22cddeb6f (bug 1550422 )
Backed out changeset 3aa72f89e295 (bug 1550422 )
Backed out changeset ab4c4e806977 (bug 1550422 )
Backed out changeset 72e5de040dda (bug 1550422 )
Backed out changeset 7d3c2d486706 (bug 1550422 )
Backed out changeset 132e0b8d8468 (bug 1550422 )
Backed out changeset 54c85ac75dd0 (bug 1550422 )
Backed out changeset d7ba4a18dd54 (bug 1550422 )
2019-05-25 09:07:49 +03:00
Jean-Yves Avenard
af5790cf9b
Bug 1550422 - P12. Convert Live gfxPrefs into StaticPrefs. r=jrmuizel
...
gfxPrefs Live preferences are almost identical to StaticPrefs.
We leave aside for now those that set a custom change callback as this feature isn't yet supported in StaticPrefs.
Differential Revision: https://phabricator.services.mozilla.com/D31256
--HG--
extra : moz-landing-system : lando
2019-05-25 00:03:32 +00:00
Gurzau Raul
74c555539e
Backed out 28 changesets (bug 1550422) for marionette AssertionError and failing browser_policy_hardware_acceleration.js on a CLOSED TREE.
...
Backed out changeset 5dd10a365ba9 (bug 1550422 )
Backed out changeset 529f5be01ab9 (bug 1550422 )
Backed out changeset b6861d3badf8 (bug 1550422 )
Backed out changeset 059cff1a3dde (bug 1550422 )
Backed out changeset 6ada1116b241 (bug 1550422 )
Backed out changeset ca67e8e45262 (bug 1550422 )
Backed out changeset a1961a51ae44 (bug 1550422 )
Backed out changeset 1c90b9cb3ad4 (bug 1550422 )
Backed out changeset 285fa46e4f26 (bug 1550422 )
Backed out changeset e2938a444234 (bug 1550422 )
Backed out changeset 7a930fc51125 (bug 1550422 )
Backed out changeset 898ed02804fe (bug 1550422 )
Backed out changeset e1b7abc99ae9 (bug 1550422 )
Backed out changeset f781d415cef6 (bug 1550422 )
Backed out changeset 2fef10a7cce5 (bug 1550422 )
Backed out changeset ea64b4d8d4ff (bug 1550422 )
Backed out changeset 86a8ba1b755c (bug 1550422 )
Backed out changeset 9c0c9e80f309 (bug 1550422 )
Backed out changeset 10c153ddbaea (bug 1550422 )
Backed out changeset 60fe635ec2c9 (bug 1550422 )
Backed out changeset a38796266b28 (bug 1550422 )
Backed out changeset 2db647dcdf1c (bug 1550422 )
Backed out changeset 952ddac02972 (bug 1550422 )
Backed out changeset ba46b53643ec (bug 1550422 )
Backed out changeset ca47ef6c59f7 (bug 1550422 )
Backed out changeset f45f471a1a40 (bug 1550422 )
Backed out changeset 371b4da5b771 (bug 1550422 )
Backed out changeset 02fc78890032 (bug 1550422 )
2019-05-23 05:59:44 +03:00
Jean-Yves Avenard
2c0ce1b3ca
Bug 1550422 - P12. Convert Live gfxPrefs into StaticPrefs. r=jrmuizel
...
gfxPrefs Live preferences are almost identical to StaticPrefs.
We leave aside for now those that set a custom change callback as this feature isn't yet supported in StaticPrefs.
Differential Revision: https://phabricator.services.mozilla.com/D31256
--HG--
extra : moz-landing-system : lando
2019-05-22 12:43:42 +00:00
Timothy Nikkel
3e6fb67de2
Bug 1552077. Use medium high runnables for a few more imagelib runnables. r=smaug
...
speedindex runs show this to be a nice win.
Differential Revision: https://phabricator.services.mozilla.com/D31370
--HG--
extra : moz-landing-system : lando
2019-05-17 23:09:38 +00:00
Timothy Nikkel
64306c8162
Bug 1377457. Only apply locks to the image if SetHasImage has been called. r=aosmond
...
This was observed in an intermittent failure of image/test/mochitest/test_discardAnimatedImage.html. What happened was:
1) Document::MaybePreLoadImage was called for the images in the test.
2) imgRequest::OnDataAvailable is called on at least one of the images. This creates the RasterImage, so any proxy for this imgRequest will now return the image via GetImage(). imgRequest::OnDataAvailable also queues the FinishPreparingForNewPartRunnable back to the main thread to call OnImageAvailable on the progress tracker on the main thread.
3) We get the actual LoadImage calls for the images of the document. We create new proxies for the existing imgRequests. imgRequestProxy::Init calls mBehaviour->SetOwner(aOwner), which sets mOwnerHasImage to true because the progress tracker has an mImage (the one we created above).
4) We get a call to LockImage, this gets forwarded to the RasterImage because mOwnerHasImage is true and we can access the image.
5) The FinishPreparingForNewPartRunnable finally runs on the main thread. The OnImageAvailable notification from the progress tracker ends up in imgRequestProxy::SetHasImage. imgRequestProxy::SetHasImage applies our local count mLockCount to the RasterImage, even though we've already forwarded one of those LockImage calls to the image. LockImage calls are now unbalanced and the image will always remain locked.
The fix is simple. Only apply the Lock/Unlock calls if the FinishPreparingForNewPartRunnable has hit the main thread (ie ignore an image we can access until this happens).
Differential Revision: https://phabricator.services.mozilla.com/D29326
--HG--
extra : moz-landing-system : lando
2019-05-01 23:05:47 +00:00
Cameron McCormack
126b79c729
Bug 1534240 - Boost loading priority of CSS images similarly to how we do for HTML images. r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D24814
--HG--
extra : moz-landing-system : lando
2019-03-28 02:54:16 +00:00
Sylvestre Ledru
4aa92e3091
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D22514
2019-03-13 10:19:06 +01:00
Jonathan Kingston
f6680698bd
Bug 1525319 - Removing context from OnDataAvailable r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D20881
--HG--
extra : moz-landing-system : lando
2019-02-27 23:42:27 +00:00