Commit graph

127 commits

Author SHA1 Message Date
Fabrice Desré
c50cb528fc Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 16:39:41 +00:00
Andreea Pavel
3ccd75af8d Backed out changeset b9d2965591b9 (bug 1761040) for landing with wrong author CLOSED TREE DONTBUILD 2022-08-03 18:55:00 +03:00
Andreea Pavel
fdb7cb2ecd Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 15:27:43 +00:00
Andreea Pavel
89d63c91e6 Backed out changeset a907159a482f (bug 1761040) for causing build bustages on a CLOSED TREE 2022-08-02 04:59:08 +03:00
Fabrice Desré
0f4ac7ad97 Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-02 00:49:41 +00:00
Tooru Fujisawa
854319c8ab Bug 1777641 - Suppress CheckForBrokenChromeURL and RecordZeroLengthEvent for JSM loaded by mozJSModuleLoader. r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D150875
2022-07-05 09:18:31 +00:00
Randell Jesup
ffb7ef2b49 Bug 1760651 - nsIOService thread-safety annotations r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D141658
2022-03-21 20:01:21 +00:00
Randell Jesup
fcaf70841e Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 18:47:08 +00:00
Noemi Erli
2390d257e6 Backed out changeset 12a59e5a50bf (bug 1207753) for causing build bustage CLOSED TREE 2022-03-16 18:32:51 +02:00
Randell Jesup
4b033a5256 Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 16:16:14 +00:00
Butkovits Atila
927ad62c6a Backed out changeset a68ee4b09f92 (bug 1207753) for causing Hazard bustages. CLOSED TREE 2022-03-16 14:38:14 +02:00
Randell Jesup
7d4b5fae04 Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 12:01:14 +00:00
Kershaw Chang
1be7893454 Bug 1600309 - P4: Avoid creating data bridge channel after crashes, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D134906
2022-02-23 11:55:59 +00:00
Kershaw Chang
36fcc2120c Bug 1600309 - P3: Avoid observing duplicate topics, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D134905
2022-02-23 11:55:59 +00:00
Kershaw Chang
cbf6f791da Bug 1600309 - P2: Don't use socket porcess when it crashes too many times, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D134904
2022-02-23 11:55:59 +00:00
Cristian Tuns
3419e72275 Backed out 4 changesets (bug 1600309) for causing networking crashes CLOSED TREE
Backed out changeset ae7282e60012 (bug 1600309)
Backed out changeset 0d8b02a8db17 (bug 1600309)
Backed out changeset c7262d966a28 (bug 1600309)
Backed out changeset e5503a84beea (bug 1600309)
2022-02-12 05:00:04 -05:00
Kershaw Chang
3140afb3e0 Bug 1600309 - P4: Avoid creating data bridge channel after crashes, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D134906
2022-02-11 10:55:54 +00:00
Kershaw Chang
d4ad673efa Bug 1600309 - P3: Avoid observing duplicate topics, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D134905
2022-02-11 10:55:53 +00:00
Kershaw Chang
769849b41a Bug 1600309 - P2: Don't use socket porcess when it crashes too many times, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D134904
2022-02-11 10:55:53 +00:00
Kershaw Chang
fc1efcd291 Bug 1745063 - Don't send SetOffline IPC to socket process in nsIOService::Observe, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D133371
2021-12-22 05:47:02 +00:00
Valentin Gosu
1a1f42da37 Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw
This changeset is the result of adding modernize-use-default-member-init to
tools/clang-tidy/config.yaml then proceeding to run
`./mach static-analysis check netwerk/ --fix`
I then went through the resulting fix and manually updated all of the member
variables which were missed due to them having a non-trivial constructor.

Note that the tool was only run on Linux, so code that only runs on some
platforms may have been missed.

The member variables that are still initialized in the contructor definition
are:
  - bitfields (not all currently supported compilers allow default-member-init
  - variables that are initialized via a parameter
  - variables that use code not visible in the header file

There are a few advantages to landing this change:
- fewer lines of code - now declaration is in the same place as initialization
  this also makes it easier to see when looking at the header.
- it makes it harder to miss initializing a member when adding a new contructor
- variables that depend on an include guard look much nicer now

Additionally I removed some unnecessary reinitialization of NetAddr members
(it has a constructor that does that now), and changed nsWifiScannerDBus to
use the thread-safe strtok_r instead of strtok.

Differential Revision: https://phabricator.services.mozilla.com/D116980
2021-06-11 07:10:41 +00:00
Csoregi Natalia
938a6943c6 Backed out changeset 6e00f8bd2acc (bug 1714307) for causing hazard bustage. CLOSED TREE 2021-06-09 21:50:03 +03:00
Valentin Gosu
d1513f313e Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw
This changeset is the result of adding modernize-use-default-member-init to
tools/clang-tidy/config.yaml then proceeding to run
`./mach static-analysis check netwerk/ --fix`
I then went through the resulting fix and manually updated all of the member
variables which were missed due to them having a non-trivial constructor.

Note that the tool was only run on Linux, so code that only runs on some
platforms may have been missed.

The member variables that are still initialized in the contructor definition
are:
  - bitfields (not all currently supported compilers allow default-member-init
  - variables that are initialized via a parameter
  - variables that use code not visible in the header file

There are a few advantages to landing this change:
- fewer lines of code - now declaration is in the same place as initialization
  this also makes it easier to see when looking at the header.
- it makes it harder to miss initializing a member when adding a new contructor
- variables that depend on an include guard look much nicer now

Additionally I removed some unnecessary reinitialization of NetAddr members
(it has a constructor that does that now), and changed nsWifiScannerDBus to
use the thread-safe strtok_r instead of strtok.

Differential Revision: https://phabricator.services.mozilla.com/D116980
2021-06-09 10:20:04 +00:00
Valentin Gosu
d595491cc7 Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 12:35:16 +00:00
Butkovits Atila
692bda1ca1 Backed out changeset c4b44c4ef15b (bug 1714307) for causing build bustages on nsHTTPCompressConv.h. CLOSED TREE 2021-06-04 13:53:37 +03:00
Valentin Gosu
98146ae90b Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 10:00:55 +00:00
Simon Giesecke
705461265d Bug 708901 - Migrate to nsTHashSet in netwerk. r=necko-reviewers,valentin
Depends on D108600

Differential Revision: https://phabricator.services.mozilla.com/D108601
2021-03-23 10:36:35 +00:00
Simon Giesecke
b5855b89fc Bug 1634281 - Remove unused nsDataHashtable.h includes. r=xpcom-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D106007
2021-03-03 08:58:52 +00:00
Masatoshi Kimura
3424a95ee0 Bug 1682103 - Make nsContentPolicyType a CEnum type. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D99580
2020-12-16 11:36:47 +00:00
Simon Giesecke
971b645fe3 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Andi-Bogdan Postelnicu
5e91efd61f Bug 1626555 - Add dom/security to the list of non-unified-build-compatible directories. r=sg
Differential Revision: https://phabricator.services.mozilla.com/D96427
2020-11-09 21:03:52 +00:00
Brindusan Cristian
ca85f574a0 Backed out changeset 3a087ad91d30 (bug 1626555) for build bustages. CLOSED TREE 2020-11-09 21:09:33 +02:00
Andi-Bogdan Postelnicu
6ffdaf663d Bug 1626555 - Add dom/security to the list of non-unified-build-compatible directories. r=sg
Differential Revision: https://phabricator.services.mozilla.com/D96427
2020-11-09 17:57:01 +00:00
Christoph Kerschbaumer
faf05f7d19 Bug 1552168: Remove pref security.data_uri.unique_opaque_origin. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D92087
2020-10-08 16:55:25 +00:00
Kershaw Chang
3e2bb60df1 Bug 1647759 - P1: Make nsIOService::mOffline and nsIOService::mConnectivity atomic r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D82351
2020-07-09 12:56:03 +00:00
Razvan Maries
ab9f3eb05b Backed out 3 changesets (bug 1647759) for GTest perma failures. CLOSED TREE
Backed out changeset 94c175860a86 (bug 1647759)
Backed out changeset e7d8a7d2bdf1 (bug 1647759)
Backed out changeset 2972984413b8 (bug 1647759)
2020-07-09 15:41:22 +03:00
Kershaw Chang
18ea12a27d Bug 1647759 - P1: Make nsIOService::mOffline and nsIOService::mConnectivity atomic r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D82351
2020-07-06 18:26:16 +00:00
Kershaw Chang
86ce6ac77d Bug 1637648 - P1: Make nsIOService the single point to forward observer notifications to socket process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D77305
2020-06-23 11:11:01 +00:00
Alexis Beingessner
0e39201277 Bug 1637727 - convert nsIOService prefs to StaticPrefs. r=KrisWright,necko-reviewers
converts:
 * security.data_uri.block_toplevel_data_uri_navigations
 * network.offline-mirrors-connectivity

Differential Revision: https://phabricator.services.mozilla.com/D77104
2020-05-28 18:23:25 +00:00
Kershaw Chang
eb032f3176 Bug 1602832 - P1: Run xpcshell tests without e10s with socket process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D58110
2020-05-26 14:30:09 +00:00
Butkovits Atila
f167b5c275 Backed out 6 changesets (bug 1602832) for causing perma failure at test_trr_case_sensitivity.js. CLOSED TREE
Backed out changeset 0e9c378df995 (bug 1602832)
Backed out changeset 534fedb3836e (bug 1602832)
Backed out changeset db012c05d64e (bug 1602832)
Backed out changeset ca0c207dca21 (bug 1602832)
Backed out changeset bea1f3aeea49 (bug 1602832)
Backed out changeset 2d54acd78124 (bug 1602832)
2020-05-26 13:09:07 +03:00
Kershaw Chang
ad95a84c3b Bug 1602832 - P1: Run xpcshell tests without e10s with socket process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D58110
2020-05-26 08:35:02 +00:00
Coroiu Cristina
44c378a7fb Backed out 5 changesets (bug 1602832) for browser-chrome failures at toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js on a CLOSED TREE
Backed out changeset 059a7f44d1a9 (bug 1602832)
Backed out changeset 2f3cc391b48a (bug 1602832)
Backed out changeset 24d1ce1b0ac9 (bug 1602832)
Backed out changeset 5ea85726cc48 (bug 1602832)
Backed out changeset ee00e846104e (bug 1602832)
2020-05-19 23:05:26 +03:00
Kershaw Chang
e5f3047c48 Bug 1602832 - P1: Run xpcshell tests without e10s with socket process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D58110
2020-05-19 12:56:47 +00:00
Arthur Iakab
5b06305b9f Backed out 4 changesets (bug 1602832) for causing multiple xpcshell failures.
CLOSED TREE

Backed out changeset a5cc1585581f (bug 1602832)
Backed out changeset 3de4624b41dc (bug 1602832)
Backed out changeset da106d35137e (bug 1602832)
Backed out changeset f9388129262a (bug 1602832)
2020-04-23 16:25:26 +03:00
Kershaw Chang
eda36941fd Bug 1602832 - P1: Run xpcshell tests without e10s with socket process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D58110
2020-04-23 12:14:55 +00:00
Kristen Wright
5094f72a18 Bug 1622111 - Convert security.data_uri.unique_opaque_origin to static pref and remove ClientPrefs. r=njn
Converts security.data_uri.unique_opaque_origin to a static pref. This pref was initialized by the ClientManager in ClientPrefs, so this commit also removes those files. Somehow this pref was getting added in VarCache twice, so it also removes the places where the pref was added in Networking.

Differential Revision: https://phabricator.services.mozilla.com/D67185

--HG--
extra : moz-landing-system : lando
2020-03-23 16:08:52 +00:00
Bogdan Tara
a3db8af185 Backed out 3 changesets (bug 1602832) for assertion failing on IOInterposer.cpp CLOSED TREE
Backed out changeset 9123faab0d42 (bug 1602832)
Backed out changeset 4c3764b3d7bc (bug 1602832)
Backed out changeset 9c955a99c95d (bug 1602832)
2020-03-20 14:03:28 +02:00
Kershaw Chang
1e77753c5b Bug 1602832 - P1: Run xpcshell tests without e10s with socket process r=dragana
1. Add `network.process.enabled` beck to `all.js`, since it's easier to run xpcshell tests locally.
2. Launch socket process at `nsHttpHandler::Init`.
3. Allow to launch socket process for running xpcshell test without e10s.

Differential Revision: https://phabricator.services.mozilla.com/D58110

--HG--
extra : moz-landing-system : lando
2020-03-19 10:29:57 +00:00
Stefan Hindli
5f419e4b50 Backed out 9 changesets (bug 1622111) for causing mochitest failures in dom/animation/test/mozilla/test_restyles.html CLOSED TREE
Backed out changeset c244160797f8 (bug 1622111)
Backed out changeset dd9209f6bd8b (bug 1622111)
Backed out changeset d694c9e7061f (bug 1622111)
Backed out changeset 486aae809f6d (bug 1622111)
Backed out changeset 709266168c41 (bug 1622111)
Backed out changeset ca0d47bb86a8 (bug 1622111)
Backed out changeset caa735c8bb91 (bug 1622111)
Backed out changeset 12397711ab25 (bug 1622111)
Backed out changeset b66002fd1480 (bug 1622111)
2020-03-19 02:47:51 +02:00