Commit graph

62 commits

Author SHA1 Message Date
Chris H-C
4a5870eeb4 Bug 1787589 - Avoid flushing FOG IPC too late in shutdown r=perry.mcmanis
Differential Revision: https://phabricator.services.mozilla.com/D155848
2022-08-29 15:58:26 +00:00
Chris H-C
8ebf835d75 Bug 1766977 - FOG IPC must register cleanup on the main thread r=janerik
As we've learned from GIFFT, though, is that the main thread might not be
available at all times (specifically if too early in startup or late in
shutdown). This is rather problematical as there's not much we can do in those
instances.

So what do we do when there's nothing to do? We log so it's obvious on the
client, and we instrument it so it's obvious on the server.

(Providing that the instrumentation can make it into the db.)

Differential Revision: https://phabricator.services.mozilla.com/D145129
2022-05-04 17:09:42 +00:00
Florian Quèze
34c0c5a32a Bug 1763474 - Report thread wake-ups and CPU time per thread through glean, r=gerald,chutten
Differential Revision: https://phabricator.services.mozilla.com/D141147
2022-04-23 11:38:19 +00:00
Marian-Vasile Laza
87994c06ad Backed out changeset 700318695e2b (bug 1763474) for causing GTest failures and mochitest failures on ProfilerThreadRegistrationData.cpp. CLOSED TREE 2022-04-22 12:57:22 +03:00
Florian Quèze
257c2cbade Bug 1763474 - Report thread wake-ups and CPU time per thread through glean, r=gerald,chutten
Differential Revision: https://phabricator.services.mozilla.com/D141147
2022-04-22 06:20:51 +00:00
Narcis Beleuzu
c5c85a1120 Backed out 1 changesets (bug 1763474) for assertion failures. CLOSED TREE
Backed out changeset 576565c650a1 (bug 1763474)
2022-04-15 02:26:13 +03:00
Florian Quèze
8f5736dae0 Bug 1763474 - Report thread wake-ups and CPU time per thread through glean, r=gerald,chutten
Differential Revision: https://phabricator.services.mozilla.com/D141147
2022-04-14 22:08:53 +00:00
Florian Quèze
394a5bf056 Bug 1759535 - Report thread wake-ups through glean, r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D141050
2022-03-28 22:13:09 +00:00
Alexandre Lissy
3d8f9e85b0 Bug 1753424 - Support running multiple UtilityProcess r=nika
Differential Revision: https://phabricator.services.mozilla.com/D139817
2022-03-26 19:46:43 +00:00
Cristian Tuns
b217ab7e55 Backed out 6 changesets (bug 1753424) for causing build bustages CLOSED TREE
Backed out changeset 930136daf858 (bug 1753424)
Backed out changeset d62c1e5d1881 (bug 1753424)
Backed out changeset 911060d2bd8e (bug 1753424)
Backed out changeset cce723862a92 (bug 1753424)
Backed out changeset 97b3fd69185b (bug 1753424)
Backed out changeset 4748652694c7 (bug 1753424)
2022-03-26 14:49:47 -04:00
Alexandre Lissy
94b46a0084 Bug 1753424 - Support running multiple UtilityProcess r=nika
Differential Revision: https://phabricator.services.mozilla.com/D139817
2022-03-26 09:53:47 +00:00
Butkovits Atila
68679c8f29 Backed out 5 changesets (bug 1753424) for causing bustages. CLOSED TREE
Backed out changeset e2b40064eb59 (bug 1753424)
Backed out changeset 0892c1d3c379 (bug 1753424)
Backed out changeset 4df499ef4647 (bug 1753424)
Backed out changeset f27fbfb9e8f1 (bug 1753424)
Backed out changeset 0f244f2eb2de (bug 1753424)
2022-03-26 16:39:16 +02:00
Alexandre Lissy
baebfcdc76 Bug 1753424 - Support running multiple UtilityProcess r=nika
Differential Revision: https://phabricator.services.mozilla.com/D139817
2022-03-26 09:53:47 +00:00
Alexandre Lissy
a11d18e011 Bug 1758715 - Dont always instantiate a UtilityProcessManager from FOG r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D139966
2022-03-11 11:47:53 +00:00
Bryce Seager van Dyk
3c8482c481 Bug 1757347 - Further qualify mozilla::gmp namespace usage. r=florian
This avoids lookup failures if we introduce glean metrics under 'gmp'. If we do
introduce such metrics, they create a mozilla::glean::gmp namespace which
confuses lookup for these lines.

Differential Revision: https://phabricator.services.mozilla.com/D139799
2022-02-28 21:04:25 +00:00
Florian Quèze
5453392f6d Bug 1755733 - record when bogus CPU or GPU time values are discarded, r=chutten.
Depends on D138917

Differential Revision: https://phabricator.services.mozilla.com/D139287
2022-02-22 23:27:39 +00:00
Florian Quèze
620a137f8f Bug 1755733 - avoid reporting impossibly large GPU time values in Glean, r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D138917
2022-02-22 23:27:39 +00:00
Kershaw Chang
4814249c00 Bug 1755866 - Don't call GetGpuTimeSinceProcessStartInMs in socket process, r=florian,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D138994
2022-02-17 13:21:19 +00:00
Florian Quèze
7fb7ffdd90 Bug 1754424 - Add profiler markers for CPU and GPU time recorded in Glean, r=gerald.
Differential Revision: https://phabricator.services.mozilla.com/D138267
2022-02-09 19:50:45 +00:00
Florian Quèze
e0e1aea459 Bug 1753598 - avoid registering FOG shutdown listeners in content process that are already late in shutdown, r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D137867
2022-02-04 16:41:34 +00:00
Florian Quèze
f84ed84ce8 Bug 1747138 - Breakdown CPU and GPU time by process type, r=chutten,gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D134441
2022-02-03 20:37:21 +00:00
smolnar
4d305a2b14 Backed out changeset cd96e020a609 (bug 1747138) for causing bc failures in browser_telemetry_video_hardware_decoding_support. CLOSED TREE 2022-02-03 19:51:02 +02:00
Florian Quèze
b8e6ccc49a Bug 1747138 - Breakdown CPU and GPU time by process type, r=chutten,gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D134441
2022-02-03 12:20:15 +00:00
Alexandre Lissy
c49224c91a Bug 1745173 - Add FOG to UtilityProcess r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D133633
2022-01-31 20:46:49 +00:00
Chris H-C
c1dba0cf9d Bug 1751241 - Ensure CPU and GPU time measurements fit in instrumentation r=florian,janerik
Differential Revision: https://phabricator.services.mozilla.com/D136652
2022-01-24 21:26:43 +00:00
Sandor Molnar
9cd84d6732 Backed out 2 changesets (bug 1751241) for causing xpc failures in toolkit/components/glean/tests/xpcshell/test_GIFFT.js CLOSED TREE
Backed out changeset 403e96a8429b (bug 1751241)
Backed out changeset 7d047cf994cc (bug 1751241)
2022-01-24 19:11:52 +02:00
Chris H-C
deb47df663 Bug 1751241 - Ensure CPU and GPU time measurements fit in instrumentation r=florian,janerik
Differential Revision: https://phabricator.services.mozilla.com/D136652
2022-01-24 16:41:43 +00:00
Florian Quèze
ffbe24736d Bug 1745511 - Expand FOG IPC to GMP process, r=bryce,chutten,media-playback-reviewers,alwu.
Differential Revision: https://phabricator.services.mozilla.com/D133550
2022-01-19 13:31:17 +00:00
Cristian Tuns
1e332f7d25 Backed out 2 changesets (bug 1745511) for causing mochitest failures on GeckoChildProcessHost.cpp CLOSED TREE
Backed out changeset 620e4b9d8b61 (bug 1745511)
Backed out changeset 0fadea77038a (bug 1745511)
2022-01-19 07:24:42 -05:00
Florian Quèze
7856bfba81 Bug 1745511 - Expand FOG IPC to GMP process, r=bryce,chutten,media-playback-reviewers,alwu.
Differential Revision: https://phabricator.services.mozilla.com/D133550
2022-01-18 22:24:10 +00:00
Alexandru Michis
3de56eb5f2 Backed out changeset 19b1136a92ec (bug 1745511) for causing mochitest failures in GMPServiceParent.cpp
CLOSED TREE
2022-01-13 18:49:34 +02:00
Florian Quèze
3269c9a736 Bug 1745511 - Expand FOG IPC to GMP process, r=bryce,chutten.
Differential Revision: https://phabricator.services.mozilla.com/D133550
2022-01-13 13:44:22 +00:00
Florian Quèze
b485c3eecc Bug 1745444 - Add a test for collecting FOG data on the Socket process, r=chutten,necko-reviewers,valentin.
Differential Revision: https://phabricator.services.mozilla.com/D133510
2021-12-15 22:18:33 +00:00
Florian Quèze
9e59876bd7 Bug 1745444 - Merge TestTriggerGPUMetrics and TestTriggerRDDMetrics into a method taking a process type as parameter, r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D133508
2021-12-15 22:18:32 +00:00
Florian Quèze
646e2b8671 Bug 1745444 - Expand FOG IPC to Socket process, to collect CPU time used there, r=chutten,necko-reviewers,valentin.
Differential Revision: https://phabricator.services.mozilla.com/D133491
2021-12-15 22:18:32 +00:00
Narcis Beleuzu
b80b92e2e1 Backed out 4 changesets (bug 1745444) for GTest failures on IHistory.Test . CLOSED TREE
Backed out changeset b3a2dc754e16 (bug 1745444)
Backed out changeset 7b9d52dff930 (bug 1745444)
Backed out changeset 15d9a79cc305 (bug 1745444)
Backed out changeset 497572ee54af (bug 1745444)
2021-12-15 20:50:24 +02:00
Florian Quèze
1a84e9c20f Bug 1745444 - Add a test for collecting FOG data on the Socket process, r=chutten,necko-reviewers,valentin.
Differential Revision: https://phabricator.services.mozilla.com/D133510
2021-12-15 16:27:57 +00:00
Florian Quèze
e665115136 Bug 1745444 - Merge TestTriggerGPUMetrics and TestTriggerRDDMetrics into a method taking a process type as parameter, r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D133508
2021-12-15 16:27:57 +00:00
Florian Quèze
90b4404217 Bug 1745444 - Expand FOG IPC to Socket process, to collect CPU time used there, r=chutten,necko-reviewers,valentin.
Differential Revision: https://phabricator.services.mozilla.com/D133491
2021-12-15 16:27:56 +00:00
Chris H-C
6d6c87fe7c Bug 1745660 - Flush FOG IPC every 100k samples r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D133664
2021-12-13 20:18:57 +00:00
Florian Quèze
7ea931ac35 Bug 1744162 - Test that RDD-process FOG metrics work r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D133137
2021-12-10 12:20:10 +00:00
Florian Queze
632f535b3d Bug 1744162 - Expand FOG IPC to RDD process, to collect CPU and GPU time used there, r=chutten,jrmuizel.
Differential Revision: https://phabricator.services.mozilla.com/D132749
2021-12-10 12:20:10 +00:00
Chris H-C
9018ab0bb7 Bug 1729026 - Test that GPU-process FOG metrics work r=Dexter,nical
Differential Revision: https://phabricator.services.mozilla.com/D132406
2021-12-01 14:35:08 +00:00
Chris H-C
217e25cfa5 Bug 1729026 - Add support for GPU-process Glean metrics via FOG r=Dexter,nical
Differential Revision: https://phabricator.services.mozilla.com/D124840
2021-12-01 14:35:08 +00:00
Florian Quèze
15f070e21c Bug 1743176 - Collect the GPU time used in the parent process through Glean, r=chutten,jrmuizel.
Differential Revision: https://phabricator.services.mozilla.com/D132265
2021-11-30 21:07:28 +00:00
Florian Quèze
bcdfb763fc Bug 1736040 - collect CPU time through Glean, r=chutten,gerald,gcp
Differential Revision: https://phabricator.services.mozilla.com/D128609
2021-10-25 18:27:24 +00:00
Jan-Erik Rediger
ba5c77a572 Bug 1708669 - Register FOG custom pings on Android builds to enable Glean functionality. r=chutten,geckoview-reviewers,agi
This instantiates the FOG service, which in turn registers an idle
observer, which is required for FOG IPC to be triggered occasionally.

Glean itself will be controlled by the surrounding Android application.
Glean symbols are shipped in this GeckoView build.
Any metrics recorded in Gecko will be passed through to the Android
application, e.g. Fenix.

This also re-exports `rlb_flush_dispatcher` to be called by Glean Core from the Kotlin side.

Currently this does not support sending custom pings inside Gecko.
Testing Glean metrics in an Android build will be enabled in subsequent commits.

Differential Revision: https://phabricator.services.mozilla.com/D126799
2021-10-22 08:53:28 +00:00
Chris H-C
343ddbd563 Bug 1731667 - Flush FOG IPC from content children on process shutdown r=janerik
Unfortunately not testable in an automated fashion.
Tested manually by adding to a test counter metric in ContentChild, shutting
down Firefox immediately (but normally),
removing the instrumentation, rebuilding, and rerunning. Then checking that
the test counter indeed has a value.

Differential Revision: https://phabricator.services.mozilla.com/D126295
2021-09-28 21:09:07 +00:00
Iulian Moraru
fa170008d3 Backed out changeset 1890b6a3b3d2 (bug 1731667) for causing frequent address sanitizer failures. 2021-09-28 19:13:19 +03:00
Chris H-C
69465260b2 Bug 1731667 - Flush FOG IPC from content children on process shutdown r=janerik
Unfortunately not testable in an automated fashion.
Tested manually by adding to a test counter metric in ContentChild, shutting
down Firefox immediately (but normally),
removing the instrumentation, rebuilding, and rerunning. Then checking that
the test counter indeed has a value.

While we're here, ensure we persist ping lifetime data _after_ flushing IPC
on idle to ensure we don't miss anything.

Differential Revision: https://phabricator.services.mozilla.com/D126295
2021-09-28 13:01:16 +00:00