nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
812871 commits 1 branch 98 tags 6.4 GiB
Commit graph

1335 commits

Author SHA1 Message Date
Stephanie Cunnane
79a9911a7e Bug 1787859 - Clarifications and typo fixes in search engine documentation. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D155874
 2022-08-29 19:14:28 +00:00
Mark Banner
3f57d4689b Bug 1787214 - Improve code and fix schema for name/version handling for search-config. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D155589
 2022-08-26 15:14:22 +00:00
Mark Banner
070737d0ac Bug 1786408 - Move isAppProvided handling from SearchEngine to AddonSearchEngine. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D155288
 2022-08-26 07:54:55 +00:00
James Teow
a2f1bf18a3 Bug 1781464 - Add ESR-only taggedCode for Bing - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D152816
 2022-08-23 13:01:06 +00:00
Max Smolens
a5b61e18d6 Bug 1771517 - Update default search engine telemetry when changing separatePrivateDefault preferences. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D154410
 2022-08-15 11:10:01 +00:00
mcheang
b568f4ff2d Bug 1779094 - Improve internal handling of user search settings Part II. r=Standard8 
This patch creates a cache of the user search settings file that is read from
disk. We use the cached settings to determine if the settings has been updated
or changed. If there has been a change, we allow the settings to be written
and saved, otherwise if there's no change, there is no need to write and save
the file.

Public setter and getter methods have also been created to modify or retrieve
the metadata of the engines.

Differential Revision: https://phabricator.services.mozilla.com/D151551
 2022-08-04 23:20:00 +00:00
mcheang
7353dfc49c Bug 1779094 - Improve internal handling of user search settings Part I. r=Standard8 
This patch removes the top level settings metadata object.

Any updates to the metadata will be done on the 2nd level object
#currentSettings.metaData instead. Removing the top level metadata object, we
improve code clarity by only having one metadata object and not two
metadata objects.

Differential Revision: https://phabricator.services.mozilla.com/D153746
 2022-08-04 23:19:59 +00:00
Cristian Tuns
1d7dc742f0 Backed out 2 changesets (bug 1779094) for causing talos damp failures CLOSED TREE 
Backed out changeset 54f9c347df9a (bug 1779094)
Backed out changeset 32bd53c3dd84 (bug 1779094)
 2022-08-05 00:27:57 -04:00
mcheang
bd9dc2df85 Bug 1779094 - Improve internal handling of user search settings Part II. r=Standard8 
This patch creates a cache of the user search settings file that is read from
disk. We use the cached settings to determine if the settings has been updated
or changed. If there has been a change, we allow the settings to be written
and saved, otherwise if there's no change, there is no need to write and save
the file.

Public setter and getter methods have also been created to modify or retrieve
the metadata of the engines.

Differential Revision: https://phabricator.services.mozilla.com/D151551
 2022-08-04 23:20:00 +00:00
mcheang
5e83b6218e Bug 1779094 - Improve internal handling of user search settings Part I. r=Standard8 
This patch removes the top level settings metadata object.

Any updates to the metadata will be done on the 2nd level object
#currentSettings.metaData instead. Removing the top level metadata object, we
improve code clarity by only having one metadata object and not two
metadata objects.

Differential Revision: https://phabricator.services.mozilla.com/D153746
 2022-08-04 23:19:59 +00:00
Mark Banner
12ee099a88 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-26 15:11:31 +00:00
smolnar
dc4f2d6a41 Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE 
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
 2022-07-25 21:00:07 +03:00
Mark Banner
4272200762 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-25 12:46:49 +00:00
Chris H-C
58c4624c3f Bug 1780564 - Ensure the private search submission url isn't blank r=Standard8 
Glean assumes non-url-parseable values for url types are a mistake.

Differential Revision: https://phabricator.services.mozilla.com/D152412
 2022-07-21 16:30:16 +00:00
smolnar
102b779608 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE 
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
 2022-07-20 22:43:53 +03:00
Mark Banner
2f65c79816 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-20 15:50:43 +00:00
Iulian Moraru
3c09fc13df Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE 
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
 2022-07-20 14:57:48 +03:00
Mark Banner
17e34b4715 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-20 10:36:53 +00:00
Mark Banner
5a872b77c5 Bug 1779981 - Migrate search consumers to use ESM imports directly. r=mcheang,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152001
 2022-07-19 17:12:43 +00:00
Mark Banner
a457483c25 Bug 1779981 - Migrate toolkit/components/search and browser/components/search to ESM. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D152000
 2022-07-19 17:12:43 +00:00
Mark Banner
f724fd0ca0 Bug 1779987 - Stop excluding search files from the rejected-words linter. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D151999
 2022-07-19 05:57:15 +00:00
Tooru Fujisawa
54623364da Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Andreea Pavel
7738a75fdd Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
8cd6ed7409 Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-11 15:09:13 +00:00
Tooru Fujisawa
bf93d07148 Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D150894
 2022-07-11 12:41:50 +00:00
Tooru Fujisawa
f3a8c52c53 Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D150893
 2022-07-11 12:41:50 +00:00
mcheang
42807f13f3 Bug 1777632 - Rename all instances of __sortedEngines to _cachedSortedEngines. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D150835
 2022-07-06 11:58:55 +00:00
mcheang
63c59155b7 Bug 1777599 - rename all instances of __searchForm to _cachedSearchForm for clarity. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D150818
 2022-07-05 20:49:18 +00:00
Tooru Fujisawa
9afd92bff5 Bug 1776837 - Part 1: Do not use lazy getter for eagerly loaded modules. r=mossop,webdriver-reviewers,application-update-reviewers,jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D150935
 2022-07-05 01:01:34 +00:00
smolnar
17ec003aab Bug 1777278 - Fix lint failure. CLOSED TREE 2022-06-30 23:10:38 +03:00
mcheang
bb14bd56d3 Bug 1777278 - Change all references of originalEngine to appDefaultEngine in search. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D150599
 2022-06-30 19:26:20 +00:00
Tooru Fujisawa
20942f46aa Bug 1773747 - Part 4: Do not use lazy getter for immediately-used symbol in toolkit/components/search/. r=Standard8 
Depends on D149988

Differential Revision: https://phabricator.services.mozilla.com/D149989
 2022-06-24 11:03:53 +00:00
Mark Banner
5526fffc2a Bug 1775312 - Add simple tests for user and policy engines. r=mak 
Depends on D149929

Differential Revision: https://phabricator.services.mozilla.com/D149930
 2022-06-22 10:51:13 +00:00
Mark Banner
c362058eb9 Bug 1775312 - When reporting an empty submission url to Glean, use a dummy value as it requires a non-empty string. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D149929
 2022-06-22 10:51:12 +00:00
Mark Banner
c6c1957341 Bug 1771173 - Remove unused imports. r=geckoview-reviewers,arai,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D149786
 2022-06-21 20:42:16 +00:00
Mark Banner
568ce7aa90 Bug 1774598 - Rework _initFromManifest to split out its component parts into the separate search engine classes. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D149615
 2022-06-17 20:41:09 +00:00
Mark Banner
a779d524b4 Bug 1774598 - When loading engines from settings, use the OpenSearchEngine class. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D149614
 2022-06-17 20:41:09 +00:00
Mark Banner
906f736d8c Bug 1774598 - Split out WebExtension search engine handling to its own class. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D149613
 2022-06-17 20:41:08 +00:00
Mark Banner
a7f654d177 Bug 1774598 - Split out user search engine handling it its own class. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D149612
 2022-06-17 20:41:08 +00:00
Mark Banner
6e4f33b924 Bug 1774598 - Split out enterprise policy search engine handling into its own class. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D149611
 2022-06-17 20:41:08 +00:00
Tooru Fujisawa
e585a0fd33 Bug 1773829 - Part 12: Stop using lazy getter unnecessarily in toolkit/components/. r=florian 
Depends on D149013

Differential Revision: https://phabricator.services.mozilla.com/D149021
 2022-06-17 20:31:09 +00:00
Chris H-C
fbd0289a78 Bug 1766887 - Mirror some SERP ad instrumentation r=Standard8 
Also track the newtab sessionId (if there was one, e.g. if this started as a
handoff search).

Also also, report the telemetry id of the normal and PBM default search engines

Differential Revision: https://phabricator.services.mozilla.com/D146342
 2022-06-17 20:21:51 +00:00
Cristian Tuns
3e81d4efd8 Backed out 8 changesets (bug 1766887) for causing mochitest failures on browser_newtab_ping.js CLOSED TREE 
Backed out changeset a6b01c1e8823 (bug 1766887)
Backed out changeset 1ef2dd2b779e (bug 1766887)
Backed out changeset f248baea014a (bug 1766887)
Backed out changeset 3f3066906403 (bug 1766887)
Backed out changeset 3ad63b0fa7b8 (bug 1766887)
Backed out changeset 06a0a6ef295a (bug 1766887)
Backed out changeset abe659b175cb (bug 1766887)
Backed out changeset f90e9e70f6d4 (bug 1766887)
 2022-06-17 10:49:00 -04:00
mcheang
6271f9caee Bug 1771759 - Documentation for the different types of search engines such as Open Search Engines, Add-ons, and Policy Engines. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149564
 2022-06-17 13:53:15 +00:00
Chris H-C
51fced142f Bug 1766887 - Mirror some SERP ad instrumentation r=Standard8 
Also track the newtab sessionId (if there was one, e.g. if this started as a
handoff search).

Also also, report the telemetry id of the normal and PBM default search engines

Differential Revision: https://phabricator.services.mozilla.com/D146342
 2022-06-17 13:47:05 +00:00
Tooru Fujisawa
4842565434 Bug 1608282 - Part 3: Remove Cu.importGlobalProperties from JSM. r=extension-reviewers,kmag 
Depends on D149195

Differential Revision: https://phabricator.services.mozilla.com/D149196
 2022-06-16 00:19:54 +00:00
Butkovits Atila
8218713aac Backed out 4 changesets (bug 1608282) for causing hazard failures. CLOSED TREE 
Backed out changeset 32aebc8be201 (bug 1608282)
Backed out changeset 37c970364269 (bug 1608282)
Backed out changeset ced8d82cc2d2 (bug 1608282)
Backed out changeset e26e480c7dd6 (bug 1608282)
 2022-06-16 03:10:02 +03:00
Tooru Fujisawa
26d5bfebf1 Bug 1608282 - Part 3: Remove Cu.importGlobalProperties from JSM. r=extension-reviewers,kmag 
Depends on D149195

Differential Revision: https://phabricator.services.mozilla.com/D149196
 2022-06-15 20:34:35 +00:00
mcheang
c26b27fcfb Bug 1774079 - refactor SearchService to use ES6 class syntax. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149344
 2022-06-15 15:57:33 +00:00
mcheang
6f98b93c83 Bug 1772365 - refactor SearchSuggestionController and SearchSuggestion to use ES6 class syntax. r=adw,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148213
 2022-06-13 14:39:10 +00:00