Commit graph

4174 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
431f95bfde Bug 1790297 - Clean-up -moz-box-emulation-specific rules. r=dao
Most of the display: block stuff isn't needed anymore because we changed
the blockification behavior in bug 1789123.

.tab-stack, and stacks in general now uses CSS grid so doesn't need that
anymore.

DevTools is the only consumer of <xul:iframe> and width/height was
getting ignored in XUL because flexibility takes precedence, so just
remove the relevant declarations.

Differential Revision: https://phabricator.services.mozilla.com/D157070
2022-09-12 13:18:34 +00:00
Itiel
4d221eced0 Bug 1789936 - Revert a part of bug 1774262 to fix styling of focused rows in the Applications menulist on about:preferences r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156898
2022-09-09 15:18:03 +00:00
Itiel
342a3bda43 Bug 1787651 - Update the accent-color var to use the Proton colors, and use it for the Update menuitem dot in about:addons r=desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D155794
2022-09-06 10:56:20 +00:00
Shane Hughes
88ec6bec35 Bug 1789278 - Adjust panel margins on Windows for box shadow. r=emilio
Just add some CSS rules to offset the 4px inner margins on panels so
they position flushly with anchor nodes. Also add a rule so we can click
through the shadow box (closing the popup).

Differential Revision: https://phabricator.services.mozilla.com/D156489
2022-09-05 19:54:45 +00:00
Emilio Cobos Álvarez
13572bce66 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
c520b707bd Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
0777329f69 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
janvi01
c39e6460d8 Bug 1779121 - Picture-in-Picture Seek buttons r=kpatenio,niklas,desktop-theme-reviewers,fluent-reviewers,sfoster,flod
Differential Revision: https://phabricator.services.mozilla.com/D152835
2022-09-01 18:33:10 +00:00
Emilio Cobos Álvarez
d0272e268c Bug 1787246 - Fix color-scheme of tabbrowser tabpanels. r=dao
And stop using the .plain class. Only padding / appearance /
color-scheme are necessary, no other themes set any other properties
reset by .plain.

Differential Revision: https://phabricator.services.mozilla.com/D155699
2022-08-30 12:53:53 +00:00
Eemeli Aro
110a144175 Bug 1784882 - Drop global styles for dlgtype="help". r=desktop-theme-reviewers,dao
After removing the button from MozDialog, the only remaining use in
PageInfo is turned into a local class style.

Differential Revision: https://phabricator.services.mozilla.com/D154872
2022-08-25 11:19:00 +00:00
Dão Gottwald
b6b32fc173 Bug 1785904 - Drop native appearance for menubar menus when using webextension themes, like we already do on Windows. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D155009
2022-08-18 21:07:39 +00:00
Dão Gottwald
8dc7f68beb Bug 1784891 - Consolidate document font-size set by common-shared.css. r=Itiel
Differential Revision: https://phabricator.services.mozilla.com/D154775
2022-08-17 16:50:54 +00:00
Emilio Cobos Álvarez
81834d4c58 Bug 1785155 - Make optgroup background be reflected on Linux with custom select styling. r=dholbert
This matches Windows' behavior with this pref enabled, though I'd note
that might not be the reporter's expectation, since we only style the
caption, which is a sibling rather than an ancestor of the menu items.

That might need further fixes, anyways seems worth doing this
regardless.

Differential Revision: https://phabricator.services.mozilla.com/D154838
2022-08-17 09:12:21 +00:00
Dão Gottwald
db0d8f4dba Bug 1784488 - Fix up SubDialog sizing with em values. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D154646
2022-08-15 21:33:36 +00:00
Emilio Cobos Álvarez
ff538cab0e Bug 1784349 - Don't use -moz-bool-pref for flexbox -moz-box emulation. r=dholbert,perftest-reviewers,sparky
Use a bool pref media query which allows dynamic changes to get
reflected instantly.

Differential Revision: https://phabricator.services.mozilla.com/D154449
2022-08-11 23:22:52 +00:00
Janvi Bajoria
82a08acc5c Bug 1779127 - PIP fullscreen button r=kpatenio,niklas,desktop-theme-reviewers,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152252
2022-08-11 17:08:17 +00:00
Dão Gottwald
fa2c674da8 Bug 1783868 - Stop reducing the opacity of findbar labels. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D154373
2022-08-11 11:29:25 +00:00
Emilio Cobos Álvarez
cf26510de6 Bug 1782858 - Make color-scheme affect Windows' non-native menus. r=desktop-theme-reviewers,dao
This matches what Linux and macOS do, and that allows the fix for bug 1782623
to work on Windows for unstyled selects.

This also simplifies the CSS (though it adds a new system color which is a bit
more annoying). I filed https://github.com/w3c/csswg-drafts/issues/7561 to
propose adding a more generic way to do this in the future (not just for
Firefox).

Differential Revision: https://phabricator.services.mozilla.com/D153549
2022-08-03 20:33:09 +00:00
Sarah Clements
7ad1c6b17a Bug 1768695 - Add error states handling to FirefoxView r=sfoster,fluent-reviewers,desktop-theme-reviewers
* Add new card and styling for network offline, sync error and sync disabled by admin errors
* Change loading spinner to rotating sync svg
* Add tests

Differential Revision: https://phabricator.services.mozilla.com/D153069
2022-08-03 12:14:32 +00:00
Emilio Cobos Álvarez
4fc9841344 Bug 1782623 - Set select color-scheme based on child background. r=dholbert
This makes us use light or dark select popups on supported platforms
based on the background of the select element, which allows us to use
the right scrollbar color.

Depends on D153424

Differential Revision: https://phabricator.services.mozilla.com/D153425
2022-08-02 15:49:13 +00:00
Sandor Molnar
10f6911775 Backed out changeset 8390be8eb18e (bug 1768695) for causing browser-chrome failures in browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js CLOSED TREE 2022-08-02 18:58:22 +03:00
Sarah Clements
f0e1d0730e Bug 1768695 - Add error states handling to FirefoxView r=sfoster,fluent-reviewers,desktop-theme-reviewers
* Add new card and styling for network offline, sync error and sync disabled by admin errors
* Change loading spinner to rotating sync svg
* Add tests

Differential Revision: https://phabricator.services.mozilla.com/D153069
2022-08-02 11:56:23 +00:00
Emilio Cobos Álvarez
18834df73a Bug 1773891 - Remove duplicate tooltip styling. r=dao
I don't think why we have a mobile stylesheet (IIUC Android doesn't have
tooltips...), but I noticed that most tooltip styles are the same and it
should be doable to just unify them in xul.css.

We can't keep the platform-specific bits on their own stylesheet because
it loads _before_ xul.css, and thus overrides wouldn't quite do.

Depends on D151640

Differential Revision: https://phabricator.services.mozilla.com/D151641
2022-07-12 23:00:46 +00:00
Molly Howell
1e6f0c752f Bug 1777456 - Add some width to the PIP explainer box. r=pip-reviewers,kpatenio
With the new description strings added in bug 1774688, it's easier for the
explainer widget to run into the video controls. Making it wider should
make that problem less likely, and also make it read a bit better now.

Differential Revision: https://phabricator.services.mozilla.com/D151415
2022-07-11 17:44:39 +00:00
Itiel
c8628d3f2f Bug 1778156 - Rename the focus outline vars in common-shared.css to be consistent with the rest of the vars r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D151036
2022-07-05 16:52:45 +00:00
Mike Conley
49438bb09a Bug 1774262 - Make search-textbox component easier to theme. r=mstriemer,desktop-theme-reviewers,dao,freddyb
This allows consumers of the component to override the clear search icon
and change the width of the focus outline.

Differential Revision: https://phabricator.services.mozilla.com/D149563
2022-06-30 22:07:01 +00:00
Cosmin Sabou
9e9ab757ca Backed out changeset 7451166dbe99 (bug 1774262) for causing a11y failures on test_txtctrl.xhtml. CLOSED TREE 2022-06-30 22:59:04 +03:00
Mike Conley
92b02b188f Bug 1774262 - Make search-textbox component easier to theme. r=mstriemer,desktop-theme-reviewers,dao,freddyb
This allows consumers of the component to override the clear search icon
and change the width of the focus outline.

Differential Revision: https://phabricator.services.mozilla.com/D149563
2022-06-30 19:11:29 +00:00
smolnar
b55439e310 Backed out changeset cfa4f2bc03ab (bug 1774262) for causing build bustages in searchfield-cancel.svg CLOSED TREE 2022-06-30 21:08:03 +03:00
Mike Conley
84745515a4 Bug 1774262 - Make search-textbox component easier to theme. r=mstriemer,desktop-theme-reviewers,dao,freddyb
This allows consumers of the component to override the clear search icon
and change the width of the focus outline.

Differential Revision: https://phabricator.services.mozilla.com/D149563
2022-06-30 17:38:17 +00:00
Niklas Baumgardner
0049c1fc67 Bug 1775334 - If subtitles settings is showing do not hide controls. r=pip-reviewers,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D150388
2022-06-30 14:41:59 +00:00
Itiel
45e9ae8b24 Bug 1775338 - Various improvements to reader mode r=Gijs,morgan
This includes:
1. Convert most of the color used for light and dark themes to the ones we use for Proton. I haven't touched some grey colors as those are from Photon era and are still in use in most places in the Firefox UI. Also haven't touches the Sepia colors as we don't have a matching theme to copy the colors from.
2. Make the font type buttons look as buttons in HCM.
3. Change the highlight underline color in HCM to SelectedItem and lower it by a few pixels to not overlap with glyphs that descend below the baseline.
4. When Sepia is selected, theme the popups accordingly.
5. Invert the tooltip colors for dark mode as its dark background blends too well with the page's.
6. Round the hover underline in popups.
7. Fix button focusrings to not extend beyond their borders (also theme them accordingly).
8. Fix an issue where scrolling a bit, opening a popup and clicking elsewhere that is not in the content area (say, devtools) would set the toolbar buttons to 0.6 opacity even though the popup is still open.

Differential Revision: https://phabricator.services.mozilla.com/D149921
2022-06-27 21:57:56 +00:00
Emilio Cobos Álvarez
4c5f20179e Bug 1775247 - Implement AccentColor/AccentColorText and remove -moz-prefixed version of the color. r=mstange
As per https://github.com/w3c/csswg-drafts/issues/7347.

Mostly renaming, doesn't change behavior other than exposing the new
color keywords (tested in wpt).

Differential Revision: https://phabricator.services.mozilla.com/D149876
2022-06-22 09:45:06 +00:00
Emilio Cobos Álvarez
b17e800b60 Bug 1772018 - Tweak tooltip colors on Windows. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D149455
2022-06-17 10:01:41 +00:00
Niklas Baumgardner
c150518c01 Bug 1764120 - Subtitle font size settings in PiP window. r=pip-reviewers,desktop-theme-reviewers,mhowell,sfoster,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D144754
2022-06-17 04:16:28 +00:00
criss
915e00a5a7 Backed out changeset c5ce4a2b9ddb (bug 1764120) for causing for causing mochitest failures on browser_fontSize_change.js. CLOSED TREE 2022-06-16 21:59:53 +03:00
Niklas Baumgardner
a64d340499 Bug 1764120 - Subtitle font size settings in PiP window. r=pip-reviewers,desktop-theme-reviewers,mhowell,sfoster,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D144754
2022-06-16 17:49:35 +00:00
Itiel
00db92e7d2 Bug 1770013 - Add full HCM support for reader mode r=desktop-theme-reviewers,morgan,Gijs,dao
Differential Revision: https://phabricator.services.mozilla.com/D146722
2022-06-16 17:16:37 +00:00
Marian-Vasile Laza
309d28caf1 Backed out changeset 1d248d1692ab (bug 1770013) for causing bc failures on browser_parsable_css.js. CLOSED TREE 2022-06-16 19:37:57 +03:00
Itiel
7e2f80af84 Bug 1770013 - Add full HCM support for reader mode r=desktop-theme-reviewers,morgan,Gijs,dao
Differential Revision: https://phabricator.services.mozilla.com/D146722
2022-06-16 15:28:33 +00:00
Gijs Kruitbosch
04ac1e54e3 Bug 1774419 - fix loading-dial.svg to not ship outside of Nightly, r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D149402
2022-06-16 10:45:29 +00:00
Sam Foster
b715ef7498 Bug 1768681 - Implement a loading state for tabs-pickup while we wait for remote tabs to sync. r=fluent-reviewers,desktop-theme-reviewers,dao,Gijs
* Add an animated svg loading spinner similar to pdf.js' loading.svg
* Add loading state strings and update string from previous steps
* Show a loading/syncing step when the last tab sync was greater than 30s ago
* Change the loading state to hide the setup steps and show the tabs list with a loading spinner
* Expose TABS_FRESH_ENOUGH_INTERVAL_SECONDS from SyncedTabs.jsm so we can define it in a single place

Differential Revision: https://phabricator.services.mozilla.com/D147565
2022-06-15 01:18:30 +00:00
Janvi Bajoria
636286877d Bug 1768451 - The PiP's buttons show a highlight on hover when in full screen r=kpatenio,niklas
Differential Revision: https://phabricator.services.mozilla.com/D148251
2022-06-13 20:34:35 +00:00
Emilio Cobos Álvarez
326b996ff8 Bug 1772507 - Implement -moz-window-input-region-margin on Windows. r=handyman
And use it for popups with shadows so that we correctly roll them up if we
click in the shadow area.

Depends on D148361

Differential Revision: https://phabricator.services.mozilla.com/D148362
2022-06-07 23:06:42 +00:00
Emilio Cobos Álvarez
b24faeba30 Bug 1750102 - Add an input-region-margin to widgets, and implement it on Linux. r=stransky
Recompute the input region when resizing the widget and so on, and use
it to check for rollups.

Depends on D148211

Differential Revision: https://phabricator.services.mozilla.com/D148222
2022-06-04 12:41:06 +00:00
Marian-Vasile Laza
c7d153ca29 Backed out changeset c8b026cff732 (bug 1750102) for causing bc failures on browser_test_autoscrolling_in_extension_popup_window.js. CLOSED TREE 2022-06-03 20:12:55 +03:00
Greg Tatum
b0b5b0333b Bug 1759504 - Prototype a UAWidget for TextRecognition r=emilio,nordzilla
Note this is an experiment in getting functionality going for text
recognition. It may be possible to do this more efficiently from
the C++ side of things, but this will allow for rapid experimentation
while working with UX.

Differential Revision: https://phabricator.services.mozilla.com/D143422
2022-06-03 16:01:33 +00:00
Emilio Cobos Álvarez
c6c289ff2d Bug 1750102 - Add an input-region-margin to widgets, and implement it on Linux. r=stransky
Recompute the input region when resizing the widget and so on, and use
it to check for rollups.

Depends on D148211

Differential Revision: https://phabricator.services.mozilla.com/D148222
2022-06-03 10:39:13 +00:00
criss
6362d2b06a Backed out 7 changesets (bug 1759504) for causing Android build bustages on NodeListBinding.cpp
Backed out changeset d1f1173aecfc (bug 1759504)
Backed out changeset a14a874c57b0 (bug 1759504)
Backed out changeset b9beaecf9708 (bug 1759504)
Backed out changeset dc1be2f0e0b6 (bug 1759504)
Backed out changeset a0b089fb747b (bug 1759504)
Backed out changeset b5f762f1f22e (bug 1759504)
Backed out changeset a21b8153ca2a (bug 1759504)
2022-06-02 19:52:05 +03:00
Greg Tatum
952a336446 Bug 1759504 - Prototype a UAWidget for TextRecognition r=emilio,nordzilla
Note this is an experiment in getting functionality going for text
recognition. It may be possible to do this more efficiently from
the C++ side of things, but this will allow for rapid experimentation
while working with UX.

Differential Revision: https://phabricator.services.mozilla.com/D143422
2022-06-02 14:31:42 +00:00