Commit graph

476 commits

Author SHA1 Message Date
Drew Willcoxon
d80536f61f Bug 1386745 - Activated URL/address/location bar makes bookmark doorhanger/panelUI located under "Show site information" button area after landing patch from bug #1352063. r=Gijs
MozReview-Commit-ID: Kzymx5qbp4i

--HG--
extra : rebase_source : a0b5eed918d8c9552c2114acc128ee7f56085653
2017-09-08 10:16:38 -07:00
Marco Bonardo
1e78e32502 Bug 1398019 - Favicons missing in Bookmarks toolbar on startup. r=past
This is due to the fact now we set the icons only when the nodes visibility is updated.
The patch always updates nodes visibility when we rebuild the toolbar.
updateChevron() is being renamed accordingly and acts regardless of chevron.collapsed.

MozReview-Commit-ID: Cz1U710J42M

--HG--
extra : rebase_source : eec1608c106b56b7ef090c52d6b57bedf948741d
2017-09-08 11:43:08 +02:00
Jared Wein
8a5df47f41 Bug 1394588 - Include the gNavToolbox offset in the calculation of the library drop animation. r=Gijs
MozReview-Commit-ID: 90eUNtqE0ee

--HG--
extra : rebase_source : 833a1738599b9620a05859a40e687329a229368a
2017-09-05 14:50:52 -04:00
Jared Wein
8bcd5cb19e Bug 1397236 - Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the library animation. r=Gijs
MozReview-Commit-ID: HXbjhQFCplb

--HG--
extra : rebase_source : ad0ca5e01d4fae85308b7be63ce3953d9767fe12
2017-09-07 03:46:46 -04:00
Mark Banner
3d92d0e6d3 Bug 1397545 - Don't update the recently bookmarks item list when it is hidden and a bookmark is deleted. r=mak
MozReview-Commit-ID: CnbFMONaRil

--HG--
extra : rebase_source : 93fb1713b1ad74f52b9945f71c267f0a27e39426
2017-09-07 10:49:03 +01:00
Marco Bonardo
b3ab6629a6 Bug 1392081 - Reset the Places toolbar view when the toolbar is collapsed. r=Gijs
MozReview-Commit-ID: IFOxCnslZRX

--HG--
extra : rebase_source : 6605bd328273fb283e62a74ee14ca37aaaf6c4c8
2017-08-29 23:26:24 +02:00
Sebastian Hengst
7fe9943c8c Backed out changeset cf5b68506bef (bug 1392081) 2017-09-05 23:11:08 +02:00
Marco Bonardo
7298681f5c Bug 1392081 - Reset the Places toolbar view when the toolbar is collapsed. r=Gijs
MozReview-Commit-ID: IFOxCnslZRX

--HG--
extra : rebase_source : 446fb2849146df0560336bd8cf751d93e18648b3
2017-08-29 23:26:24 +02:00
Jared Wein
d395875dc0 Bug 1393565 - De-duplicate the JS code and CSS that sets the bookmark and pocket library animation. r=Gijs
MozReview-Commit-ID: Z1kIdrY2Um

--HG--
extra : rebase_source : fbff99adf6446d060f32cb49cfdce8a9912da891
2017-08-30 15:58:24 -04:00
Jared Wein
b10d09d78c Bug 1395438 - The bookmarks panel should fade out when it times out, not close abruptly. r=adw
MozReview-Commit-ID: 2alzsK8M9Xb

--HG--
extra : rebase_source : 94deabb9f416ce4f84d42c864bda6ffe9052c62b
2017-08-31 00:27:07 -04:00
Dão Gottwald
7f59f101a8 Bug 1394753 - Remove unstarred48.png. r=mak
MozReview-Commit-ID: EKUEQsOxy50

--HG--
extra : rebase_source : 9e014c80ba2bfae0563dc62af1cf49bca03ad209
2017-08-29 11:51:12 +02:00
Mark Banner
a74cac68c6 Bug 1388687 - Change the recent bookmarks object to only update the menu items when really necessary, and only do a database query when the recent bookmarks need updating. r=mak
MozReview-Commit-ID: J4WxNoTPxkc

--HG--
extra : rebase_source : d4c014b2e1b77bc761a62de49a767f539689ee29
2017-08-21 16:05:30 +01:00
Mark Banner
f75bd69b38 Bug 1388687 - Split out inline functions into members of RecentBookmarksMenuUI to make testing/updates easier. r=mak
MozReview-Commit-ID: 1qD7xmlGa8y

--HG--
extra : rebase_source : b528bd3d1b1ba9d6ccb6a6f5da64f7cea9a8d890
2017-08-10 08:27:36 +01:00
Mark Banner
70cb5355a6 Bug 1388687 - Separate out the recent bookmarks menu code into its own object. r=mak
MozReview-Commit-ID: EhNk4cDLbAH

--HG--
extra : rebase_source : 4afdaef70da7578b3f185e6b11b2155d75d5057b
2017-08-09 11:07:50 +01:00
Jared Wein
e5bbbb1e79 Bug 1384953 - Run the library and pocket animations outside of the navigation-toolbar to workaround z-index issues with the selected tab. r=gijs
MozReview-Commit-ID: dXVThUXdXi
2017-08-09 20:36:17 -04:00
Dão Gottwald
fc65927e70 Bug 1391017 - Use a .bookmark-item placeholder for the bookmarks toolbar items in the toolbar while customizing. r=Gijs
MozReview-Commit-ID: JB9OSshDLKy

--HG--
extra : rebase_source : 2eded7e6868e231ae5ac91a693848cc42a221236
2017-08-23 13:01:06 +02:00
Mike de Boer
25583e0eda Bug 1377968 - Add a tools section and subview to the Bookmarks subview inside the Library widget. r=Gijs
MozReview-Commit-ID: GqbUMbuvYoO

--HG--
extra : rebase_source : 09f489b9b558a9b8dfc0aecbf1ab863d816ee43b
2017-08-15 13:34:41 +02:00
Ursula Sarracini
ae69f895c2 Bug 1388863 - Bookmarking a link via Activity Stream context menu should give feedback r=adw
MozReview-Commit-ID: Bd2eed1rX91

--HG--
extra : rebase_source : 5a2cc568e78c04173d463b84647453d2ebdfedef
2017-08-14 16:27:39 -04:00
Valentin Gosu
3ebf792b66 Bug 1380617 - Change firefox code to use uri.displaySpec when unicode URLs are wanted r=Gijs
* Make URL bar show unicode URL by making losslessDecodeURI call uri.displaySpec
* Make sure URL bar copying returns unicode variant

MozReview-Commit-ID: GTESwOSJW0P
* * *
[mq]: bug1380617-url-autofill.patch

MozReview-Commit-ID: JUxFZcpc3rN
2017-08-09 17:43:51 +02:00
Michael Kohler
674e1b96fb Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao
MozReview-Commit-ID: 8w1vfF2yRui

--HG--
extra : rebase_source : 222d8e9d3b9543552ff5b08967375fa46d62b896
2017-08-08 12:09:14 +02:00
Jared Wein
76f886b972 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs
MozReview-Commit-ID: 40TP43EKPCU

--HG--
extra : rebase_source : 203f7449e8345ed5c779dfc4fd5e9bd515b89da8
2017-08-07 12:37:34 -04:00
Gijs Kruitbosch
768b0621d1 Bug 1385083 - history panel should actually list history, r=mikedeboer
MozReview-Commit-ID: G98QMcmASv0

--HG--
extra : rebase_source : 4a8e533d21d0a4a1d464f1e5f546c82c81fce37f
2017-08-07 15:24:49 +01:00
Sebastian Hengst
ca40024d84 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
45d5f35624 Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao
MozReview-Commit-ID: CoHv9mKpAe

--HG--
extra : rebase_source : 20d6404db9f90cfcb7de03d4c527ad6ed79d49f8
2017-08-05 20:37:40 +02:00
Erica Wright
07f9a3c3a5 Bug 1382570 - Ignore non-left clicks on the bookmark icon. r=Gijs
MozReview-Commit-ID: KrFYUijzawU

--HG--
extra : rebase_source : cd9f323d3fb6889e00dd5427adbb57aa1f8c875e
2017-08-02 16:20:52 -04:00
Gijs Kruitbosch
1409e6926f Bug 1354117 - stop relying on gPhotonStructure in bookmarks/history code, r=adw
MozReview-Commit-ID: FqUFNrSufvQ

--HG--
extra : rebase_source : 91e20d260e2fc227b153366aab09e37fbe99ef57
2017-08-01 19:55:41 +01:00
Gijs Kruitbosch
cf5f0b7624 Bug 1354117 - remove wrap handling for the bookmarks toolbar button and tests verifying it, r=johannh
MozReview-Commit-ID: CeSGIQrDPpw

--HG--
extra : rebase_source : 11a15f98fe7b4fc8fa26152ad5e5e43551cc8a3b
2017-07-31 21:52:06 +01:00
Wes Kocher
949b1032a9 Backed out changeset 4c8cc6044599 (bug 1382570) because it might have caused the spike in browser_page_action_menu.js failures a=backout CLOSED TREE
MozReview-Commit-ID: HCTskH7e4RF
2017-08-03 18:42:02 -07:00
Erica Wright
9932a43a72 Bug 1382570 - Ignore non-left clicks on the bookmark icon. r=Gijs
MozReview-Commit-ID: KrFYUijzawU

--HG--
extra : rebase_source : f607606a0e4dd1e8fe01d385dfd7a9e2544a510b
2017-08-02 16:20:52 -04:00
Marco Bonardo
f32ef43797 Bug 1382991 - Cleanup Places controller InsertionPoint. r=standard8
MozReview-Commit-ID: 2pSbYtPGtYx

--HG--
extra : rebase_source : a66e444f03ad45ff9d9a0e622d1951cff5964082
2017-08-03 12:16:36 +02:00
Mark Banner
78d5f1bdd0 Bug 1094812 - Use Bookmarks.jsm in browser-places.js. r=mak
MozReview-Commit-ID: HJ1NbFMm0l8

--HG--
extra : rebase_source : e212c74f41b89a7f6015e98d0b12029c15c5afd2
2017-07-19 13:50:47 +01:00
Marco Bonardo
7f236c3765 Bug 1094818 - Use Bookmarks.jsm in controller.js. r=standard8
MozReview-Commit-ID: 7vli02K19bt

--HG--
extra : rebase_source : a28bfe52ea3672b5342b44890198703c455e92cb
2017-07-18 19:18:02 +02:00
Mark Banner
0835730b22 Bug 1386197 - Show/Hide recently bookmarked menuitems don't exist in the Library window on Mac, handle the case so to avoid exceptions stopping listeners being removed. r=mak
MozReview-Commit-ID: 6zcw2Q7vRYI

--HG--
extra : rebase_source : 2c1a728fd6f6acf8948e932318718bf0ddfe5148
2017-08-01 11:59:41 +01:00
Jared Wein
35296b8931 Bug 1384145 - Guard the removal of the 'animate' attribute so it only happens in builds with MOZ_PHOTON_ANIMATIONS since the attribute only makes sense when MOZ_PHOTON_ANIMATIONS=True. r=mconley
MozReview-Commit-ID: DuUCYGt5uV2

--HG--
extra : rebase_source : 295cfb32c4fd71007c9863032f95891ed2f8ebeb
2017-07-26 08:53:04 -04:00
Jared Wein
d22613adea Bug 1352063 - Implement new animation for bookmarking. r=Gijs
MozReview-Commit-ID: GDfxtaCNtZo

--HG--
extra : rebase_source : b207c927de65ba58cadbd023fa9974a106c88433
2017-07-24 17:52:44 -04:00
Wes Kocher
405e53a630 Backed out changeset 9202b42e8dcb (bug 1352063) for failures in browser_startup_images.js a=backout
MozReview-Commit-ID: 4sfnaQwjv76

--HG--
extra : rebase_source : 246199563008021af991fb998dd1906924f0e631
2017-07-24 14:38:10 -07:00
Jared Wein
a8397f2404 Bug 1352063 - Implement new animation for bookmarking. r=Gijs
MozReview-Commit-ID: GDfxtaCNtZo

--HG--
extra : rebase_source : b44fde278671bf895c7107336a7a1d248a223f69
2017-07-23 02:45:51 -04:00
Florian Quèze
c41a960d40 Bug 1381853 - lazy load browserPlacesViews.js into the browser window, r=mconley. 2017-07-23 00:17:56 +02:00
Johann Hofmann
39ffb53fce Bug 1371219 - Increase margin of main menu items when accessed through touch. r=mikedeboer
MozReview-Commit-ID: 9gjxxc6O5YS

--HG--
extra : rebase_source : 71cec7055786687a23325ec667d59a2e630f5c57
2017-07-20 16:45:02 +02:00
Mark Banner
de21cc127c Bug 1381049 - Fix cases of async function definitions without await in Places code. r=mak
MozReview-Commit-ID: 3G3BD5SrJ8b

--HG--
extra : rebase_source : 29d06e076a7fda3cf9b2d6089cefb7bd43de1a03
2017-07-14 17:32:22 +01:00
Mark Banner
a18adffa87 Bug 1380570 - Fix setting the title when bookmarking a url from an error page when the url is not found in the history. r=mak
MozReview-Commit-ID: EMuCpR1Sg9G

--HG--
extra : rebase_source : 8d9e97170ff7e1ef331791dcda34180b2181ce21
2017-07-12 22:56:06 +01:00
Marco Bonardo
1c6157f76f Bug 1379611 - Avoid GetItemTitle() synchronous API in editBookmarkOverlay.js. r=standard8
MozReview-Commit-ID: 9Ig63XHcEIE

--HG--
extra : rebase_source : 8a1ff8778f00075c8741bf3a8ee3367ddf848260
2017-07-10 16:13:55 +02:00
Marco Bonardo
c4a765574b Bug 1379611 - Avoid GetFolderIdForItem() synchronous API in editBookmarkOverlay.js. r=standard8
MozReview-Commit-ID: LLikbxfAN4u

--HG--
extra : rebase_source : b16980fdfee12533355acc63d16944882ed64870
2017-07-10 15:37:55 +02:00
Mark Banner
6ba07150a4 Bug 1377599 - Fix typos to make the Star UI remove bookmarks correctly, and add an extra hook to ensure the tests passes in async mode. r=mak
MozReview-Commit-ID: FGBq9GTP2sB

--HG--
extra : rebase_source : 84147c433f8a6b86b493708bf71f0739cbf244af
2017-07-12 17:35:59 +01:00
Johann Hofmann
a84fe102d8 Bug 1377802 - Check if bookmarking UI is visible before anchoring bookmarking popup. r=mak
This also avoids flushing when bounds checking the identity popup for visibility.

MozReview-Commit-ID: EBUR7RIB0w6

--HG--
extra : rebase_source : 496811988d26be3065888845c699663f0cc20d52
2017-07-11 23:17:07 +02:00
Marco Bonardo
bfc44708bc Bug 1371677 - Delay the database connection in the history service as far as possible. r=adw
Makes initing Places services cheaper, by delaying the connection creation to the first time
it's actually needed.
Same way, delays reading the bookmark roots at the first time they are requested.
Deprecates the concept of lazy observers, since they are no more needed, we can just use addObserver.
Simplifies the startup path: always sends "places-init-complete" (both as a category and a topic) when
the connection starts and adds a "locked" database state when we can't get a working connection.
Makes PlacesCategoriesStarter register for the new category, since it's cheaper than being a bookmarks
observer.
Fixes a couple race conditions in keywords and expiration due to new startup timings.
Removes a test in test_keywords.js that is no more easily feasible, since it'd requires a pre-build
places.sqlite that should be kept up-to-date at every version.

MozReview-Commit-ID: 6ccPUZ651m0

--HG--
extra : rebase_source : 07376076eb42c84caaedeffd75f133d83a6c3d70
2017-06-09 18:51:09 +02:00
Mike de Boer
702aa1332c Bug 1354159 - Part 3 - Add a Bookmarks button to the Library panel that shows a subview with a list of most recent bookmarks. r=Gijs,mak
This patch changes the Recent Bookmarks flow in browser-places.js to use the new
PlacesPanelview to provide a rich view that support drag and drop and context
actions.
A new button 'Search Bookmarks' was added, which prefills the urlbar with '* ',
which is a shortcut for searching bookmarks using the Awesomebar.

MozReview-Commit-ID: 1XlO8HMKEJs

--HG--
extra : rebase_source : 59cdf8a24341eb5df55511c5be83ebee8787aad5
2017-06-29 17:57:25 -07:00
Mike de Boer
0da1ebf2ab Bug 1354159 - Part 1 - Remove the unneeded third 'view' argument from PlacesUIUtils.openNodeWithEvent(). r=mak
MozReview-Commit-ID: Jema2qMYEdX

--HG--
extra : rebase_source : 9cd5850e7c306ff62f9751ce419a278e8978b04e
2017-06-29 17:57:22 -07:00
Gijs Kruitbosch
dd070a9e91 Bug 1352120 - move the bookmarks star into the url bar, r=mak
MozReview-Commit-ID: Ka5Wn2hrb1P

--HG--
extra : rebase_source : e22d25295066386c4becc1a430b78aaa9c40ae4f
2017-06-23 17:35:59 +01:00
Rajesh Kathiriya
fafb858b26 Bug 1370225 - Enabled the ESLint comma-style rule across mozilla-central. r=standard8
MozReview-Commit-ID: 9OhLgBpYS4L

--HG--
extra : rebase_source : 5155e715934e7acd2ffadb4856eb91f481cbf56c
2017-06-15 18:24:17 +01:00