nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
829843 commits 1 branch 98 tags 6.4 GiB
Commit graph

84 commits

Author SHA1 Message Date
Andreas Pehrson
d1a36ee5d5 Bug 1813468 - Signal start and stop to MediaPipeline through state mirroring. r=bwc 
Differential Revision: https://phabricator.services.mozilla.com/D168727
 2023-02-09 15:33:01 +00:00
Andreas Pehrson
9d815d4c33 Bug 1813468 - Rework RTCRtpReceiver unmute logic through Watchables. r=bwc 
This patch makes RTCRtpReceiver in charge of mute and unmute decisions directly.
MediaPipeline still informs about unmuting after receiving the first RTP packet.

This also removes a dependency on `RTCRtpReceiver::Stop` that is out of sync
with `mReceiving = false`.

Differential Revision: https://phabricator.services.mozilla.com/D168726
 2023-02-09 15:33:01 +00:00
Andreas Pehrson
df94e1e4de Bug 1813468 - In RemoteTrackSource add a ref to RTCRtpReceiver to prevent GC at the wrong time. r=bwc 
Differential Revision: https://phabricator.services.mozilla.com/D168724
 2023-02-09 15:33:00 +00:00
Andreas Pehrson
11a514f0d4 Bug 1813468 - Remove RemoteTrackSource from MediaPipeline. r=bwc 
Differential Revision: https://phabricator.services.mozilla.com/D168722
 2023-02-09 15:32:59 +00:00
Andreas Pehrson
ee8df7af6e Bug 1813468 - Move unmute-after-enabling logic out of MediaPipeline into RTCRtpReceiver. r=bwc 
Differential Revision: https://phabricator.services.mozilla.com/D168721
 2023-02-09 15:32:59 +00:00
Andreas Pehrson
5b10e4fd58 Bug 1813468 - Make RemoteTrackSource an RTCRtpReceiver member and add it to CC traversal. r=bwc 
Differential Revision: https://phabricator.services.mozilla.com/D168719
 2023-02-09 15:32:58 +00:00
Andreas Pehrson
bd2859df20 Bug 1813468 - Trigger setting the private PrincipalHandle in MediaPipeline through RTCRtpReceiver. r=bwc 
This removes one dependency in MediaPipeline on RemoteTrackSource.

Differential Revision: https://phabricator.services.mozilla.com/D168718
 2023-02-09 15:32:57 +00:00
Andreas Pehrson
dd8b6edb48 Bug 1813468 - Use an enum for principal privacy in PeerConnectionImpl and friends. r=bwc 
Differential Revision: https://phabricator.services.mozilla.com/D168717
 2023-02-09 15:32:57 +00:00
Byron Campen
82e964f5c5 Bug 1815328: Add mediaType back, since there are still services that use it (somehow). r=jib,webidl,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D169106
 2023-02-08 15:32:30 +00:00
Byron Campen
73d5fe4032 Bug 1225718: Make RTCRtpStreamStats.kind/ssrc required, and remove mediaType. r=ng,webidl,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D168601
 2023-02-03 16:34:24 +00:00
Byron Campen
b44097a83f Bug 1728357: Implement framesDropped. r=ng,webidl,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D168582
 2023-02-03 00:35:43 +00:00
Byron Campen
7769d3635e Bug 1804676: Implement RTCInboundRtpStreamStats.trackIdentifier r=ng,webidl,smaug 
Depends on D168607

Differential Revision: https://phabricator.services.mozilla.com/D168608
 2023-02-02 22:06:23 +00:00
Byron Campen [:bwc]
0efa8a54b5 Bug 1800136: Make RTCRtpSender::GetStats get ICE stats. r=ng 
Also fix bugs where we would get duplicate ICE stats. This mostly mattered to
WebrtcGlobalInformation since RTCStatsReportInternal does not automatically
remove duplicate ids like RTCStatsReport (RTCStatsReport is maplike).

Differential Revision: https://phabricator.services.mozilla.com/D162322
 2022-12-22 15:29:02 +00:00
Cristian Tuns
94af79dc93 Backed out 4 changesets (bug 1800136) for causing build bustages CLOSED TREE 
Backed out changeset fe152aff2a22 (bug 1800136)
Backed out changeset 99ea4f221834 (bug 1800136)
Backed out changeset 5801060dd3d0 (bug 1800136)
Backed out changeset a80074bc3200 (bug 1800136)
 2022-12-21 22:13:37 -05:00
Byron Campen [:bwc]
336686074a Bug 1800136: Make RTCRtpSender::GetStats get ICE stats. r=ng 
Also fix bugs where we would get duplicate ICE stats. This mostly mattered to
WebrtcGlobalInformation since RTCStatsReportInternal does not automatically
remove duplicate ids like RTCStatsReport (RTCStatsReport is maplike).

Differential Revision: https://phabricator.services.mozilla.com/D162322
 2022-12-22 02:33:57 +00:00
Butkovits Atila
472bb85fa9 Backed out 4 changesets (bug 1800136) for causing build bustages at PeerConnectionCtx.cpp. CLOSED TREE 
Backed out changeset fb1a765ec213 (bug 1800136)
Backed out changeset 3621f5bf1cb0 (bug 1800136)
Backed out changeset d2ace48b830c (bug 1800136)
Backed out changeset 8e09b3e06b10 (bug 1800136)
 2022-12-21 10:03:48 +02:00
Byron Campen [:bwc]
dd8d375ce3 Bug 1800136: Make RTCRtpSender::GetStats get ICE stats. r=ng 
Also fix bugs where we would get duplicate ICE stats. This mostly mattered to
WebrtcGlobalInformation since RTCStatsReportInternal does not automatically
remove duplicate ids like RTCStatsReport (RTCStatsReport is maplike).

Differential Revision: https://phabricator.services.mozilla.com/D162322
 2022-12-20 22:12:10 +00:00
Andreas Pehrson
2ed52d6125 Bug 1796069 - Annotate MediaStreamTrackSources with a tracking id and apply it to CopyVideoStages. r=padenot 
This will allow time consuming tasks (copies, capture, etc.) along the pipe to
be grouped per-track-source when visualizing profiler markers.

Differential Revision: https://phabricator.services.mozilla.com/D160754
 2022-12-01 09:52:46 +00:00
Michael Froman
ce2a0081ba Bug 1790097 (MOZ) - handle upstream change to use webrtc::TimeDelta for total_decode_time 2022-10-25 22:50:07 -05:00
Michael Froman
0a6a0e5d52 Bug 1790097 (MOZ) - handle upstream removing deprecated AudioReceiveStream for AudioReceiveStreamInterface 
Also fix the deprecation warnings for VideoReceiveStream by using VideoReceiveStreamInterface.
 2022-09-22 14:11:34 -05:00
Nico Grunbaum
da1cf2599a Bug 1790508 - Add new RTP and RTCP stats post libwebrtc fast-forward;r=dbaker,mjf,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D157167
 2022-09-15 22:38:43 +00:00
criss
2260491bf2 Backed out changeset 44c7e645f9c4 (bug 1790508) for causing mochitest failures. CLOSED TREE 2022-09-15 17:44:53 +03:00
Nico Grunbaum
d1408f8496 Bug 1790508 - Add new RTP and RTCP stats post libwebrtc fast-forward;r=dbaker,mjf,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D157167
 2022-09-15 09:23:41 +00:00
Butkovits Atila
8ef8248f4a Backed out changeset 99c66f2c4097 (bug 1790508) for causing wpt failures. CLOSED TREE 2022-09-15 06:20:33 +03:00
Nico Grunbaum
c0c6652785 Bug 1790508 - Add new RTP and RTCP stats post libwebrtc fast-forward;r=dbaker,mjf,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D157167
 2022-09-15 00:50:09 +00:00
Dan Baker
91082459f4 Bug 1788790 - Using TimeDelta instead of TimeStamp to allow for negative values when given non spec ntp;r=pehrsons 
Differential Revision: https://phabricator.services.mozilla.com/D156243
 2022-09-12 22:15:33 +00:00
Dan Baker
43da894f09 Bug 1788790 - Fixing static analysis error.;r=ng 
Differential Revision: https://phabricator.services.mozilla.com/D157160
 2022-09-12 22:15:32 +00:00
Olli Pettay
93acdfad59 Bug 1777574, automate CC zone handling, r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D155084
 2022-09-07 11:22:51 +00:00
Byron Campen
390d075796 Bug 1769802: Call the success callback for sRD/sLD after the JS work is done. r=jib,webidl,smaug 
This fixes a class of bugs where modifications to the RTCRtpTransceivers were
applied before sRD/sLD were completely done (while all of the JSEP and transport
stuff was finished, JS could still be working on identity-related stuff).

Differential Revision: https://phabricator.services.mozilla.com/D150173
 2022-08-05 14:03:45 +00:00
Byron Campen
6c8a78a85a Bug 1769802: Ensure that PeerConnectionImpl is in charge of unlinking (except when it shouldn't be, ugh). r=mjf 
The previous changeset was causing nullptr crashes because RTCRtpTransceiver
was performing an unlink before PeerConnectionImpl got a chance to close. It is
likely that there were already ways to trigger this bug.

Differential Revision: https://phabricator.services.mozilla.com/D150172
 2022-08-05 14:03:45 +00:00
Byron Campen
7b4149d838 Bug 1769802: Stop holding a reference to the JsepTransceiver in RTCRtpSender/Receiver. r=mjf 
This will make it easier to replace the JsepTransceiver a given
RTCRtpTransceiver is using, which is necessary if we're going to be
deep-copying and replacing the JSEP engine.

Differential Revision: https://phabricator.services.mozilla.com/D150171
 2022-08-05 14:03:44 +00:00
Jeff Muizelaar
2a6bb59540 Bug 1780282 - Implement some more inbound rtp stats. r=ng,emilio 
These are the inbound rtp stats that are P2 for MS Teams.

Differential Revision: https://phabricator.services.mozilla.com/D152213
 2022-07-22 00:47:31 +00:00
Byron Campen
918543a8e9 Bug 1586109: Move RTCRtpTransceiver to c++. r=mjf,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D145679
 2022-05-10 18:07:19 +00:00
Butkovits Atila
6683515559 Backed out changeset c11ccbe584a2 (bug 1586109) for causing toolchains bustages on central. CLOSED TREE 2022-05-10 08:19:09 +03:00
Byron Campen
3a6dbeb8f4 Bug 1586109: Move RTCRtpTransceiver to c++. r=mjf,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D145679
 2022-05-09 14:30:41 +00:00
Butkovits Atila
ea12341925 Merge autoland to mozilla-central. a=merge 2022-05-03 00:36:36 +03:00
Peter Van der Beken
e77783380e Bug 1766130 - Properly propagate errors from Promise creation. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D144515
 2022-05-02 07:44:23 +00:00
Jeff Muizelaar
6e2effa62e Bug 1766473. Implement some inbound-rtc/outbound-rtc stats needed for MS Teams. r=ng,emilio 
The calculation of framesSent/framesReceved matches webrtc_video_engine.cc.

framesSent:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/media/engine/webrtc_video_engine.cc;l=2611;drc=edab26bf11e993e5069d433e8c2186ad2dee012e

framesReceived:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/media/engine/webrtc_video_engine.cc;l=3159;drc=edab26bf11e993e5069d433e8c2186ad2dee012e

Differential Revision: https://phabricator.services.mozilla.com/D144724
 2022-04-27 19:12:37 +00:00
Byron Campen
e95e4b7b05 Bug 1763435: Implement RTCInboundRtpStreamStats.framesPerSecond. r=ng,webidl,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D144007
 2022-04-26 14:07:37 +00:00
Byron Campen
6bd040b9d9 Bug 1616937: Move some sender and receiver logic to RTCRtpSender/Receiver. r=mjf 
Differential Revision: https://phabricator.services.mozilla.com/D142385
 2022-04-05 18:39:14 +00:00
Byron Campen
f4c5bad5c0 Bug 1616937: Improve error handling during conduit updates. r=mjf 
Most of the errors we check for here should never happen, so crash/assert where
appropriate. Also, handle the codec negotiation failure case outside of the
conversion function, where we can log it better.

Differential Revision: https://phabricator.services.mozilla.com/D142384
 2022-04-05 18:39:14 +00:00
Byron Campen
d582c03bab Bug 1616937: Hold strong refs to the PC in Transceiver/Sender/Receiver. r=mjf 
These are cycle collected, so no need to use this weakptr stuff.

Differential Revision: https://phabricator.services.mozilla.com/D142383
 2022-04-05 18:39:14 +00:00
Byron Campen
571c7afb5b Bug 1616937: Remove main thread parameters/members. r=mjf 
This ability to set the main thread has never been used, and in many cases is
not possible due to things being cycle collected (and therefore
main-thread-only).

Differential Revision: https://phabricator.services.mozilla.com/D142382
 2022-04-05 18:39:13 +00:00
Byron Campen
d15909a769 Bug 1616937: Move RTCRtpSender to c++ r=mjf,webidl,smaug 
Also involves moving identity-related stuff to MediaPipelineTransmit.

Differential Revision: https://phabricator.services.mozilla.com/D141770
 2022-04-05 18:39:13 +00:00
Byron Campen
6dc2f82017 Bug 1756222: Do not disable SSRC switching if there were no a=ssrc attributes in the remote SDP. r=mjf 
Differential Revision: https://phabricator.services.mozilla.com/D140236
 2022-03-09 16:23:31 +00:00
Nils Ohlmeier
1f04e76928 Bug 1754027: disable SSRC changes for bundled audio RTP r=bwc 
Differential Revision: https://phabricator.services.mozilla.com/D138244
 2022-02-16 00:02:04 +00:00
Byron Campen
ed0747f425 Bug 1753938: Return a resolved promise instead of a nullptr here. r=jib 
Differential Revision: https://phabricator.services.mozilla.com/D138047
 2022-02-10 22:34:25 +00:00
Andreas Pehrson
82fa5caa68 Bug 1225722 - Wire up RTCCodecStats from GetStats. r=bwc,jib 
This patch contains the plumbing work for taking all coalesced codec stats
for a peer connection and mapping them to rtp stream stats and their codecIds.

It depends on two skeleton methods; one for populating and coalescing all codec
stats to transport level, and one for filtering out only the codec stats
referred to by rtp stream stats.

Differential Revision: https://phabricator.services.mozilla.com/D135865
 2022-02-01 23:12:27 +00:00
Andreas Pehrson
362e85af4b Bug 1225722 - Modularize RTCStatsIdGenerator::RewriteIds somewhat. r=bwc 
Differential Revision: https://phabricator.services.mozilla.com/D135864
 2022-02-01 23:12:27 +00:00
Andreas Pehrson
893ac95145 Bug 1751532 - Do not expose rtp stream stats until there is packet flow. r=jib 
Differential Revision: https://phabricator.services.mozilla.com/D137042
 2022-01-27 16:23:52 +00:00