Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198826
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198825
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html
- this patch also resolves Bug 1872919 by adding a scroll into view during the `search_synced_tabs_recent_browsing` test
Differential Revision: https://phabricator.services.mozilla.com/D196347
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html
Differential Revision: https://phabricator.services.mozilla.com/D196347
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html
Differential Revision: https://phabricator.services.mozilla.com/D196347
The Firefox View provides a custom menu for Open Tab links. This menu is attempted to be clicked [twice](https://searchfox.org/mozilla-central/rev/6321fb8f7533456a62dfa2aa68ee0477a6c8f693/browser/components/firefoxview/tests/browser/firefoxview-next/browser_opentabs_firefoxview_next.js#134,238) in the test file `browser/components/firefoxview/tests/browser/firefoxview-next/browser_opentabs_firefoxview_next.js`. But since the `<panel-item>` itself has a role of `presentation` and is serving as a container for an accessible `<button role="menuitem">`, the automatic accessibility checks are flagging these clicks as ones on a non-accessible elements. We can update the test case to send a click on a `menuitem` itself to ensure the test is working as expected too, since the keyboard-only users and users of assistive technology would be activating the menuitem.
Since this would allow the a11y_checks to test an actual control and we expect these tests to pass, we need to update the `fail-if` notation in the test manifest to exclude the `panel-item` failure.
Differential Revision: https://phabricator.services.mozilla.com/D197727
- removes all old View related files and assets
- removes legacy telemetry
- removes tests related to prefs that have since been removed
- remove `browser_all_files_referenced.js` exceptions added in Bug 1869833
Depends on D196093
Differential Revision: https://phabricator.services.mozilla.com/D196208
- removes all old View related files and assets
- removes legacy telemetry
- removes tests related to prefs that have since been removed
- remove `browser_all_files_referenced.js` exceptions added in Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196208
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196093
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196093
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196093
This patch removes all tests covering the old Firefox View whilst preserving those that cover Next.
- Removed tests that have been replaced/amended for the new incarnation of View can be found in browser/components/firefoxview/tests/browser/firefoxview-next/.
- Test coverage that still requires porting over to the new incarnation is documented in bug 1869643.
- `browser_sma_open_firefoxview.js` also removed as referenced in meta bug 1850501.
- Skip feature callout tests as tests reference legacy view elements which are removed in bug 1869833. Feature callout to be removed in bug 1870296
- Remove `browser_sma_click_element.js` as tests reference legacy view elements which are removed in bug 1869833
Ideally this patch will be landed alongside patches that:
- update the view pref
- update the about redirector
- remove all legacy Firefox View files and assets
Differential Revision: https://phabricator.services.mozilla.com/D196080
When the D195198 would be ready to land, there are a few tests that are going to be passing all a11y-checks or some of them, thus we need to update the manifest to remove `skip-if` notations when appropriate and update the comments in the remaining tests
Depends on D195198
Differential Revision: https://phabricator.services.mozilla.com/D195745
Several `show-all-link` controls lack interactive role - this would prevent users of speech-to-text/Voice Control from being able to send a click to it by calling its label and screen reader users and users of other assistive technology would not be able to get to this control via shortcuts like a list of controls, etc. Being focusable with keyboard does not guarantee that assistive technology could guess that this programmatically static text is, in fact, interactive.
While providing an explicit ARIA `role` to the element is going [against the First Rule of ARIA](https://www.w3.org/TR/using-aria/#rule1) while semantically appropriate HTML elements exist - `<a>` anchor (for the visual appearance of this control) or `<button>` (for the actual functionality that this control performs) - this patch would at least remove the barrier for assistive technology to be able to set interactivity expectations to this control appropriately.
No test manifests are being updated, because there are other elements in the updated test files that are failing a11y-checks, besides these `show-all-link` controls.
Differential Revision: https://phabricator.services.mozilla.com/D197349
- removes about:firefoxview-next route
- about:firefoxview now points to firefoxview-next.html (until we rename)
- remove pref for browser.tabs.firefox-view-next
- preserve pref for browser.tabs.firefox-view-newIcon as part of firefoxViewNext feature manifest (until experiment is over)
Depends on D196080
Differential Revision: https://phabricator.services.mozilla.com/D196093
This patch removes all tests covering the old Firefox View whilst preserving those that cover Next.
- Removed tests that have been replaced/amended for the new incarnation of View can be found in browser/components/firefoxview/tests/browser/firefoxview-next/.
- Test coverage that still requires porting over to the new incarnation is documented in bug 1869643.
- `browser_sma_open_firefoxview.js` also removed as referenced in meta bug 1850501.
Ideally this patch will be landed alongside patches that:
- update the view pref
- update the about redirector
- remove all legacy Firefox View files and assets
Differential Revision: https://phabricator.services.mozilla.com/D196080
This patch removes all tests covering the old Firefox View whilst preserving those that cover Next.
- Removed tests that have been replaced/amended for the new incarnation of View can be found in browser/components/firefoxview/tests/browser/firefoxview-next/.
- Test coverage that still requires porting over to the new incarnation is documented in bug 1869643.
- `browser_sma_open_firefoxview.js` also removed as referenced in meta bug 1850501.
Ideally this patch will be landed alongside patches that:
- update the view pref
- update the about redirector
- remove all legacy Firefox View files and assets
Differential Revision: https://phabricator.services.mozilla.com/D196080
