Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198831
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198830
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198826
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198825
I started hitting search issues with my change in D196494 and with other experiments to use more reusable components in about:preferences. We'll likely have to keep adding new elements to `searchWithinNode`, but changing `textNodeDescendants` to look for text nodes in the shadow DOM seems like a generally helpful change + gets the highlighting working properly.
Differential Revision: https://phabricator.services.mozilla.com/D197120
Add a temporary check in AccessibilityUtils to pass clicks on inacessible richlistbox treecol so we could remove the `fail-if` notations from the affected test manifests until the bug 1848397 is being resolved. This would allow a11y-checks to continue monitor these affected tests and to avoid unknowingly introducing new inaccessible controls because of that.
When the bug 1848397 is fixed, remove the temporary check introduced in this patch.
Differential Revision: https://phabricator.services.mozilla.com/D196376
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.
While here, we add more logging to this interaction to allow easier
debugging with QA.
Differential Revision: https://phabricator.services.mozilla.com/D194949
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.
While here, we add more logging to this interaction to allow easier
debugging with QA.
Differential Revision: https://phabricator.services.mozilla.com/D194949
This removes the pref to re-enable the legacy wizard, and all of the things that used
to read from it.
It also disables the ability to use the legacy wizard from about:welcome with the
aboutWelcomeBehavior feature.
It also removes the closeMigrationWizard utility from BrowserTestUtils, since that
effectively became a thin-wrapper around BrowserTestUtils.removeTab.
Finally, this patch also removes some documentation about the legacy migration wizard,
and tests that specifically check the legacy dialog behaviour.
Differential Revision: https://phabricator.services.mozilla.com/D190716
Attempt to find other link elements in the document and insert the injected
stylesheets after those. Strictly speaking we could probably just insert them
at the end of the document but this at least keeps them together with other
link elements to aid in inspecting. Falls back to using the XML processing
instruction in hte unlikely case that no other link elements are present.
Differential Revision: https://phabricator.services.mozilla.com/D190679
This removes "best match" as its own separate Firefox Suggest feature. In the
future, whether or not a suggestion is a best match (a.k.a. top pick) will be
determined by relevant product requirements. I've confirmed this with Nive.
Here's a summary of changes:
* Removes prefs and Nimbus variables related to best match
* Removes the "Top pick" checkbox in about:preferences
* Removes support for the `best_match` quick suggest config property. This
property was removed from the config in remote settings a while ago.
* Removes legacy telemetry scalars related to best match. These scalars were
added years ago for the original best match experiment and before we started
using Glean. In the case of non-sponsored suggestions, the scalars have not
been recorded at all for some time. In the case of sponsored suggestions, they
can now be recorded again due to the recent addition of sponsored priority
suggestions, but they are superseded by Glean.
Differential Revision: https://phabricator.services.mozilla.com/D190516
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to fail-if the failing tests altogether and then handle each one of them individually.
This task is to add `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Settings UI-specific meta bug 1854637
- Explore capturing click events for a11y_checks: bug 1692110
Depends on D188990
Differential Revision: https://phabricator.services.mozilla.com/D188991
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.
This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Settings UI-specific meta bug 1854637
- Explore capturing click events for a11y_checks: bug 1692110
Differential Revision: https://phabricator.services.mozilla.com/D188991
There's now a dedicated nsIQuotaManagerService::ClearStoragesForOriginPrefix
method for clearing storages for origin prefix. All callers of
nsIQuotaManagerService::ClearStoragesForPrincipal which want to clear all
storages for given origin prefix can be now converted to call the new method.
Changed done in this patch:
- replaced some nsIQuotaManagerService::ClearStoragesForPrincipal calls with
nsIQuotaManagerService::ClearStoragesForOriginPrefix
Differential Revision: https://phabricator.services.mozilla.com/D186778
This is weirdly placed in the colors dialog, and adds a global selector
to the UA sheet for no great reason.
This sub-setting doesn't really make a lot of sense. We don't let you
force underlines in any way, so any site CSS will override it (unlike
colors, where you can actually override the site).
Just move this to the UA sheet properly.
Differential Revision: https://phabricator.services.mozilla.com/D188326
This patch adds a RFP warning banner shown when there is a RFP pref
enabled. Firefox has two prefs for RFP, one for normal windows and
another for private windows.
The warning banner contains a learn more linke for users to learn more
about the warning.
Differential Revision: https://phabricator.services.mozilla.com/D187451
