nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
870454 commits 1 branch 98 tags 6.4 GiB
Commit graph

219 commits

Author SHA1 Message Date
Niklas Baumgardner
97703c5be8 Bug 1875109 - Add screenshots button to start of toolbar for tests. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D199100
 2024-01-22 17:53:07 +00:00
Niklas Baumgardner
aca7845a56 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-19 22:08:30 +00:00
Stanca Serban
a56fab1284 Backed out changeset 9df2731a0530 (bug 1867644) for causing mochitests failures in browser_contentAltClick.js on OSX. CLOSED TREE 2024-01-20 03:59:49 +02:00
Niklas Baumgardner
c922147937 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-19 22:08:30 +00:00
Erik Nordin
57d4903df0 Bug 1875090 - Rename ContentTaskUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,sgalich 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198831
 2024-01-19 02:15:34 +00:00
Erik Nordin
2a01092c90 Bug 1875090 - Rename BrowserTestUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,bytesized,sfoster 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198826
 2024-01-19 02:15:33 +00:00
Erik Nordin
736a5983b8 Bug 1875090 - Rename BrowserTestUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,mhowell 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198825
 2024-01-19 02:15:33 +00:00
Natalia Csoregi
5fd68dd6cb Backed out changeset c6a30d94edf2 (bug 1867644) for causing failures on browser_screenshots_drag_test.js. CLOSED TREE 2024-01-19 03:46:03 +02:00
Niklas Baumgardner
0c9ea25838 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-19 00:07:46 +00:00
Iulian Moraru
c2befb5de7 Backed out changeset 2b70f662a797 (bug 1867644) for causing bc failures on browser_overlay_keyboard_test.js. CLOSED TREE 2024-01-18 22:14:11 +02:00
Niklas Baumgardner
fbd83453f3 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-18 17:47:54 +00:00
Niklas Baumgardner
8537612432 Bug 1873977 - Reset hover element region when retrying screenshot. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D198202
 2024-01-17 16:17:42 +00:00
Niklas Baumgardner
6fedd4b29e Bug 1873882 - Canceling screenshots selected state should go to crosshairs state. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D198468
 2024-01-17 01:18:08 +00:00
Niklas Baumgardner
10e944bf30 Bug 1872764 - Screenshots should always get events. r=sfoster,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D197802
 2024-01-12 02:24:43 +00:00
Niklas Baumgardner
3126ddf62c Bug 1874014 - Check that screenshots anchor is connected to document. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D198199
 2024-01-11 18:51:57 +00:00
Sam Foster
f3819a9d6c Bug 1820015 - Make the screenshots UI keyboard accessible. r=niklas 
* Move the chrome panel buttons into a `box` which is inserted into #navigator-toolbox
* Adjust what open/closed means using hidden instead
* Capture a weak ref to the focused element on open, and attempt to put focus back on exit
* Add some restore-focus tests
* Fix a bug where cancel via overlay "X" button wasn't exiting properly
* Place initial focus in the preview dialog button on the download button

Differential Revision: https://phabricator.services.mozilla.com/D181184
 2023-12-18 19:01:44 +00:00
Niklas Baumgardner
d4aaf4bd0c Bug 1801954 - Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D192109
 2023-12-01 16:07:25 +00:00
Stanca Serban
7b0cb90122 Backed out changeset 87051213c0bc (bug 1801954) for causing mochitests failures in browser_overlay_keyboard_test.js and on OSX. CLOSED TREE 2023-12-01 03:44:32 +02:00
Niklas Baumgardner
9d29449b10 Bug 1801954 - Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D192109
 2023-11-30 22:11:53 +00:00
Niklas Baumgardner
9c82fcdb22 Bug 1864889 - Only allow left mouse button on screenshots overlay. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D193680
 2023-11-28 02:33:17 +00:00
Niklas Baumgardner
31d21cfa94 Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-14 15:57:46 +00:00
Norisz Fay
ba48d1612a Backed out changeset 9ec09eb75c9f (bug 1842037) for causing bc failures on browser_screenshots_drag_test.js CLOSED TREE 2023-11-14 04:06:58 +02:00
Niklas Baumgardner
cf3a00db17 Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-13 23:57:17 +00:00
Niklas Baumgardner
37309c10f6 Bug 1862663 - Rename panel-footer-button to footer-button for screenshots buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D192580
 2023-11-02 18:07:29 +00:00
Niklas Baumgardner
5dbfeaed58 Bug 1859882 - Make sure screenshots overlay isn't bigger than document. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191349
 2023-11-02 18:06:38 +00:00
Norisz Fay
3a022002da Backed out changeset 80cec114b8a6 (bug 1859882) for causing bc failures on browser_screenshots_telemetry_tests.js 2023-11-01 18:00:54 +02:00
Niklas Baumgardner
a5dd2648f5 Bug 1859882 - Make sure screenshots overlay isn't bigger than document. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191349
 2023-11-01 15:06:22 +00:00
Niklas Baumgardner
88213c35d4 Bug 1860611 - Do not skip test_content_events screenshots test. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191667
 2023-10-24 01:04:09 +00:00
Niklas Baumgardner
9e9cc7579b Bug 1855313 - Show current selection size in screenshots overlay. r=sfoster,fluent-reviewers,desktop-theme-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D189312
 2023-10-20 23:25:37 +00:00
Niklas Baumgardner
47be6b9a07 Bug 1859394 - Use global styles for screenshots panel buttons. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D191213
 2023-10-20 21:20:58 +00:00
Niklas Baumgardner
bce29cb41b Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D190491
 2023-10-19 02:11:48 +00:00
Cosmin Sabou
4d7de2f1be Backed out changeset 08bb959c7dca (Bug 1857946) for being partially backed out by merge back commit. 2023-10-19 07:47:11 +03:00
Sandor Molnar
cb5655f905 Merge mozilla-central to autoland. a=merge 2023-10-19 07:22:30 +03:00
Niklas Baumgardner
523be3ce49 Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D190491
 2023-10-19 02:11:48 +00:00
Sandor Molnar
89d15d199d Backed out changeset b4a0f8afc02e (bug 1857946) for causing bc failures at browser/components/screenshots/tests/browser/browser_screenshots_short_page_test.js 2023-10-19 03:33:17 +03:00
Sandor Molnar
54f3613ea5 Backed out changeset b4a0f8afc02e (bug 1857946) for causing bc failures at browser/components/screenshots/tests/browser/browser_screenshots_short_page_test.js 2023-10-19 03:33:17 +03:00
Niklas Baumgardner
e1e695e734 Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D190491
 2023-10-18 20:33:53 +00:00
Emilio Cobos Álvarez
0d4810205e Bug 1858752 - Explicitly z-sort bghighlight. r=niklas 
Before bug 1799036, this was not an issue because the background and the
highlight ended up in different containing blocks.

Depends on D191137

Differential Revision: https://phabricator.services.mozilla.com/D191138
 2023-10-17 17:24:22 +00:00
Emilio Cobos Álvarez
8276ff85e5 Bug 1858752 - Simplify screenshots component markup. r=niklas 
This doesn't fix the issue at hand, but makes stuff easier to reason about.

Differential Revision: https://phabricator.services.mozilla.com/D191137
 2023-10-17 17:24:22 +00:00
Emilio Cobos Álvarez
d9cac16a84 Bug 1859058 - Fix button position after showing them on both sides. r=niklas 
Drive-by, but I noticed it while poking so might as well fix it.

Depends on D191138

Differential Revision: https://phabricator.services.mozilla.com/D191139
 2023-10-17 14:49:22 +00:00
Niklas Baumgardner
6e5b9a5a1e Bug 1854953 - Improve performance when taking large screenshots. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189158
 2023-10-12 16:15:41 +00:00
Cristina Horotan
bb4c800611 Backed out changeset 919bb91f27bb (bug 1854953) for causing bc failures on browser_screenshots_drag_test.js CLOSED TREE 2023-10-11 00:38:25 +03:00
Niklas Baumgardner
3d5c54e8d0 Bug 1854953 - Improve performance when taking large screenshots. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189158
 2023-10-10 16:39:02 +00:00
Sam Foster
f66a0aefaa Bug 1812202 - Reduce the max capture dimension by 1px. r=niklas 
* Captures at exactly the max dimension (32767) result in a fully transparent image.
* Import these dimensions to use in tests so we have a single source of truth
* Update the same constant in the extension

Differential Revision: https://phabricator.services.mozilla.com/D190221
 2023-10-06 22:37:16 +00:00
Niklas Baumgardner
a861bb857d Bug 1855061 - Screenshots overlay buttons should be centered vertically. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189159
 2023-09-28 15:33:08 +00:00
Tom Marble
d596ebea8e Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D188427
 2023-09-21 22:47:07 +00:00
Sam Foster
8165b4bf88 Bug 1845796 - Rework the flow in ScreenshotsUtils to make exit an explicit outcome rather than a side-effect. r=niklas 
* Add a UIPhases / getUIPhase to figure out where we are in the flow, and get the UI into the right state
* Refactor to get rid of a bunch of implicit side-effects:
  - Separate out getting the panel from creating it
  - closePanel only closes the buttons panel
  - Add a closeOverlay so we do that and only that when needed
* When the preview dialog closes, we expect to exit unless exitOnPreviewClose was set false
* Keep some state for each browser using a weakmap so we can better handle re-entry (and later, re-focusing)

Differential Revision: https://phabricator.services.mozilla.com/D185379
 2023-09-19 00:14:27 +00:00
Gregory Pappas
8a35d5cf5f Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Niklas Baumgardner
c0a6a9f5c3 Bug 1844171 - Update screenshots tests. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183912
 2023-07-27 16:15:03 +00:00
Niklas Baumgardner
9ab7b37e1c Bug 1844171 - Refactor screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183313
 2023-07-27 16:15:02 +00:00