nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
870454 commits 1 branch 98 tags 6.4 GiB
Commit graph

3025 commits

Author SHA1 Message Date
Dão Gottwald
52777c231c Bug 1875772 - UrlbarProviderInputHistory should set isBlockable to true/false rather than true/undefined. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D199212
 2024-01-23 10:58:04 +00:00
Marc Seibert
375e996176 Bug 1861530 - Implement the updated UX spec for Switch to tab in containers feature.r=mak,desktop-theme-reviewers,fluent-reviewers,bolsson,dao 
Differential Revision: https://phabricator.services.mozilla.com/D192026
 2024-01-23 08:54:19 +00:00
Anna Yeddi
f0b8b8744c Bug 1874290 - Add exceptions from a11y_checks for clicks on non-interactive chrome UI in Search and Address Bar. r=adw 
The `browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js` and `browser/components/urlbar/tests/browser/browser_closePanelOnClick.js` tests send a click event on a non-interactive `<toolbarspring>` element to test that the URL Bar panel and a search tip would, in fact, be closed.

For users of keyboards and assistive technology another way like pressing `Esc` key is available to dismiss the dialog, thus we need to add an exception from the a11y_checks for this tests via `setEnv` and remove the `fail-if` notations from their test manifests.

Differential Revision: https://phabricator.services.mozilla.com/D198411
 2024-01-23 00:55:16 +00:00
Mark Banner
89628c568f Bug 1875071 - Simplify OpenSearchEngine loading and install process in the search service. r=search-reviewers,mcheang 
The current process creates the OpenSearchEngine and gets it to load its data. Once the data is loaded,
it notifies the SearchService that is ready to be added.

This changes the structure so that the SearchService loads the data, creates the engine and then adds it
straight away.

This also means that the contextual search provider can be simplified and doesn't need to tell the engine
not to add itself to the SearchService.

Differential Revision: https://phabricator.services.mozilla.com/D198814
 2024-01-22 19:12:39 +00:00
Dão Gottwald
90fcff9291 Bug 1810113 - UrlbarProviderPlaces and UrlbarProviderSearchSuggestions should set isBlockable and blockL10n for history results. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D168993
 2024-01-19 21:43:28 +00:00
Stephanie Cunnane
005f77b098 Bug 1843509 - Remove suggest_sponsor and suggest_non_sponsor are from the urlbar's metrics.yaml file. r=mak DONTBUILD 
@mak, in [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1843509#c0 | this comment ]], you mention letting DS know about this removal. So once this patch lands, I'll update the commentary box in the Glean dictionary for urlbar engagement telemetry.

Differential Revision: https://phabricator.services.mozilla.com/D199010
 2024-01-19 15:02:30 +00:00
Sandor Molnar
f15fa5a7fe Backed out changeset 4ec2b9afc62a (bug 1874202) bc failures at browser/components/urlbar/tests/browser/browser_clipboard.js CLOSED TREE 2024-01-19 17:03:32 +02:00
Karandeep
8131d5a86b Bug 1874202 - Add a stopwatch telemetry to record the time it takes to read from the clipboard. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D198595
 2024-01-19 13:24:04 +00:00
Daisuke Akatsuka
5e912f6a8e Bug 1868922: Pass user's query as is to Rust component to keep string cases r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D198513
 2024-01-19 02:44:41 +00:00
Daisuke Akatsuka
e40b174a8d Bug 1855375: Basic implementation for Yelp Suggestions r=fluent-reviewers,flod,adw 
Differential Revision: https://phabricator.services.mozilla.com/D189335
 2024-01-19 02:44:41 +00:00
Erik Nordin
2a01092c90 Bug 1875090 - Rename BrowserTestUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,bytesized,sfoster 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198826
 2024-01-19 02:15:33 +00:00
Erik Nordin
736a5983b8 Bug 1875090 - Rename BrowserTestUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,mhowell 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198825
 2024-01-19 02:15:33 +00:00
James Teow
5f2f854067 Bug 1804010 - Add tests for topsite_search interactions - r=daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D198798
 2024-01-19 01:48:22 +00:00
mcheang
076c4fb736 Bug 1667639 - Make keyword at the start of the string take precedence over restrict symbols at the end of the string. r=mak 
This patch modifies PlacesUtils to cache the keywords and adds functionality to
find a keyword. The Tokenizer calls PlacesUtils to know if the first word
is a keyword and if the first word is a keyword, then the rest of the search
string will be treated as text and Tokenizer won't filter any other restrict
symbols.

Differential Revision: https://phabricator.services.mozilla.com/D198208
 2024-01-19 01:13:39 +00:00
Dale Harvey
37a4dedc0a Bug 1841762 - Ensure onEngagement has queryContext defined. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D197265
 2024-01-18 17:52:58 +00:00
Cristian Tuns
74c0e58b85 Backed out 4 changesets (bug 1868922, bug 1855375, bug 1874990) for causing xpcshell failures in /test_tab_quickwrite.js CLOSED TREE 
Backed out changeset d558120aba19 (bug 1868922)
Backed out changeset e2c1399903d8 (bug 1855375)
Backed out changeset de119e6a8ced (bug 1874990)
Backed out changeset 3d1ef7c11154 (bug 1874990)
 2024-01-18 12:07:55 -05:00
Daisuke Akatsuka
11cfb5b64c Bug 1868922: Pass user's query as is to Rust component to keep string cases r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D198513
 2024-01-18 15:54:42 +00:00
Daisuke Akatsuka
645131edfa Bug 1855375: Basic implementation for Yelp Suggestions r=fluent-reviewers,flod,adw 
Differential Revision: https://phabricator.services.mozilla.com/D189335
 2024-01-18 15:54:41 +00:00
Marco Bonardo
f631b61aa3 Bug 1874546 - Fix test_autofill_urls.js failing at beta merge. r=mseibert 
The heuristic fallback provider is not trimming. Regardless of that being
expected or not, the test is not right for the status quo.

Differential Revision: https://phabricator.services.mozilla.com/D198706
 2024-01-17 16:02:05 +00:00
Mark Banner
60c20c22b6 Bug 1822097 - Separate out OpenSearch loading into a separate module. r=search-reviewers,daleharvey 
This improves the architecture by separating out the loading and therefore not having
the object try to load itself.

There are no functional changes nor removals here, the code is only being restructured.

Differential Revision: https://phabricator.services.mozilla.com/D198378
 2024-01-17 14:48:14 +00:00
Karandeep
228874f4ea Bug 1862616 - Additional text can be inserted in the clipboard result link. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D198194
 2024-01-16 17:43:55 +00:00
James Teow
f10988981b Bug 1874344 - Add additional tests and documentation for Persisted Search Terms logic - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D198379
 2024-01-12 18:14:08 +00:00
James Teow
7580982b71 Bug 1868133 - Use SearchStaticData to extract Google TLD's - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D197985
 2024-01-12 13:58:49 +00:00
Marc Seibert
ddee9a38e3 Bug 1858994 - Punycode is shown in heuristic result. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D191218
 2024-01-12 13:56:28 +00:00
Karandeep
7ee5c5d124 Bug 1874200 - Disable the clipboard provider if the clipboard contents are too large. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D198288
 2024-01-12 12:46:40 +00:00
Anna Yeddi
16775fd283 Bug 1872398 - Add an exception from a11y_checks for one click on the URL Bar in a mouse-specific test. r=adw 
We intentionally turn off a11y_checks for the click updated, because it is send to send a focus on the URL Bar with the mouse, while other ways to focus it are accessible for users of assistive technology and keyboards, thus this test can be excluded from the accessibility tests.

Since this test is now expected to pass a11y_checks, we are also remiving the `fail-if` notation from the test manifest.

Differential Revision: https://phabricator.services.mozilla.com/D197433
 2024-01-11 13:39:42 +00:00
Drew Willcoxon
261dc77768 Bug 1874072 - Don't query the Suggest Rust component for disabled suggestion types. r=daisuke 
Please see the bug for context.

Differential Revision: https://phabricator.services.mozilla.com/D198216
 2024-01-11 04:23:33 +00:00
Hanna Jones
1cd9e53b6b Bug 1845150 - Update notificationbox usage for search engine removal notification r=search-reviewers,fluent-reviewers,Standard8,bolsson 
Notification can be triggered locally via this snippet:

```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```

Depends on D189872

Differential Revision: https://phabricator.services.mozilla.com/D194312
 2024-01-10 18:55:30 +00:00
mcheang
a34314823d Bug 1873788 - Fix bookmark keyword and alias search switching to default engine search when restrict symbols are at the end of the search string. r=mak 
This patch does not fix the ? symbol at the end. That fix will be in Bug 1667639.

Differential Revision: https://phabricator.services.mozilla.com/D198102
 2024-01-10 18:23:40 +00:00
Anna Yeddi
dd2c3f98ef Bug 1789051 - Re-enable a11y_checks for browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js. r=CosminS 
The test was skipped while the main fix for the underlying issue was resolved in bug 1867430. Since the blocking bug was resolved, test should be re-enabled.

In general, using `skip-if` notation instead of `fail-if` prevents the test from reporting when it would actually start passing, when the issue is resolved.

Differential Revision: https://phabricator.services.mozilla.com/D197805
 2024-01-06 19:11:44 +00:00
Norisz Fay
0d4fc02631 Backed out 7 changesets (bug 1845150) for causing failures on browser_datachoices_notification.js CLOSED TREE 
Backed out changeset a07c835a4bf7 (bug 1845150)
Backed out changeset 0016d7f4e556 (bug 1845150)
Backed out changeset 46cfe5fe6e6a (bug 1845150)
Backed out changeset 83190b8a08d0 (bug 1845150)
Backed out changeset ada948351267 (bug 1845150)
Backed out changeset 7aa4340bfd96 (bug 1845150)
Backed out changeset 683745289588 (bug 1845150)
 2024-01-05 18:52:01 +02:00
Hanna Jones
26d37311c1 Bug 1845150 - Update notificationbox usage for search engine removal notification r=search-reviewers,fluent-reviewers,Standard8,bolsson 
Notification can be triggered locally via this snippet:

```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```

Differential Revision: https://phabricator.services.mozilla.com/D194312
 2024-01-05 15:04:19 +00:00
Mark Banner
8ce23e4908 Bug 1864821 - Replace PromiseUtils.defer() with Promise.withResolvers() in system modules. r=Gijs,perftest-reviewers,necko-reviewers,extension-reviewers,application-update-reviewers,fxview-reviewers,sync-reviewers,sessionstore-reviewers,reusable-components-reviewers,rpl,jesup,hjones,kshampur,skhamis,nalexander,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D197489
 2024-01-05 09:22:34 +00:00
Mark Banner
7a4d095f30 Bug 1864821 - Replace PromiseUtils.defer() with Promise.withResolvers() in browser window scopes. r=Gijs,extension-reviewers,application-update-reviewers,rpl,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D197486
 2024-01-05 09:22:33 +00:00
Cosmin Sabou
45ad585956 Backed out 7 changesets (bug 1845150) for causing dt failures on browser_screenshot_button_warning. CLOSED TREE 
Backed out changeset fdc3f1b5e5ae (bug 1845150)
Backed out changeset ba7789c89bdd (bug 1845150)
Backed out changeset 6c405863be54 (bug 1845150)
Backed out changeset f66e8bb15e18 (bug 1845150)
Backed out changeset a75fe63bd39f (bug 1845150)
Backed out changeset 91365291f80f (bug 1845150)
Backed out changeset 7477fd1c48fa (bug 1845150)
 2024-01-04 18:53:25 +02:00
Hanna Jones
ba93129cb7 Bug 1845150 - Update notificationbox usage for search engine removal notification r=search-reviewers,fluent-reviewers,Standard8,bolsson 
Notification can be triggered locally via this snippet:

```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```

Differential Revision: https://phabricator.services.mozilla.com/D194312
 2024-01-04 15:31:12 +00:00
Karandeep
0dccdeeb70 Bug 1852048 - Move address bar to search preferences. r=dao,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D194895
 2024-01-04 09:11:22 +00:00
Anna Yeddi
c0ab4585d7 Bug 1871491 - Add a check for combobox container of moz-input-box and options within the URL bar autocomplete list in AccessibilityUtils. r=Jamie,search-reviewers,credential-management-reviewers,sgalich,Standard8 
Adding an additional check similar to [the isKeyboardFocusableBrowserToolbarButton check](https://searchfox.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/AccessibilityUtils.js#228-238) that could pass the `assertLabelled` rule for following URL Bar-specific controls, since these controls are either left unlabeled or are being labeled after the Fluent l10n is completed deliberately:
1. [Combobox container of the Search Input](https://searchfox.org/mozilla-central/rev/b580e3f77470b2337bc8ae032b58a85c11e66aba/browser/base/content/navigator-toolbox.inc.xhtml#314-318) with id `moz-input-box` - we intentionally leave this element unlabeled, because its child is a search input (properly labeled) that is the target and main control of this component and we want to avoid duplication in the label announcement when a user focuses the input. This causes an a11y failure `Interactive elements must be labeled: id: , tagName: moz-input-box, className: urlbar-input-box`
1. [Options within an autocomplete listbox](https://searchfox.org/mozilla-central/rev/b580e3f77470b2337bc8ae032b58a85c11e66aba/browser/components/urlbar/UrlbarSearchOneOffs.sys.mjs#141-151) with class `urlbarView-row-inner` - we know each of these option is accessible, but it disappears as soon as it is clicked and the a11y-checks do not have time to test the label, because the Fluent localization is not yet completed by then. This causes an a11y warning `Unlabeled element removed before l10n finished`
1. [Additional Searchbar](https://searchfox.org/mozilla-central/rev/b580e3f77470b2337bc8ae032b58a85c11e66aba/browser/base/content/navigator-toolbox.inc.xhtml#699) with id `searchbar` that triggers `Interactive elements must be labeled` failure. To activate this Search bar next to the URL Bar: `about:preferences` > `Search` > `Search Bar` > select `Add search bar in toolbar`.

Since the `browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js` and six other tests will be passing the a11y_checks without warnings now and two tests will pass this specific check, we are updating appropriate test manifests to remove or update `fail-if` conditions as well.

Differential Revision: https://phabricator.services.mozilla.com/D197113
 2024-01-02 21:10:57 +00:00
Daisuke Akatsuka
fe8ef57751 Bug 1853044: Open page with edited value by user regardless of selected result r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D196908
 2023-12-25 01:19:25 +00:00
Cosmin Sabou
5fa5e42cf9 Bug 1789051 - Disable browser_view_selectionByMouse.js on a11y-checks for permafailing and until a fix is in place. a=test-only 2023-12-22 22:09:41 +02:00
Cosmin Sabou
80d786a51f Bug 1787020 - re-enable browser_locationBarCommand.js after a potential fix. a=test-only 2023-12-20 13:52:05 +02:00
Mark Banner
d08854fc16 Bug 1870644 - Remove nsISearchEngine.iconURI and replace by the new getIconURL function. r=search-reviewers,extension-reviewers,settings-reviewers,mconley,mcheang,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D196734
 2023-12-20 13:28:24 +00:00
Karandeep
3436530f73 Bug 1866616 - Save the current date when starting a search from the search bar. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D196840
 2023-12-19 14:05:52 +00:00
Chris H-C
3a958a1442 Bug 1868988 - Remove PingCentre. Its watch has ended. r=nanj,thecount,perry.mcmanis 
Differential Revision: https://phabricator.services.mozilla.com/D196227
 2023-12-18 16:56:22 +00:00
Daisuke Akatsuka
9fbbab6278 Bug 1869253: Use ORDER BY clause in group_concat() for tags r=places-reviewers,mak 
Differential Revision: https://phabricator.services.mozilla.com/D196402
 2023-12-18 12:27:17 +00:00
Mark Banner
00a8658fd9 Bug 1868749 - Remove search engine send attribution request. r=search-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D195758
 2023-12-18 12:01:34 +00:00
Mark Banner
b60fe683f0 Bug 1870275 - Change more urlbar tests to use add_setup. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D196575
 2023-12-16 14:00:13 +00:00
Dão Gottwald
0bca13f60b Bug 1866204 - Prolong urlbar.quick_suggest_contextual_opt_in metric. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D196429
 2023-12-14 15:40:10 +00:00
Dale Harvey
4290544652 Bug 1868368 - Show suggestions without icons when richsuggestions are disabled. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D196140
 2023-12-14 11:50:19 +00:00
ogiorgis
111705f5fd Bug 1840493 - doc/rst: fix some languages declaration r=firefox-source-docs-reviewers,webdriver-reviewers,necko-reviewers,geckoview-reviewers,devtools-reviewers,profiler-reviewers,championshuttler,whimboo,nchevobbe,julienw,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D196268
 2023-12-13 18:32:20 +00:00