pacman_install() uses sudo pacman -S to install packages, which requires the user to enter their password for sudo even if there's nothing to do. Checking for installed packages using pacman -Q allows us to skip calling sudo when all packages are already installed.
Differential Revision: https://phabricator.services.mozilla.com/D199242
While this message was sometimes useful to help troubleshoot for end
users, it's causing issues parsing `stdout` (since it can't use the mach
logging infrastructure due to being too early in the startup). We also
can't use `stderr` since some mozharness scripts treat any `stderr`
output as a full error.
Differential Revision: https://phabricator.services.mozilla.com/D198451
It's not technically an error, but we can't make it debug level output
since the mach logging isn't available this early on startup. There's
precedent for using `stderr` output elsewhere in `site.py`, though it
usually precedes an exception being raised.
Differential Revision: https://phabricator.services.mozilla.com/D198307
The protections panel message should show once when the panel is first opened; after that it will be collapsed by default and can be shown again by clicking the "info" button on the panel
Messaging system previously sent the following pings on message show, and when the "learn more" link was clicked:
```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“IMPRESSION”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```
and
```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“CLICK”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```
This patch replaces these pings with 'RecordEvents' telemetry on the `protectionsPopup` object:
```
33153 security.ui.protectionspopup open protectionspopup_cfr impression {"message": "PROTECTIONS_PANEL_1"}
```
and
```
34932 security.ui.protectionspopup click protectionspopup_cfr
```
Differential Revision: https://phabricator.services.mozilla.com/D192968
Notification can be triggered locally via this snippet:
```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```
Depends on D189872
Differential Revision: https://phabricator.services.mozilla.com/D194312
The protections panel message should show once when the panel is first opened; after that it will be collapsed by default and can be shown again by clicking the "info" button on the panel
Messaging system previously sent the following pings on message show, and when the "learn more" link was clicked:
```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“IMPRESSION”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```
and
```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“CLICK”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```
This patch replaces these pings with 'RecordEvents' telemetry on the `protectionsPopup` object:
```
33153 security.ui.protectionspopup open protectionspopup_cfr impression {"message": "PROTECTIONS_PANEL_1"}
```
and
```
34932 security.ui.protectionspopup click protectionspopup_cfr
```
Differential Revision: https://phabricator.services.mozilla.com/D192968
In bug 1866395 I added a function to return the canonical Firefox
remote and use it when determining the base ref. I overlooked
that this also needs to be used for `get_branch_nodes` to avoid
returning a set of branch nodes that doesn't begin from the same
base ref. Move the building of the `--remotes` arg to a separate
function and use it in `get_branch_nodes`.
Differential Revision: https://phabricator.services.mozilla.com/D198032
This patch fixes the mozperftest docs to mention mochitest in the writing section, as well as fixes the `info` calls so that they mention the JSON.stringify requirement.
Differential Revision: https://phabricator.services.mozilla.com/D196853
Notification can be triggered locally via this snippet:
```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```
Differential Revision: https://phabricator.services.mozilla.com/D194312
Notification can be triggered locally via this snippet:
```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```
Differential Revision: https://phabricator.services.mozilla.com/D194312
For some reason, in some files, file elements are under file elements.
Python's ElementTree's findall doesn't work like DOM's
getElementsByTagName, and doesn't find them. So manually recurse.
Differential Revision: https://phabricator.services.mozilla.com/D197278
Part 1 of migrating passwordmgr.properties to fluent: Converting the strings from LoginManagerPrompter
1. The following strings [saveLoginMsg2, saveLoginMsgNoUser2, saveLoginButtonDeny.label, saveLoginButtonDeny.accesskey, updateLoginMsg3, updateLoginMsgNoUser3, updateLoginButtonDelete.label, updateLoginButtonDelete.accesskey] are not migrated as the messages are changed. They get replaced by [save-password-message, save-password-button-deny, update-password-messsage, update-password-button-delete]
2. The remaining string from LoginManagerPrompter are migrated by the python script.
Differential Revision: https://phabricator.services.mozilla.com/D195931
Ensure the focusable and actionable control is also labeled, so an assistive technology user would know the purpose of this control. It should not only be announced as `Close` but also provide a context by referencing the search mode title text as well, so the "History" search would be announced as `Close History mode` or just `Close History` or similar.
Also, since there were a series of test cases failing the a11y-checks because of this unlabeled control, we remove the `fail-if` notations from their test manifests to allow for the accessibility tests to run and expect to pass, as they should be.
Differential Revision: https://phabricator.services.mozilla.com/D196095
