Commit graph

566 commits

Author SHA1 Message Date
Mike Conley
d622bd6c52 Bug 1505909 - Make basic context menu actions Fission-compatible. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D32876

--HG--
extra : moz-landing-system : lando
2019-06-08 01:09:46 +00:00
Mike Conley
638dd8fb19 Bug 1505909 - Stop sending a CPOW for the target element for context menu messages. r=MattN
This introduces a new toolkit module, ContentDOMReference, which can generate identifiers
for DOM elements that can be safely passed across the process boundary without having to
use the CPOW infrastructure.

The Password Manager code seemed to be the only thing using the original CPOW, so this
has been updated to use the ContentDOMReference identifier instead.

Differential Revision: https://phabricator.services.mozilla.com/D32758

--HG--
extra : moz-landing-system : lando
2019-06-08 01:09:29 +00:00
Mike Conley
42b822a5ef Bug 1505909 - Merge remote and non-remote context menu handlers. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D32757

--HG--
extra : moz-landing-system : lando
2019-06-08 01:09:10 +00:00
Noemi Erli
ea35f4b13b Backed out 6 changesets (bug 1505909) for failures in browser_ext_webNavigation_onCreatedNavigationTarget_contextmenu.js CLOSED TREE
Backed out changeset 57336967a6c7 (bug 1505909)
Backed out changeset 8adcacadd689 (bug 1505909)
Backed out changeset bcca6bb913ef (bug 1505909)
Backed out changeset afc11a5ebb6d (bug 1505909)
Backed out changeset 40f0a56ed3af (bug 1505909)
Backed out changeset 3e31f9726798 (bug 1505909)
2019-06-07 19:19:14 +03:00
Mike Conley
6d0f158a7d Bug 1505909 - Make basic context menu actions Fission-compatible. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D32876

--HG--
extra : moz-landing-system : lando
2019-06-07 14:28:59 +00:00
Mike Conley
cf5863f79c Bug 1505909 - Stop sending a CPOW for the target element for context menu messages. r=MattN
This introduces a new toolkit module, ContentDOMReference, which can generate identifiers
for DOM elements that can be safely passed across the process boundary without having to
use the CPOW infrastructure.

The Password Manager code seemed to be the only thing using the original CPOW, so this
has been updated to use the ContentDOMReference identifier instead.

Differential Revision: https://phabricator.services.mozilla.com/D32758

--HG--
extra : moz-landing-system : lando
2019-06-07 14:28:47 +00:00
Mike Conley
cef09f3647 Bug 1505909 - Merge remote and non-remote context menu handlers. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D32757

--HG--
extra : moz-landing-system : lando
2019-06-07 14:28:33 +00:00
Bogdan Tara
4da63aeb53 Backed out 6 changesets (bug 1505909) for bc failures complaining about WebNavigationChild and browser_e10s_about_page_triggeringprincipal.js CLOSED TREE
Backed out changeset 56449fd37aee (bug 1505909)
Backed out changeset 3ff09b79821c (bug 1505909)
Backed out changeset a1a2a9efe22f (bug 1505909)
Backed out changeset 8aeb77291207 (bug 1505909)
Backed out changeset 4aa17e28ee54 (bug 1505909)
Backed out changeset dbe6803d979e (bug 1505909)
2019-06-07 06:15:16 +03:00
Mike Conley
261632c77d Bug 1505909 - Make basic context menu actions Fission-compatible. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D32876

--HG--
extra : moz-landing-system : lando
2019-06-06 20:32:50 +00:00
Mike Conley
3d1ba6b08c Bug 1505909 - Stop sending a CPOW for the target element for context menu messages. r=MattN
This introduces a new toolkit module, ContentDOMReference, which can generate identifiers
for DOM elements that can be safely passed across the process boundary without having to
use the CPOW infrastructure.

The Password Manager code seemed to be the only thing using the original CPOW, so this
has been updated to use the ContentDOMReference identifier instead.

Differential Revision: https://phabricator.services.mozilla.com/D32758

--HG--
extra : moz-landing-system : lando
2019-06-06 20:32:30 +00:00
Mike Conley
014fa7a924 Bug 1505909 - Merge remote and non-remote context menu handlers. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D32757

--HG--
extra : moz-landing-system : lando
2019-06-06 20:32:11 +00:00
Thomas Nguyen
01ff0bf93f Bug 1534681 Use ReferrerInfo class in document r=ckerschb,baku,Gijs
Also, in many place, we use document uri as referrer. It is not right
for the case srdoc iframe. We should use the last non-srdoc parent
document's uri

Differential Revision: https://phabricator.services.mozilla.com/D30191

--HG--
rename : testing/web-platform/tests/referrer-policy/generic/iframe-inheritance.html => testing/web-platform/tests/referrer-policy/generic/inheritance/iframe-inheritance-data.html
rename : testing/web-platform/tests/referrer-policy/generic/iframe-inheritance.html => testing/web-platform/tests/referrer-policy/generic/inheritance/iframe-inheritance-srcdoc.html
extra : moz-landing-system : lando
2019-06-06 07:23:37 +00:00
Sam Foster
2aa0106cdc Bug 1543499 - Record telemetry event when opening the password management UI. r=MattN
* Remove the PWMGR_MANAGE_OPENED histogram and references to it
* Add a new pwmgr event category, open_management method and objects for each of the entry points
* Expect an entryPoint key to be passed to LoginHelper.openPasswordManager so it can record the event
* Update all callers of LoginHelper.openPasswordManager to pass the correct entryPoint key
* Record the event in preferences when we open the password management UI as a subdialog
* Add test assertions to confirm the telemetry events are recorded, piggybacking on existing tests where practical to avoid duplicating helpers and boilerplate

Differential Revision: https://phabricator.services.mozilla.com/D29840

--HG--
extra : moz-landing-system : lando
2019-05-15 23:24:28 +00:00
Thomas Nguyen
23f12685bd Bug 1532318 - Part 3 : update js code related to the change of nsIHttpChannel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D22787

--HG--
extra : moz-landing-system : lando
2019-05-02 12:34:06 +00:00
Mike Conley
4854def475 Bug 1545168 - Picture-in-Picture context menu item should be disabled on broken videos. r=jaws
For videos that break after alreading being in Picture-in-Picture, we keep the toggle enabled so
that the user can exit Picture-in-Picture.

Differential Revision: https://phabricator.services.mozilla.com/D27951

--HG--
extra : moz-landing-system : lando
2019-04-18 03:26:14 +00:00
Gurzau Raul
b2185e6c29 Backed out 4 changesets (bug 1527925, bug 1545168, bug 1539567) for failing at /actions/test_media.html on a CLOSED TREE.
Backed out changeset a55e5c83e32e (bug 1527925)
Backed out changeset 45d19d0692b2 (bug 1539567)
Backed out changeset d418d95454eb (bug 1527925)
Backed out changeset a37009048470 (bug 1545168)
2019-04-18 05:09:03 +03:00
Mike Conley
34a2267f54 Bug 1545168 - Picture-in-Picture context menu item should be disabled on broken videos. r=jaws
For videos that break after alreading being in Picture-in-Picture, we keep the toggle enabled so
that the user can exit Picture-in-Picture.

Differential Revision: https://phabricator.services.mozilla.com/D27951

--HG--
extra : moz-landing-system : lando
2019-04-17 19:25:28 +00:00
Christoph Kerschbaumer
64005a8818 Bug 1524970: Update more frontend code to explicitly pass a csp. r=Gijs,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D24959

--HG--
extra : moz-landing-system : lando
2019-03-27 16:38:01 +00:00
Mike Conley
2c8a12e078 Bug 1535748 - Remove NIGHTLY_BUILD build-time switches for Picture-in-Picture. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D23948

--HG--
extra : moz-landing-system : lando
2019-03-21 13:58:17 +00:00
Mike Conley
c218b68adf Bug 1535760 - Update strings and controls for toggling Picture-in-Picture from the context menu. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D23947

--HG--
extra : moz-landing-system : lando
2019-03-21 13:58:05 +00:00
Brindusan Cristian
327ca02963 Backed out 2 changesets (bug 1535760, bug 1535748) for ESlint failure at browser_contextMenu.js:66:11. CLOSED TREE
Backed out changeset 8ab3c856b9c2 (bug 1535748)
Backed out changeset a9a01b1c9e3a (bug 1535760)
2019-03-21 04:35:52 +02:00
Mike Conley
47e70b9c38 Bug 1535748 - Remove NIGHTLY_BUILD build-time switches for Picture-in-Picture. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D23948

--HG--
extra : moz-landing-system : lando
2019-03-20 21:24:15 +00:00
Mike Conley
50371e1fee Bug 1535760 - Update strings and controls for toggling Picture-in-Picture from the context menu. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D23947

--HG--
extra : moz-landing-system : lando
2019-03-20 21:24:37 +00:00
Dhyey Thakore
d35fbfef92 Bug 1444133 - Have an option to have view-source open in a separate (browser) window, not separate tab, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D18071

--HG--
extra : moz-landing-system : lando
2019-03-19 11:17:18 +00:00
Thomas Nguyen
26bd1e060c Bug 1528695 - Part 2 : Use referrerInfo in openWindow, contextmenu and openLinkIn r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D21911

--HG--
extra : moz-landing-system : lando
2019-03-15 05:10:17 +00:00
Gijs Kruitbosch
4d5129f897 Bug 1529901 - saving resources behind http auth should work, r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D21842

--HG--
extra : moz-landing-system : lando
2019-03-04 15:26:46 +00:00
Jonathan Kingston
f6680698bd Bug 1525319 - Removing context from OnDataAvailable r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
2019-02-27 23:42:27 +00:00
Jonathan Kingston
dd4c731d8c Bug 1525319 - Changing js to remove context from onStartRequest and onStopRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20771

--HG--
extra : moz-landing-system : lando
2019-02-27 23:41:54 +00:00
Christoph Kerschbaumer
8124d3a763 Bug 1518454: Part 2, frontend changes, add CSP to loadURIOptions dictionary and pass CSP explicitly from frontend to docshell. r=gijs 2019-02-22 09:19:26 +01:00
Matthew Noorenberghe
0f34dbc0e2 Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster
Fixes some stales comments and identation.

Differential Revision: https://phabricator.services.mozilla.com/D20392

--HG--
extra : moz-landing-system : lando
2019-02-22 15:40:43 +00:00
Bogdan Tara
de6fb7d842 Backed out 5 changesets (bug 1304001) for dom/html/test/test_bug430351.html failures CLOSED TREE
Backed out changeset 275c3744e059 (bug 1304001)
Backed out changeset c9628639b5e1 (bug 1304001)
Backed out changeset 7d8f97779a35 (bug 1304001)
Backed out changeset a5644de3c2f5 (bug 1304001)
Backed out changeset e23ef4dbbc7f (bug 1304001)
2019-02-22 05:05:56 +02:00
Matthew Noorenberghe
f1ec30658a Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster
Fixes some stales comments and identation.

Differential Revision: https://phabricator.services.mozilla.com/D20392

--HG--
extra : moz-landing-system : lando
2019-02-21 20:18:19 +00:00
Noemi Erli
7c565dc045 Backed out 6 changesets (bug 1304001) for mochitest failures in test_bug430351.html CLOSED TREE
Backed out changeset 5fafa838de11 (bug 1304001)
Backed out changeset d75340a9a264 (bug 1304001)
Backed out changeset ed7ae6b877df (bug 1304001)
Backed out changeset 93bd4d634b14 (bug 1304001)
Backed out changeset e41015881591 (bug 1304001)
Backed out changeset 6346331d934d (bug 1304001)
2019-02-21 04:04:47 +02:00
Matthew Noorenberghe
e911b23229 Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster
Fixes some stales comments and identation.

Differential Revision: https://phabricator.services.mozilla.com/D20392

--HG--
extra : moz-landing-system : lando
2019-02-20 15:26:29 +00:00
Jonas Allmann
fbe8b0661c Bug 1523813, Remove new Function from utilityOverlay.js, r=Gijs
Replaced new Function() by CustomEvent carrying original click event as sourceEvent.
Adapted all oncommand listeners to use event.sourceEvent instead of event.

Differential Revision: https://phabricator.services.mozilla.com/D18847

--HG--
extra : moz-landing-system : lando
2019-02-19 16:20:02 +00:00
Daisuke Akatsuka
a48415d8aa Bug 1522400: Set proper context menu items on about:devtools-toolbox page. r=jdescottes,mconley
Depends on D17458

Differential Revision: https://phabricator.services.mozilla.com/D17459

--HG--
extra : moz-landing-system : lando
2019-02-13 01:50:20 +00:00
Jonathan Kingston
3421b8fcff Bug 1520868 - Replacing AsyncOpen2 with AsyncOpen always r=valentin
Replacing js and text occurences of asyncOpen2
Replacing open2 with open

Differential Revision: https://phabricator.services.mozilla.com/D16885

--HG--
rename : layout/style/test/test_asyncopen2.html => layout/style/test/test_asyncopen.html
extra : moz-landing-system : lando
2019-02-12 16:08:25 +00:00
Mike Conley
52278792ca Bug 1520329 - Add messaging infrastructure for opening videos in a Picture in Picture window. r=Felipe
Differential Revision: https://phabricator.services.mozilla.com/D16903

--HG--
extra : moz-landing-system : lando
2019-02-12 02:34:38 +00:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Daisuke Akatsuka
336d4a7b39 Bug 1495944: Show/Hide 'Inspect Element' item in content context menu. r=jdescottes
This patch removes "Inspect Element" menu item from content context menu in
case that about:devtools-toolbox are opening.
However, we may be able to remove after fixing 1515265.

Depends on D16684

Differential Revision: https://phabricator.services.mozilla.com/D16685

--HG--
extra : moz-landing-system : lando
2019-01-18 16:21:43 +00:00
Dorel Luca
5e7e061044 Backed out 5 changesets (bug 1495944) for DevTools failures in devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_devtoolstoolbox_menubar.js
Backed out changeset 52e5f0d01900 (bug 1495944)
Backed out changeset 025ffd6f441f (bug 1495944)
Backed out changeset df656c9d03b1 (bug 1495944)
Backed out changeset be64b571b600 (bug 1495944)
Backed out changeset 9418ac4c2fa1 (bug 1495944)
2019-01-18 16:14:34 +02:00
Daisuke Akatsuka
d5682bba8c Bug 1495944: Show/Hide 'Inspect Element' item in content context menu. r=jdescottes
This patch removes "Inspect Element" menu item from content context menu in
case that about:devtools-toolbox are opening.
However, we may be able to remove after fixing 1515265.

Depends on D16684

Differential Revision: https://phabricator.services.mozilla.com/D16685

--HG--
extra : moz-landing-system : lando
2019-01-18 11:53:50 +00:00
Bogdan Tara
1aa3019b05 Backed out 5 changesets (bug 1495944) for browser_989751_subviewbutton_class.js failures CLOSED TREE
Backed out changeset f365b9fa9697 (bug 1495944)
Backed out changeset cd627a79a250 (bug 1495944)
Backed out changeset 7862a0a1c3ec (bug 1495944)
Backed out changeset f78876cf49e6 (bug 1495944)
Backed out changeset 85f355a22192 (bug 1495944)
2019-01-18 04:58:40 +02:00
Daisuke Akatsuka
d6c3c7678a Bug 1495944: Show/Hide 'Inspect Element' item in content context menu. r=jdescottes
This patch removes "Inspect Element" menu item from content context menu in
case that about:devtools-toolbox are opening.
However, we may be able to remove after fixing 1515265.

Depends on D16684

Differential Revision: https://phabricator.services.mozilla.com/D16685

--HG--
extra : moz-landing-system : lando
2019-01-17 06:59:17 +00:00
Luca Greco
49a13352a4 Bug 1468460 - Fix and test extension menus and menus.overrideContext on options_ui pages. r=mixedpuppy,robwu
Depends on D9920

Differential Revision: https://phabricator.services.mozilla.com/D15225

--HG--
extra : moz-landing-system : lando
2019-01-08 22:23:00 +00:00
Luca Greco
b003d66246 Bug 1468460 - Support context menu in WebExtensions options pages embedded inside an about:addons tab. r=mixedpuppy,robwu
Differential Revision: https://phabricator.services.mozilla.com/D9920

--HG--
extra : moz-landing-system : lando
2019-01-07 20:53:13 +00:00
Siddhant085
6ab6938f8c Bug 1493483 - Use nsIBrowserSearchService::defaultEngine instead of currentEngine (in production code) r=Standard8
nsIBrowserSearchService::currentEngine and nsIBrowserSearchService::defaultEngine are the same thing.
The use of defaultEngine makes more sense and thus we are phasing out the use of currentEngine and replace it with defaultEngine.

Differential Revision: https://phabricator.services.mozilla.com/D7972

--HG--
extra : moz-landing-system : lando
2018-10-27 16:52:02 +00:00
Csoregi Natalia
523d3ae4fe Backed out changeset c35bab726b03 (bug 1493483) for multiple browser-chrome failures e.g browser_extension_controlled.js. CLOSED TREE 2018-10-09 23:26:24 +03:00
Siddhant085
5e4fc9f261 Bug 1493483 - Use nsIBrowserSearchService::defaultEngine instead of currentEngine (in production code) r=Standard8
nsIBrowserSearchService::currentEngine and nsIBrowserSearchService::defaultEngine are the same thing.
The use of defaultEngine makes more sense and thus we are phasing out the use of currentEngine and replace it with defaultEngine.

Differential Revision: https://phabricator.services.mozilla.com/D7972

--HG--
extra : moz-landing-system : lando
2018-10-09 18:40:08 +00:00