Commit graph

995 commits

Author SHA1 Message Date
Ricky Stewart
210585edd2 Bug 1672023 - Remove excluded files from black.yml
These files were omitted from the original patch because reformatting them required some manual intervention in order to avoid breaking unit tests. Generally the `noqa` lines were already there and just needed to be moved from one line to another (due to the reformatting by `black`), but sometimes `black` saw fit to move a bunch of stuff all onto one line, requiring me to introduce new `noqa` lines.

Besides the autoformat by `black` and some manual fixups, this patch contains no other changes.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94052

Depends on D94045
2020-10-26 18:21:44 +00:00
Ricky Stewart
02a7b4ebdf Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
fe80718d67 Bug 1672023 - Remove excluded files from black.yml r=sylvestre,perftest-reviewers,geckoview-reviewers,agi
These files were omitted from the original patch because reformatting them required some manual intervention in order to avoid breaking unit tests. Generally the `noqa` lines were already there and just needed to be moved from one line to another (due to the reformatting by `black`), but sometimes `black` saw fit to move a bunch of stuff all onto one line, requiring me to introduce new `noqa` lines.

Besides the autoformat by `black` and some manual fixups, this patch contains no other changes.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94052
2020-10-23 20:40:44 +00:00
Ricky Stewart
c0cea3b0fa Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Dorel Luca
26941cf2f5 Backed out changeset 94ec15429e21 (bug 1672023) for Backout conflicts with Bug 1654103. CLOSED TREE 2020-10-22 03:43:01 +03:00
Ricky Stewart
8b352f1843 Bug 1672023 - Remove excluded files from black.yml r=sylvestre,perftest-reviewers,geckoview-reviewers,agi
These files were omitted from the original patch because reformatting them required some manual intervention in order to avoid breaking unit tests. Generally the `noqa` lines were already there and just needed to be moved from one line to another (due to the reformatting by `black`), but sometimes `black` saw fit to move a bunch of stuff all onto one line, requiring me to introduce new `noqa` lines.

Besides the autoformat by `black` and some manual fixups, this patch contains no other changes.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94052
2020-10-21 21:29:30 +00:00
Ricky Stewart
50762dacab Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Gijs Kruitbosch
c2ae84a7b4 Bug 1665442 - remove the import button once the user successfully imports bookmarks, r=jaws
Any import of bookmarks that attempts to insert at least 1 bookmark successfully
will be treated as a success. This avoids discounting imports where one or more
bookmarks could not be imported due to issues with the URL, especially because
the user has no obvious remedial options - retrying is unlikely to fix things.

Differential Revision: https://phabricator.services.mozilla.com/D93768
2020-10-20 15:28:28 +00:00
Gijs Kruitbosch
51bd17828e Bug 1665442 - show an import button on the bookmarks toolbar for new profiles without bookmarks, r=jaws,fluent-reviewers,flod,dao
Differential Revision: https://phabricator.services.mozilla.com/D93618
2020-10-20 15:29:30 +00:00
Gijs Kruitbosch
79cf5eb5d9 Bug 1665442 - cleanup in browser migration code while passing by, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D93617
2020-10-20 13:04:40 +00:00
Gijs Kruitbosch
1eb312de26 Bug 1671587 - fix perma-fail of test_Chrome_bookmarks.js when the 2020h2 pref gets flipped, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D94030
2020-10-19 16:16:21 +00:00
Jared Wein
21ab31bac4 Bug 1670810 - Don't create the 'From BrowserX' wrapper folder after import if the 2h2020 pref is enabled. r=Gijs
The value of this wrapper folder diminishes quickly over time and its presence is just a reminder of a users former browser.

Differential Revision: https://phabricator.services.mozilla.com/D93278
2020-10-13 10:00:38 +00:00
Gijs Kruitbosch
772244bb90 Bug 1493103 - allow users to import bookmarks from Safari without granting full disk access, r=jaws,Mardak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D91485
2020-10-06 15:45:46 +00:00
Ed Lee
ee5d495548 Bug 1665802 - Directly migrate importable passwords without wizard for single profile r=sfoster
Share importable handling from LoginManagerParent and support directly migrating.

Differential Revision: https://phabricator.services.mozilla.com/D90635
2020-09-24 20:00:08 +00:00
Mihai Alexandru Michis
89d33e1c3b Backed out 2 changesets (bug 1666373, bug 1665802) for causing gv-junit and xpcshell failures.
Backed out changeset 296c8ba967c9 (bug 1666373)
Backed out changeset c1fe3374ab97 (bug 1665802)
2020-09-24 10:52:40 +03:00
Ed Lee
9f44cacde2 Bug 1665802 - Directly migrate importable passwords without wizard for single profile r=sfoster
Share importable handling from LoginManagerParent and support directly migrating.

Differential Revision: https://phabricator.services.mozilla.com/D90635
2020-09-23 22:32:47 +00:00
Jared Wein
fa53a5752f Bug 1659736 - Move tracking of bookmark roots during IE migration later so the source is clearer. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D88059
2020-08-28 15:21:57 +00:00
Butkovits Atila
dd5480d8da Backed out changeset f263318ebce4 (bug 1659736) for failure at test_Safari_bookmarks.js. CLOSED TREE 2020-08-28 01:49:31 +03:00
Jared Wein
f2e65e077b Bug 1659736 - Move tracking of bookmark roots during IE migration later so the source is clearer. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D88059
2020-08-27 20:45:23 +00:00
Razvan Maries
f916ec87b2 Backed out changeset 538c51598420 (bug 1659736) for perma failures on test_IE_bookmarks.js. CLOSED TREE 2020-08-25 21:04:59 +03:00
Jared Wein
df99f886f1 Bug 1659741 - Fix typo in Telemetry reporting of Safari migrator and add automated test. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D88072
2020-08-25 16:38:53 +00:00
Jared Wein
b72b308558 Bug 1659736 - Move tracking of bookmark roots during IE migration later so the source is clearer. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D88059
2020-08-25 16:35:43 +00:00
Jared Wein
32685b1f6e Bug 1659847 - Explicitly set the showBookmarksToolbarAfterMigration pref so tests will continue to run after the feature is disabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D87980
2020-08-24 10:32:27 +00:00
Ed Lee
b666b9283a Bug 1634386 - The Password Import Autocomplete suggestion is displayed on Linux r=MattN
Share ChromeMigrationUtils.supportsLoginsForPlatform for ChromeProfileMigrator.getResources and ChromeMigrationUtils.getImportableLogins.

Differential Revision: https://phabricator.services.mozilla.com/D87639
2020-08-20 17:48:50 +00:00
Mihai Alexandru Michis
91527a2bb0 Bug 1656277 - Fix lint failure regarding missing spaces. a=lint-fix
CLOSED TREE
2020-08-14 19:30:38 +03:00
Jared Wein
972dd7e8cd Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is behind a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-14 15:56:36 +00:00
Mihai Alexandru Michis
ff85a31698 Backed out changeset 8b917683232d (bug 1656277) for causing xpcshell failures in test_IE_bookmarks.js
CLOSED TREE
2020-08-14 08:36:35 +03:00
Jared Wein
2f679b3933 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is behind a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-14 03:27:22 +00:00
Csoregi Natalia
324be7e980 Backed out changeset 4fc26e678c18 (bug 1656277) for failures on test_Edge_db_migration.js. CLOSED TREE 2020-08-14 04:21:35 +03:00
Jared Wein
3cce4b4e65 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is controlled by a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-13 21:56:40 +00:00
Noemi Erli
fd115ffc27 Backed out changeset c2c4b8d6b915 (bug 1656277) for causing build bustages in nsDocShell.cpp CLOSED TREE 2020-08-14 01:13:41 +03:00
Jared Wein
d0ce281442 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is controlled by a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-13 21:56:40 +00:00
Ed Lee
98b1408e33 Bug 1649180 - Localize password import source-browser name r=MattN,fluent-reviewers,flod
Based on the approach in D80944 but of the supported browser ids exposed via ChromeMigrationUtils.CONTEXTUAL_LOGIN_IMPORT_BROWSERS.

Differential Revision: https://phabricator.services.mozilla.com/D84465
2020-08-11 07:13:51 +00:00
Cameron McCormack
dd61f595eb Bug 1620467 - Part 4: Change internal uses of -moz-appearance to appearance and -moz-default-appearance. r=emilio,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,ntim,agi,miketaylr
Uses of `-moz-appearance: none` are changed to `appearance: none`.

Uses of other values that are simply reverting the appearance back to
its default are changed to `appearance: auto`.

Uses of values in UA sheets that are defining the inherent appearance of
widgets are changed to:

  appearance: auto;
  -moz-default-appearance: <value>;

since those values are either no longer supported on (-moz-)appearance,
or are still supported but only in some limited form.

There are some uses of `-moz-appearance: textfield` on <input
type=number> elements that are renamed to `appearance: textfield`.

Differential Revision: https://phabricator.services.mozilla.com/D83430
2020-07-16 22:04:14 +00:00
Kris Maglione
9d78661f88 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Tom Tung
7e78f4ec74 Bug 1626581 - Use mozfile.remove in test_refresh_firefox.py and add the "\\?\" prefix for file path on Windows for mozfile.remove; r=whimboo,gbrown
Differential Revision: https://phabricator.services.mozilla.com/D81901
2020-07-07 15:00:46 +00:00
Coroiu Cristina
07dda135f5 Backed out changeset 64456c63779a (bug 1626581) for xpcshell task aborted failures on a CLOSED TREE 2020-07-03 16:36:32 +03:00
Tom Tung
30f78a7f6e Bug 1626581 - Use mozfile.remove in test_refresh_firefox.py and add the "\\?\" prefix for file path on Windows for mozfile.remove; r=whimboo,gbrown
Differential Revision: https://phabricator.services.mozilla.com/D81901
2020-07-03 12:02:28 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Gijs Kruitbosch
d523471eac Bug 1644863 - fix trailing whitespace in browser/toolkit/devtools/mobile frontend code files, r=mossop,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D79201
2020-06-17 22:40:53 +00:00
Gijs Kruitbosch
caf43f579b Bug 1645165 - fix header labels in migration dialog, r=MattN,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D79383
2020-06-12 12:25:47 +00:00
Gijs Kruitbosch
6f1da44727 Bug 1643321 - fix missing/differently-identified fluent localization of browser profile migration data types, r=MattN,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D78412
2020-06-08 12:00:38 +00:00
Nicholas Nethercote
515dfde5da Bug 1636706 - Re-enable test_refresh_firefox.py test on Linux 64 opt. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D77768
2020-06-03 13:38:46 +00:00
Andrea Marchesini
5ccae203ff Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-02 13:49:27 +00:00
Riley Byrd
ad82a96dad Bug 1518234 - Migrate migration wizard to Fluent r=flod,Gijs,fluent-reviewers
Based on a patch originally written by Ian Kirkpatrick <kirkpa47@msu.edu>

Differential Revision: https://phabricator.services.mozilla.com/D17393
2020-06-02 06:46:09 +00:00
Csoregi Natalia
e960b9f449 Backed out 7 changesets (bug 1640405, bug 1638358) for failures on browser_webconsole_network_messages_status_code.js. CLOSED TREE
Backed out changeset ef5f7479ddf8 (bug 1640405)
Backed out changeset 286e0c83eb30 (bug 1638358)
Backed out changeset 89e396b2896e (bug 1638358)
Backed out changeset 33ad5fa05209 (bug 1638358)
Backed out changeset d213264c1379 (bug 1638358)
Backed out changeset 6bc05236afb4 (bug 1638358)
Backed out changeset 87e9d0ed3982 (bug 1638358)
2020-06-02 15:16:42 +03:00
Andrea Marchesini
b4173bc59e Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-02 09:13:51 +00:00
Razvan Maries
79fe28f0d6 Backed out 6 changesets (bug 1638358) for perma failures on browser_webconsole_navigate_to_parse_error.js. CLOSED TREE
Backed out changeset beb85cf281d5 (bug 1638358)
Backed out changeset 39f2e21623aa (bug 1638358)
Backed out changeset 2c873c72bf1f (bug 1638358)
Backed out changeset e91292c7c719 (bug 1638358)
Backed out changeset 0219ef931cd9 (bug 1638358)
Backed out changeset 4ac06f3992f4 (bug 1638358)
2020-06-02 00:24:46 +03:00