Commit graph

308 commits

Author SHA1 Message Date
Itiel
cf26dda371 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-14 17:16:39 +00:00
Iulian Moraru
1a03d0ff0d Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
d6ff8a9975 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-12 17:16:35 +00:00
Shane Hughes
52d6ffecf9 Bug 1831906 - Add release notes link to update modal prompts. r=bytesized,omc-reviewers,application-update-reviewers,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D177410
2023-06-08 15:48:01 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Katherine Patenio
ac4145f34d Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D178362
2023-05-18 18:34:51 +00:00
Iulian Moraru
170aaf5bb7 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
076aaf6671 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-05-18 17:19:45 +00:00
Mark Banner
a94fe03b9d Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D167297
2023-01-20 17:49:21 +00:00
Mike Conley
42a671591b Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
2022-11-08 14:51:40 +00:00
Mark Banner
8d1ebcb9d6 Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Emilio Cobos Álvarez
13572bce66 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
c520b707bd Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
0777329f69 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Shane Caraveo
41e03a66c8 Bug 1783972 make browser actions pop out of overflow r=zombie,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D154179
2022-08-22 18:55:59 +00:00
Iulian Moraru
3c09fc13df Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
2022-07-20 14:57:48 +03:00
Mark Banner
3ad13294d8 Bug 1780074 - Migrate newtab consumers to use ESM imports directly. r=daleharvey,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D152114
2022-07-20 10:36:52 +00:00
Neil Deakin
fa28d1157f Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm

This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.

Differential Revision: https://phabricator.services.mozilla.com/D149285
2022-07-03 09:44:39 +00:00
Norisz Fay
75a2126b47 Backed out 2 changesets (bug 1682621) for causing bc failures on browser_menu_touch.js CLOSED TREE
Backed out changeset 88be5107a4a1 (bug 1682621)
Backed out changeset e32910a4948b (bug 1682621)
2022-06-29 19:36:51 +03:00
Neil Deakin
ed7b6c18f3 Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm

This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.

Differential Revision: https://phabricator.services.mozilla.com/D149285
2022-06-29 12:38:30 +00:00
Marian-Vasile Laza
5d317b0f12 Backed out 2 changesets (bug 1682621) for causing bc failures on browser_ext_browserAction_click_types.js.
Backed out changeset 31a6b027b4e7 (bug 1682621)
Backed out changeset 782fd4871c5f (bug 1682621)
2022-06-28 20:27:15 +03:00
Neil Deakin
d8cb8edd49 Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm

This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.

Differential Revision: https://phabricator.services.mozilla.com/D149285
2022-06-28 16:02:37 +00:00
Gijs Kruitbosch
371e133ed3 Bug 1749537 - remove obsolete _formatPrintButtonShortcuts(), r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D135949
2022-02-28 14:33:29 +00:00
Jonathan Watt
c5150cf5bd Bug 1745332 - Remove print.tab_modal.enabled checks from CustomizableUI code. r=mconley
The old UI is going away.

Differential Revision: https://phabricator.services.mozilla.com/D133451
2022-01-06 18:55:37 +00:00
Rob Wu
d6767c7c9e Bug 1714846 - Really hide panels on hide, r=robwu,emilio
Differential Revision: https://phabricator.services.mozilla.com/D132574
2021-12-07 11:50:19 +00:00
Butkovits Atila
da4e10d9f4 Backed out changeset 6e298bdd0dd8 (bug 1714846) for causing assertion failures at CompositorBridgeParent.cpp. CLOSED TREE 2021-12-03 23:30:10 +02:00
Rob Wu
c30c452a2e Bug 1714846 - Really hide panels on hide, r=robwu,emilio
Differential Revision: https://phabricator.services.mozilla.com/D132574
2021-12-03 19:16:51 +00:00
Scott
c910dfa83e Bug 1737868 - Pocket panel overflow menu not properly getting the remote attribute. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D130770
2021-11-16 00:35:34 +00:00
Tooru Fujisawa
0a19cba72a Bug 1706650 - Split localization item for update banner label for each notification. r=zbraniecki,fluent-reviewers,Gijs
Instead of copying from label-* attributes, set data-l10n-id for each
notification

Also, stop using attributes for checking if the notification is supported.

Differential Revision: https://phabricator.services.mozilla.com/D129270
2021-10-26 18:32:36 +00:00
Neil Deakin
e9450de0a6 Bug 1733786, replace uitour implementation of show how button with one that focuses the item on the app menu and submenu instead, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D128428
2021-10-19 14:54:45 +00:00
Scott
f492bcff55 Bug 1693582 - Moving Pocket button panels to remote content process r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D122128
2021-09-08 16:11:34 +00:00
Scott
d5e1071c25 Bug 1724668 - Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D122278
2021-08-25 00:46:01 +00:00
Marian-Vasile Laza
925f82df84 Backed out changeset 6ba2b54d02f6 (bug 1724668) for causing bc failures on browser_panel_locationSpecific.js. CLOSED TREE 2021-08-20 20:52:53 +03:00
Scott
f9ebad60df Bug 1724668 - Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D122278
2021-08-20 16:54:00 +00:00
Sam Foster
9302af6664 Bug 1719463 - Part 7: Remove the Logins, Addons, Preferences and Print buttons from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121807
2021-08-10 05:29:32 +00:00
Mike Conley
a3b91b5afb Bug 1720534 - Clean up styles in Bookmarks Menu Button menupopups on Windows 7 and 10. r=desktop-theme-reviewers,dao
This also gets rid of a dead CSS class (panel-subview-footer).

Differential Revision: https://phabricator.services.mozilla.com/D119906
2021-07-18 00:06:41 +00:00
Gijs Kruitbosch
6e1012d2e4 Bug 1711508 - remove PanelUI.protonAppMenuEnabled property, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D117058
2021-07-07 22:15:50 +00:00
Mike Conley
958f051aed Bug 1700198 - Remove subviewbutton-iconic class from Library panel markup. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D118621
2021-06-24 20:27:46 +00:00
prathikshaprasadsuman
0ed2bc3b2f Bug 1701057 - Addon icon should be visible in the addon install confirmation dialog. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D112742
2021-04-21 08:22:22 +00:00
Emma Malysz
897010cdec Bug 1701287, use brand short name for app menu button label r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D110113
2021-03-29 15:52:08 +00:00
Doug Thayer
c8daa84209 Bug 1694811 - Extend existing popup hiding logic to PanelUI r=Gijs
This effectively mirrors the panel hiding logic we use to hide
PopupNotifications panels so that we also hide notifications attached to the
hamburger menu. This will cover alerts and other similar modals originating
from content.

Differential Revision: https://phabricator.services.mozilla.com/D109526
2021-03-25 17:54:10 +00:00
Emma Malysz
993984618c Bug 1700503, insert enterprise policy support menu item to app menu r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D109569
2021-03-24 20:48:28 +00:00
Molly Howell
c233e319d2 Bug 1696260 - Keep app menu button badges showing while the menu is open. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D107950
2021-03-15 15:51:19 +00:00
Gijs Kruitbosch
a3aabe77b4 Bug 1697420 - add fluent support to CustomizableUI API widgets, r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D107797
2021-03-10 17:29:51 +00:00
Gijs Kruitbosch
c36def023b Bug 1695904 - update menu button tooltip when the panel hides/shows regardless of cause, r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D106912
2021-03-02 17:08:49 +00:00
Emma Malysz
18e5aff93f Bug 1695698: update hamburger menu tooltip text r=fluent-reviewers,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D106808
2021-03-01 18:51:00 +00:00
Mike Conley
dc2631ac79 Bug 1695348 - Mass rename browser.proton.appmenu.enabled to browser.proton.enabled. r=emalysz,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106800
2021-03-01 17:27:52 +00:00
Mike Conley
2687e4f918 Bug 1691152 - Apply latest Proton stylings to AppMenu. r=ewright
Depends on D104749

Differential Revision: https://phabricator.services.mozilla.com/D105027
2021-02-12 17:59:50 +00:00
Mike Conley
511394874d Bug 1690662 - Port the add-on and browser update banners to the Proton AppMenu. r=ewright
Differential Revision: https://phabricator.services.mozilla.com/D104749
2021-02-12 17:59:49 +00:00
Micah Tigley
6fcd8ab391 Bug 1690351 - Create a Proton-specific More Tools panel. r=jdescottes,mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D104249
2021-02-10 15:21:58 +00:00