Commit graph

55 commits

Author SHA1 Message Date
James Teow
9e73d7364c Bug 1836156 - Remove extraPageRegexps from search-telemetry-v2 - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D180862
2023-08-04 15:04:02 +00:00
Gregory Pappas
3eac12bbd7 Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao
Differential Revision: https://phabricator.services.mozilla.com/D184481
2023-07-26 16:28:11 +00:00
Mark Banner
ae619c5049 Bug 1838155 - Clean up some console.error calls that had been migrated from Cu.reportError. r=jdescottes,perftest-reviewers,geckoview-reviewers,credential-management-reviewers,search-reviewers,sgalich,owlish,jteow,sparky
This goes through the previous changes in the dependencies of bug 877389, and does two things:
1) Remove instances of \n
2) Change reporting of exceptions so that they are passed as separate arguments. This should result
   in an improved display of the exception in the browser console, should it occur.

Differential Revision: https://phabricator.services.mozilla.com/D180843
2023-06-15 08:33:57 +00:00
James Teow
ce144701bb Bug 1837429 - Rename hasShoppingTab to shoppingTabDisplayed - r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D180346
2023-06-08 19:55:51 +00:00
James Teow
74322cab78 Bug 1836507 - Prevent tab-history events from triggering a click event - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D179966
2023-06-08 16:13:59 +00:00
Stephanie Cunnane
527b260019 Bug 1829953 - Add follow_on_from_refine_on_SERP tracking to the SERP impression event. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D179491
2023-06-03 17:58:13 +00:00
Mark Banner
9da713aa30 Bug 1836107 - Add schema validation testing for search-telemetry-v2. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D179582
2023-06-02 10:11:49 +00:00
James Teow
b7663bfe8c Bug 1835321 - Allow any link on SERPs that don't match an ad expression to be considered a non-ad - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D179367
2023-06-01 02:13:18 +00:00
Stephanie Cunnane
415beb83a9 Bug 1816738 - Add opened_in_new_tab tracking to SERP impression event. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D177531
2023-05-23 22:04:08 +00:00
James Teow
295aa5b6b5 Bug 1833245 - Enable cached page loads to be monitored in SearchSERPTelemetry - r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D178502
2023-05-23 15:06:16 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
James Teow
78b8147915 Bug 1833877 - Don't check page for components related to the impression if components don't exist - r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D178445
2023-05-19 02:09:57 +00:00
James Teow
2505db3753 Bug 1831876 - Don't attempt to record an impression / ad impression on pages that don't include a search parameter - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D177385
2023-05-09 15:46:57 +00:00
James Teow
ce93f45d04 Bug 1830209 - Refactor observeActivity - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D176610
2023-04-27 16:18:20 +00:00
James Teow
06c6f14e38 Bug 1829877 - Remove browser from browserContentSourceMap after source has been used - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D176420
2023-04-26 13:48:22 +00:00
James Teow
8329a650e3 Bug 1829672 - Ensure network event is from a top level load - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D176390
2023-04-25 11:16:59 +00:00
James Teow
67d2b60534 Bug 1829578 - Allow hrefs of SERPs to be classified as non_ads_link - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D176243
2023-04-24 14:54:29 +00:00
James Teow
26c970ec24 Bug 1816736 - Add in-content search tracking to SERP impression event - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D176242
2023-04-24 14:54:28 +00:00
James Teow
62944933ed Bug 1828786 - Allow component categorization and ad_impression to occur on pages without ads - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D176159
2023-04-24 14:54:28 +00:00
James Teow
8e9b6d5099 Bug 1824543 - Add shopping_tab_displayed and is_shopping_page to Impression Event - r=Standard8
Since we rely on the child process to parse this information, we need to
wait until the child has reported the presence of the shopping page
before sending the Impression event.

Differential Revision: https://phabricator.services.mozilla.com/D175576
2023-04-21 21:19:39 +00:00
James Teow
b447eb856c Bug 1816735 - Add expanded and submitted states - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D175546
2023-04-21 20:22:21 +00:00
James Teow
9345673523 Bug 1816730 - Step 2: Allow targets in content process to register click events - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D175311
2023-04-21 16:54:22 +00:00
James Teow
2a3dfda4ee Bug 1816730 - Step 1: Add target property for click events that can be detected in network processes - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D175160
2023-04-21 16:54:21 +00:00
Stephanie Cunnane
3962ebb39d Bug 1814776 - Implement the SERP abandonment event. r=Standard8,jteow
Differential Revision: https://phabricator.services.mozilla.com/D171884
2023-04-12 19:25:31 +00:00
James Teow
6b5742e06e Bug 1816729 - Implement the impression event for refinement buttons and shopping tabs - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D173691
2023-04-03 14:01:26 +00:00
James Teow
cab323cdc1 Bug 1816729 - Implement the impression event for ad_sitelink, ad_sidebar - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D172753
2023-04-03 14:01:26 +00:00
James Teow
66a685a8aa Bug 1816728 - Add impression event for carousels - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D171820
2023-03-24 14:04:04 +00:00
James Teow
fb969de225 Bug 1814773 - Implement a basic SERP engagement event - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D169542
2023-02-28 11:30:37 +00:00
Mark Banner
8acde8d74e Bug 1816934 - Update consumers of services/settings to import ES modules directly. r=leplatrem,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,robwu
Differential Revision: https://phabricator.services.mozilla.com/D169934
2023-02-17 19:32:06 +00:00
Cristian Tuns
b3bf09cc0d Backed out 6 changesets (bug 1816934, bug 1817182, bug 1817179, bug 1817183) for causing dt failures in browser_jsterm_autocomplete_null.js CLOSED TREE
Backed out changeset 17d4c013ed92 (bug 1817183)
Backed out changeset cfed8d9c23f3 (bug 1817183)
Backed out changeset 62fe2f589efe (bug 1817182)
Backed out changeset 557bd773fb85 (bug 1817179)
Backed out changeset 7f8a7865868b (bug 1816934)
Backed out changeset d6c1d4c0d2a0 (bug 1816934)
2023-02-17 10:51:33 -05:00
Mark Banner
aec4c1293b Bug 1816934 - Update consumers of services/settings to import ES modules directly. r=leplatrem,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,robwu
Differential Revision: https://phabricator.services.mozilla.com/D169934
2023-02-17 09:01:43 +00:00
Stephanie Cunnane
71b6b6b395 Bug 1813162 - Implement the SERP impression event. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D168172
2023-02-09 04:03:37 +00:00
Marian-Vasile Laza
8b8b467a26 Backed out changeset 7d610bc570cd (bug 1813162) as requested by the dev, issue with the patch. CLOSED TREE 2023-02-08 21:17:51 +02:00
Stephanie Cunnane
fc95891f96 Bug 1813162 - Implement the SERP impression event. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D168172
2023-02-08 18:53:28 +00:00
Stephanie Cunnane
5827267455 Bug 1804739 - Make Search SERP Telemetry work with multiple providers using the same ad provider. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D164251
2022-12-12 14:59:42 +00:00
Mark Banner
3546e1a363 Bug 1801808 - Automatically replace Cu.reportError with console.error (search). r=scunnane
Manual fixing of tests.

Differential Revision: https://phabricator.services.mozilla.com/D162696
2022-11-23 12:29:20 +00:00
Mark Banner
d1fe4b6dd7 Bug 1702180 - Remove obsolete search SERP telemetry probes. r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D161563
2022-11-09 08:06:45 +00:00
Michael Kohler
3a66f0e8ec Bug 1688599 - Remove old browser.search.with_ads/browser.search.ad_clicks scalars r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D148383
2022-11-07 11:41:36 +00:00
trickypr
0a0f9e5473 Bug 1510561 - Part 5: Apply plugin:mozilla/require-jsdoc to browser/components/search. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D159470
2022-10-24 13:32:37 +00:00
trickypr
1b9044bf2f Bug 1510561 - Part 4: Apply plugin:mozilla/valid-jsdoc to browser/components/search. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D159469
2022-10-24 13:32:36 +00:00
Mark Banner
a9ba6e830d Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 21:47:50 +00:00
Marian-Vasile Laza
130adc5d9a Backed out changeset 0679274d6ed5 (bug 1792398) for causing bc failures on browser_sendQuery.js. CLOSED TREE 2022-09-26 22:53:00 +03:00
Mark Banner
3e99025d45 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 18:51:57 +00:00
Narcis Beleuzu
6c2d0d8cea Backed out changeset 849faf753208 (bug 1792398) for bc failures on browser_sendQuery.js . CLOSED TREE 2022-09-26 20:44:40 +03:00
Mark Banner
05dcda5a7f Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 16:51:10 +00:00
Mark Banner
12ee099a88 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D152253
2022-07-26 15:11:31 +00:00
smolnar
dc4f2d6a41 Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
2022-07-25 21:00:07 +03:00
Mark Banner
4272200762 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D152253
2022-07-25 12:46:49 +00:00
smolnar
102b779608 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00