Commit graph

1058 commits

Author SHA1 Message Date
Mark Banner
2e1253978b Bug 1588785 - Make the search service also detect when the UI is not enabled. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D49652

--HG--
extra : moz-landing-system : lando
2019-10-18 18:53:36 +00:00
Oana Pop Rus
852f034b58 Backed out 2 changesets (bug 1588785) for causing bc perma failures in browser_searchDefaultEngine.js on a CLOSED TREE
Backed out changeset 6ad4b26b21d7 (bug 1588785)
Backed out changeset 4a4afa268baf (bug 1588785)
2019-10-18 18:45:58 +03:00
Mark Banner
c481f33c74 Bug 1588785 - Make the search service also detect when the UI is not enabled. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D49652

--HG--
extra : moz-landing-system : lando
2019-10-18 13:48:17 +00:00
Marco Bonardo
3f507f3fdc Bug 1587803 - Check BrowserContentHandler.jsm::doSearch() uses the private engine when appropriate. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D49446

--HG--
extra : moz-landing-system : lando
2019-10-18 10:24:52 +00:00
Harry Twyford
e897e72031 Bug 1586861 - Use promiseDocumentFlushed in SearchOneOffs.__rebuild. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D48405

--HG--
extra : moz-landing-system : lando
2019-10-16 14:46:44 +00:00
James Teh
76247694a7 Bug 1588416: Reinstate the label for the search one-offs container. r=Standard8
The previous code relied on the header label having a value property.
However, after the conversion to Fluent in bug 1563026, this is no longer the case.
Instead, use aria-labelledby, which avoids label duplication and will work irrespective of the label's implementation.

Differential Revision: https://phabricator.services.mozilla.com/D49125

--HG--
extra : moz-landing-system : lando
2019-10-14 12:27:49 +00:00
Mark Banner
50b98750a5 Bug 1583162 - Remove 'Show Suggestions' from the search bar context menu as it doesn't work correctly, and using prefs UI is better. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D48971

--HG--
extra : moz-landing-system : lando
2019-10-11 14:57:27 +00:00
Mike de Boer
7d3c7d45d1 Bug 1563024 - Adapt unit tests to include coverage for the new Search in Private Window context menu option. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D48673

--HG--
rename : browser/base/content/test/general/browser_bug970746.js => browser/components/search/test/browser/browser_contentContextMenu.js
rename : browser/base/content/test/general/browser_bug970746.xhtml => browser/components/search/test/browser/browser_contentContextMenu.xhtml
extra : moz-landing-system : lando
2019-10-10 22:49:18 +00:00
Noemi Erli
f85d19767f Backed out changeset 030df8fe65c7 (bug 1586861) for causing browser-chrome failures 2019-10-09 01:08:00 +03:00
Harry Twyford
a604e4862e Bug 1586861 - Use promiseDocumentFlushed in SearchOneOffs.__rebuild. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D48405

--HG--
extra : moz-landing-system : lando
2019-10-08 19:25:20 +00:00
Mark Banner
8e1c08c3f8 Bug 1563026 - Add a right-click context menu item for the one-off search buttons to set as default for private browsing. r=fluent-reviewers,mak,flod
Differential Revision: https://phabricator.services.mozilla.com/D47079

--HG--
extra : moz-landing-system : lando
2019-10-08 10:06:01 +00:00
Mark Banner
307a88a039 Bug 1563026 - Migrate search one-offs xul fragment to use fluent. r=fluent-reviewers,mak,flod
Differential Revision: https://phabricator.services.mozilla.com/D47078

--HG--
extra : moz-landing-system : lando
2019-10-08 10:05:54 +00:00
Dão Gottwald
2322d61c8b Bug 1586232 - Animate the megabar with transforms only r=mak
Differential Revision: https://phabricator.services.mozilla.com/D48164

--HG--
extra : moz-landing-system : lando
2019-10-05 02:35:17 +00:00
Francesco Lodolo (:flod)
90b06e0032 Bug 1584920 - Add Tibetan (bo) and Bodo (brx) to Firefox Nightly builds r=Pike. On a CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D47868

--HG--
extra : rebase_source : 360606a3921ba9bb4c793587eedff27d6bd1c9ec
extra : amend_source : 4b3753a9e240708c6c8f256bc6c72ac64c79cef7
extra : source : b3743b6fb2f3408201cb491fa4f3c8d69222a1a6
2019-10-02 14:42:21 +00:00
Daniel Varga
bcc9154683 Backed out changeset b3743b6fb2f3 (bug 1584920) for mochitest failure in remove_imptest_failure_expectations. On a CLOSED TREE 2019-10-02 20:41:14 +03:00
Francesco Lodolo (:flod)
3b98439b95 Bug 1584920 - Add Tibetan (bo) and Bodo (brx) to Firefox Nightly builds r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D47868

--HG--
extra : moz-landing-system : lando
2019-10-02 14:42:21 +00:00
Harry Twyford
f0f21826c4 Bug 1584336 - Re-add the width attribute to the searchbar. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D47624

--HG--
extra : moz-landing-system : lando
2019-10-01 08:27:56 +00:00
Mark Banner
b93f2c2970 Bug 1576158 - Display the private browsing engine on the private browsing page. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D47208

--HG--
extra : moz-landing-system : lando
2019-09-27 14:54:38 +00:00
Harry Twyford
a9baf68cab Bug 1582022 - Update search one-offs selection behaviour to respect selectable elements in the view instead of rows. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D46339

--HG--
extra : moz-landing-system : lando
2019-09-24 18:45:18 +00:00
Harry Twyford
22d7c283b7 Bug 1582396 - Set width correctly on the searchbar autocomplete in the overflow menu. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D46488

--HG--
extra : moz-landing-system : lando
2019-09-24 10:17:21 +00:00
Mark Banner
ab0ed8162d Bug 1583147 - When right-clicking a one-off search button, correctly disable the set as default option for the default engine. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D46766

--HG--
extra : moz-landing-system : lando
2019-09-23 19:11:00 +00:00
Dale Harvey
4b0aa468ec Bug 1572465 - Add engine codes to engines.json r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D46619

--HG--
extra : moz-landing-system : lando
2019-09-23 13:46:28 +00:00
Tim Nguyen
f6434a147c Bug 1582639 - Fix browser_426329.js and browser_940307_panel_click_closure_handling.js failures.
Differential Revision: https://phabricator.services.mozilla.com/D46680

--HG--
extra : moz-landing-system : lando
2019-09-21 00:26:36 +00:00
Tim Nguyen
c87e8cb82b Bug 1582639 - Fix 'Clear Search History' menu item and clean up related code. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D46660

--HG--
extra : moz-landing-system : lando
2019-09-21 00:27:38 +00:00
Oana Pop Rus
65d7eaa6ed Backed out changeset b510b386edff (bug 1582639) for bc failures in browser/components/search/test/browser/browser_426329.js on a CLOSED TREE 2019-09-21 03:21:54 +03:00
Tim Nguyen
fe0f35121d Bug 1582639 - Fix 'Clear Search History' menu item and clean up related code. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D46660

--HG--
extra : moz-landing-system : lando
2019-09-20 21:30:21 +00:00
Dale Harvey
5c9c5d5aad Bug 1572468 - Add telemetryIds to modern config. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D46370

--HG--
extra : moz-landing-system : lando
2019-09-20 11:43:10 +00:00
Dale Harvey
94b162a8ea Bug 1575554 - Support default region in search configuration. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45537

--HG--
extra : moz-landing-system : lando
2019-09-17 17:58:23 +00:00
Tim Nguyen
e043df8d78 Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33250

--HG--
rename : toolkit/content/widgets/autocomplete.xml => toolkit/content/widgets/autocomplete-input.js
extra : moz-landing-system : lando
2019-09-17 06:22:42 +00:00
Mihai Alexandru Michis
f9580519b8 Backed out changeset e859a5aebb5b (bug 1534455) for causing failures at test_bug437844.xul
--HG--
rename : toolkit/content/widgets/autocomplete-input.js => toolkit/content/widgets/autocomplete.xml
2019-09-17 07:51:36 +03:00
Tim Nguyen
5d8a3da397 Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33250

--HG--
rename : toolkit/content/widgets/autocomplete.xml => toolkit/content/widgets/autocomplete-input.js
extra : moz-landing-system : lando
2019-09-17 01:35:25 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Dão Gottwald
a9c4c1d278 Bug 1577181 - Fix one off search button overflow layout in the urlbar. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D45826

--HG--
extra : moz-landing-system : lando
2019-09-14 09:18:11 +00:00
Harry Twyford
23ad8796f5 Bug 1578435 - Update UrlbarView's selection model to support selection within "tip" results. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D45455

--HG--
extra : moz-landing-system : lando
2019-09-13 22:47:41 +00:00
Cosmin Sabou
9bd5920216 Backed out changeset dc7ec5a19a13 (bug 1577181) for browser chrome failures on browser_oneOffContextMenu. CLOSED TREE 2019-09-13 20:33:34 +03:00
Mark Banner
d081f85ab5 Bug 1563017 - Use private browsing search engine in the search bar when in private browsing mode. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D45850

--HG--
extra : moz-landing-system : lando
2019-09-13 15:37:24 +00:00
Dão Gottwald
5f29710fd7 Bug 1577181 - Fix one off search button overflow layout in the urlbar. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D45826

--HG--
extra : moz-landing-system : lando
2019-09-13 14:52:53 +00:00
Francesco Lodolo (:flod)
2417762adc Bug 1580092 - [ca-valencia] Search engine setup for Firefox for Catalan (Valencian) r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D45307

--HG--
extra : moz-landing-system : lando
2019-09-13 15:28:20 +00:00
Dale Harvey
e821ea6bdc Bug 1575555 - Support multiple locales in modern config r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45541

--HG--
extra : moz-landing-system : lando
2019-09-13 10:10:54 +00:00
Dão Gottwald
a355f15d53 Bug 1580822 - a11y focus lost when selecting the first one-off search button or the search settings button. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D45692

--HG--
extra : moz-landing-system : lando
2019-09-12 21:07:39 +00:00
Razvan Maries
7330509f46 Backed out changeset fdb95b58fb6c (bug 1580092) for build bustages. CLOSED TREE 2019-09-12 14:35:46 +03:00
Francesco Lodolo (:flod)
fa89d4cae1 Bug 1580092 - [ca-valencia] Search engine setup for Firefox for Catalan (Valencian) r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D45307

--HG--
extra : moz-landing-system : lando
2019-09-12 10:53:44 +00:00
James Teh
9cede8d015 Bug 1579767: Reinstate the accessibility group role for the search one-offs container. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D45151

--HG--
extra : moz-landing-system : lando
2019-09-09 16:39:34 +00:00
Dão Gottwald
28ad95b9a1 Bug 1578375 - Stop flushing layout in SearchOneOffs::__rebuild when used with the address bar. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D44449

--HG--
extra : moz-landing-system : lando
2019-09-03 18:32:32 +00:00
Dale Harvey
5cfefa7835 Bug 1572470 - Add wikipedia to engines.json r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D43768

--HG--
extra : moz-landing-system : lando
2019-08-30 15:02:47 +00:00
Dale Harvey
6e2b1a210d Bug 1542268 - Use new engine selector behind a pref r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D42879

--HG--
extra : moz-landing-system : lando
2019-08-30 14:01:59 +00:00
Dão Gottwald
d7d5e6829f Bug 1577810 - Setting SearchOneOffs::selectedButton = null shouldn't remove the input's aria-activedescendant attribute when it was pointing to an item that isn't a one off search button. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D44170

--HG--
extra : moz-landing-system : lando
2019-08-30 17:37:25 +00:00
Dão Gottwald
4421e12bbe Bug 1577801 - Stop messing with aria-activedescendant when mousing over one-off search buttons. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D44162

--HG--
extra : moz-landing-system : lando
2019-08-30 15:07:31 +00:00
Mark Banner
6f85a36322 Bug 1577197 - Re-enable browser_oneOffContextMenu.js for test-verify. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D43766

--HG--
extra : moz-landing-system : lando
2019-08-30 15:11:51 +00:00
Mark Banner
511a7ababf Bug 1562929 - Use the default private search engine in the context menu. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D43771

--HG--
extra : moz-landing-system : lando
2019-08-29 14:43:43 +00:00