nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
676156 commits 1 branch 98 tags 6.4 GiB
Commit graph

671 commits

Author SHA1 Message Date
Dão Gottwald
ac88ea2827 Bug 1584101 - Clip the navigation toolbar when the address bar can be rendered within the toolbar's bounds. r=Gijs,mattwoodrow 
Differential Revision: https://phabricator.services.mozilla.com/D49861

--HG--
extra : moz-landing-system : lando
 2019-10-22 19:02:59 +00:00
Marco Bonardo
d6c6a3496f Bug 1589865 - Search in a Private Window appears for the search restriction token. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D49888

--HG--
extra : moz-landing-system : lando
 2019-10-22 14:21:15 +00:00
Dão Gottwald
786dcf2f6a Bug 1589923 - Strip https:// instead of http:// from URLs in the results view. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D49842

--HG--
extra : moz-landing-system : lando
 2019-10-22 07:22:55 +00:00
Dão Gottwald
854a6bfecb Bug 1589836 - Add permanent search icon in front of the megabar. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D49826

--HG--
extra : moz-landing-system : lando
 2019-10-21 23:06:06 +00:00
shindli
e5617f8407 Backed out changeset 675c7c3794bc (bug 1589923) for causing xpcshell failures in xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_urlbar.js CLOSED TREE 2019-10-22 00:58:58 +03:00
Dão Gottwald
e3dfaefb00 Bug 1589923 - Strip https:// instead of http:// from URLs in the results view. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D49842

--HG--
extra : moz-landing-system : lando
 2019-10-21 18:55:25 +00:00
Mark Banner
2e1253978b Bug 1588785 - Make the search service also detect when the UI is not enabled. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D49652

--HG--
extra : moz-landing-system : lando
 2019-10-18 18:53:36 +00:00
Marco Bonardo
21f39cc00f Bug 1588469 - Show Search in a Private Window even if search suggestions in address bar are disabled. r=Standard8 
Stop filtering search results when browser.urlbar.suggest.searches is false,
that pref is intended to filter search suggestions coming from the network, and
we should completely avoid hitting the network when it's set, rather than
filtering entries (that may instead cover real bugs).

Differential Revision: https://phabricator.services.mozilla.com/D49172

--HG--
extra : moz-landing-system : lando
 2019-10-18 14:21:54 +00:00
Marco Bonardo
9105b2fe51 Bug 1587959 - The userSelectionBehavior property of the urlbar controller may get stale and confuse a11y. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D49725

--HG--
extra : moz-landing-system : lando
 2019-10-18 15:55:54 +00:00
Oana Pop Rus
852f034b58 Backed out 2 changesets (bug 1588785) for causing bc perma failures in browser_searchDefaultEngine.js on a CLOSED TREE 
Backed out changeset 6ad4b26b21d7 (bug 1588785)
Backed out changeset 4a4afa268baf (bug 1588785)
 2019-10-18 18:45:58 +03:00
Mark Banner
c481f33c74 Bug 1588785 - Make the search service also detect when the UI is not enabled. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D49652

--HG--
extra : moz-landing-system : lando
 2019-10-18 13:48:17 +00:00
Harry Twyford
6c24ba64b2 Bug 1578445 - Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D47980

--HG--
extra : moz-landing-system : lando
 2019-10-17 17:46:01 +00:00
Coroiu Cristina
34a649cd21 Backed out changeset 8c0ed99d462c (bug 1578445) for browser-chrome failures at browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js on a CLOSED TREE 2019-10-17 20:29:23 +03:00
Harry Twyford
8347b171c4 Bug 1578445 - Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D47980

--HG--
extra : moz-landing-system : lando
 2019-10-17 16:49:38 +00:00
Oana Pop Rus
e0fb2f2a1e Backed out changeset 62d172103a78 (bug 1578445) for bc failures in browser/browser_ext_urlbar.js on a CLOSED TREE 2019-10-17 17:28:29 +03:00
Harry Twyford
07dd6769fb Bug 1578445 - Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D47980

--HG--
extra : moz-landing-system : lando
 2019-10-17 10:48:26 +00:00
Marco Bonardo
4a41f42413 Bug 1588464 - Add a delay to Search in a private window to reduce flicker. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D49266

--HG--
extra : moz-landing-system : lando
 2019-10-17 11:47:13 +00:00
Dão Gottwald
97dc13cb94 Bug 1586889 - Stop re-initializing the urlbar when exiting customize mode. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D49405

--HG--
extra : moz-landing-system : lando
 2019-10-17 09:03:12 +00:00
Mihai Alexandru Michis
d874b02b52 Backed out 2 changesets (bug 1588469, bug 1588464) for causing bc failures in browser_test_focus_urlbar.js CLOSED TREE 
Backed out changeset c5bff62e1640 (bug 1588464)
Backed out changeset b85a79175973 (bug 1588469)
 2019-10-17 02:09:57 +03:00
Marco Bonardo
3db57b200e Bug 1588037 - Don't show 'Search in a private window' if an alias was typed. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D49423

--HG--
extra : moz-landing-system : lando
 2019-10-16 22:07:43 +00:00
Marco Bonardo
e24c974e7d Bug 1588464 - Add a delay to Search in a private window to reduce flicker. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D49266

--HG--
extra : moz-landing-system : lando
 2019-10-16 22:07:26 +00:00
Marco Bonardo
eddf83bc7a Bug 1588469 - Show Search in a Private Window even if search suggestions in address bar are disabled. r=Standard8 
Split the SEARCH source into SEARCH_NETWORK or SEARCH_LOCAL to distinguish
search results coming from a remote source, from those generated locally.
browser.urlbar.suggest.searches will only affect SEARCH_NETWORK results.

Differential Revision: https://phabricator.services.mozilla.com/D49172

--HG--
extra : moz-landing-system : lando
 2019-10-16 22:07:14 +00:00
Harry Twyford
e928de6825 Bug 1589169 - Stop calling _addTextContentWithHighlights for the tip text. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D49468

--HG--
extra : moz-landing-system : lando
 2019-10-16 20:00:16 +00:00
Harry Twyford
7cfeb10bd3 Bug 1586239 - Stop calling _addTextContentWithHighlights for the tip button. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D49440

--HG--
extra : moz-landing-system : lando
 2019-10-16 15:41:10 +00:00
Brad Werth
0b6d9f7d9c Bug 1588167: Make UrlbarView._getFirstSelectableElement handle having no children at time of call. r=adw 
This avoids a JS error when the tab has been removed before this function
has a chance to run.

Differential Revision: https://phabricator.services.mozilla.com/D48993

--HG--
extra : moz-landing-system : lando
 2019-10-16 01:14:30 +00:00
Drew Willcoxon
1643004a5d Bug 1579612 - Properly extract tags from urlbar results in all cases. r=mak 
We extract tags from the result title only when `info.style.includes("bookmark")`, but that only captures one of the two cases where we include tags in the title: the "bookmark" style. We also include tags for the "tag" style. So the bug reports in this bug are hitting that "tag" case. It doesn't have anything to do with non-Latin tags afaict (see the bug summary).

I took the opportunity to streamline `UnifiedComplete._addFilteredQueryMatch`, which was a little hard to follow. I had to look at it to make sure I captured all the cases where tags are included in the title. I think I've made it easier to follow.

Differential Revision: https://phabricator.services.mozilla.com/D49223

--HG--
extra : moz-landing-system : lando
 2019-10-16 00:31:53 +00:00
Dão Gottwald
d093241f42 Bug 1586351 - Cache retained results in the view temporarily to prevent results from flickering when MegaBar reopens. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D48818

--HG--
extra : moz-landing-system : lando
 2019-10-15 16:05:05 +00:00
Dorel Luca
b6eeb7d5d3 Backed out changeset 35d4451f348d (bug 1588458) as requested by the dev 2019-10-15 19:04:22 +03:00
Sylvestre Ledru
0f71aeba53 Bug 1588458 - Replace dxr by searchfox in the doc r=ahal 
Differential Revision: https://phabricator.services.mozilla.com/D49140

--HG--
extra : moz-landing-system : lando
 2019-10-15 15:27:13 +00:00
Marco Bonardo
cff612c7b4 Bug 1586681 - Ensure URIFIxup uses the right engine when there's a separate PB engine. r=Standard8,Gijs 
Add a new FIXUP_FLAG_PRIVATE_CONTEXT to nsIURIFixup, make it use the default
private search engine when it's set.
Update consumers to pass the new flag when necessary.

Differential Revision: https://phabricator.services.mozilla.com/D48741

--HG--
extra : moz-landing-system : lando
 2019-10-12 12:37:51 +00:00
Mark Banner
bbdd994f71 Bug 1583162 - Add an option in preferences to allow search suggestions in private windows. r=mak,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D48972

--HG--
extra : moz-landing-system : lando
 2019-10-11 14:57:44 +00:00
Dão Gottwald
f49de631fa Bug 1587800 - Remove the hidden-focus class. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D48845

--HG--
extra : moz-landing-system : lando
 2019-10-11 13:35:52 +00:00
Noemi Erli
9bb4859279 Backed out changeset 41fb463d4a8c (bug 1587800) for failures in test_about_private_browsing.py 2019-10-11 13:49:51 +03:00
Dão Gottwald
ea4ddcd840 Bug 1587800 - Remove the hidden-focus class. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D48845

--HG--
extra : moz-landing-system : lando
 2019-10-11 09:58:13 +00:00
Kashav Madan
409851d51d Bug 1583240 - Update fission annotations, r=kmag 
Differential Revision: https://phabricator.services.mozilla.com/D47648

--HG--
extra : moz-landing-system : lando
 2019-10-08 15:29:06 +00:00
Kashav Madan
8dc620b8bc Bug 1583240 - Make BrowserTestUtils.waitForDocLoadAndStopIt Fission-compatible, r=kmag 
Differential Revision: https://phabricator.services.mozilla.com/D47649

--HG--
extra : moz-landing-system : lando
 2019-10-10 23:21:22 +00:00
harry
bb242e5b57 Bug 1563351 - Insert search shortcuts into the Urlbar with Touch Bar buttons. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D38892

--HG--
extra : moz-landing-system : lando
 2019-10-09 10:45:33 +00:00
harry
b4a08851a2 Bug 1563350 - Add popover to the Touch Bar that displays when the Urlbar has focus. r=mikedeboer,spohl,fluent-reviewers,Pike,flod 
Differential Revision: https://phabricator.services.mozilla.com/D38563

--HG--
extra : moz-landing-system : lando
 2019-10-10 19:57:32 +00:00
Harry Twyford
0733410a0c Bug 1583535 - The Megabar should not expand when auto-focused after a panel is closed. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D48114

--HG--
extra : moz-landing-system : lando
 2019-10-10 13:51:26 +00:00
Dão Gottwald
986df12c96 Bug 1586589 - Replace obsolete <textbox> comments in urlbar code. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D48675

--HG--
extra : moz-landing-system : lando
 2019-10-09 13:18:15 +00:00
shindli
083cbd8b40 Backed out 8 changesets (bug 1563350, bug 1563351, bug 1563349, bug 1567939) on suspicion of causing OS X crashes https://bugzilla.mozilla.org/show_bug.cgi?id=1587351 CLOSED TREE a=backout 
Backed out changeset 86ed8b9bee5f (bug 1563351)
Backed out changeset 355b0329bd95 (bug 1563350)
Backed out changeset 653caa0c494a (bug 1567939)
Backed out changeset 4b4a71e170bd (bug 1563349)
Backed out changeset 81b93962243b (bug 1563349)
Backed out changeset cff2050ff540 (bug 1563349)
Backed out changeset db50ea44f0b1 (bug 1563349)
Backed out changeset dcbddc5738c3 (bug 1563349)
 2019-10-09 13:33:05 +03:00
harry
abf9b97e30 Bug 1563351 - Insert search shortcuts into the Urlbar with Touch Bar buttons. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D38892

--HG--
extra : moz-landing-system : lando
 2019-10-08 15:10:20 +00:00
harry
980501c285 Bug 1563350 - Add popover to the Touch Bar that displays when the Urlbar has focus. r=mikedeboer,spohl,fluent-reviewers,Pike,flod 
Differential Revision: https://phabricator.services.mozilla.com/D38563

--HG--
extra : moz-landing-system : lando
 2019-10-08 00:52:07 +00:00
Harry Twyford
4ea53a93ad Bug 1586026 - Expand Megabar in window.focusAndSelectUrlbar. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D48104

--HG--
extra : moz-landing-system : lando
 2019-10-08 12:39:30 +00:00
Marco Bonardo
f10ec767a4 Bug 1580834 - Add a Search in private window entry in the address bar results when only search suggestions are present r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D48082

--HG--
extra : moz-landing-system : lando
 2019-10-07 15:51:59 +00:00
Harry Twyford
33ff8ec5b5 Bug 1583708 - Disable failing part of browser_urlbar_collapseOnChromeMousedown.js. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D48325

--HG--
extra : moz-landing-system : lando
 2019-10-07 16:21:20 +00:00
Marco Bonardo
45b356558e Bug 1583616 - Some numbers are searched and not autofilled. r=Standard8 
The tokenizer currently thinks large numbers are "broken" IPs, thus it says they
can't be an origin. Unfortunately we use that same code path to identify possible
origin prefixes, and origins can start with a number. Thus we end up searching
rather than autofilling the origin.

For now fix the heuristic for IPs, in the future we may evaluate splitting these
code paths.

Differential Revision: https://phabricator.services.mozilla.com/D48187

--HG--
extra : moz-landing-system : lando
 2019-10-07 14:16:02 +00:00
Marco Bonardo
95fe2a1f7a Bug 1584545 - Clear the autofill placeholder if the first result is not an autofill one. r=Standard8 
Fixes a problem where the autofill placeholder is applied regardless of the
first result. This is particularly critical for keywords and aliases.

It also changes the title of keyword results without a search string, because
currently it looks like they browse to the root of the host, but instead they
visit the bookmark url. It's better to show the bookmark url so the user knows
what will be visited.

Differential Revision: https://phabricator.services.mozilla.com/D48111

--HG--
extra : moz-landing-system : lando
 2019-10-07 14:43:31 +00:00
Marco Bonardo
6c52e9095c Bug 1585847 - Megabar doesn't expand properly when autofill is involved. r=harry 
Differential Revision: https://phabricator.services.mozilla.com/D48304

--HG--
extra : moz-landing-system : lando
 2019-10-07 13:00:47 +00:00
Dão Gottwald
f497f36252 Bug 1586392 - Fix dragging from the expanded urlbar. r=harry 
Differential Revision: https://phabricator.services.mozilla.com/D48248

--HG--
extra : moz-landing-system : lando
 2019-10-05 19:13:27 +00:00