Commit graph

50 commits

Author SHA1 Message Date
Mike Conley
3ecc7966f4 Bug 1860606 - Get rid of migration.ftl in favour of migrationWizard.ftl. r=kpatenio,fluent-reviewers,bolsson
migration.ftl was used by the old, legacy XUL migration dialog that was removed
in bug 1824851.

There were still a few strings being used by migration.ftl, but I've moved those
over to migrationWizard.ftl, and gone ahead and just removed the old file.

Differential Revision: https://phabricator.services.mozilla.com/D192509
2023-11-02 22:03:26 +00:00
Mike Conley
e1336c1a0f Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 20:09:21 +00:00
Sandor Molnar
e9864bd8c9 Backed out 2 changesets (bug 1818237) for causing xpc failures on browser/components/migration/tests/unit/test_Chrome_permissions.js CLOSED TREE
Backed out changeset e5d78a9ddcb4 (bug 1818237)
Backed out changeset 87f67f05c8a8 (bug 1818237)
2023-10-11 19:53:35 +03:00
Mike Conley
ce487ed3b3 Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 14:53:55 +00:00
Sandor Molnar
fe0eee2ad6 Backed out 2 changesets (bug 1818237) for causing mochitest/xpc failures on browser/components/migration/<...>.js CLOSED TREE
Backed out changeset a8584f57dc7c (bug 1818237)
Backed out changeset 477292e081b3 (bug 1818237)
2023-10-11 09:32:23 +03:00
Mike Conley
71dcfe8cb4 Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 04:16:49 +00:00
Mike Conley
929f4a5c82 Bug 1838432 - Only check for read permissions on Safari files when the files exist. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D183538
2023-07-25 13:26:22 +00:00
Mark Banner
ae619c5049 Bug 1838155 - Clean up some console.error calls that had been migrated from Cu.reportError. r=jdescottes,perftest-reviewers,geckoview-reviewers,credential-management-reviewers,search-reviewers,sgalich,owlish,jteow,sparky
This goes through the previous changes in the dependencies of bug 877389, and does two things:
1) Remove instances of \n
2) Change reporting of exceptions so that they are passed as separate arguments. This should result
   in an improved display of the exception in the browser console, should it occur.

Differential Revision: https://phabricator.services.mozilla.com/D180843
2023-06-15 08:33:57 +00:00
Marco Castelluccio
21a2f56033 Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-15 08:10:45 +00:00
Noemi Erli
37e0c3eb20 Backed out changeset 63ccd00a399a (bug 898315) for causing failures in test_no_window_update_restart.py CLOSED TREE 2023-06-15 03:21:27 +03:00
Marco Castelluccio
c85e65e2e0 Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-14 20:55:52 +00:00
Mike Conley
32eff06ac8 Bug 1837604 - Only attempt to get count of Safari history entries if read access has been granted. r=mstriemer
Unfortunately, testing this sort of thing in automation is really really
tricky because macOS's directory access permissions aren't a thing that
we can easily manipulate from tests.

Differential Revision: https://phabricator.services.mozilla.com/D180435
2023-06-13 19:15:16 +00:00
Alvin Lew
edbb72c6ca Bug 1831087 - NS_ERROR_MALFORMED_URI errors in the browser console when importing from Safari r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D177354
2023-06-02 14:33:07 +00:00
Mark Striemer
7753334b44 Bug 1236916 - Part 1: Fix Safari history migration r=mconley
This patch based on work that was started by Evan Liang <eliang@calstatela.edu>.

Differential Revision: https://phabricator.services.mozilla.com/D179104
2023-05-30 17:06:52 +00:00
Norisz Fay
6ae57c0e0d Backed out 2 changesets (bug 1236916) for causing xpcshell failures on test_Safari_bookmarks.js
Backed out changeset 539dfe08bec7 (bug 1236916)
Backed out changeset a0b5a7ade705 (bug 1236916)
2023-05-30 19:20:17 +03:00
Mark Striemer
ac66adffa3 Bug 1236916 - Part 1: Fix Safari history migration r=mconley
This patch based on work that was started by Evan Liang <eliang@calstatela.edu>.

Differential Revision: https://phabricator.services.mozilla.com/D179104
2023-05-30 14:27:50 +00:00
Stanca Serban
b9d2220795 Backed out 2 changesets (bug 1236916) for causing mochitests failures in browser_aboutwelcome_multistage_mr.js. CLOSED TREE
Backed out changeset 2c9ee3c4df9f (bug 1236916)
Backed out changeset 7989dfc3c15c (bug 1236916)
2023-05-29 22:31:01 +03:00
Mark Striemer
bc103558b1 Bug 1236916 - Part 1: Fix Safari history migration r=mconley
This patch based on work that was started by Evan Liang <eliang@calstatela.edu>.

Differential Revision: https://phabricator.services.mozilla.com/D179104
2023-05-29 17:30:16 +00:00
Sandor Molnar
479cfff4e4 Backed out 2 changesets (bug 1236916) for causing xpc failures in browser/components/migration/tests/unit/test_Safari_history.js CLOSED TREE
Backed out changeset 2f004b59bfdb (bug 1236916)
Backed out changeset a2f5b34d7551 (bug 1236916)
2023-05-27 00:31:36 +03:00
Mark Striemer
ec26b0b950 Bug 1236916 - Part 1: Fix Safari history migration r=mconley
This patch based on work that was started by Evan Liang <eliang@calstatela.edu>.

Differential Revision: https://phabricator.services.mozilla.com/D179104
2023-05-26 20:30:52 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
elephanteatsapple
b9ac3332aa Bug 1824870 - Fix Sinon usage in browser_safari_permissions.js. r=mconley,kpatenio
This makes it so that we properly use and restore a Sinon sandbox when stubbing out things
on the SafariProfileMigrator, whereas before we were merely stubbing and not restoring.

Differential Revision: https://phabricator.services.mozilla.com/D174647
2023-04-04 17:08:37 +00:00
Alvin Lew
1124f83fa1 Bug 1815320 - Update Safari permission step in migrator to be a folder picker for the Safari folder under ~/Library. r=mconley,flod
Depends on D161306

Differential Revision: https://phabricator.services.mozilla.com/D171407
2023-03-13 16:54:59 +00:00
Alvin Lew
8c26bea50a Bug 326701 - Favicons should be imported from Safari r=mconley
Depends on D162361

Differential Revision: https://phabricator.services.mozilla.com/D161306
2023-03-13 16:54:59 +00:00
steven wang
5ac03ecad1 Bug 1815543 - Sort the migrators in the new migration wizard in MRU order descending. r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D172231
2023-03-13 16:19:18 +00:00
elephanteatsapple
453f875d73 Bug 1809352- Include branding assets for each browser that can be imported from. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D170016
2023-02-17 03:18:06 +00:00
Norisz Fay
17babe8929 Backed out changeset 7d45f0ddbd8b (bug 1809352) for causing mochitest failures on browser_all_files_referenced.js CLOSED TREE 2023-02-16 21:58:52 +02:00
elephanteatsapple
b5b9a415a5 Bug 1809352- Include branding assets for each browser that can be imported from. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D170016
2023-02-16 18:53:48 +00:00
Barret Rennie
a1db25841d Bug 1798734 - Port osfile.jsm usage to IOUtils in SafariProfileMigrator.sys.mjs r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D164766
2023-02-06 15:52:24 +00:00
Mike Conley
828431224a Bug 1811935 - Adjust visibility of the resource types available for each migrator / profile pair in the new migration wizard. r=Gijs
This causes the MigrationWizardChild to request the full collection of available
migrators and user profiles, and then based on which resourceTypes those migrators
and user profiles have available, changes the visibility of the checkboxes in the
selection page of the new MigrationWizard component.

Differential Revision: https://phabricator.services.mozilla.com/D167617
2023-01-25 12:53:31 +00:00
Marian-Vasile Laza
188fed440d Backed out changeset 97ee58e6c65d (bug 1811935) for causing bc failures on browser_dialog_cancel_close.js. CLOSED TREE 2023-01-25 04:06:11 +02:00
Mike Conley
ed79566bd6 Bug 1811935 - Adjust visibility of the resource types available for each migrator / profile pair in the new migration wizard. r=Gijs
This causes the MigrationWizardChild to request the full collection of available
migrators and user profiles, and then based on which resourceTypes those migrators
and user profiles have available, changes the visibility of the checkboxes in the
selection page of the new MigrationWizard component.

Differential Revision: https://phabricator.services.mozilla.com/D167617
2023-01-24 21:15:03 +00:00
Mark Banner
a94fe03b9d Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D167297
2023-01-20 17:49:21 +00:00
Mike Conley
187e447724 Bug 718280 - Part 2: Move registration of migrators into MigrationUtils instead of components.conf. r=NeilDeakin
Depends on D164138

Differential Revision: https://phabricator.services.mozilla.com/D164139
2022-12-13 17:01:24 +00:00
Sandor Molnar
70c13f22bb Backed out 9 changesets (bug 1800917, bug 718280) for causing xpc failures in browser/components/migration/tests/unit/test_Edge_db_migration.js CLOSED TREE
Backed out changeset d55b95d9d14f (bug 1800917)
Backed out changeset 8427f1e65df4 (bug 1800917)
Backed out changeset 2d0f77d324f2 (bug 718280)
Backed out changeset eba58fd1ed1c (bug 718280)
Backed out changeset 33027a0f9ce9 (bug 718280)
Backed out changeset 237be1f62d01 (bug 718280)
Backed out changeset 007afe158ae5 (bug 718280)
Backed out changeset f1dea7abdfb7 (bug 718280)
Backed out changeset 47e2cccd33c7 (bug 718280)
2022-12-13 00:50:16 +02:00
Mike Conley
25d5dbe3b1 Bug 718280 - Part 2: Move registration of migrators into MigrationUtils instead of components.conf. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D164139
2022-12-12 16:04:03 +00:00
Mike Conley
ade405818a Bug 1802961 - Convert MigratorPrototype into an ES6 class and move into its own ESM as MigratorBase to be subclassed. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D163257
2022-12-06 17:50:39 +00:00
Mike Conley
5bb704309f Bug 1802961 - Make MigrationUtils an ES6 class singleton. r=kpatenio,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D163256
2022-12-06 17:50:39 +00:00
Mike Conley
026d72dfc9 Bug 1802358 - Enable require-jsdoc / valid-jsdoc for browser/components/migration. r=kpatenio
This doesn't do a thorough job of actually documenting things, it just makes sure that
the existing documentation abides by the JSDoc formatting rules. I did flesh out some
documentation here and there, but writing new / updating / clarifying documentation is
left as later work.

Differential Revision: https://phabricator.services.mozilla.com/D163133
2022-12-06 17:50:38 +00:00
Butkovits Atila
be54bd233f Backed out 7 changesets (bug 1802358, bug 1801314, bug 1802961) for causing documentation failures.
Backed out changeset bb0f5e137128 (bug 1802961)
Backed out changeset 4c2a66bfe913 (bug 1802961)
Backed out changeset baaa090cada1 (bug 1802961)
Backed out changeset d98ee38a13bb (bug 1802961)
Backed out changeset 618dcf6d8284 (bug 1802961)
Backed out changeset 59d98ca9fd51 (bug 1802358)
Backed out changeset bce1ea9149bd (bug 1801314)
2022-12-06 18:21:11 +02:00
Mike Conley
e4dfc42d84 Bug 1802961 - Convert MigratorPrototype into an ES6 class and move into its own ESM as MigratorBase to be subclassed. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D163257
2022-12-06 14:46:42 +00:00
Mike Conley
ba4ff5a0ef Bug 1802961 - Make MigrationUtils an ES6 class singleton. r=kpatenio,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D163256
2022-12-06 14:46:42 +00:00
Mike Conley
53e100ace0 Bug 1802358 - Enable require-jsdoc / valid-jsdoc for browser/components/migration. r=kpatenio
This doesn't do a thorough job of actually documenting things, it just makes sure that
the existing documentation abides by the JSDoc formatting rules. I did flesh out some
documentation here and there, but writing new / updating / clarifying documentation is
left as later work.

Differential Revision: https://phabricator.services.mozilla.com/D163133
2022-12-06 14:46:41 +00:00
Mark Banner
95357f3083 Bug 1802855 - Convert toolkit/components/satchel JSM modules to ES modules. r=credential-management-reviewers,daleharvey,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D163201
2022-11-29 15:53:20 +00:00
brian
be3a6d1b65 Bug 1673047 - Remove browser.migrate.showBookmarksToolbarAfterMigration pref and set the default behavior to the 'true' branch. r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D161375
2022-11-22 15:30:56 +00:00
Marian-Vasile Laza
bff0d2da74 Backed out changeset ef5db6a50556 (bug 1673047) for causing xpcshell failures on test_IE_bookmarks.js. CLOSED TREE 2022-11-16 04:10:02 +02:00
brian
6b1b824b72 Bug 1673047 - Remove browser.migrate.showBookmarksToolbarAfterMigration pref and set the default behavior to the 'true' branch. r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D161375
2022-11-15 21:08:14 +00:00
steven100695
a3f2b1c51f Bug 1788919 - Convert browser/components/migration JSM modules to ESMs. r=mconley,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D158655
2022-10-27 23:52:49 +00:00
Noemi Erli
01a2d27871 Backed out 2 changesets (bug 1788919) for causing failures in browser_noLoginsView.js CLOSED TREE
Backed out changeset 2f03490ec72e (bug 1788919)
Backed out changeset 449aea6fc974 (bug 1788919)
2022-10-27 23:45:56 +03:00
steven100695
14e60b6839 Bug 1788919 - Convert browser/components/migration JSM modules to ESMs. r=mconley,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D158655
2022-10-27 18:15:55 +00:00
Renamed from browser/components/migration/SafariProfileMigrator.jsm (Browse further)