nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
865198 commits 1 branch 98 tags 6.4 GiB
Commit graph

71 commits

Author SHA1 Message Date
Niklas Baumgardner
31d21cfa94 Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-14 15:57:46 +00:00
Norisz Fay
ba48d1612a Backed out changeset 9ec09eb75c9f (bug 1842037) for causing bc failures on browser_screenshots_drag_test.js CLOSED TREE 2023-11-14 04:06:58 +02:00
Niklas Baumgardner
cf3a00db17 Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-13 23:57:17 +00:00
Sam Foster
8165b4bf88 Bug 1845796 - Rework the flow in ScreenshotsUtils to make exit an explicit outcome rather than a side-effect. r=niklas 
* Add a UIPhases / getUIPhase to figure out where we are in the flow, and get the UI into the right state
* Refactor to get rid of a bunch of implicit side-effects:
  - Separate out getting the panel from creating it
  - closePanel only closes the buttons panel
  - Add a closeOverlay so we do that and only that when needed
* When the preview dialog closes, we expect to exit unless exitOnPreviewClose was set false
* Keep some state for each browser using a weakmap so we can better handle re-entry (and later, re-focusing)

Differential Revision: https://phabricator.services.mozilla.com/D185379
 2023-09-19 00:14:27 +00:00
Niklas Baumgardner
136f09bcf6 Bug 1832667 - Add ConfirmationHint when screenshot is copied. r=sfoster,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D178674
 2023-05-25 14:27:24 +00:00
Mark Banner
2a53076d43 Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177938
 2023-05-20 12:26:56 +00:00
Sam Foster
952981ddac Bug 1832171 - Link the packaged platform-specific common stylesheets in Screenshots. r=niklas,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D177569
 2023-05-10 15:55:46 +00:00
Niklas Baumgardner
6efe17252a Bug 1805984 - Update save visible and save full page screenshot buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D176081
 2023-05-03 17:53:15 +00:00
Niklas Baumgardner
cb1468a860 Bug 1824430 - Update screenshots buttons styling. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D173708
 2023-03-30 15:30:21 +00:00
Niklas Baumgardner
7af2440201 Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D172043
 2023-03-30 15:30:21 +00:00
Iulian Moraru
7b8409fc77 Backed out 2 changesets (bug 1824430, bug 1812631) for causing multiple mochitest failures. CLOSED TREE 
Backed out changeset 500e6e1d7092 (bug 1824430)
Backed out changeset 6d0d5de3be6e (bug 1812631)
 2023-03-30 04:44:53 +03:00
Niklas Baumgardner
b5b1a040f1 Bug 1824430 - Update screenshots buttons styling. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D173708
 2023-03-30 00:36:32 +00:00
Niklas Baumgardner
167ba02296 Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D172043
 2023-03-30 00:36:31 +00:00
Niklas Baumgardner
c057486ca0 Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-25 17:26:34 +00:00
Marian-Vasile Laza
5a3faecdb0 Backed out changeset d853ddfd853e (bug 1801019) for bc failures on browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-23 21:11:16 +02:00
Niklas Baumgardner
26e4c6bc8a Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-23 17:37:01 +00:00
Butkovits Atila
f8a9ce74db Backed out changeset aaf82d1483ad (bug 1801019) for causing failures at browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-21 23:04:05 +02:00
Niklas Baumgardner
ab7aa855c8 Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-21 19:59:09 +00:00
Niklas Baumgardner
f75d08ab66 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-12-06 00:06:20 +00:00
Stanca Serban
7515134a78 Backed out changeset b080b41aecf4 (bug 1785293) for causing bc failures on browser_screenshots_test_escape.js. CLOSED TREE 2022-12-02 16:39:01 +02:00
Niklas Baumgardner
42e1023b26 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-12-02 13:45:57 +00:00
Marian-Vasile Laza
5da98a3a05 Backed out changeset 1fdf3fc76d06 (bug 1785293) for causing bc failures on browser_screenshots_drag_test.js. CLOSED TREE 2022-11-30 22:53:47 +02:00
Niklas Baumgardner
8350b30596 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-11-30 15:00:33 +00:00
Cieara Meador
23f2900806 Bug 1794142 - Screenshots module buttom HCM r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D162044
 2022-11-17 22:50:18 +00:00
Cristian Tuns
52cb72774f Backed out changeset 57d19e70e34c (bug 1794142) for causing mochitest failures in browser_parsable_css.js CLOSED TREE 2022-11-16 16:11:06 -05:00
Cieara Meador
835634ecc4 Bug 1794142 - Screenshots module buttom HCM r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D162044
 2022-11-16 19:31:49 +00:00
Marian-Vasile Laza
252c199704 Backed out changeset 7c0eb6e89712 (bug 1785293) for causing bc failures on browser_screenshots_test_downloads.js. CLOSED TREE 2022-11-11 02:36:29 +02:00
Niklas Baumgardner
eee2b35e37 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-11-10 22:21:11 +00:00
Mark Banner
18753bfe42 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D161013
 2022-11-07 17:56:10 +00:00
Mark Banner
8d1ebcb9d6 Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Tooru Fujisawa
54623364da Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Andreea Pavel
7738a75fdd Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
8cd6ed7409 Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-11 15:09:13 +00:00
Tooru Fujisawa
bf93d07148 Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D150894
 2022-07-11 12:41:50 +00:00
Niklas Baumgardner
9ada5c2e06 Bug 1741740 - Add draggable selection ui for screenshots component. r=sfoster,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D138494
 2022-05-06 15:45:52 +00:00
Niklas Baumgardner
cb539fff0e Bug 1751060 - Add fallback color and removed st2 class for screenshots SVGs. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D136417
 2022-01-20 19:52:38 +00:00
Alexandru Michis
c5d4f89a03 Backed out changeset 338f8b736b41 (bug 1747429) as requested by sfoster. 2022-01-20 20:58:34 +02:00
Sam Foster
d292d48758 Bug 1747429 - Replace preprocessor urlbar* variables with CSS vars. r=dao 
* Define urlbarMarginInline and urlbarSearchButtonWidth as CSS rather than preprocessor variables
* Replace the urlbarViewPadding, urlbarViewFaviconWidth and urlbarViewIconMarginEnd preprocessor variables with CSS vars.
* Remove %ifdefs around the license comment in these 2 files
* Update ambiguous/out-of-date comment in the skeleton UI code

Differential Revision: https://phabricator.services.mozilla.com/D135962
 2022-01-20 00:48:42 +00:00
Niklas Baumgardner
7b9254918c Bug 1745045 - Clicking child of screenshots preview button behaves correctly. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D133276
 2021-12-15 19:54:16 +00:00
Niklas Baumgardner
f8ae22b846 Bug 1740029 - Add retry button for screenshots ui. r=sfoster,fluent-reviewers,Gijs,jaws 
Differential Revision: https://phabricator.services.mozilla.com/D131381
 2021-12-07 16:57:53 +00:00
Niklas Baumgardner
1a3b424909 Bug 1741987 - screenshots.html titles to Fluent. r=Gijs,fluent-reviewers,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D131637
 2021-11-22 14:47:14 +00:00
Sam Foster
861b4bbc43 Bug 1736429 - Set up jswindowactors for screenshots and pass dimensions and scroll offsets from the child. r=mconley,sfoster 
* Add jswindowactors for the Screenshots component, to facilitate communication between the UI (lives in the parent) and the content document.
* Fetch content document dimensions/offsets with e.g: `ScreenshotsUtils.fetchContentBounds(gBrowser.selectedBrowser)`.

Differential Revision: https://phabricator.services.mozilla.com/D129326
 2021-11-19 15:25:19 +00:00
Niklas Baumgardner
c0129a4a68 Bug 1739209 - Border color to follow theme in svg for screenshots buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D130479
 2021-11-11 19:50:59 +00:00
Niklas Baumgardner
527568806d Bug 1735614 - Building initial save visible / save full page UI in the tab modal. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D128516
 2021-11-04 17:57:29 +00:00
Butkovits Atila
661953d2d9 Backed out changeset 1884a0785032 (bug 1735614) for causing failures at browser_all_files_referenced.js. CLOSED TREE 2021-11-03 22:50:51 +02:00
Niklas Baumgardner
5d70e45896 Bug 1735614 - Building initial save visible / save full page UI in the tab modal. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D128516
 2021-11-03 19:29:17 +00:00
Niklas Baumgardner
25d5bcddbd Bug 1734910 - Toggle screenshots UI for screenshots component. r=sfoster 
This patch removes the disabled state from the screenshots button when the screenshots ui is activated. The button now works as a toggle to activate and deactivate the screenshots ui.
The screenshots button is still disabled on about pages.
For this patch we only need to check if there is an open dialog box for the screenshots ui and if it is open then we close the dialog box, otherwise open a new one.

Differential Revision: https://phabricator.services.mozilla.com/D128410
 2021-10-21 18:06:54 +00:00
Niklas Baumgardner
cc869830d5 Bug 1733639 - Use toBlob instead of toDataURL. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D127303
 2021-10-14 15:15:58 +00:00
Niklas Baumgardner
023e10a432 Bug 1725433 - Replace placeholder image with a screenshot of the current viewport in new screenshots UI. r=emalysz 
Differential Revision: https://phabricator.services.mozilla.com/D126292
 2021-09-21 22:52:29 +00:00
Kajal Sah
337d8e8e1c Bug 1725432 - Disables toolbar button when new screenshots UI is showing. r=emalysz 
Differential Revision: https://phabricator.services.mozilla.com/D122965
 2021-08-24 17:49:28 +00:00