nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
911429 commits 1 branch 98 tags 6.4 GiB
Commit graph

64 commits

Author SHA1 Message Date
Dave Townsend
95ccf713ef Bug 1864896: Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao 
Differential Revision: https://phabricator.services.mozilla.com/D202949
 2024-03-19 14:59:20 +00:00
Valentin Gosu
36cdb65832 Bug 1824218 - Close captive portal page even if it navigated to support.mozilla.org r=mconley 
In bug 1433500 we made the canonical URI be a meta refresh to a SUMO page in
order to show the user useful information if they happen to unlock the captive
portal just as the page is loading.

The portal watcher will close the tab if its location is
http://detectportal.firefox.com/canonical.html, but since the page will do a
meta refresh, its URL might be support.mozilla.org at that point, so we
make sure to also close it if it's already refreshed so it doesn't stick
around and urge the user to file a bug about it :)

Differential Revision: https://phabricator.services.mozilla.com/D200928
 2024-02-09 20:12:07 +00:00
Andrew Creskey
ef6dd39d7f Bug 1868145 - Record telemetry for how often we display the Captive Portal banner to users r=necko-reviewers,jesup,valentin 
Collect scalars on key captive portal events so we can better understand usage.

Differential Revision: https://phabricator.services.mozilla.com/D195816
 2024-01-22 14:33:42 +00:00
Hanna Jones
486ebc0ee0 Bug 1845150 - Update notificationbox usage for captive portal notification r=reusable-components-reviewers,tgiles 
Can be tested locally by running this code in the browser toolbox:

```js
gBrowser.selectedBrowser.ownerGlobal.CaptivePortalWatcher._showNotification();
```

Depends on D194313

Differential Revision: https://phabricator.services.mozilla.com/D194314
 2024-01-10 18:55:31 +00:00
Norisz Fay
0d4fc02631 Backed out 7 changesets (bug 1845150) for causing failures on browser_datachoices_notification.js CLOSED TREE 
Backed out changeset a07c835a4bf7 (bug 1845150)
Backed out changeset 0016d7f4e556 (bug 1845150)
Backed out changeset 46cfe5fe6e6a (bug 1845150)
Backed out changeset 83190b8a08d0 (bug 1845150)
Backed out changeset ada948351267 (bug 1845150)
Backed out changeset 7aa4340bfd96 (bug 1845150)
Backed out changeset 683745289588 (bug 1845150)
 2024-01-05 18:52:01 +02:00
Hanna Jones
054cf00051 Bug 1845150 - Update notificationbox usage for captive portal notification r=reusable-components-reviewers,tgiles 
Can be tested locally by running this code in the browser toolbox:

```js
gBrowser.selectedBrowser.ownerGlobal.CaptivePortalWatcher._showNotification();
```

Differential Revision: https://phabricator.services.mozilla.com/D194314
 2024-01-05 15:04:19 +00:00
Cosmin Sabou
45ad585956 Backed out 7 changesets (bug 1845150) for causing dt failures on browser_screenshot_button_warning. CLOSED TREE 
Backed out changeset fdc3f1b5e5ae (bug 1845150)
Backed out changeset ba7789c89bdd (bug 1845150)
Backed out changeset 6c405863be54 (bug 1845150)
Backed out changeset f66e8bb15e18 (bug 1845150)
Backed out changeset a75fe63bd39f (bug 1845150)
Backed out changeset 91365291f80f (bug 1845150)
Backed out changeset 7477fd1c48fa (bug 1845150)
 2024-01-04 18:53:25 +02:00
Hanna Jones
7fcf629581 Bug 1845150 - Update notificationbox usage for captive portal notification r=reusable-components-reviewers,tgiles 
Can be tested locally by running this code in the browser toolbox:

```js
gBrowser.selectedBrowser.ownerGlobal.CaptivePortalWatcher._showNotification();
```

Differential Revision: https://phabricator.services.mozilla.com/D194314
 2024-01-04 15:31:13 +00:00
Dan Mosedale
32925b5fc4 Bug 1811150 - remove captive_portal.login* telemetry,r=barret,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D169405
 2023-02-10 03:52:51 +00:00
lyavor
545ca5ab31 Bug 1730920 - Https only mode shouldn't be triggered by the wifi portal code. r=nhnt11,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D131125
 2021-12-13 13:32:11 +00:00
Nihanth Subramanya
b53d383be3 Bug 1743148 - Call ensureCaptivePortalTab() directly from NetErrorParent instead of firing an obs notification. r=lyavor,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D132254
 2021-12-04 01:49:43 +00:00
Butkovits Atila
13de1c3770 Backed out changeset dbd90d486efd (bug 1743148) for causing failures at browser_captivePortal_certErrorUI.js. CLOSED TREE 2021-12-04 01:07:26 +02:00
Nihanth Subramanya
77a737b1a4 Bug 1743148 - Call ensureCaptivePortalTab() directly from NetErrorParent instead of firing an obs notification. r=lyavor,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D132254
 2021-12-03 21:52:41 +00:00
criss
67b2c3928c Backed out changeset f03fa07c78df (bug 1743148) for causing failures on browser_captivePortal_certErrorUI.js. CLOSED TREE 2021-12-03 22:15:36 +02:00
Nihanth Subramanya
c80b5b3dfc Bug 1743148 - Call ensureCaptivePortalTab() directly from NetErrorParent instead of firing an obs notification. r=lyavor,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D132254
 2021-12-03 19:16:48 +00:00
Neil Deakin
a62618baa7 Bug 1690390, change appendNotification to take a smaller number of arguments: the string type value, a dictionary containing the notification details, and the button list, r=mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D107755
 2021-09-17 09:04:59 +00:00
Narcis Beleuzu
72152613c6 Backed out 3 changesets (bug 1690390) for mochitest failures on test_notificationbox.xhtml . CLOSED TREE 
Backed out changeset e6404b7424cd (bug 1690390)
Backed out changeset a161177099af (bug 1690390)
Backed out changeset cc7e02d3d418 (bug 1690390)
 2021-09-16 23:41:21 +03:00
Neil Deakin
82501df9f7 Bug 1690390, change appendNotification to take a smaller number of arguments: the string type value, a dictionary containing the notification details, and the button list, r=mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D107755
 2021-09-16 19:11:17 +00:00
Dan Mosedale
7a569a1ce6 Bug 1728057 - fix captive portal telemetry, r=nhnt11 
Differential Revision: https://phabricator.services.mozilla.com/D123911
 2021-08-30 13:49:25 +00:00
Butkovits Atila
f0d3689c30 Backed out 3 changesets (bug 1724108) as requested by Dan. CLOSED TREE 
Backed out changeset 0bdbea37f84f (bug 1724108)
Backed out changeset 91aa3dd65624 (bug 1724108)
Backed out changeset 5e57386eae33 (bug 1724108)
 2021-08-21 01:06:14 +03:00
Dan Mosedale
26912a6f9f Bug 1724108 - Don't send captive-portal-login-success-after-button-pressed in some cases, r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D121936
 2021-08-11 22:07:43 +00:00
Dan Mosedale
7565145cdf Bug 1724108 - Only show captive portal VPN promo after button press, r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D121935
 2021-08-11 21:22:18 +00:00
Barret Rennie
0b01559886 Bug 1722834 - Implement telemetry for captive portal detection and login r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D121665
 2021-08-04 15:25:14 +00:00
Neil Deakin
b143d2943a Bug 1714337, remove separate high and non-high notification box references, r=mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D121083
 2021-07-28 18:24:42 +00:00
Mark Striemer
f1d9abc078 Bug 1702327 - Fix captive portal tests r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D110626
 2021-04-06 04:26:33 +00:00
prathiksha
75c7060274 Bug 1303775 - Fix race conditions prevalent with closing captive portal tabs that re-direct to the canonicalURL after successful login/abort. r=johannh,nhnt11 
Differential Revision: https://phabricator.services.mozilla.com/D65554

--HG--
extra : moz-landing-system : lando
 2020-03-26 19:04:59 +00:00
Stefan Hindli
bcca559238 Backed out changeset 6b86d0dfff95 (bug 1303775) for causing perma bc failures in browser/base/content/test/captivePortal/browser_CaptivePortalWatcher.js CLOSED TREE 2020-03-26 15:52:02 +02:00
prathiksha
743ccb63ac Bug 1303775 - Fix race conditions prevalent with closing captive portal tabs that re-direct to the canonicalURL after successful login/abort. r=johannh,nhnt11 
Differential Revision: https://phabricator.services.mozilla.com/D65554

--HG--
extra : moz-landing-system : lando
 2020-03-26 12:43:11 +00:00
prathiksha
8649f633e8 Bug 1313577 - Forget references to the captive portal tab once login has succeeded or aborted. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D63765

--HG--
extra : moz-landing-system : lando
 2020-03-04 13:13:37 +00:00
Nihanth Subramanya
ba28d4e4a2 Bug 1608713 - Add nsIWebNavigation load flags to force TRR mode and use them to load captive portal tabs with TRR disabled. r=valentin,Gijs,baku 
Differential Revision: https://phabricator.services.mozilla.com/D60860

--HG--
extra : moz-landing-system : lando
 2020-01-24 17:18:35 +00:00
Victor Porof
f9f5914039 Bug 1561435 - Format browser/base/, a=automatic-formatting 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041

--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
 2019-07-05 09:48:57 +02:00
Nihanth Subramanya
665d6f3c26 Bug 1558023 - Make CaptivePortalWatcher._showNotification idempotent. r=MattN 
Differential Revision: https://phabricator.services.mozilla.com/D35546

--HG--
extra : moz-landing-system : lando
 2019-06-21 18:02:40 +00:00
prathiksha
04f8eeac8f Bug 1544610 - Part 1 - Have certerror captive portal message exchanges happen over RPM. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D28539

--HG--
extra : moz-landing-system : lando
 2019-05-03 23:30:35 +00:00
Pavithra
d531649527 Bug 1531008: Replace makeURI with Services.io.newURI r=johannh 
Replaced makeURI with Services.io.newURI

Differential Revision: https://phabricator.services.mozilla.com/D21404

--HG--
extra : moz-landing-system : lando
 2019-02-28 11:32:18 +00:00
Paolo Amadini
f6b106efb2 Bug 1496827 - Remove the "notification" binding. r=bgrins 
Differential Revision: https://phabricator.services.mozilla.com/D11650

--HG--
rename : browser/components/customizableui/content/.eslintrc.js => browser/components/translation/content/.eslintrc.js
rename : browser/components/translation/jar.mn => browser/components/translation/content/jar.mn
rename : browser/components/translation/microsoft-translator-attribution.png => browser/components/translation/content/microsoft-translator-attribution.png
rename : browser/components/customizableui/content/moz.build => browser/components/translation/content/moz.build
rename : browser/components/translation/translation-infobar.xml => browser/components/translation/content/translation-notification.js
extra : rebase_source : 598396d2da96b04782413946976f7bb9fb6be75f
 2018-11-13 12:56:42 +00:00
Paolo Amadini
ce13039af3 Bug 1471403 - Part 2 - Lazify the creation of "notificationbox" elements. r=dao,bgrins 
Differential Revision: https://phabricator.services.mozilla.com/D10892

--HG--
extra : rebase_source : f66fe90d780c3d446f4a065c0397cbb37f43cb0c
 2018-11-09 14:38:49 +00:00
Dão Gottwald
870f76961c Bug 1490627 - browser-captivePortal.js leaks cps variable into the browser window's global scope. r=nhnt11 2018-09-12 12:37:37 +02:00
Dão Gottwald
ea0f7105ea Bug 1490617 - CaptivePortalWatcher reads the captivedetect.portalRecheckDelayMS pref before being initialized. r=nhnt11 2018-09-12 11:54:16 +02:00
Dão Gottwald
87b1e322e2 Bug 1489552 - Let BrowserWindowTracker.getTopWindow use the module's internal window list instead of nsIWindowMediator::getZOrderDOMWindowEnumerator / getMostRecentWindow. r=nhnt11 2018-09-10 22:27:38 +02:00
Gijs Kruitbosch
ef7146a4be Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11 
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : rebase_source : e51b66bb18d0e600814b48d5cd3ec9d5dea3028a
extra : source : 96b5a88ac0041a1bd382a731749e1fca9aa911ed
 2018-09-03 14:43:38 +01:00
Margareta Eliza Balazs
5ddcd7b745 Backed out changeset 96b5a88ac004 (bug 1486824) for causing frequent failures e.g: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js a=backout 2018-08-31 12:17:27 +03:00
Gijs Kruitbosch
9d70cb3843 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11 
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
 2018-08-30 15:07:36 +00:00
Narcis Beleuzu
a4ec006bb0 Backed out changeset 4e195f7b2d6b (bug 1486824) for clipboard failures on OSX browser_editcontrols_update. a=backout 2018-08-30 15:59:59 +03:00
Gijs Kruitbosch
a8e2b8e702 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11 
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
 2018-08-29 17:58:25 +00:00
Jonathan Kingston
9b7fb2f20c Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb r=Gijs 
Reviewers: ckerschb!, Gijs!

Tags: #secure-revision

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046

--HG--
extra : source : 44b25dea67d2ed079e17057ab619d827e9983400
extra : amend_source : 5742820277e0269b6f5d42b1abd98fd9b228ac4a
extra : histedit_source : 790bd2490333e4d8fea7774d036eafbc2fc329b9
 2018-07-06 15:14:54 +01:00
dvarga
12f19b94e9 Backed out 2 changesets (bug 1362034) for failure at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE 
Backed out changeset 1c3329958b8a (bug 1362034)
Backed out changeset f68b1b76af36 (bug 1362034)

--HG--
extra : histedit_source : 6169c5ffe856266d3bc8b2ca32f4b67054c71bbe
 2018-08-08 22:11:56 +03:00
Jonathan Kingston
f389570122 Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb,Gijs 
Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Subscribers: mixedpuppy, reviewbot

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046

--HG--
extra : rebase_source : ea688b35744f970e74de3039da3973f1177d8577
extra : amend_source : 89efdb8ccec2c334a83155eec6b30f08fa0f7074
 2018-08-08 20:03:55 +03:00
Andreea Pavel
f5c1119983 Backed out 2 changesets (bug 1362034) for failing damp | inspector/cold-open.js on a CLOSED TREE 
Backed out changeset 8c8925b75aa2 (bug 1362034)
Backed out changeset ff6b05c96094 (bug 1362034)
 2018-08-06 20:42:44 +03:00
Jonathan Kingston
9be2ebdb53 Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb,Gijs 
Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Subscribers: reviewbot

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046

--HG--
extra : rebase_source : 57c6bda461781ec20f0ceba8d1dd9c48778bf568
extra : amend_source : 2eebbf1e7df91697ce984d2845dbae41f9dcbcbd
 2018-08-06 19:54:47 +03:00
Mike de Boer
ecf63670d4 Bug 1034036 - Part 2: Rename and shorten getMostRecentBrowserWindow to getTopWindow and modernize the style used in BrowserWindowTracker.jsm. r=dao 
MozReview-Commit-ID: EvgAhq4uR3a

--HG--
extra : rebase_source : 8fd8040cd1eee94675d4e9ca0c8ccc60db9e1bf7
 2018-04-11 12:05:59 +02:00