Commit graph

50 commits

Author SHA1 Message Date
Nicholas Nethercote
b71747b2ac Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.

--HG--
extra : rebase_source : 886e57a9e433e0cb6ed635cc075b34b7ebf81853
2016-09-01 15:01:16 +10:00
Decky Coss
646f325157 Bug 1277019 - Change header and status parsing methods to take nsACString instead of char array. r=mayhemer
MozReview-Commit-ID: 7ZNwvnTMCzo

--HG--
extra : transplant_source : %E7T%DC%83%08%22%11%92%A4%2C%89G%1C%88%B3L%0D%7D%FA%FC
2016-05-31 12:42:15 -04:00
Chris Peterson
2dec5055ef Bug 1274162 - Fix -Wshadow warnings in netwerk/protocol/http/ directory. r=mcmanus
netwerk/protocol/http/nsHttpHeaderArray.h:96:63 [-Wshadow] declaration shadows a field of 'mozilla::net::nsHttpHeaderArray::nsEntry'
netwerk/protocol/http/Http2Session.cpp:2766:14 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/HttpBaseChannel.cpp:1886:14 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/HttpChannelChild.cpp:265:53 [-Wshadow] declaration shadows a field of 'mozilla::net::AssociateApplicationCacheEvent'
netwerk/protocol/http/HttpChannelChild.cpp:266:53 [-Wshadow] declaration shadows a field of 'mozilla::net::AssociateApplicationCacheEvent'
netwerk/protocol/http/HttpChannelChild.cpp:2566:14 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/HttpChannelParent.cpp:397:17 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/InterceptedChannel.cpp:276:14 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/InterceptedChannel.cpp:285:14 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/SpdySession31.cpp:2177:14 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/nsCORSListenerProxy.cpp:304:30 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/nsHttpChannel.cpp:796:17 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/nsHttpChannel.cpp:4474:35 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/nsHttpChannel.cpp:5915:18 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/nsHttpConnection.cpp:982:21 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/nsHttpConnectionMgr.cpp:1220:43 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/nsHttpConnectionMgr.cpp:1240:43 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/nsHttpConnectionMgr.cpp:2247:27 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/nsHttpConnectionMgr.cpp:2758:23 [-Wshadow] declaration shadows a local variable
netwerk/protocol/http/nsHttpPipeline.cpp:709:30 [-Wshadow] declaration shadows a local variable
2016-05-10 23:57:24 -07:00
Ben Kelly
46ccf135c6 Bug 1261784 Make sure InterceptedChannel body streams are always closed. r=jdm 2016-04-04 13:24:05 -07:00
Daniel Holbert
9b70d28e34 Bug 1249450 part 1: Move GetSecureUpgradedURI from HttpBaseChannel to nsNetUtil. r=mcmanus 2016-03-10 15:23:45 -08:00
Patrick McManus
7ed406b2be Bug 1238290 - fix bad necko deps on unified_sources r=valentin.gosu
---
 netwerk/base/ARefBase.h                            |  2 ++
 netwerk/base/CaptivePortalService.cpp              |  1 +
 netwerk/base/CaptivePortalService.h                |  1 +
 netwerk/base/EventTokenBucket.cpp                  |  4 +++-
 netwerk/base/LoadContextInfo.cpp                   |  3 +++
 netwerk/base/LoadInfo.cpp                          |  3 +++
 netwerk/base/MemoryDownloader.cpp                  |  1 +
 netwerk/base/Predictor.cpp                         |  1 +
 netwerk/base/RedirectChannelRegistrar.h            |  1 +
 netwerk/base/nsBaseChannel.cpp                     |  1 +
 netwerk/base/nsChannelClassifier.cpp               |  1 +
 netwerk/base/nsDirectoryIndexStream.cpp            |  3 ++-
 netwerk/base/nsDownloader.cpp                      |  1 +
 netwerk/base/nsIOService.cpp                       |  1 +
 netwerk/base/nsIncrementalDownload.cpp             |  3 +++
 netwerk/base/nsNetUtil.cpp                         |  4 ++++
 netwerk/base/nsNetUtil.h                           |  1 +
 netwerk/base/nsProtocolProxyService.cpp            |  1 +
 netwerk/base/nsSecCheckWrapChannel.cpp             |  2 ++
 netwerk/base/nsUDPSocket.cpp                       |  4 +++-
 netwerk/cache/nsDiskCacheBinding.cpp               |  2 +-
 netwerk/cache/nsDiskCacheDeviceSQL.cpp             |  2 ++
 netwerk/cache/nsMemoryCacheDevice.cpp              |  2 +-
 netwerk/cache2/CacheFileUtils.cpp                  |  2 ++
 netwerk/cache2/CacheStorageService.h               |  1 +
 netwerk/ipc/NeckoParent.cpp                        |  1 +
 netwerk/ipc/RemoteOpenFileChild.cpp                |  1 +
 netwerk/protocol/about/nsAboutBloat.cpp            |  1 +
 netwerk/protocol/about/nsAboutCacheEntry.cpp       |  1 +
 netwerk/protocol/about/nsAboutProtocolHandler.cpp  |  1 +
 netwerk/protocol/data/DataChannelParent.cpp        |  1 +
 netwerk/protocol/file/nsFileProtocolHandler.cpp    |  1 +
 netwerk/protocol/ftp/FTPChannelParent.cpp          |  2 ++
 netwerk/protocol/ftp/FTPChannelParent.h            |  1 +
 netwerk/protocol/ftp/nsFtpConnectionThread.cpp     |  1 +
 netwerk/protocol/ftp/nsFtpProtocolHandler.h        |  1 +
 netwerk/protocol/http/Http2Compression.cpp         |  1 +
 netwerk/protocol/http/Http2Session.cpp             |  1 +
 netwerk/protocol/http/Http2Stream.h                |  2 ++
 netwerk/protocol/http/HttpBaseChannel.cpp          |  4 ++++
 netwerk/protocol/http/HttpBaseChannel.h            |  1 +
 netwerk/protocol/http/HttpChannelChild.cpp         | 25 ++--------------------
 netwerk/protocol/http/HttpChannelChild.h           | 24 +++++++++++++++++++++
 netwerk/protocol/http/HttpChannelParent.cpp        |  1 +
 netwerk/protocol/http/HttpChannelParent.h          |  1 +
 .../protocol/http/HttpChannelParentListener.cpp    |  1 +
 netwerk/protocol/http/HttpChannelParentListener.h  |  1 +
 netwerk/protocol/http/InterceptedChannel.cpp       |  1 +
 netwerk/protocol/http/NullHttpChannel.cpp          |  1 +
 netwerk/protocol/http/NullHttpTransaction.cpp      |  1 +
 netwerk/protocol/http/PackagedAppService.cpp       | 14 ++++++++++--
 netwerk/protocol/http/PackagedAppService.h         |  4 +++-
 netwerk/protocol/http/PackagedAppVerifier.cpp      |  1 +
 netwerk/protocol/http/nsCORSListenerProxy.cpp      |  2 +-
 netwerk/protocol/http/nsHttpBasicAuth.cpp          |  1 +
 netwerk/protocol/http/nsHttpChannel.cpp            |  2 ++
 netwerk/protocol/http/nsHttpChunkedDecoder.cpp     |  1 +
 netwerk/protocol/http/nsHttpConnectionInfo.cpp     |  2 ++
 netwerk/protocol/http/nsHttpConnectionMgr.cpp      |  1 +
 netwerk/protocol/http/nsHttpDigestAuth.cpp         |  1 +
 netwerk/protocol/viewsource/nsViewSourceHandler.h  |  4 ++++
 .../protocol/websocket/BaseWebSocketChannel.cpp    |  1 +
 .../websocket/WebSocketEventListenerParent.cpp     |  1 +
 .../protocol/websocket/WebSocketEventService.cpp   |  3 +++
 netwerk/protocol/websocket/WebSocketFrame.cpp      |  2 ++
 netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp      |  1 +
 .../protocol/wyciwyg/nsWyciwygProtocolHandler.cpp  |  1 +
 netwerk/streamconv/converters/mozTXTToHTMLConv.cpp |  1 +
 .../streamconv/converters/nsFTPDirListingConv.cpp  |  1 +
 .../streamconv/converters/nsHTTPCompressConv.cpp   |  2 ++
 netwerk/streamconv/converters/nsHTTPCompressConv.h |  1 +
 netwerk/streamconv/converters/nsIndexedToHTML.cpp  |  1 +
 netwerk/streamconv/converters/nsMultiMixedConv.cpp |  2 ++
 netwerk/streamconv/converters/nsTXTToHTMLConv.cpp  |  2 ++
 netwerk/streamconv/converters/nsUnknownDecoder.cpp |  2 ++
 75 files changed, 147 insertions(+), 32 deletions(-)
2016-01-08 20:20:50 -05:00
Ehsan Akhgari
40c82fa10c Bug 1236686 - Remove nsIFetchEventDispatcher; r=jdm 2016-01-05 15:04:41 -05:00
Ehsan Akhgari
69ce1d24d9 Bug 1214305 - Part 6: Use a non-IPC redirect for synthesized upgraded responses to ensure the response URL is correctly propagated; r=mcmanus 2016-01-04 16:30:02 -05:00
Ehsan Akhgari
a48f3795ae Bug 1214305 - Part 3: Add a nsIInterceptedChannel.secureUpgradedChannelURI helper; r=jdm 2016-01-04 16:30:02 -05:00
Wes Kocher
dbbade6e75 Backed out 10 changesets (bug 1214305) for leaks on linux debug m-e10s(bc7)
Backed out changeset 1f482566235a (bug 1214305)
Backed out changeset 001b31489756 (bug 1214305)
Backed out changeset 4e94d2088219 (bug 1214305)
Backed out changeset fba4a5bcea41 (bug 1214305)
Backed out changeset 100f8e249007 (bug 1214305)
Backed out changeset a59c453192dc (bug 1214305)
Backed out changeset 2daa86fc1fb9 (bug 1214305)
Backed out changeset c04efb57b0ed (bug 1214305)
Backed out changeset 52046e843c60 (bug 1214305)
Backed out changeset ac4fd6615828 (bug 1214305)

--HG--
extra : commitid : ILmaVumvmvH
2016-01-04 10:34:24 -08:00
Ehsan Akhgari
1927591d62 Bug 1214305 - Part 6: Use a non-IPC redirect for synthesized upgraded responses to ensure the response URL is correctly propagated; r=mcmanus 2016-01-04 09:52:45 -05:00
Ehsan Akhgari
17e63f2856 Bug 1214305 - Part 3: Add a nsIInterceptedChannel.secureUpgradedChannelURI helper; r=jdm 2016-01-04 09:52:40 -05:00
Ben Kelly
3fcfa5995a Bug 1233962 P1 Call ResetInterception() if the controller is nullptr. r=jdm 2015-12-22 11:57:10 -08:00
Ben Kelly
d6cd5e961e Bug 1217909 P8 Track navigation interceptions per scope in ServiceWorkerManager. r=catalinb 2015-11-16 08:04:11 -08:00
Phil Ringnalda
596e8ff827 Back out 9 changesets (bug 1214305) for e10s devtools browser_bug1045902_console_csp_ignore_reflected_xss_message.js failures
Backed out changeset 82929be36e95 (bug 1214305)
Backed out changeset e926606aefbf (bug 1214305)
Backed out changeset 226c83ca9a2a (bug 1214305)
Backed out changeset 88ab26108f2d (bug 1214305)
Backed out changeset 2e3e4f256d46 (bug 1214305)
Backed out changeset 347cd0f8f1e3 (bug 1214305)
Backed out changeset be072bba15fc (bug 1214305)
Backed out changeset 3b85acbe7be7 (bug 1214305)
Backed out changeset 49b930683c02 (bug 1214305)
2015-11-14 10:09:58 -08:00
Ehsan Akhgari
cef4c60f16 Bug 1214305 - Part 6: Use a non-IPC redirect for synthesized upgraded responses to ensure the response URL is correctly propagated; r=mcmanus 2015-11-02 11:27:00 -05:00
Ehsan Akhgari
03d8835f92 Bug 1214305 - Part 3: Add a nsIInterceptedChannel.secureUpgradedChannelURI helper; r=jdm 2015-11-02 11:27:00 -05:00
Ben Kelly
8267928bb3 Bug 1220007 P2 Make InterceptedChannel's collect logs locally and only flush to nsIChannel on main thread r=bz 2015-11-03 11:20:56 -08:00
Carsten "Tomcat" Book
042b4d64cd Backed out changeset d8d75be11275 (bug 1220007) 2015-11-03 14:08:04 +01:00
Ben Kelly
537f8dad54 Bug 1220007 P2 Make InterceptedChannel's collect logs locally and only flush to nsIChannel on main thread r=bz 2015-11-02 12:04:29 -08:00
Ben Kelly
69c8a55480 Bug 1215140 P10 Avoid AddRef'ing the nsIChannel OMT. r=bz 2015-10-29 19:53:25 -07:00
Ehsan Akhgari
0549164d1b Bug 1206298 - Part 1: Update the expiration time on the fake cache entry object for an intercepted request in the non-e10s case; r=mcmanus 2015-10-27 11:58:29 -04:00
Josh Matthews
de85fb3b8a Bug 1173811 - Part 2: Propagate the response URL to intercepted channels when necessary (e10s). r=mayhemer,bkelly 2015-10-22 09:23:48 -04:00
Josh Matthews
d3726427db Bug 1173811 - Part 1: Propagate the response URL to intercepted channels when necessary (non-e10s). r=mayhemer,bkelly 2015-10-22 09:23:39 -04:00
Phil Ringnalda
6401c0185c Back out 2 changesets (bug 1173811) for test_synthesized_response.js timeouts
CLOSED TREE

Backed out changeset 56bc1314e660 (bug 1173811)
Backed out changeset 0ad51d302ba9 (bug 1173811)
2015-10-21 20:21:05 -07:00
Josh Matthews
187a3da7d2 Bug 1173811 - Part 2: Propagate the response URL to intercepted channels when necessary (e10s). r=mayhemer,bkelly 2015-10-21 00:05:40 -04:00
Josh Matthews
591281df75 Bug 1173811 - Part 1: Propagate the response URL to intercepted channels when necessary (non-e10s). r=mayhemer,bkelly 2015-10-21 00:05:40 -04:00
Ehsan Akhgari
a9097bf0fb Bug 1213150 - Part 3: Remove nsIInterceptedChannel.isNavigation; r=jdm 2015-10-09 10:52:56 -04:00
Nikhil Marathe
48d53f38df Bug 1184798 - Ensure workers loads are treated as non-subresource fetches. r=jdm
--HG--
extra : commitid : KSrA2sDx3MI
extra : rebase_source : c28988811316aa40e38752669a928d27750001b6
2015-09-17 11:56:41 -07:00
Ehsan Akhgari
46ece311dc Bug 1206894 follow-up: Add a null check 2015-09-21 22:13:39 -04:00
Ehsan Akhgari
5d40efa578 Bug 1206894 - Enable asynchronous dispatching of fetch events; r=jdm
This refactoring patch separates the preparation of the fetch event
object from its dispatching, so that consumers would be able to
dispatch the event asynchronously.
2015-09-21 20:59:27 -04:00
Ben Kelly
e2321797dc Bug 1173934 Show a message if a docshell fails to load due to SW intercept failure. r=ehsan r=jdm 2015-07-14 13:11:26 -07:00
Ben Kelly
c88bedc28b Bug 1172884 P1 Properly decode body when intercepted response redirects. r=jduell 2015-06-12 07:20:21 -07:00
Phil Ringnalda
26d25ec201 Backed out 3 changesets (bug 1172884, bug 1169819) for OS X timeouts in browser_force_refresh.js in bc3
CLOSED TREE

Backed out changeset 7b23ff6ac3a2 (bug 1169819)
Backed out changeset 1434730c0e19 (bug 1172884)
Backed out changeset 17d6ecf1b4ec (bug 1172884)
2015-06-11 20:57:24 -07:00
Ben Kelly
9e311feb1c Bug 1172884 P1 Properly decode body when intercepted response redirects. r=jduell 2015-06-11 18:29:28 -07:00
Wes Kocher
6783fcf01d Backed out changeset 6231a72d0557 (bug 1172884) for being the wrong patches landed a=backout
--HG--
extra : amend_source : 0c9d908d7b413bcf054c85aa5db901651cdc06a3
2015-06-11 17:57:51 -07:00
Ben Kelly
2ce68bcbc9 Bug 1172884 P1 Properly decode body when intercepted response redirects. r=mayhemer a=kwierso 2015-06-11 17:52:01 -07:00
Ehsan Akhgari
4017e4028f Bug 1168208 - Refactor the existing logic for syncing the security info between Response and channel objects into a new helper class; r=nsm,jdm,bkelly
--HG--
rename : dom/fetch/InternalResponse.cpp => dom/fetch/ChannelInfo.cpp
rename : dom/fetch/Response.h => dom/fetch/ChannelInfo.h
2015-05-27 14:22:53 -04:00
Carsten "Tomcat" Book
1f0ef48e79 Backed out changeset ae9c77fa58d1 (bug 1168208) for bustage on a CLOSED TREE 2015-05-27 14:50:43 +02:00
Ehsan Akhgari
c66a858d3a Bug 1168208 - Refactor the existing logic for syncing the security info between Response and channel objects into a new helper class; r=nsm,jdm,bkelly
--HG--
rename : dom/fetch/InternalResponse.cpp => dom/fetch/ChannelInfo.cpp
rename : dom/fetch/Response.h => dom/fetch/ChannelInfo.h
2015-05-27 08:25:03 -04:00
Josh Matthews
9726be2a7e Bug 1137287 - Part 1: Shift some code from InterceptedChannelContent to HttpChannelChild. r=mayhemer 2015-04-17 18:59:10 -04:00
Ehsan Akhgari
54a6fed4fc Bug 1148854 - Part 2: Resume the intercepted network reuest if the interception fails for some reason; r=jdm 2015-04-02 17:58:22 -04:00
Ehsan Akhgari
8ee8c0e69c Bug 1146169 - Check mChannel for null-ness in nsIInterceptedChannel::SetSecurityInfo(); r=jdm 2015-03-22 19:54:03 -04:00
Nikhil Marathe
fa2b7dfb6b Bug 1141332 - Disable content decoding and use decoded length on intercepted channels. r=mcmanus
--HG--
extra : transplant_source : %B9%A2%AB.%EA%A4%ABH%86%D0%F0%3F%DE%03%DF%7D%A9p%B2%D5
2015-03-17 08:48:32 -07:00
Nikhil Marathe
191be106d4 Bug 1134462 - Synthesize status and headers from Response returned by ServiceWorker. r=jdm
--HG--
extra : rebase_source : 6bfb181427869bb99a0812608e75b6311f3dfb97
2015-03-17 08:48:30 -07:00
Ehsan Akhgari
876c77c8e4 Bug 1133763 - Part 5: Allow the security info on intercepted HTTP channels to be overridden; r=michal 2015-03-13 14:37:21 -04:00
Josh Matthews
86618832b4 Bug 1065216 - Dispatch a fetch event to workers when controlled pages initiate a network load. r=baku,mayhemer,smaug 2015-02-18 20:34:29 -05:00
Ryan VanderMeulen
5abea51e9a Backed out changeset 25f90464e93b (bug 1065216) for Android mochitest failures. 2015-02-18 16:00:33 -05:00
Josh Matthews
cb61a019fc Bug 1065216 - Dispatch a fetch event to workers when controlled pages initiate a network load. r=baku,mayhemer,smaug 2015-02-18 14:10:52 -05:00
Josh Matthews
8f259e6613 Bug 898524: Part 2 - Avoid IPC roundtrips for synthesized responses. r=mayhemer 2014-10-17 09:55:09 -04:00