Commit graph

242 commits

Author SHA1 Message Date
Jeff Walden
e4f79e2a19 Bug 1484421 - Move JSON-related functionality into js/public/JSON.h that isn't #include'd in jsapi.h. r=jandem 2018-08-20 07:54:45 -07:00
Henri Sivonen
d3a158ae38 Bug 1483764 - Fix EOF behavior when decoding responseText lazily. r=smaug
* Drop the decoder when it finishes regardless of who called it.
 * Match criteria for having mDecoder process EOF from OnStopRequest to
   the criteria used for eager decoding in StreamReaderFunc.
 * Process EOF when decoding lazily.
 * Get rid of the useless mResponseCharset field.

MozReview-Commit-ID: 7oJwyKQYP8K

Differential Revision: https://phabricator.services.mozilla.com/D3591

--HG--
extra : moz-landing-system : lando
2018-08-17 17:04:22 +00:00
Thomas Wisniewski
78af5fd2ae Bug 1454590 - Align overrideMIMEType with the XMLHttpRequest Standard. r=hsivonen
MozReview-Commit-ID: 5k34F96jRPX

--HG--
extra : rebase_source : 95944acc3123406dbf490f2fd1837b8decaa3e0b
2018-08-13 16:12:10 -04:00
Henri Sivonen
22d42c4507 Bug 1482640 - Null out mDecoder in OnStopRequest to avoid asserting when there is more than one OnStopRequest. r=smaug
MozReview-Commit-ID: K25XhiYGzhl

Differential Revision: https://phabricator.services.mozilla.com/D3217

--HG--
extra : moz-landing-system : lando
2018-08-13 17:10:06 +00:00
Thomas Wisniewski
d4606b265f Bug 1070763 - Ensure that XHRs sniff the BOM for non-JSON responseTypes, and flush the decoder upon end-of-stream; r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D3063

--HG--
extra : moz-landing-system : lando
2018-08-10 06:38:01 +00:00
Thomas Wisniewski
a0847cc720 Bug 1362354 - Handle XHRs with aborted bindings as aborted rather than network errors. r=baku
MozReview-Commit-ID: 86e00dRe6qc

--HG--
extra : rebase_source : 992523d5ca534923b4e1b38c7e5e0351dcf322eb
2018-08-02 19:07:07 -07:00
Thomas Wisniewski
0471de08a0 Bug 1456421 - Align XHR username/password precedence rules with current spec. r=baku
MozReview-Commit-ID: FXCFoNhCVJz

--HG--
extra : rebase_source : fa9ecd5b6f04c1102fb9326291e5760c8285841d
2018-07-31 09:49:00 -04:00
Boris Zbarsky
f44ce81c0a Bug 1478743 part 3. Remove bogus clearing of the response when xhr.overrideMimeType throws. r=baku 2018-07-30 11:51:52 -04:00
Andi-Bogdan Postelnicu
88cc63910d Bug 1453795 - DOM - Initialize member fields in classes/ structures. r=peterv
--HG--
extra : rebase_source : 249fc26e50bded4e94f5effa4308af0f1e54b908
2018-06-16 17:21:46 +03:00
Jeff Gilbert
5b753da289 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Chris Peterson
2afd829d0f Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.

MozReview-Commit-ID: 5UQVHElSpCr

--HG--
extra : rebase_source : 4c1b2fc32b269342f07639266b64941e2270e9c4
extra : source : 907543f6eae716f23a6de52b1ffb1c82908d158a
2018-06-17 22:43:11 -07:00
Andrea Marchesini
9a9a71e436 Bug 1469126 - GetAllocationSize should report unique blobs when dealing with nested blobs, r=smaug 2018-06-18 11:35:46 -04:00
Emilio Cobos Álvarez
fffb25b74f Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Patrick McManus
f18aa94399 Bug 1462357 - remove the channel and socket interface id r=bagder,baku
the id was a b2g feature only settable via chrome privd xhr and is no
longer active in the code base

MozReview-Commit-ID: 84GPNvhvjNb

--HG--
extra : rebase_source : ab5c2229b98e1407b8b74ef2ee00dcfea45e046a
2018-05-16 16:05:03 -04:00
Adrian Wielgosik
4fca802957 Bug 1460940 - Convert NS_NewDOMDocument to use nsIDocument. r=bz
MozReview-Commit-ID: GoJ30YZGRhq

--HG--
extra : rebase_source : 0995705c2c31c1a779c22c8336482d4c7e89e319
2018-05-11 19:46:15 +02:00
Chris Peterson
71422dcaa9 Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent

MozReview-Commit-ID: KuUsnVe2h8L

--HG--
extra : source : c14655ab3df2c9b1465dd8102b9d25683359a37b
2018-04-28 12:50:58 -07:00
Andrea Marchesini
0f38ba4351 Bug 1453927 - Get rid of XMLHttpRequestMainThread::Init, r=qdot 2018-04-14 08:11:35 +02:00
Sebastian Hengst
0819f35e51 Backed out 4 changesets (bug 525063) on request from Andi. a=backout
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
a3a77c0312 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
Boris Zbarsky
1483606219 Bug 1452235 part 4. Remove nsIDOMSerializer. r=qdot
MozReview-Commit-ID: 5foaztSLyEC
2018-04-09 16:30:33 -04:00
Boris Zbarsky
4292bca4ee Bug 1449631 part 6. Remove nsIDOMEventTarget::DispatchEvent. r=smaug
MozReview-Commit-ID: 8YMgmMwZkAL
2018-04-05 13:42:41 -04:00
Ben Kelly
9bd4654613 Bug 1450266 P7 Make XMLHttpRequestMainThread check for a valid inner window before dispatching events. r=baku r=smaug 2018-04-03 17:10:17 -07:00
Emilio Cobos Álvarez
c03ffd9c62 Bug 1425759: Simplify the style backend type setup. r=bholley
Now that what we use to decide whether a document is styled by Servo are only
prefs and the doc principal, we don't need to inherit the style backend type,
since unless the pref has changed, the result will be the same.

MozReview-Commit-ID: KBmeBn1cRne
2018-02-27 12:39:20 +01:00
Valentin Gosu
84b854ce2c Bug 1433958 - Change code that sets nsIURI.userPass to use nsIURIMutator r=mayhemer
* Code in XMLHttpRequestMainThread is converted to set the username and password individually. This is because when the parameters are empty, it ended up calling SetUserPass(":") which always returns an error.

MozReview-Commit-ID: 3cK5HeyzjFE

--HG--
extra : rebase_source : f34400c11245d88648b0ae9c196637628afa9517
2018-02-26 20:43:46 +01:00
Thomas Wisniewski
8d2ee99353 Bug 1439022 r=baku
MozReview-Commit-ID: HSKAPIXUrtz

--HG--
extra : amend_source : 5c6b3e29de5ac96d85e771a7341375a919b66d13
2018-02-21 22:20:37 -05:00
Thomas Wisniewski
c02f2f2b85 Bug 792808 - use XMLHttpRequestBinding::STATE consts in the XHR subclasses and remove XMLHttpRequest::State enum class; r=baku
MozReview-Commit-ID: HcP9oEzOnub

--HG--
extra : rebase_source : 794ed0897508f3e0e5f9ccc794cfe745bb9468b0
2017-11-19 23:00:10 -05:00
Thomas Wisniewski
7c05457e0d Bug 792808 - Purge nsIXMLHttpRequest, nsIXMLHttpRequestUpload, nsIXMLHttpRequestEventTarget, nsIXHRSendable XPCOM interfaces; r=baku
MozReview-Commit-ID: 8yzCXSeyO85

--HG--
extra : rebase_source : 80f2a96df1e250ad646a20271b7d3dbebf7774e4
2017-11-19 17:11:41 -05:00
Thomas Wisniewski
bd0b3ab10a Bug 792808 - Migrate BodyExtractor away from using nsIXHRSendable; r=baku
MozReview-Commit-ID: 1fNcm1mPJJB

--HG--
extra : rebase_source : 443ad7309f2e6a064b54466ece967ced0c3155ea
2017-09-19 21:32:12 -04:00
Thomas Wisniewski
4476561b7d Bug 792808 - Migrate nsXMLParseEndListener away from nsIXMLHttpRequest interfaces; r=baku
MozReview-Commit-ID: 14Lxuj37GdJ

--HG--
extra : rebase_source : ac146258773810adf01ba05f14d0901b0f5ad663
2017-09-25 22:20:26 -04:00
Thomas Wisniewski
1a7374f71c Bug 792808 - Migrate XMLHttpRequestMainThread away from needing nsIXMLHttpRequest's constants; r=baku
MozReview-Commit-ID: 1yaM9DAKPW7

--HG--
extra : rebase_source : b81366e7572ddf4da342ca40016de54bc8a6fd33
2017-09-24 14:08:38 -04:00
Andrea Marchesini
c6da271117 Bug 1425458 - Resource timing entries Workers - part 0 - NS_NewChannel, r=smaug
* * *
Bug 1425458 - Resource timing entries Workers - part 10 - Correct parameters in NS_NewChannel in nsDataObj.cpp, r=me
2018-01-24 17:17:31 +01:00
Brindusan Cristian
368c3d5b6b Backed out 12 changesets (bug 1425458) for mochitest failures on WorkerPrivate.cpp on a CLOSED TREE
Backed out changeset 11997de13778 (bug 1425458)
Backed out changeset 100b9d4f36bc (bug 1425458)
Backed out changeset a29e9dbb8c42 (bug 1425458)
Backed out changeset b96d58fd945c (bug 1425458)
Backed out changeset f140da44ba68 (bug 1425458)
Backed out changeset af56400233d9 (bug 1425458)
Backed out changeset 7034af4332e4 (bug 1425458)
Backed out changeset f70500179140 (bug 1425458)
Backed out changeset 793bbfc23257 (bug 1425458)
Backed out changeset 2efb375a8ffc (bug 1425458)
Backed out changeset 07e781e37451 (bug 1425458)
Backed out changeset e875f3702a5f (bug 1425458)
2018-01-24 20:47:48 +02:00
Andrea Marchesini
6480b95ba3 Bug 1425458 - Resource timing entries Workers - part 0 - NS_NewChannel, r=smaug 2018-01-24 17:17:31 +01:00
Ben Kelly
a88ba0dac1 Bug 1231211 P15 Make xhr pass worker ClientInfo and ServiceWorkerDescriptor to NS_NewChannel(). r=asuth 2018-01-23 10:38:54 -05:00
Andrea Marchesini
209fb327a0 Bug 1411384 - nested sync XHR should throw, r=smaug 2017-11-13 10:17:05 +01:00
Kris Maglione
27c96362b9 Bug 1412345: Downgrade expanded principals before inheriting. r=bz,krizsa
There are several ways that expanded principals can be used as triggering
principals for requests. While that works fine for security checks, it also
sometimes causes them to be inherited, and used as result principals in
contexts where expanded principals aren't allowed.

This patch changes our inheritance behavior so that expanded principals are
downgraded to the most appropriate constituent principal when they would
otherwise be inherited.

The logic for choosing the most appropriate principal is a bit suspect, and
may eventually need to be changed to always select the last whitelist
principal, but I chose it to preserve the current principal downgrade behavior
used by XMLHttpRequest for the time being.

MozReview-Commit-ID: 9fvAKr2e2fa

--HG--
extra : rebase_source : c30df1b3851c11fed5a1d6a7fb158cec14933182
2017-11-02 19:56:27 -07:00
Thomas Wisniewski
34162c2171 Bug 1405696 - pass the document encoding to NS_NewURI for XMLHttpRequest; r=bkelly
MozReview-Commit-ID: IZkWHGZacO0

--HG--
extra : rebase_source : 4cffffd6ce76f49f8515a04cd4f7523e5ceabb1f
2017-10-20 20:47:36 -04:00
Sebastian Hengst
19c5a8852b Backed out changeset 2dd370ac9599 (bug 1405696) for failing web-platform-test /workers/semantics/encodings/003.html. r=backout
--HG--
extra : amend_source : 40342d008230ad926612e852650e3608fc7e44a0
2017-10-20 23:47:38 +02:00
Thomas Wisniewski
0262ef8292 Bug 1405696 - pass the document encoding to NS_NewURI for XMLHttpRequest; r=bkelly
MozReview-Commit-ID: IZkWHGZacO0

--HG--
extra : rebase_source : ac6e2f72fbd0475ba7cbb4ea1231a81d534461fc
2017-10-20 13:49:03 -04:00
Andrea Marchesini
6626e900f9 Bug 1409327 - NS_NewBufferedInputStream should take the ownership of the inputStream, r=smaug 2017-10-19 11:39:30 +02:00
Kris Maglione
60d080b412 Bug 1404198: Part 2i - Switch to NS_NewTimer* in dom. r=njn
MozReview-Commit-ID: 8Oei6TuXNbu

--HG--
extra : rebase_source : 31c583c699790cbcf302064146d313ee8126ef0c
2017-10-15 23:15:40 -07:00
Kris Maglione
bd6d63772a Bug 1407428: Hand out a const array reference for expanded principal whiteList. r=krizsa
The current API makes the life time and ownership of the result array unclear
without careful reading. The result array is always owned by the principal,
and its lifetime tied to the lifetime of the principal itself. Returning a
const array reference makes this clear, and should prevent callers from
accidentally modifying the returned array.

MozReview-Commit-ID: 3f8mhynkKAj

--HG--
extra : source : 237acf2879f6222bc4b076c377bf026d18a6ebef
extra : amend_source : dfaf6e88e3c4758f7fdcf7fb422d457edafab1b7
2017-10-10 15:00:16 -07:00
Sebastian Hengst
11a2b8ef67 Backed out changeset 237acf2879f6 (bug 1407428) for frequent crashes, e.g. in xpcshell's test_bug248970_cookie.js. r=backout on a CLOSED TREE
--HG--
extra : amend_source : 1ccac4fb953566239cba8db7d6f8bdca4ce48b35
2017-10-16 00:00:15 +02:00
Kris Maglione
7d8f8ea3d6 Bug 1407428: Hand out a const array reference for expanded principal whiteList. r=krizsa
The current API makes the life time and ownership of the result array unclear
without careful reading. The result array is always owned by the principal,
and its lifetime tied to the lifetime of the principal itself. Returning a
const array reference makes this clear, and should prevent callers from
accidentally modifying the returned array.

MozReview-Commit-ID: 3f8mhynkKAj

--HG--
extra : rebase_source : d2a5e0862f8c964fb5a3e46b50c2e9629b218699
extra : amend_source : 27d7a7ef5da6fe2aa1104009b6ee067465db73e1
2017-10-10 15:00:16 -07:00
Sebastian Hengst
24f9efc1d1 Backed out changeset 4bac27faa19b (bug 1070763) for crashes and broken websites. r=backout a=backout
MozReview-Commit-ID: 6BAkoAT8JyJ
2017-10-14 23:50:33 +02:00
Sebastian Hengst
776dca65f3 Backed out changeset 224d8c57a469 (bug 1405571) for crashes and broken websites. r=backout a=backout
MozReview-Commit-ID: FZe9hj8nX5w
2017-10-14 23:49:00 +02:00
Thomas Wisniewski
3208e48423 Bug 1405571 - Only do a final flush on the XHR text decoder once; r=hsivonen
MozReview-Commit-ID: 7KphkchHBiw

--HG--
extra : rebase_source : 1125db1e55f5fe579c44d2cb7f259510bba59475
2017-10-04 15:05:28 -04:00
Thomas Wisniewski
5b68608547 Bug 1070763 - Ensure that XHRs sniff the BOM for non-JSON responseTypes, and flush the decoder upon end-of-stream; r=hsivonen
MozReview-Commit-ID: ICHbs2BQcbR

--HG--
extra : rebase_source : 91fac79b191330c5f771386f9977450a569157b1
2017-10-03 08:54:14 -04:00
Thomas Wisniewski
81d59581ae Bug 1341609 - Don't throw on async XHR send() failures when open() created no channel; r=baku
MozReview-Commit-ID: IKVSbdRXoP8

--HG--
extra : rebase_source : 6f85751dae1bf7413598a3ddc381bee86545de9b
2017-09-29 11:36:55 -04:00
Thomas Wisniewski
2956d278f7 Bug 1400748 - Correct our handling of XHR.abort edge-cases; r=baku
1. Handle the "terminate the ongoing fetch" cases in the spec-text
   - do not CloseRequest in Abort/Open if the state is UNSENT or DONE).
   - ensure we don't fire extra events after terminating this way
     if a stray OnDataAvailable happens afterward.
2. Ensure that status/statusText correctly return 0/"" to mimic the
   spec's "set response to a network error" steps (requires special
   handling in the worker XHR code).

MozReview-Commit-ID: 5kMyGgD7uUU

--HG--
extra : rebase_source : ba8b6e85fb922869bbba749b4948bb4489878f22
2017-09-25 12:58:23 -04:00