Commit graph

76 commits

Author SHA1 Message Date
Anna Yeddi
6eee9a9520 Bug 1884981 - Import history from another browser section on Firefox View History tab would not announce the context for buttons on it. r=fxview-reviewers,kcochrane
Adding a grouping markup on the `import-history-banner`, so the text outside of the focusable CTAs is being announced to a screen reader user.

Note: the heading remains implicit (being only styled to look as such but it is not marked up appropriately an is a generic `<span>`)

Differential Revision: https://phabricator.services.mozilla.com/D206272
2024-04-16 23:57:18 +00:00
Sandor Molnar
a1b5483a02 Backed out 2 changesets (bug 1884981, bug 1884986) for causing bc failures @ browser_firefoxview.js CLOSED TREE
Backed out changeset ae9729a59875 (bug 1884981)
Backed out changeset 2ad302b112b2 (bug 1884986)
2024-04-16 00:10:30 +03:00
Anna Yeddi
4247a52f34 Bug 1884981 - Import history from another browser section on Firefox View History tab would not announce the context for buttons on it. r=fxview-reviewers,kcochrane
Adding a grouping markup on the `import-history-banner`, so the text outside of the focusable CTAs is being announced to a screen reader user.

Note: the heading remains implicit (being only styled to look as such but it is not marked up appropriately an is a generic `<span>`)

Differential Revision: https://phabricator.services.mozilla.com/D206272
2024-04-15 18:41:00 +00:00
Hanna Jones
c1021a6f87 Bug 1850037 - Part 2: Use moz-button to remove ghost button styles in fxview r=fxview-reviewers,desktop-theme-reviewers,reusable-components-reviewers,kcochrane,mstriemer,dao
Differential Revision: https://phabricator.services.mozilla.com/D187932
2024-04-01 16:08:41 +00:00
Nikki Sharpley
89022a0076 Bug 1883231 - Prevent "no results" from showing if history search is still in progress r=fxview-reviewers,places-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D205756
2024-04-01 13:14:01 +00:00
Nikki Sharpley
1975fae7ce Bug 1879926 - Add Lit history component to Sidebar r=fxview-reviewers,desktop-theme-reviewers,dao,kcochrane,fluent-reviewers,jsudiaman,kpatenio
Styling and templates will change as we receive UX specs.

Depends on D202726

Differential Revision: https://phabricator.services.mozilla.com/D204226
2024-03-26 20:09:37 +00:00
Nikki Sharpley
c7d11e9f05 Bug 1880540 - Refactor History component functionality into Lit controller r=fxview-reviewers,jsudiaman,sclements,hjones
Extrapolate common history functionality to a controller that can be used across view and sidebar.
This includes the ability to delete from history, visit a link from history, sort by options, search history and format results.

Differential Revision: https://phabricator.services.mozilla.com/D202726
2024-03-18 04:59:43 +00:00
Nikki Sharpley
c93c77d631 Bug 1884170 - Missing options button icon in history fixed r=fxview-reviewers,kcochrane
Added correct secondary class names to show options button icon in history.

Differential Revision: https://phabricator.services.mozilla.com/D203928
2024-03-07 21:39:31 +00:00
Nikki Sharpley
c2a33192da Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Depends on D201652

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-28 19:37:22 +00:00
Stanca Serban
7d719a0f5f Backed out 2 changesets (bug 1857298) for causing mochitests failures in browser_parsable_css.js. CLOSED TREE
Backed out changeset 32ca524f7abf (bug 1857298)
Backed out changeset c4ed2e3e1ff2 (bug 1857298)
2024-02-28 20:47:18 +02:00
Nikki Sharpley
88756da91d Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-28 17:31:17 +00:00
Jonathan Sudiaman
1d82377f9c Bug 1880067 - Typing in Firefox View's history search causes flickering and loss of characters typed r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D202248
2024-02-20 19:51:09 +00:00
Iulian Moraru
08629b9d2c Backed out changeset 37ef0aa2d2b5 (bug 1857298) for causing bc failures on browser_recentlyclosed_firefoxview.js. 2024-02-20 18:06:25 +02:00
Nikki Sharpley
1a596d38ec Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-20 14:50:25 +00:00
Jules Simplicio
63ba6c1626 Bug 1877793 - Standardize headings 1-3 r=kcochrane,desktop-theme-reviewers,settings-reviewers,fxview-reviewers,dao,hjones,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D200203
2024-02-09 15:15:11 +00:00
Kelly Cochrane
d1aa2508a7 Bug 1869765 - Add test coverage for View search telemetry. r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D199578
2024-02-05 17:07:45 +00:00
Nikki Sharpley
98576b3263 Bug 1869765 - Add telemetry to Firefox View search. r=fxview-reviewers,kcochrane
- record frequency and page of search
- record how often show all search results is clicked on recent browsing and from which section
- record how often sort by date or site is clicked on history
- record how many searches are made before clicking on a search result

Differential Revision: https://phabricator.services.mozilla.com/D199285
2024-01-26 19:52:59 +00:00
Nikki Sharpley
57db0ea127 Bug 1869836 - Rename files with Firefox View Next to Firefox View. r=fxview-reviewers,sfoster
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html
- this patch also resolves Bug 1872919 by adding a scroll into view during the `search_synced_tabs_recent_browsing` test

Differential Revision: https://phabricator.services.mozilla.com/D196347
2024-01-18 14:32:33 +00:00
Cristian Tuns
014080f990 Backed out changeset 7ec1dad4bca4 (bug 1869836) for causing bc failures in browser_syncedtabs_firefoxview.js CLOSED TREE 2024-01-16 17:36:03 -05:00
Nikki Sharpley
80020bf88f Bug 1869836 - Rename files with Firefox View Next to Firefox View. r=fxview-reviewers,sfoster
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html

Differential Revision: https://phabricator.services.mozilla.com/D196347
2024-01-16 21:46:47 +00:00
Kelly Cochrane
a493fe5451 Bug 1873683 - Ensure card collapsed state is preserved on the History page when the view is changed in Fx View r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D198164
2024-01-16 14:32:21 +00:00
Norisz Fay
ae3df68e9b Backed out changeset 1ec7a77be890 (bug 1869836) for causing bc and lint failures CLOSED TREE 2024-01-15 19:09:33 +02:00
Nikki Sharpley
ea95272239 Bug 1869836 - Rename files with Firefox View Next to Firefox View. r=fxview-reviewers,sfoster
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html

Differential Revision: https://phabricator.services.mozilla.com/D196347
2024-01-15 15:34:34 +00:00
Jonathan Sudiaman
8d5088a9fd Bug 1868776 - "Search recently closed tabs" placeholder text is cut off in the search box in Firefox View r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D196216
2024-01-02 14:56:54 +00:00
Natalia Csoregi
d113410d83 Backed out changeset 8e11ea7d34e4 (bug 1868776) for causing failures on browser_firefoxview_paused.js. CLOSED TREE 2023-12-22 19:10:28 +02:00
Kelly Cochrane
64cdaa81d9 Bug 1868847 - Debounce search in Fx View r=jsudiaman,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D196970
2023-12-22 16:48:56 +00:00
Jonathan Sudiaman
fa49da5af5 Bug 1868776 - "Search recently closed tabs" placeholder text is cut off in the search box in Firefox View r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D196216
2023-12-22 16:33:33 +00:00
Cristian Tuns
d88427a135 Backed out changeset 84f22b125d8b (bug 1868847) for causing bc failures in firefoxview-next/browser_syncedtabs_firefoxview_next.js CLOSED TREE 2023-12-21 16:39:51 -05:00
Kelly Cochrane
e8ad6f11c7 Bug 1868847 - Debounce search in Fx View r=jsudiaman,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D196970
2023-12-21 21:03:20 +00:00
Kelly Cochrane
92f69f8295 Bug 1857634 - Pause updates and clear interval time in fxview-tab-list when containing cards are collapsed r=sfoster,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D194421
2023-12-12 21:50:56 +00:00
Noemi Erli
92a10c2108 Backed out changeset c5f52ea7e7d0 (bug 1857634) for causing failures in test_fxview_tab_list.html 2023-12-12 22:39:33 +02:00
Kelly Cochrane
927996dd37 Bug 1857634 - Pause updates and clear interval time in fxview-tab-list when containing cards are collapsed r=sfoster,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D194421
2023-12-12 18:02:04 +00:00
Jonathan Sudiaman
1509dc3a51 Bug 1867030 - Hardcode the value for limiting history search results r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D195894
2023-12-08 18:46:26 +00:00
Kelly Cochrane
4826d47124 Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-12-04 17:50:04 +00:00
Cosmin Sabou
62b1c8b8d7 Backed out changeset e1b32d718ed1 (bug 1859788) for high frequency failures on browser_firefoxview_next_general_telemetry.js. 2023-11-30 20:33:51 +02:00
Kelly Cochrane
234b79048d Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-11-30 16:54:08 +00:00
Kelly Cochrane
9d3aa6f573 Bug 1833102 - Add search to Tabs from other devices page in Fx View r=jsudiaman,fluent-reviewers,fxview-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D195004
2023-11-30 14:46:41 +00:00
Norisz Fay
f8a308f78e Backed out changeset d3d999e4ff71 (bug 1859788) for causing bc failures on browser_firefoxview_next.js 2023-11-28 20:31:50 +02:00
Kelly Cochrane
241249e8ec Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-11-28 16:56:45 +00:00
Sam Foster
2cd97ee94c Bug 1863783 - Ensure fxview page content only listens/observes and renders updates when visible. r=fxview-reviewers,sclements,jsudiaman
* Add a type=page to the top-level ViewPage instances
* Rename viewTabVisibleCallback and viewTabHiddenCallback to view*Callback and call each when selectedness or visiblity changes
* Ensure active view/pages are always properly initialized during page load and category switching
* Add a test to verify no mutations happen when tabs change while firefox view is inactive
* Fix tests to better account for loading and readiness sequence when activating firefox view

Differential Revision: https://phabricator.services.mozilla.com/D193744
2023-11-23 07:57:33 +00:00
Jonathan Sudiaman
fd64955080 Bug 1859829 - Add search to recently closed tabs r=fxview-reviewers,fluent-reviewers,bolsson,sclements
Linear search through the list of recently closed tabs, and some light refactoring for the sake of upcoming search enhancements.

Differential Revision: https://phabricator.services.mozilla.com/D193692
2023-11-21 18:01:05 +00:00
Jonathan Sudiaman
3645ff1757 Bug 1826328 - Add search capability to view in history r=fxview-reviewers,places-reviewers,fluent-reviewers,flod,mak,sclements
Leverages `AUTOCOMPLETE_MATCH` in order to add search functionality to Fx View History.

https://treeherder.mozilla.org/jobs?repo=try&revision=a45a29326ba22252756cd9d142e9199508b6693b

Differential Revision: https://phabricator.services.mozilla.com/D190844
2023-11-08 02:17:13 +00:00
Jules Simplicio
cf45a952a0 Bug 1854930 - Apply heading large styles to Firefox View's h2 r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189147
2023-09-25 19:48:16 +00:00
Kelly Cochrane
51bd0826d5 Bug 1833674 - Add Telemetry for History in Firefox View r=jsudiaman,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D188628
2023-09-22 15:26:38 +00:00
Iulian Moraru
a1c7cd6b4c Backed out changeset 0769835cb15d (bug 1833674) for causing bc failures on browser_history_firefoxview_next.js. CLOSED TREE 2023-09-20 23:56:40 +03:00
Kelly Cochrane
4c5476f29b Bug 1833674 - Add Telemetry for History in Firefox View r=jsudiaman,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D188628
2023-09-20 18:37:48 +00:00
Kelly Cochrane
368a50bd94 Bug 1833658 - Add Telemetry for Recent Browsing r=fxview-reviewers,jsudiaman,sclements
Differential Revision: https://phabricator.services.mozilla.com/D187676
2023-09-13 13:06:50 +00:00
Jonathan Sudiaman
7b495d4221 Bug 1842602 - Add observer handler functions to viewpage.mjs in about:firefoxview-next r=sfoster,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D187214
2023-09-01 14:58:46 +00:00
Mike Kaply
6718d67ce7 Bug 1848928 - Update class for sort by site. r=jsudiaman DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D186545
2023-08-18 20:58:11 +00:00
Kelly Cochrane
93d1e7e4c7 Bug 1842616 - Add telemetry for Recently Closed tabs r=mkaply,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D186190
2023-08-18 16:06:33 +00:00