Commit graph

2255 commits

Author SHA1 Message Date
Christoph Kerschbaumer
be82c7af85 Bug 1329032 - Extend loadURIWithOptions by a triggeringPrincipal. r=bz,gijs 2017-01-18 08:24:55 +01:00
Wes Kocher
cb7e0bda60 Backed out 2 changesets (bug 1329032) for failures a=backout
Backed out changeset 16c4f0df527d (bug 1329032)
Backed out changeset 54f7bfe3ca11 (bug 1329032)

MozReview-Commit-ID: ChGyTdJvT8N
2017-01-17 14:08:10 -08:00
Christoph Kerschbaumer
05287d4fa8 Bug 1329032 - Extend loadURIWithOptions by a triggeringPrincipal. r=bz,gijs 2017-01-17 21:52:01 +01:00
Jessica Jong
cb707ac950 Bug 1326779 - [e10s] Fire beforeunload event when navigating to a page in different process. r=smaug
--HG--
extra : rebase_source : f1268fbb9c2725e79fef2d6627e9e11e6e000acc
2017-01-16 21:33:00 -05:00
Michael Layzell
3a272149c6 Bug 1329331 - Leave the Large-Allocation process after subsequent navigations, r=smaug
MozReview-Commit-ID: DfivmSEvzBu
2017-01-16 14:03:09 -05:00
Phil Ringnalda
191c2661b5 Backed out 2 changesets (bug 1307736) for failures in browser_490040.js and test_refresh_firefox.py TestFirefoxRefresh.testReset
CLOSED TREE

Backed out changeset 338dd2c343f8 (bug 1307736)
Backed out changeset 1a71a0d9aa90 (bug 1307736)
2017-01-16 10:47:55 -08:00
Christoph Kerschbaumer
19cdb07e5c Bug 1307736 - Ensure History loads pass valid triggeringPrincipal. r=bz 2017-01-16 18:18:54 +01:00
Andrea Marchesini
359ae91eac Bug 1328653 - Merging all the various *OriginAttributes to just one, r=huseby 2017-01-12 17:38:48 +01:00
Carsten "Tomcat" Book
d959fb5581 Backed out changeset 3b3884fa2026 (bug 1329288) for m10 test failures 2017-01-11 15:42:10 +01:00
Christoph Kerschbaumer
a00dc3fc66 Bug 1329288 - Bring back ContentPolicy check within nsDocShell. r=smaug 2017-01-11 11:29:27 +01:00
Cameron McCormack
babad063ff Bug 1328832 - Part 2: Rename mozFlushType to mozilla::FlushType and make it an enum class. r=bzbarsky
MozReview-Commit-ID: D3fIngSHSsl
2017-01-05 15:31:56 +08:00
Thomas Nguyen
0aaea58b69 Bug 1304623 - Create a pref to control the default referrer policy - part 3. r=bkelly
MozReview-Commit-ID: 1A6IHPeNYBQ
2017-01-05 11:29:56 +08:00
Christoph Kerschbaumer
63fe5cb0bb Bug 1182569 - Skip security check for plugins using newstream attribute. r=smaug 2017-01-03 20:59:54 +01:00
Christoph Kerschbaumer
0bfc26fd77 Bug 1182569: Use AsyncOpen2 for docshell loads. r=smaug 2017-01-03 20:57:45 +01:00
Michael Layzell
f24af1792b Bug 1324359 - Rename and simplify the DocShell ProcessLock concept, r=smaug
MozReview-Commit-ID: JTp8Q2mWqpN
2017-01-03 17:00:25 -05:00
Wei-Cheng Pan
19fc36c981 Bug 1323947 - Use Use MOZ_MUST_USE in netwerk/protocol/viewsource r=valentin
MozReview-Commit-ID: 5JAkF53s42X

--HG--
extra : rebase_source : 5e3d82f3b15b25c610086e26e941cb6064acf975
2016-11-23 17:21:17 +08:00
Samael Wang
1e9e35e6e1 Bug 1323651 - Rename Partial/GroupedSessionHistory to Partial/GroupedSHistory. r=ehsan
MozReview-Commit-ID: G2GW4ZPIfH3
2016-12-22 16:06:50 +08:00
Michael Layzell
0fa642800b Bug 1315105 - Part 2: Implement <link rel=prerender> behind a pref, r=smaug
MozReview-Commit-ID: ARET98o1FTU

--HG--
extra : rebase_source : fd549baa1a4a180db1ca6701191f081033811d0f
2016-12-19 15:05:31 +08:00
Yoshi Huang
2ceecc22f5 Bug 1324115 - Part 2: replace the callers to use C++ helper. r=smaug 2016-12-21 14:59:21 +08:00
Kris Maglione
e6f4ea4dcb Bug 1318388: Prevent setting usePrivateBrowsing after initial document load. r=ehsan
MozReview-Commit-ID: ArmAhSWMaCJ

--HG--
extra : rebase_source : 6cf914f29092ed281a3f80cf757c1a29dc7fbac5
2016-12-18 15:07:08 -08:00
Carsten "Tomcat" Book
51614d31e4 Backed out changeset 059753ec9117 (bug 1315105) for test failures in own test
--HG--
extra : rebase_source : de2846d1205d3e885c1040379f2816629a925d22
2016-12-19 15:59:14 +01:00
Michael Layzell
b5fd619e72 Bug 1315105 - Part 2: Implement <link rel=prerender> behind a pref, r=smaug
MozReview-Commit-ID: ARET98o1FTU
2016-12-19 15:05:31 +08:00
Andrea Marchesini
b78570578a Bug 1322207 - DOM Timing must be reset if the loading of a content page is aborted, r=smaug 2016-12-15 19:58:22 +01:00
Andrea Marchesini
a69bf81efe Bug 1322588 - Get rid of nsIDocShell::addSessionStorage, r=qdot 2016-12-12 09:33:11 +01:00
Nihanth Subramanya
a84e6f6916 Bug 989197 - Include captive portal state as a flag in the about:certerror URI. r=valentin
MozReview-Commit-ID: J2MjX6zJOTA

--HG--
extra : rebase_source : 272e9158355cac695947503eb0384b9c114b98be
2016-12-01 15:41:41 -08:00
Dave Huseby
fc467046c8 Bug 1309070 make sure that docshell always has private browsing id unset. r=ehsan 2016-12-01 14:11:00 +01:00
Sebastian Hengst
98798d9c07 Backed out changeset 5ac111460188 (bug 1316256) for failure in test_ext_webrequest_basic.html. r=backout 2016-12-07 13:52:18 +01:00
JOrg K
7d596b4b82 Bug 1316256 - Allow passing nullptr as principal to content policy check. r=bz 2016-12-01 15:32:11 +08:00
Boris Zbarsky
41288ac4b0 Bug 1318911. When creating an about:blank content viewer during a history navigation to a javascript: URI, use the right principal. r=tanvi 2016-12-06 07:41:42 -10:00
Dave Huseby
feaec25987 Bug 1316075 - Additional patch to clean up tabs and trailing whitespace in files touched. r=ehsan
--HG--
extra : rebase_source : 1344bdec2d3c11dcb2b025c7bd071f110e6b99ba
extra : histedit_source : 8e697a2200117bf0db6e6728f65ffe71f88fcc5b
2016-11-28 10:41:46 -08:00
Dave Huseby
59c8485430 Bug 1316075 - Add asserts for the places where we've gotten rid of the private browsing boolean. r=ehsan
--HG--
extra : rebase_source : 7088d1e4666b903bb7b6fcc9255974b04c248e36
extra : histedit_source : 299bc64978878300c2e00b2f2730fd22d0a95e0c
2016-11-21 14:58:10 -08:00
Timothy Nikkel
369187c6f2 Bug 1312609. r=smaug a=abillings 2016-11-29 15:15:35 -06:00
Samael Wang
cb7131182c Bug 1310768 - Use CreataAboutBlankContentViewer to stop inactive tabs. Update History API. a=ehsan
MozReview-Commit-ID: LPcaQkQ900G
2016-11-29 17:31:17 +08:00
Andrew McCreight
908a323277 Backed out changeset 2bbc7be933e2 (bug 1309070) for causing bug 1320041. 2016-11-26 09:31:17 -08:00
Gijs Kruitbosch
be8efc6f08 Bug 1314249 - if the target changes, assume we should not pass an opener ref, r=smaug
MozReview-Commit-ID: 7DBrRW1WiMP

--HG--
rename : browser/base/content/test/general/browser_bug1064280_changeUrlInPinnedTab.js => browser/base/content/test/tabs/browser_navigatePinnedTab.js
extra : rebase_source : 2aa1a459e07cd0d326e9c3d6e1b87afd0dbbc28b
2016-11-16 16:31:42 +00:00
Dave Huseby
531d98d41c Bug 1309070 - make sure that docshell always has private browsing id unset. r=ehsan 2016-11-21 12:53:00 +08:00
Michael Layzell
d6d2411526 Bug 944694 - Part 1: Use globally unique UUIDs for docshellID, r=smaug
MozReview-Commit-ID: DVLMijTkYKh
2016-11-17 16:50:48 -05:00
Ehsan Akhgari
d07f79a266 Bug 1318210 - Remove nsIAppsService; r=baku 2016-11-17 10:41:36 -05:00
Ehsan Akhgari
eac76d9772 Bug 1310845 - Remove support for mozapp iframes; r=fabrice,jryans,baku,mcmanus
This patch removes support for mozapp iframes, leaving support for
mozbrowser iframes intact.  Some of the code has been rewritten in order
to phrase things in terms of mozbrowser only, as opposed to mozbrowser
or app.  In some places, code that was only useful with apps has been
completely removed, so that the APIs consumed can also be removed.  In
some places where the notion of appId was bleeding out of this API, now
we use NO_APP_ID.  Other notions of appId which were restricted to this
API have been removed.
2016-11-16 09:13:38 -05:00
Carsten "Tomcat" Book
3eacc680db Backed out changeset 7d1f7dd996f7 (bug 1310845) 2016-11-16 14:50:44 +01:00
Ehsan Akhgari
cb369370b3 Bug 1310845 - Remove support for mozapp iframes; r=fabrice,jryans,baku,mcmanus
This patch removes support for mozapp iframes, leaving support for
mozbrowser iframes intact.  Some of the code has been rewritten in order
to phrase things in terms of mozbrowser only, as opposed to mozbrowser
or app.  In some places, code that was only useful with apps has been
completely removed, so that the APIs consumed can also be removed.  In
some places where the notion of appId was bleeding out of this API, now
we use NO_APP_ID.  Other notions of appId which were restricted to this
API have been removed.
2016-11-15 18:31:46 -05:00
Christoph Kerschbaumer
c658a4fd74 Bug 1316889 - Remove dead triggeringPrincipal fallback in docshell. r=bz 2016-11-11 17:21:18 +01:00
Markus Stange
3994547b42 Bug 1307242 - Add a non-blank paint telemetry probe for foreground root content documents. r=bkelly, f=bsmedberg
This adds a probe called TIME_TO_NON_BLANK_PAINT_MS which reports time to
non-blank paint for root content documents whose docshell was active for the
entire time between navigation start and first non-blank paint.

MozReview-Commit-ID: 7JQdk5vHr1O

--HG--
extra : rebase_source : 66be2aab4c4a32d20fb44c88c5270c5b5cfc0b81
extra : histedit_source : 5d6bef86d4a2a2250405d24ce28c6bfd9d654f8d
2016-11-10 14:26:54 -05:00
Ben Kelly
6495475955 Bug 1316289 P1 Make sure we thaw child frames properly. r=smaug 2016-11-10 14:02:18 -08:00
Carsten "Tomcat" Book
4b6cab91f9 merge mozilla-inbound to mozilla-central a=merge 2016-11-10 16:59:38 +01:00
Tim Huang
950b86072e Bug 1313627 - Get the firstPartyDomain from the nodePrincipal of the document in nsDocShell::CanAccessItem() if the first party isolation is on. r=smaug 2016-11-10 14:20:38 +08:00
KuoE0
1ea270f7da Bug 1305352 - (Part 1) Make Presentation API support XUL browser element. r=smaug
MozReview-Commit-ID: 9t5mhvcbpXB

--HG--
extra : rebase_source : 50c65bf06aae1df6a17e9328315edf977ceada49
2016-10-27 11:27:41 +08:00
Christoph Kerschbaumer
f2776f1b8d Bug 1308889 - Try to explicitly pass aTriggeringPrincipal and aPrincipalToInherit to DoURILoad(). r=bz 2016-11-08 07:23:12 +01:00
Michael Layzell
d53091c307 Bug 1314792 - Extract process changing logic into nsContentUtils::GetDocShellProcessLock, r=bkelly
MozReview-Commit-ID: FI0pIvHPN0h
2016-11-04 13:40:55 -04:00
Ting-Yu Lin
904617e77f Bug 1310509 - Call NotifyAsyncPanZoomStarted/Stopped on document containing current scrolling content. r=kats
We now call NotifyAsyncPanZoomStarted/Stopped precisely on the document
which is being transformed, so we no longer need to notify the child
docshells which was added in Bug 1088559.

Remove the |nsIDocument| argument for ProcessAPZStateChange(), which is not
used anymore.

mActiveAPZTransforms added in bug 1142926 is removed because AccessibleCaret
is the only consumer for AsyncPanZoomStarted/Stopped, and it now defaults to
always show while scrolling, i.e.
"layout.accessiblecaret.always_show_when_scrolling" defaults to true. And I
cannot reproduce the bug even if I turn off the preference.

MozReview-Commit-ID: DiEk2gCIHn2
2016-11-04 22:27:02 +08:00
Michael Layzell
0ae1d338c3 Bug 1313739 - Move TabGroup into its own file, seperate from DocGroup, r=bkelly
MozReview-Commit-ID: AndPWOBpkox
2016-10-31 13:40:36 -04:00
Michael Layzell
c72ea0d3f1 Bug 1310778 - Move TabGroup and GetDocGroup accessors onto nsPIDOMWindow{Inner,Outer}, r=smaug
MozReview-Commit-ID: Hl0QVktr0Lw
2016-10-28 15:38:28 -04:00
Michael Layzell
76969f2737 Bug 1310345 - Change FindChildWithName and related methods to take nsAString& instead of char16_t*, r=bz
MozReview-Commit-ID: 4aQwYX9ObcN
2016-10-27 15:53:35 -04:00
Michael Layzell
029a7def5d Bug 1303196 - Part 3: Update the named window resolution logic to be scoped to TabGroup instead of being process-global, r=bz
MozReview-Commit-ID: FaGoj6wmEuG
2016-10-27 15:53:35 -04:00
Michael Layzell
f9eea2d135 Bug 1303196 - Part 2: Connect the DocGroup and TabGroup objects to nsGlobalWindow and nsDocument, ensuring that Opener is set early enough that it is correct, r=smaug
MozReview-Commit-ID: 3rZfLw3dXkF
2016-10-27 15:53:35 -04:00
Ben Kelly
0983850a63 Bug 1303167 P6 Rename new suspend and freeze methods to final names. r=smaug 2016-10-26 10:20:16 -07:00
Ben Kelly
bf0ca72f77 Bug 1303167 P2 Use new window suspend and freeze methods. r=smaug
* * *
Bug 1303167 P2 interdiff 0001 Review feedback
2016-10-26 10:20:15 -07:00
Ehsan Akhgari
98fb5e2107 Bug 1312527 - Promote docshell private browsing assertions to diagnostic asserts; r=baku
This will allow us to catch these assertions failing in non-debug
builds on our pre-release channels.
2016-10-25 09:28:40 -04:00
Boris Zbarsky
34454ebcd3 Bug 1222516 part 4. Implement support for rel=noopener on links. r=mconley 2016-10-20 16:52:39 -04:00
Boris Zbarsky
d53cc929eb Bug 1222516 part 3. Rejigger our rel="noreferrer" support to avoid setting an opener altogether instead of setting one and then nulling it out. r=mconley 2016-10-20 16:52:38 -04:00
Ehsan Akhgari
4a51ebacfa Bug 1310378 - Remove support for mozwidget; r=baku 2016-10-17 13:15:36 -04:00
Ehsan Akhgari
e2fdfd7548 Bug 1310366 - Remove support for app redirects; r=baku 2016-10-17 13:15:36 -04:00
Ehsan Akhgari
ceb6c867f9 Bug 1310350 - Fix the return value of nsDocShell::GetInheritPrivateBrowsingId(); r=baku
This function was mistakenly returning mPrivateBrowsingId instead of
mInheritPrivateBrowsingId.  Thankfully this function isn't being used
anywhere yet.
2016-10-17 10:05:12 -04:00
Christoph Kerschbaumer
a14cba1726 Bug 1303943: Don't inherit principal for external loads and update documentation for principalToInherit. r=bz 2016-10-14 20:08:21 +02:00
Ehsan Akhgari
69dce6c397 Bug 1310101 - Remove nsILoadContext::IsAppOfType; r=baku 2016-10-14 10:45:27 -04:00
Sebastian Hengst
700f9d4edf Backed out changeset 07f70194e136 (bug 1303943) for tests crashing related to sessionhistory. r=backout on a CLOSED TREE 2016-10-14 12:53:09 +02:00
Christoph Kerschbaumer
12c0c49d7e Bug 1303943 - Don't inherit principal for external loads and update documentation for principalToInherit. r=bz 2016-10-13 15:13:40 +02:00
Carsten "Tomcat" Book
1615c5d144 Backed out changeset 9ae5fb774393 (bug 1297338) landed with wrong bug number 2016-10-14 08:44:00 +02:00
Christoph Kerschbaumer
f3cb1ffcb6 Bug 1297338 - Don't inherit principal for external loads and update documentation for principalToInherit. r=bz 2016-10-13 15:13:40 +02:00
Eric Rahm
f52b26bf1d Bug 1308611 - Convert nsISHEntry.refreshURIList to nsIMutableArray. r=bz
|refreshURIList| is converted to a an nsIMutableArray as nsISupportsArray is
deprecated. This attribute is only used internally and does not show up in a
textual search of the plugins repo.

nsIMutableArray is used rather than nsIArray in order to support modifying the
array as current users expect.

MozReview-Commit-ID: F0GYVFZarOQ
2016-10-10 11:36:41 -07:00
Yoshi Huang
a43d017190 Bug 1264137 - Part 4: Improve the usefulness of what we pass as requestingContext to nsIContentPolicy for navigations (loads in a docshell). r=bz
For toplevel document loads (TYPE_DOCUMENT) in the content process,
we pass the currently-loaded window, if any.

For toplevel document loads in the chrome process (e.g. tabs in non-e10s mode),
we pass the node which created our docshell, if any.

For all subframe loads, we pass the node that created the docshell,
which is the frameElement of the window in the docshell.
2016-10-07 17:40:21 +08:00
Yoshi Huang
06ba09a073 Bug 1264137 - Part 3: perform ContentPolicy check if the load is happening on this docshell. r=bz, smaug 2016-10-07 17:40:21 +08:00
Yoshi Huang
351ea50d4c Bug 1264137 - Part 2: use isTargetTopLevelDocShell instead. r=bz
In Bug 841850 we added a !isNewDocShell check.
And In Bug 902350 we added a !isTargetTopLevelDocShell check.
We can get rid of isNewDocShell variable and just keep track of
isTargetTopLevelDocShell.
2016-10-07 17:40:21 +08:00
Yoshi Huang
a1cdd18cb8 Bug 1264137 - Part 1: rename from loadingPrincipal to requestingPrincipal in nsDocShell::InternalLoad. r=bz
In nsIContentPolicy terminology, it uses 'requestingPrincipal'.
So in nsDocShell::InternalLoad, we rename 'loadingPrincipal' to
'requestingPrincipal', and rename 'context' to 'requestingContext' when
calling nsIContentPolicy.
2016-10-07 17:40:21 +08:00
Christoph Kerschbaumer
fcc4788550 Bug 1307720 - Assert that docshell loads of TYPE_SUDOCUMENT always get a valid principal. r=tanvi 2016-10-05 14:24:38 +02:00
Samael Wang
104fe2c997 Bug 1300461 - UpdateIndex on LOAD_NORMAL_REPLACE, ReplaceEntry at requestedIndex when available. r=smaug
--HG--
extra : rebase_source : 9bb3c7488a1785ee5c4106b8e024555f31b3220c
2016-09-30 11:55:10 +08:00
James Andreou
a47ce92ac2 Bug 1282124 - Remove nsILoadInfo.usePrivateBrowsing and the SEC_FORCE_PRIVATE_BROWSING flag; r=smaug,jryans 2016-09-27 16:56:44 -04:00
Kate McKinley
c57d400961 Bug 1246540 - HSTS Priming Proof of Concept. r=ckerschb, r=mayhemer, r=jld, r=smaug, r=dkeeler, r=jmaher, p=ally
HSTS priming changes the order of mixed-content blocking and HSTS
upgrades, and adds a priming request to check if a mixed-content load is
accesible over HTTPS and the server supports upgrading via the
Strict-Transport-Security header.

Every call site that uses AsyncOpen2 passes through the mixed-content
blocker, and has a LoadInfo. If the mixed-content blocker marks the load as
needing HSTS priming, nsHttpChannel will build and send an HSTS priming
request on the same URI with the scheme upgraded to HTTPS. If the server
allows the upgrade, then channel performs an internal redirect to the HTTPS URI,
otherwise use the result of mixed-content blocker to allow or block the
load.

nsISiteSecurityService adds an optional boolean out parameter to
determine if the HSTS state is already cached for negative assertions.
If the host has been probed within the previous 24 hours, no HSTS
priming check will be sent.

MozReview-Commit-ID: ES1JruCtDdX

--HG--
extra : rebase_source : 2ac6c93c49f2862fc0b9e595eb0598cd1ea4bedf
2016-09-27 11:27:00 -04:00
Christoph Kerschbaumer
bc9a70d964 Bug 1297338 - Introduce concept of principalToInherit to docshell and scriptSecurityManager. r=bz 2016-09-20 08:36:25 +02:00
Bill McCloskey
50c44c717c Bug 1279086 - Allow painting for tab switch when JS is running (r=dvander,mconley,mrbkap) 2016-09-16 20:35:11 -07:00
Kris Maglione
afd82f6743 Bug 1294199: Part 1 - Add a docShell flag to allow legacy panels to skip inheriting origin attributes. r=ehsan
MozReview-Commit-ID: 1c6V0kv9E38

--HG--
extra : rebase_source : 9a9ab21a41a8a235378ff7a21dccbf9de37a5499
2016-09-15 13:47:55 -07:00
Blake Kaplan
8aeb3f91d9 Bug 623436 - Deal a little better with replacing inexistant session history entries. r=smaug
--HG--
extra : source : 20c734f8107e43e15ae11abae1d6a6e985510d93
2016-09-08 15:34:31 -07:00
Carsten "Tomcat" Book
656d6db419 Merge mozilla-central to mozilla-inbound 2016-09-07 17:21:27 +02:00
Carsten "Tomcat" Book
1c61ba654e merge mozilla-inbound to mozilla-central a=merge 2016-09-07 17:20:12 +02:00
Michael Layzell
e583117bfa Bug 1018486 - Part 5: Changes in docshell/ and uriloader/, r=bz
MozReview-Commit-ID: GiyHWL3aaOv
2016-09-07 10:50:41 -04:00
Matteo Ferretti
46b536cd2f Bug 1299154 - added Set/GetOverrideDPPX to restorefromHistory; r=mstange
MozReview-Commit-ID: AsyAcG3Igbn
2016-09-07 10:21:51 +02:00
Xidorn Quan
fcb403fc25 Bug 1299795 - Disable fullscreen for sidebar. r=smaug
MozReview-Commit-ID: G09fKdufKW3

--HG--
extra : source : d9b03fdeb466e280d6ba392d98c3aec3f281db4d
2016-09-07 09:13:14 +08:00
Yoshi Huang
10b437080c Bug 1260931 - Part 3: Propagate firstPartyDomain. r=smaug 2016-09-06 10:25:58 +08:00
Sebastian Hengst
c9519f7c29 Backed out changeset b9afda2804fd (bug 1260931) 2016-09-05 21:15:29 +02:00
Yoshi Huang
6cca1d0c54 Bug 1260931 - Part 3: Propagate firstPartyDomain. r=smaug 2016-09-06 01:50:30 +08:00
Sebastian Hengst
df3ad10e28 Backed out changeset 10da0eca7bbb (bug 1260931) 2016-09-02 15:33:51 +02:00
Sebastian Hengst
31c5f85098 Backed out 5 changesets (bug 1260931)
Backed out changeset 86e1a437021b (bug 1260931)
Backed out changeset be65e87da9e3 (bug 1260931)
Backed out changeset 39cff1d988fd (bug 1260931)
Backed out changeset 2fa7c4d8a5bc (bug 1260931)
Backed out changeset 075d612841fb (bug 1260931)
2016-09-02 14:55:59 +02:00
Sebastian Hengst
5bbaac898b Backed out changeset 10da0eca7bbb (bug 1260931) 2016-09-02 14:38:42 +02:00
Yoshi Huang
88b9430165 Bug 1260931 - Part 3: Propagate firstPartyDomain. r=smaug 2016-09-02 15:04:40 +08:00
Nicholas Nethercote
b71747b2ac Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.

--HG--
extra : rebase_source : 886e57a9e433e0cb6ed635cc075b34b7ebf81853
2016-09-01 15:01:16 +10:00
Nicholas Nethercote
c94421bf7c Bug 1297961 (part 2) - Use nsIURI::GetSpecOrDefault() for comparisons to fixed URIs. r=hurley.
--HG--
extra : rebase_source : c742ded3ca4ff6ddf745cf8d720261624f172027
2016-08-26 16:02:32 +10:00
Nicholas Nethercote
742fc7eb48 Bug 1297961 (part 1) - Introduce nsURI::GetSpecOrDefault(). r=hurley.
This function is an infallible alternative to nsIURI::GetSpec(). It's useful
when it's appropriate to handle a GetSpec() failure with a failure string, e.g.
for log/warning/error messages. It allows code like this:

  nsAutoCString spec;
  uri->GetSpec(spec);
  printf("uri: %s", spec.get());

to be changed to this:

  printf("uri: %s", uri->GetSpecOrDefault().get());

This introduces a slight behavioural change. Previously, if GetSpec() failed,
an empty string would be used here. Now, "[nsIURI::GetSpec failed]" will be
produced instead. In most cases this failure string will make for a clearer
log/warning/error message than the empty string.
* * *
Bug 1297961 (part 1b) - More GetSpecOrDefault() additions. r=hurley.

I will fold this into part 1 before landing.

--HG--
extra : rebase_source : ddc19a5624354ac098be019ca13cc24b99b80ddc
2016-08-26 16:02:31 +10:00
Wei-Cheng Pan
9a0fc7767f Bug 1293212 - Add MOZ_MUST_USE to prevent potential bugs. r=smaug
MozReview-Commit-ID: EuyeBkDlk2G

--HG--
extra : rebase_source : de8d5a95f74b757b7441cdc1e0f2dadb3a77ac6e
2016-08-08 18:16:15 +08:00
Kan-Ru Chen
b6d880aca1 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES


--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Ryan VanderMeulen
a99793373f Merge m-c to inbound. a=merge 2016-08-22 09:43:40 -04:00