nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
870023 commits 1 branch 98 tags 6.4 GiB
Commit graph

90 commits

Author SHA1 Message Date
Ben Hearsum
97b4985a08 Bug 1874177: enable macOS attribution reporting by default r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D198294
 2024-01-11 20:39:40 +00:00
Ben Hearsum
5e6ef0e003 Bug 1865845: stop caching mac attribution data in a separate file r=nalexander 
This is mostly removing code and tests related to reading/writing the cache file on macOS and updating of tests. Aside from that, the most notable part is the change to `setAttributionString` to automatically prepend `__MOZCUSTOM__` when writing an attribution code. This is mostly done to make things simpler and cleaner in the majority of the tests, but seeing as `getAttributionString` is also aware of it, it seems like a generally nicer way to do this.

Differential Revision: https://phabricator.services.mozilla.com/D197204
 2024-01-09 20:21:54 +00:00
Narcis Beleuzu
b7ba2ef9c7 Backed out 3 changesets (bug 1865845) for bc failures on browser_AttributionCode_telemetry.js . CLOSED TREE 
Backed out changeset 4f799b89c628 (bug 1865845)
Backed out changeset e825fb03ff56 (bug 1865845)
Backed out changeset 9a8c396a22db (bug 1865845)
 2024-01-09 21:26:48 +02:00
Ben Hearsum
352258de42 Bug 1865845: stop caching mac attribution data in a separate file r=nalexander 
This is mostly removing code and tests related to reading/writing the cache file on macOS and updating of tests. Aside from that, the most notable part is the change to `setAttributionString` to automatically prepend `__MOZCUSTOM__` when writing an attribution code. This is mostly done to make things simpler and cleaner in the majority of the tests, but seeing as `getAttributionString` is also aware of it, it seems like a generally nicer way to do this.

Differential Revision: https://phabricator.services.mozilla.com/D197204
 2024-01-09 15:38:04 +00:00
Michael Hughes
3b64a17a14 Bug 1830725: Synchronous nsWindowsPackageManager::GetCampaignId blocks main thread for many seconds r=nrishel 
Made GetCampaignId asynchronous to not block anything.
Also fix Bug 1872933 (broken build)

Differential Revision: https://phabricator.services.mozilla.com/D188520
 2024-01-05 21:26:39 +00:00
Iulian Moraru
877b25a390 Backed out changeset f7c78cadff5d (bug 1830725) for causing bc failures on browser_AttributionCode_telemetry.js. 2024-01-04 01:53:19 +02:00
Michael Hughes
558ec24fc1 Bug 1830725: Synchronous nsWindowsPackageManager::GetCampaignId blocks main thread for many seconds r=nrishel 
Made GetCampaignId asynchronous to not block anything.

Differential Revision: https://phabricator.services.mozilla.com/D188520
 2024-01-03 21:50:04 +00:00
Norisz Fay
7a9a35c44e Backed out changeset 416268cc8a36 (bug 1830725) for causing bc failures on browser_AttributionCode_telemetry.js 2023-11-29 00:56:57 +02:00
Michael Hughes
2128bde58f Bug 1830725: Synchronous nsWindowsPackageManager::GetCampaignId blocks main thread for many seconds r=bytesized,nrishel 
Made GetCampaignId asynchronous to not block anything.

Differential Revision: https://phabricator.services.mozilla.com/D188520
 2023-11-28 18:24:34 +00:00
Joel Maher
2cae29b76e Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D193996
 2023-11-21 17:35:23 +00:00
Ben Hearsum
afabf171b4 Bug 1858545: put macOS attribution reporting behind a Nimbus flag r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D190986
 2023-10-18 00:02:47 +00:00
Ben Hearsum
16fe634564 Bug 1816998: Replace macOS quarantine database-based attribution with extended attribute attribution r=nalexander 
With extended attribute attribution using exactly the same attribution strings as Windows (eg: no URLs), this turns out to be quite straightforward. Once we've pulled in the attribution string from the extended attribute, the existing parsing, validation, etc. just works.

The only wrinkle is that the extended attributes may have nul bytes or tabs that we need to strip away. (Tabs may be present because we use them to pad the attribution area when we prepare the DMG for attribution. Nul bytes may be present because we overwrite the entire attribution before updating the attribution data.)

Differential Revision: https://phabricator.services.mozilla.com/D189258
 2023-10-05 23:30:57 +00:00
Robin Steuber
497b34833f Bug 1815021 - Back out reading provenance data from AttributionCode r=nalexander 
Backed out Bug 1815021's patch: https://hg.mozilla.org/mozilla-central/rev/9b8c31e9eb9f

Differential Revision: https://phabricator.services.mozilla.com/D189594
 2023-10-03 23:40:25 +00:00
Robin Steuber
8281d2f582 Bug 1855604 - Back out support for sending provenance data via telemetry r=nalexander 
Backed out Bug 1815023's patch: https://hg.mozilla.org/mozilla-central/rev/fc0d63d3404b

Depends on D189592

Differential Revision: https://phabricator.services.mozilla.com/D189593
 2023-10-03 23:40:25 +00:00
Robin Steuber
2ac0a7eee5 Bug 1855604 - Back out putting provenance attribution in installation.first_seen r=nalexander 
Backs out Bug 1821189's patch: https://hg.mozilla.org/mozilla-central/rev/c4f8098f81bb

Differential Revision: https://phabricator.services.mozilla.com/D189591
 2023-10-03 23:40:24 +00:00
Sylvestre Ledru
4c29c24344 Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D189896
 2023-10-03 09:22:18 +00:00
Tom Marble
d596ebea8e Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D188427
 2023-09-21 22:47:07 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
anwar
1dbd9bffb3 Bug 1829673 - Put all mochitest test manifest files under browser/components into alphabetical order. r=mconley,extension-reviewers,credential-management-reviewers,dimi,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D176459
 2023-05-02 16:13:24 +00:00
CanadaHonk
91709586ba Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu 
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
 2023-03-29 07:34:10 +00:00
William Durand
86d264f943 Bug 1819997 - Allow dlsource in attribution data. r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D173429
 2023-03-28 19:41:36 +00:00
Robin Steuber
4be49e117e Bug 1821189 - Associate provenance attribution with installation.first_seen event r=nalexander 
We can't add the provenance data to the `installation.first_seen` extra data because it is already at its maximum number of keys. So instead we will add the `installation.first_seen_prov_ext` event which will be sent at the same time as `installation.first_seen` and will contain provenance attribution data in its extras object.

Differential Revision: https://phabricator.services.mozilla.com/D172520
 2023-03-14 18:08:16 +00:00
Robin Steuber
cf96a4611e Bug 1821406 - testProvenance calls should be awaited upon r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D172074
 2023-03-09 17:28:37 +00:00
Robin Steuber
0a57d388ca Bug 1815023 - Add support for sending attribution provenance data via telemetry r=nalexander,chutten 
Add a function that sets scalars to convey what kind of data is present in the :Zone.Identifier Alternate Data Stream. Also adds testing that the scalars get set correctly.

Does not actually call the function that sends the telemetry. This will be done in the next patch since we need to call it in some slightly different places than we usually would since we want to be sure it is included in the `new-profile` ping and in the ping with the `installation.first_seen` event.

Differential Revision: https://phabricator.services.mozilla.com/D171818
 2023-03-08 22:25:07 +00:00
Robin Steuber
1f131fa5fb Bug 1815021 - Update AttributionCode.jsm to read provenance data r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D171817
 2023-03-08 22:25:06 +00:00
elephanteatsapple
bfd805d38c Bug 1812141 - Convert JSMs in browser/components/attribution to ESMs. r=mconley,kpatenio,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D167730
 2023-02-15 21:40:30 +00:00
Marian-Vasile Laza
f44882d7b1 Backed out changeset 0d0223fcdc02 (bug 1812141) for xpcshelll failures on test_ClientEnvironment.js. CLOSED TREE 2023-02-13 20:34:22 +02:00
elephanteatsapple
87ced737b9 Bug 1812141 - Convert JSMs in browser/components/attribution to ESMs. r=mconley,kpatenio,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D167730
 2023-02-13 16:32:41 +00:00
Ben Hearsum
3e5bd87204 Bug 1807924: make attribution tests work against MSIX builds r=nalexander 
Two notable things here:
- Small refactor of AttributionCode.jsm to make it more testable (allowing `getCampaignId` to be easily stubbed out)
- An ugly skip of one of the "invalid" attribution code tests -- for reasons noted in the comments. Ultimately, this points to maybe a refactor or larger change being needed, but I don't think it's worth blocking getting these tests on.

Differential Revision: https://phabricator.services.mozilla.com/D166688
 2023-01-16 19:32:05 +00:00
Ben Hearsum
6c520ec6c8 Bug 1805919: disable tests that are currently failing against MSIX packages. r=jmaher,necko-reviewers,kershaw 
Differential Revision: https://phabricator.services.mozilla.com/D165754
 2023-01-11 14:45:03 +00:00
Mark Banner
8730eec697 Bug 1806359 - Convert telemetry imports to direct ES imports. r=necko-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,janerik,mconley,sgalich,bytesized,kershaw 
Differential Revision: https://phabricator.services.mozilla.com/D165002
 2022-12-23 12:37:07 +00:00
Ben Hearsum
1ddbce2898 Bug 1804894: Don't write postSigningData in MSIX builds r=nalexander 
This is only done by the Return-to-AMO flow, which is not supported in MSIX anyways.

Also, disable the RTAMO test for MSIX builds while we're here.

Differential Revision: https://phabricator.services.mozilla.com/D164666
 2022-12-15 14:30:09 +00:00
Iulian Moraru
cc585bd1b0 Backed out 11 changesets (bug 1804903, bug 1804902, bug 1804900, bug 1804899, bug 1712329, bug 1804898, bug 1804894, bug 1804904, bug 1804896, bug 1804905) for breaking gecko decision task. CLOSED TREE 
Backed out changeset 9e7813271e6b (bug 1712329)
Backed out changeset 29aa1d032dd3 (bug 1804903)
Backed out changeset 22ef0b00cc99 (bug 1804905)
Backed out changeset 8fad832a574e (bug 1804904)
Backed out changeset 60f185a3a485 (bug 1804902)
Backed out changeset 8b69824de6e2 (bug 1804900)
Backed out changeset 140f75f3f919 (bug 1804899)
Backed out changeset f4da44b1a219 (bug 1804898)
Backed out changeset 7cf946ae8295 (bug 1804896)
Backed out changeset 07d62af0767f (bug 1804894)
Backed out changeset 1e3e02cc3b1f (bug 1712329)
 2022-12-15 03:16:41 +02:00
Ben Hearsum
4764cf4239 Bug 1804894: Don't write postSigningData in MSIX builds r=nalexander 
This is only done by the Return-to-AMO flow, which is not supported in MSIX anyways.

Also, disable the RTAMO test for MSIX builds while we're here.

Differential Revision: https://phabricator.services.mozilla.com/D164666
 2022-12-15 00:45:13 +00:00
Barret Rennie
2578434663 Bug 1541508 - Use Services.env in browser/ r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D160136
 2022-11-25 19:09:06 +00:00
Cristian Tuns
4d37cf70f1 Backed out 19 changesets (bug 1541508) for causing xpcshell failures on test_notHeadlessByDefault.js CLOSED TREE 
Backed out changeset 08476fa2bc27 (bug 1541508)
Backed out changeset 0bf7514845db (bug 1541508)
Backed out changeset aa612a5e9ef7 (bug 1541508)
Backed out changeset 6bb9360473f7 (bug 1541508)
Backed out changeset b3d8e92f50c2 (bug 1541508)
Backed out changeset fa40dded133e (bug 1541508)
Backed out changeset 2e7db4aa8d4f (bug 1541508)
Backed out changeset 6098e2eb62ea (bug 1541508)
Backed out changeset 2c599ee639c4 (bug 1541508)
Backed out changeset 7d44f6e2644c (bug 1541508)
Backed out changeset c1279c3d674c (bug 1541508)
Backed out changeset 8bd08a62a590 (bug 1541508)
Backed out changeset 740010cb005c (bug 1541508)
Backed out changeset 0bfc7dd85c62 (bug 1541508)
Backed out changeset c4374a351356 (bug 1541508)
Backed out changeset 44ccfeca7364 (bug 1541508)
Backed out changeset e944e706a523 (bug 1541508)
Backed out changeset 2c59d66f43e4 (bug 1541508)
Backed out changeset a1896eacb6f1 (bug 1541508)
 2022-11-01 22:38:52 -04:00
Barret Rennie
9290133923 Bug 1541508 - Use Services.env in browser/ r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D160136
 2022-11-02 02:08:53 +00:00
Mark Banner
2ffde1e92f Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Mark Banner
a7e93ca96e Bug 1782659 - Enable ESlint rule no-unused-vars on the global scope for browser/ xpcshell-tests. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D153433
 2022-08-05 08:38:50 +00:00
Tooru Fujisawa
bf93d07148 Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D150894
 2022-07-11 12:41:50 +00:00
Ben Hearsum
e84c6b96a0 Bug 1766479: don't run Windows only attribution tests on Mac r=aryx 
Differential Revision: https://phabricator.services.mozilla.com/D144729
 2022-04-26 19:20:13 +00:00
Ben Hearsum
443289cf0f Bug 1756209: send Windows Store Campaign ID as attribution code r=nalexander 
Nearly all the complexity here is abstracted away in the previous patch, so this is quite straightforward other than the one oddity noted in the comments.

Differential Revision: https://phabricator.services.mozilla.com/D143112
 2022-04-26 15:55:34 +00:00
Gijs Kruitbosch
8e67201171 Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D141437
 2022-03-30 16:16:42 +00:00
Norisz Fay
acdd6851cd Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE 
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
 2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
27039e2946 Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D141437
 2022-03-30 08:18:51 +00:00
Barret Rennie
c7594bbe50 Bug 1745356 - Remove osfile.jsm from browser/components/attribution r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D133840
 2021-12-25 20:59:24 +00:00
Barret Rennie
2605c53228 Bug 1745356 - Remove osfile.jsm from Mac Attribution r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D133838
 2021-12-25 20:59:24 +00:00
Evgenia Kotovich
b7899c1c92 Bug 1733535 - Replace OS.File with IOUtils in the attribution code. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D128715
 2021-10-25 08:38:52 +00:00
Norisz Fay
b641c43be1 Backed out changeset d63aab4e0688 (bug 1733535) for causing mochitest failures on browser_AttributionCode_telemetry.js CLOSED TREE 2021-10-22 16:32:43 +03:00