Commit graph

51 commits

Author SHA1 Message Date
Nikki Sharpley
57db0ea127 Bug 1869836 - Rename files with Firefox View Next to Firefox View. r=fxview-reviewers,sfoster
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html
- this patch also resolves Bug 1872919 by adding a scroll into view during the `search_synced_tabs_recent_browsing` test

Differential Revision: https://phabricator.services.mozilla.com/D196347
2024-01-18 14:32:33 +00:00
Cristian Tuns
014080f990 Backed out changeset 7ec1dad4bca4 (bug 1869836) for causing bc failures in browser_syncedtabs_firefoxview.js CLOSED TREE 2024-01-16 17:36:03 -05:00
Nikki Sharpley
80020bf88f Bug 1869836 - Rename files with Firefox View Next to Firefox View. r=fxview-reviewers,sfoster
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html

Differential Revision: https://phabricator.services.mozilla.com/D196347
2024-01-16 21:46:47 +00:00
Norisz Fay
ae3df68e9b Backed out changeset 1ec7a77be890 (bug 1869836) for causing bc and lint failures CLOSED TREE 2024-01-15 19:09:33 +02:00
Nikki Sharpley
ea95272239 Bug 1869836 - Rename files with Firefox View Next to Firefox View. r=fxview-reviewers,sfoster
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html

Differential Revision: https://phabricator.services.mozilla.com/D196347
2024-01-15 15:34:34 +00:00
Jonathan Sudiaman
8d5088a9fd Bug 1868776 - "Search recently closed tabs" placeholder text is cut off in the search box in Firefox View r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D196216
2024-01-02 14:56:54 +00:00
Anna Yeddi
8e186f1de2 Bug 1872174 - Add programmatic role to Show All controls in Firefox View. r=fxview-reviewers,kcochrane
Several `show-all-link` controls lack interactive role - this would prevent users of speech-to-text/Voice Control from being able to send a click to it by calling its label and screen reader users and users of other assistive technology would not be able to get to this control via shortcuts like a list of controls, etc. Being focusable with keyboard does not guarantee that assistive technology could guess that this programmatically static text is, in fact, interactive.

While providing an explicit ARIA `role` to the element is going [against the First Rule of ARIA](https://www.w3.org/TR/using-aria/#rule1) while semantically appropriate HTML elements exist - `<a>` anchor (for the visual appearance of this control) or `<button>` (for the actual functionality that this control performs) - this patch would at least remove the barrier for assistive technology to be able to set interactivity expectations to this control appropriately.

No test manifests are being updated, because there are other elements in the updated test files that are failing a11y-checks, besides these `show-all-link` controls.

Differential Revision: https://phabricator.services.mozilla.com/D197349
2023-12-28 14:37:24 +00:00
Natalia Csoregi
d113410d83 Backed out changeset 8e11ea7d34e4 (bug 1868776) for causing failures on browser_firefoxview_paused.js. CLOSED TREE 2023-12-22 19:10:28 +02:00
Jonathan Sudiaman
fa49da5af5 Bug 1868776 - "Search recently closed tabs" placeholder text is cut off in the search box in Firefox View r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D196216
2023-12-22 16:33:33 +00:00
Kelly Cochrane
92f69f8295 Bug 1857634 - Pause updates and clear interval time in fxview-tab-list when containing cards are collapsed r=sfoster,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D194421
2023-12-12 21:50:56 +00:00
Noemi Erli
92a10c2108 Backed out changeset c5f52ea7e7d0 (bug 1857634) for causing failures in test_fxview_tab_list.html 2023-12-12 22:39:33 +02:00
Kelly Cochrane
927996dd37 Bug 1857634 - Pause updates and clear interval time in fxview-tab-list when containing cards are collapsed r=sfoster,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D194421
2023-12-12 18:02:04 +00:00
Jonathan Sudiaman
25237524ed Bug 1851447 - Add search for recent browsing r=fxview-reviewers,fluent-reviewers,flod,sclements,kcochrane
Slightly different from the previous search revisions. In this case, rather than having their own search boxes, the recent browsing components share a single search box located within the parent element. Thus, `fxview-search-textbox-query` event listeners are added/removed from the //parent// component rather than the components themselves.

Differential Revision: https://phabricator.services.mozilla.com/D195596
2023-12-08 15:56:08 +00:00
Sam Foster
31393cc98e Bug 1863642 - Move the open tabs context menu functionality to its own component. r=fxview-reviewers,sclements
* Create a new OpenTabsContextMenu to replace the inlined menu content in the open tabs template
* Fetch the devices list when the menu opens, rather than updating it in the background
* Add a getLogger to the helpers module to easily create named loggers

Differential Revision: https://phabricator.services.mozilla.com/D193138
2023-12-05 23:29:16 +00:00
Nikki Sharpley
0b7ab691d4 Bug 1864505 - Move "Connect another device" button to top of the page of "Tabs from other devices" r=desktop-theme-reviewers,fxview-reviewers,kcochrane
- Moved "footer" to within sticky container above cards and renamed to "header".
- Update "Connect another device" button to use the `.small-button` styling
- Conditionally display `Recently closed tabs` `h2` on the corresponding view only (an existing bug revealed in this patch)
- Update `.sticky-container` to reflect upcoming styling with the inclusion of search and other secondary headers.

Please see link to bug for screenshot of intended appearance.

Differential Revision: https://phabricator.services.mozilla.com/D193930
2023-12-04 17:16:29 +00:00
Jonathan Sudiaman
92467c1a11 Bug 1831142 - Search all Open Tabs r=fxview-reviewers,fluent-reviewers,flod,sclements
Differential Revision: https://phabricator.services.mozilla.com/D194906
2023-12-01 06:26:44 +00:00
Sam Foster
2cd97ee94c Bug 1863783 - Ensure fxview page content only listens/observes and renders updates when visible. r=fxview-reviewers,sclements,jsudiaman
* Add a type=page to the top-level ViewPage instances
* Rename viewTabVisibleCallback and viewTabHiddenCallback to view*Callback and call each when selectedness or visiblity changes
* Ensure active view/pages are always properly initialized during page load and category switching
* Add a test to verify no mutations happen when tabs change while firefox view is inactive
* Fix tests to better account for loading and readiness sequence when activating firefox view

Differential Revision: https://phabricator.services.mozilla.com/D193744
2023-11-23 07:57:33 +00:00
Sam Foster
6e6ac6197e Bug 1852622 - Track a lastSetActive property on each tab and use that when sorting open tabs for recency in firefox view. r=jsudiaman,Gijs,fxview-reviewers,tabbrowser-reviewers,mak,sclements
Differential Revision: https://phabricator.services.mozilla.com/D189444
2023-10-05 23:44:57 +00:00
Sarah Clements
746e764f2c Bug 1833669 - Add telemetry for open tabs r=fxview-reviewers,kcochrane
* Add events to new context menu items and open tab clicks

Differential Revision: https://phabricator.services.mozilla.com/D188962
2023-09-26 12:40:46 +00:00
Jules Simplicio
cf45a952a0 Bug 1854930 - Apply heading large styles to Firefox View's h2 r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189147
2023-09-25 19:48:16 +00:00
Kelly Cochrane
5f4040f3b7 Bug 1852148 - Switch Open Tabs card layout to 2 columns on narrow viewports in Firefox View r=jsudiaman,desktop-theme-reviewers,fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D188876
2023-09-23 16:36:31 +00:00
Cristian Tuns
36a0e62e44 Backed out changeset f6ecdc6c2215 (bug 1852148) for causing mochitest failures in test_opentabs.html CLOSED TREE 2023-09-22 21:11:50 -04:00
Kelly Cochrane
ba0fca5c2e Bug 1852148 - Switch Open Tabs card layout to 2 columns on narrow viewports in Firefox View r=jsudiaman,desktop-theme-reviewers,fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D188876
2023-09-22 22:50:07 +00:00
Sarah Clements
24889f6a8c Bug 1845333 - Add submenu items to open tabs more menu r=mstriemer,fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,reusable-components-reviewers,sfoster,flod,tgiles
* Modify panel-list and panel-item to support submenu list items
* Add submenu items for Move Tabs and Send Tabs to Devices to open tabs
* Add test coverage for submenu items in open tabs

Differential Revision: https://phabricator.services.mozilla.com/D186471
2023-09-21 07:31:44 +00:00
Iulian Moraru
13c034b936 Backed out changeset 424ebf6979de (bug 1845333) for causing mochitest-chrome failures on test_opentabs.html. CLOSED TREE 2023-09-20 21:49:00 +03:00
Sarah Clements
ec86095ac6 Bug 1845333 - Add submenu items to open tabs more menu r=mstriemer,fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,reusable-components-reviewers,sfoster,flod,tgiles
* Modify panel-list and panel-item to support submenu list items
* Add submenu items for Move Tabs and Send Tabs to Devices to open tabs
* Add test coverage for submenu items in open tabs

Differential Revision: https://phabricator.services.mozilla.com/D186471
2023-09-20 16:14:58 +00:00
Noemi Erli
cbb5f1e1ac Backed out changeset 36af6059cb2b (bug 1845333) for causing failures in browser_opentabs_firefoxview_next.js CLOSED TREE 2023-09-20 16:09:51 +03:00
Sarah Clements
927ae3c0b9 Bug 1845333 - Add submenu items to open tabs more menu r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,sfoster,flod
* Modify panel-list and panel-item to support submenu list items
* Add submenu items for Move Tabs and Send Tabs to Devices to open tabs
* Add test coverage for submenu items in open tabs

Differential Revision: https://phabricator.services.mozilla.com/D186471
2023-09-20 11:25:44 +00:00
Kelly Cochrane
368a50bd94 Bug 1833658 - Add Telemetry for Recent Browsing r=fxview-reviewers,jsudiaman,sclements
Differential Revision: https://phabricator.services.mozilla.com/D187676
2023-09-13 13:06:50 +00:00
Kelly Cochrane
fb90089531 Bug 1846255 - Fix tab key navigation for 'Show more' link in Open Tabs cards r=jsudiaman,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D187123
2023-09-05 15:39:05 +00:00
Stanca Serban
405e022d17 Backed out changeset 798de3f71896 (bug 1846255) for causing OSX mochitests failures in test_opentabs.html. CLOSED TREE 2023-09-05 18:20:21 +03:00
Kelly Cochrane
07e4af33f2 Bug 1846255 - Fix tab key navigation for 'Show more' link in Open Tabs cards r=jsudiaman,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D187123
2023-09-05 14:23:23 +00:00
Mike Kaply
0689b04be0 Bug 1846243 - Private windows should only have their own tabs in open tabs. r=jsudiaman,fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D186370
2023-08-30 20:52:54 +00:00
Kelly Cochrane
93d1e7e4c7 Bug 1842616 - Add telemetry for Recently Closed tabs r=mkaply,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D186190
2023-08-18 16:06:33 +00:00
Sarah Clements
624c9599b0 Bug 1831141 - Add more menu to open tabs r=fxview-reviewers,fluent-reviewers,flod,kcochrane
* Add more menu with a subset of menu items, more to come
* Change fluent strings to include url on hover

Differential Revision: https://phabricator.services.mozilla.com/D184612
2023-08-14 13:50:17 +00:00
Mike Kaply
1981bb9d4c Bug 1846597 - Use proper semantic styling for headers in view. r=jsudiaman,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185612
2023-08-11 14:03:36 +00:00
Kelly Cochrane
d7740874a5 Bug 1846545 - Update card-container to use 'pageName' and 'showViewAll' properties r=mkaply,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D185852
2023-08-10 17:00:16 +00:00
Mike Kaply
e911d9a8a7 Bug 1845218 - Pass -1 as maxTabsLength so all tabs are displayed. r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D184952
2023-07-31 19:38:52 +00:00
Mark Banner
6fe765f7ca Bug 1845079 - Update more consumers to import ES modules directly. r=arai,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D184371
2023-07-24 15:32:45 +00:00
Kelly Cochrane
a253f7e7f1 Bug 1824826 - Implement view of History and sticky header/navigation in next iteration of Firefox View r=mkaply,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D180135
2023-06-29 19:12:25 +00:00
Stanca Serban
fabab5d108 Backed out changeset 33c08027f6aa (bug 1824826) for causing mochitests failures in test_history.html. CLOSED TREE 2023-06-29 07:04:25 +03:00
Kelly Cochrane
2b807cde68 Bug 1824826 - Implement view of History and sticky header/navigation in next iteration of Firefox View r=mkaply,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D180135
2023-06-28 20:14:59 +00:00
Iulian Moraru
c7ac902e0c Backed out changeset a4e3a2f3ce1b (bug 1824826) for causing bc failures on browser_all_files_referenced.js. 2023-06-27 22:26:39 +03:00
Kelly Cochrane
9c4465339a Bug 1824826 - Implement view of History and sticky header/navigation in next iteration of Firefox View r=mkaply,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D180135
2023-06-27 15:59:37 +00:00
Kelly Cochrane
b9ff8580a5 Bug 1840377 - Add reusable empty state component for Firefox View r=mkaply,desktop-theme-reviewers,fxview-reviewers,dao,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D182010
2023-06-26 19:12:19 +00:00
Jonathan Sudiaman
d87c046ac4 Bug 1831118 - Open tabs additional functionality r=kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D181644
2023-06-23 11:59:45 +00:00
Jonathan Sudiaman
e1208b882a Bug 1826600 - Add Open Tabs page r=fluent-reviewers,flod,dao
Initial open tabs implementation in Firefox View Next. Note that this only lists out the open tabs. It does not yet provide the ability to switch to an open tab or window. See bug description for a full list of expected behaviors.

[[ https://bugzilla.mozilla.org/attachment.cgi?id=9324749&action=diff | This patch ]] from @mkaply was used as a starting point.

https://treeherder.mozilla.org/jobs?repo=try&revision=789cd12b31cc76c4f9532560fd10727af6b264d5

Differential Revision: https://phabricator.services.mozilla.com/D178970
2023-06-14 17:39:06 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Mike Kaply
62b989c003 Bug 1824438 - Implement a module system for Firefox View. r=kcochrane,jsudiaman,fxview-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D175794
2023-05-12 18:39:12 +00:00
Stanca Serban
c4c8369901 Backed out changeset 41155ff2690b (bug 1824438) for Firefox View related build bustages. CLOSED TREE 2023-05-12 18:26:47 +03:00