nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
870023 commits 1 branch 98 tags 6.4 GiB
Commit graph

55 commits

Author SHA1 Message Date
Natalia Csoregi
5fd68dd6cb Backed out changeset c6a30d94edf2 (bug 1867644) for causing failures on browser_screenshots_drag_test.js. CLOSED TREE 2024-01-19 03:46:03 +02:00
Niklas Baumgardner
0c9ea25838 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-19 00:07:46 +00:00
Iulian Moraru
c2befb5de7 Backed out changeset 2b70f662a797 (bug 1867644) for causing bc failures on browser_overlay_keyboard_test.js. CLOSED TREE 2024-01-18 22:14:11 +02:00
Niklas Baumgardner
fbd83453f3 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-18 17:47:54 +00:00
Niklas Baumgardner
8537612432 Bug 1873977 - Reset hover element region when retrying screenshot. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D198202
 2024-01-17 16:17:42 +00:00
Niklas Baumgardner
6fedd4b29e Bug 1873882 - Canceling screenshots selected state should go to crosshairs state. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D198468
 2024-01-17 01:18:08 +00:00
Niklas Baumgardner
10e944bf30 Bug 1872764 - Screenshots should always get events. r=sfoster,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D197802
 2024-01-12 02:24:43 +00:00
Niklas Baumgardner
d4aaf4bd0c Bug 1801954 - Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D192109
 2023-12-01 16:07:25 +00:00
Stanca Serban
7b0cb90122 Backed out changeset 87051213c0bc (bug 1801954) for causing mochitests failures in browser_overlay_keyboard_test.js and on OSX. CLOSED TREE 2023-12-01 03:44:32 +02:00
Niklas Baumgardner
9d29449b10 Bug 1801954 - Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D192109
 2023-11-30 22:11:53 +00:00
Niklas Baumgardner
9c82fcdb22 Bug 1864889 - Only allow left mouse button on screenshots overlay. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D193680
 2023-11-28 02:33:17 +00:00
Niklas Baumgardner
31d21cfa94 Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-14 15:57:46 +00:00
Norisz Fay
ba48d1612a Backed out changeset 9ec09eb75c9f (bug 1842037) for causing bc failures on browser_screenshots_drag_test.js CLOSED TREE 2023-11-14 04:06:58 +02:00
Niklas Baumgardner
cf3a00db17 Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-13 23:57:17 +00:00
Niklas Baumgardner
5dbfeaed58 Bug 1859882 - Make sure screenshots overlay isn't bigger than document. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191349
 2023-11-02 18:06:38 +00:00
Norisz Fay
3a022002da Backed out changeset 80cec114b8a6 (bug 1859882) for causing bc failures on browser_screenshots_telemetry_tests.js 2023-11-01 18:00:54 +02:00
Niklas Baumgardner
a5dd2648f5 Bug 1859882 - Make sure screenshots overlay isn't bigger than document. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191349
 2023-11-01 15:06:22 +00:00
Niklas Baumgardner
9e9cc7579b Bug 1855313 - Show current selection size in screenshots overlay. r=sfoster,fluent-reviewers,desktop-theme-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D189312
 2023-10-20 23:25:37 +00:00
Niklas Baumgardner
bce29cb41b Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D190491
 2023-10-19 02:11:48 +00:00
Cosmin Sabou
4d7de2f1be Backed out changeset 08bb959c7dca (Bug 1857946) for being partially backed out by merge back commit. 2023-10-19 07:47:11 +03:00
Niklas Baumgardner
523be3ce49 Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D190491
 2023-10-19 02:11:48 +00:00
Emilio Cobos Álvarez
8276ff85e5 Bug 1858752 - Simplify screenshots component markup. r=niklas 
This doesn't fix the issue at hand, but makes stuff easier to reason about.

Differential Revision: https://phabricator.services.mozilla.com/D191137
 2023-10-17 17:24:22 +00:00
Emilio Cobos Álvarez
d9cac16a84 Bug 1859058 - Fix button position after showing them on both sides. r=niklas 
Drive-by, but I noticed it while poking so might as well fix it.

Depends on D191138

Differential Revision: https://phabricator.services.mozilla.com/D191139
 2023-10-17 14:49:22 +00:00
Sam Foster
8165b4bf88 Bug 1845796 - Rework the flow in ScreenshotsUtils to make exit an explicit outcome rather than a side-effect. r=niklas 
* Add a UIPhases / getUIPhase to figure out where we are in the flow, and get the UI into the right state
* Refactor to get rid of a bunch of implicit side-effects:
  - Separate out getting the panel from creating it
  - closePanel only closes the buttons panel
  - Add a closeOverlay so we do that and only that when needed
* When the preview dialog closes, we expect to exit unless exitOnPreviewClose was set false
* Keep some state for each browser using a weakmap so we can better handle re-entry (and later, re-focusing)

Differential Revision: https://phabricator.services.mozilla.com/D185379
 2023-09-19 00:14:27 +00:00
Niklas Baumgardner
9ab7b37e1c Bug 1844171 - Refactor screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183313
 2023-07-27 16:15:02 +00:00
Sebastian Hengst
92e3e4e7e5 Backed out 2 changesets (bug 1844171) for causing mochitest failures on browser_quickactions.js. Complete backout. CLOSED TREE 
Backed out changeset 2989a10ac4e6 (bug 1844171)
Backed out changeset 9bc360cfb992 (bug 1844171)
 2023-07-26 21:24:18 +02:00
Norisz Fay
b6a33dbfc8 Backed out 2 changesets (bug 1844171) for causing mochitest failures on browser_quickactions.js CLOSED TREE 
Backed out changeset 2989a10ac4e6 (bug 1844171)
Backed out changeset 9bc360cfb992 (bug 1844171)
 2023-07-26 21:58:58 +03:00
Gregory Pappas
3eac12bbd7 Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184481
 2023-07-26 16:28:11 +00:00
Niklas Baumgardner
4b0d1b06cc Bug 1844171 - Refactor screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183313
 2023-07-26 15:37:45 +00:00
Emilio Cobos Álvarez
bd1b363ff9 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
 2023-07-09 11:34:05 +00:00
Stanca Serban
15c8455338 Backed out changeset 1c835137f532 (bug 1824886) for causing multiple failures. CLOSED TREE 2023-07-06 02:11:59 +03:00
Emilio Cobos Álvarez
3338831b84 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
 2023-07-05 21:59:44 +00:00
Cosmin Sabou
fb92d5f42f Backed out 2 changesets (bug 1824886) for causing failures on browser_all_files_referenced.js. CLOSED TREE 
Backed out changeset 650ef77d1c4d (bug 1824886)
Backed out changeset 1c835137f532 (bug 1824886)
 2023-07-06 00:42:53 +03:00
Emilio Cobos Álvarez
454c0b932e Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
 2023-07-05 18:21:31 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Niklas Baumgardner
cb1468a860 Bug 1824430 - Update screenshots buttons styling. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D173708
 2023-03-30 15:30:21 +00:00
Iulian Moraru
7b8409fc77 Backed out 2 changesets (bug 1824430, bug 1812631) for causing multiple mochitest failures. CLOSED TREE 
Backed out changeset 500e6e1d7092 (bug 1824430)
Backed out changeset 6d0d5de3be6e (bug 1812631)
 2023-03-30 04:44:53 +03:00
Niklas Baumgardner
b5b1a040f1 Bug 1824430 - Update screenshots buttons styling. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D173708
 2023-03-30 00:36:32 +00:00
Niklas Baumgardner
190d1e4964 Bug 1811953 - Scroll when resizing near the edge. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D167614
 2023-03-22 21:02:49 +00:00
Niklas Baumgardner
56c696e37f Bug 1813394 - Updated screenshots overlay shrinks with window. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D168315
 2023-03-14 17:23:53 +00:00
Stanca Serban
cdaf1de237 Backed out changeset 47a62f76fe40 (bug 1813394) for causing mochitests failures in browser_screenshots_drag_test.js. 2023-03-08 17:37:43 +02:00
Niklas Baumgardner
0fd7834bac Bug 1813394 - Updated screenshots overlay shrinks with window. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D168315
 2023-03-07 21:25:10 +00:00
Noemi Erli
93ca893555 Backed out changeset a33c121cae89 (bug 1813394) for causing failures in browser_screenshots_test_downloads.js CLOSED TREE 2023-03-07 00:27:21 +02:00
Niklas Baumgardner
d57de84fe6 Bug 1813394 - Updated screenshots overlay shrinks with window. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D168315
 2023-03-06 21:23:27 +00:00
Niklas Baumgardner
c057486ca0 Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-25 17:26:34 +00:00
Marian-Vasile Laza
5a3faecdb0 Backed out changeset d853ddfd853e (bug 1801019) for bc failures on browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-23 21:11:16 +02:00
Niklas Baumgardner
26e4c6bc8a Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-23 17:37:01 +00:00
Butkovits Atila
f8a9ce74db Backed out changeset aaf82d1483ad (bug 1801019) for causing failures at browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-21 23:04:05 +02:00
Niklas Baumgardner
ab7aa855c8 Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-21 19:59:09 +00:00
Niklas Baumgardner
f50ece2128 Bug 1799215 - Screenshots overlay buttons should have focus states. r=cmkm 
Differential Revision: https://phabricator.services.mozilla.com/D167583
 2023-01-31 16:20:48 +00:00