Commit graph

77 commits

Author SHA1 Message Date
Bevis Tseng
95b18d794e Bug 1382172 - Name nsITimerCallback instances in native implementation. r=billm
--HG--
extra : rebase_source : 84de1abfcc30a6964144c2e6718a508c71027b65
2017-07-27 02:18:20 +08:00
Sylvestre Ledru
4e9cf83ee8 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG

--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Marco Bonardo
2710c1ba7f Bug 1370518 - Don't completely detach/attach the autocomplete controller on TabSelect. r=mconley
Due to recent changes to tabbrowser focus behavior, now the "focus" event to the location bar
happens before the "TabSelect" event. On "focus" we would like to open the location bar popup,
but detaching the controller would immediately close it. Thus we don't want "TabSelect" to
detach the controller just to reset its internal state. Moreover, this should be cheaper.

MozReview-Commit-ID: 5NZ1TTI9NFW

--HG--
extra : rebase_source : 48e5e755c304f3963f328da06ca300e98304f38d
2017-06-06 18:47:19 +02:00
Marco Bonardo
3be38fff9a Bug 1368074 - Autocomplete popup is not re-opened when repeating the same search in a new tab. r=mconley
MozReview-Commit-ID: GSZoWFgw0X8

--HG--
extra : rebase_source : a9601dee7f20e4fdeb536f28853f344cd84cbcd1
2017-05-30 17:28:34 +02:00
Marco Bonardo
6fba552346 Bug 1304501 - Properly disable trimUrl on autofill. r=adw
MozReview-Commit-ID: IxCOWkqFYV0

--HG--
extra : rebase_source : f6519c6f245199db550e2d999931c65154d38427
2016-09-21 21:55:00 +02:00
Marco Bonardo
ababc57dbb Bug 1306639 - Searching in locationbar by typing something and pressing enter is not accounted in telemetry. r=adw
MozReview-Commit-ID: 9r8IyyyxruC

--HG--
extra : rebase_source : 039983cca262164bfc004e05bf77dc8ced0b1f29
2016-10-06 17:40:13 +02:00
Marco Bonardo
4df7f64a07 Bug 1303624 - Remove typeAheadResult support from autocomplete. r=adw
MozReview-Commit-ID: 7XLTON1Rj96

--HG--
extra : rebase_source : e024f2321cbae1433d5a1f8d524a58291f654a9f
2016-09-21 18:11:45 +02:00
Marco Bonardo
9c0acc7b35 Bug 1302472 - keyboard selected value in autocomplete popup cannot be confirmed with <enter> if completedefaultindex is true but completeselectedindex is false. r=adw
MozReview-Commit-ID: FR4pKGZLAl2

--HG--
extra : rebase_source : 478155aa8ec4f41f6c81592f0b2872fa2882f6e7
2016-09-17 14:03:37 +02:00
Marco Bonardo
6c9f104521 Bug 1301093 - Part 3: fix delayed handleEnter regression. r=adw
MozReview-Commit-ID: 1SZeMUtLjNg

--HG--
extra : rebase_source : 7b544bfe695cd6c3a19326c71cf603b265213963
2016-09-13 09:35:00 +02:00
Marco Bonardo
95dbb8627b Bug 1301093 - Part 1: don't wait for a result when we won't get one. r=adw
MozReview-Commit-ID: E6l9mW3ZoKp

--HG--
extra : rebase_source : 39144a190f27257b190178308b26fa3f7bea15a2
2016-09-07 17:44:46 +02:00
Marco Bonardo
ace6c4d3d7 Bug 1292310 - Enter may wrongly confirm a mouse selected entry in the urlbar. r=adw
MozReview-Commit-ID: 6teMoPr1vb6

--HG--
extra : rebase_source : 624e1bb088de142868e78b50c81df12612095025
2016-09-06 17:55:56 +02:00
Yoshi Huang
8c13a9fd49 Bug 1244340 - Part 3: pass userContextId to search suggestions r=mak 2016-08-26 18:59:00 +08:00
Drew Willcoxon
55ab8f47c3 Bug 1180944 - Implement one-off searches from Awesomebar. r=mak,florian
MozReview-Commit-ID: A9YXB32L7MN
2016-08-02 18:00:26 -07:00
Nicholas Nethercote
916e86a26e Bug 1257128 (part 4) - Remove unused nsIAtomService references in toolkit/. r=froydnj. 2016-03-16 21:11:10 +11:00
Drew Willcoxon
9c91646152 Bug 1236364 - Don't reuse existing richlistitem in urlbar when handling a delete. r=mak 2016-01-25 10:13:26 -08:00
Marco Bonardo
5903f88256 Bug 1234186 - Unified autocompletion Visit feature doesn't use https for https-only websites. r=adw
--HG--
extra : commitid : AVhL5Xx9aN7
extra : rebase_source : 27d68c51870c104fff2fe31092be391a12408fdf
2016-01-19 00:39:57 +01:00
Drew Willcoxon
f47dc136b4 Bug 1182783 - Restore search string and selection when selecting an autofilled urlbar popup result. r=mak 2015-12-15 17:08:41 -08:00
Marco Bonardo
2cb37ef1e6 Bug 720589 - mMatchCounts may be accessed with a nonexisting index. r=neil 2015-11-10 20:18:24 +01:00
Marco Bonardo
19e86a8419 Bug 1172937 - Action row doesn't always update correctly with unified autocomplete. r=adw
Original patch by Felipe Gomes <felipc@gmail.com>

--HG--
extra : commitid : Cen9r3nQixn
2015-07-30 16:54:27 +02:00
Ryan VanderMeulen
5a0dad74c7 Backed out changeset 91b6fe481685 (bug 1172937) for test_autocomplete_with_composition_on_input.html failures. 2015-07-30 12:45:03 -04:00
Marco Bonardo
d2d3c3a83b Bug 1172937 - Action row doesn't always update correctly with unified autocomplete. r=adw
Original patch by Felipe Gomes <felipc@gmail.com>

--HG--
extra : commitid : 9zGMBGXYqlm
2015-07-30 16:54:27 +02:00
Matt Brubeck
c462f70f94 Bug 1185183 - Don't replace edited URL value with old completed value [r=mak] 2015-07-27 17:58:58 -07:00
Magnus Melin
ee6b010108 Bug 1130858 - Recipient autocomplete suggestion overrides ANY manual address input if quickly entered/pasted and confirmed with Enter/Tab before autocomplete suggestions disappear. r=mak
--HG--
extra : rebase_source : acc6290ed31c40cf83f467e86c5bb83d73c60915
2015-07-15 16:21:52 +03:00
Matthew Noorenberghe
9bdaefa259 Bug 998893 - Update the autocomplete search string when pressing DOM_VK_DOWN to initiate a search. r=mak
Some script may have changed the value of the text field since our last keypress or after our focus handler and we don't want to search for a stale string.

--HG--
extra : rebase_source : de4dab916dc1abdcd5d9293891a7903f360e884b
2015-05-06 11:23:51 -07:00
Tim Taubert
caebf28f30 Bug 1042561 - Iterate a copy of mSearches in StartSearch() so that an observer can't modify the array we're iterating r=mak 2015-03-23 08:33:53 +01:00
Tim Taubert
879cec2f51 Bug 1042561 - Correct autocomplete search result update handling in OnUpdateSearchResult() r=mak 2015-03-22 13:26:09 +01:00
Jorg K
6cb48726c1 Bug 1042561 - Autocomplete: Typed text in red despite results/matches found if suggestions change by last input r=mak 2015-03-22 13:25:42 +01:00
Carsten "Tomcat" Book
cb5b2490cb backed out changeset b798fd098e09 (bug 1042561) for assertion failure in mochitests 2015-03-20 13:32:28 +01:00
Carsten "Tomcat" Book
c150e8dbed Backed out changeset ef86c7c53d21 (bug 1042561) 2015-03-20 13:32:01 +01:00
Tim Taubert
6b0e509bcd Bug 1042561 - Correct autocomplete search result update handling in OnUpdateSearchResult() r=mak 2015-03-20 11:15:40 +01:00
Jorg K
79075a61e1 Bug 1042561 - Autocomplete: Typed text in red despite results/matches found if suggestions change by last input r=mak 2015-03-20 11:18:07 +01:00
Neil Deakin
4be3ac5710 Bug 1131685, don't have the selection in the list interfere with caret movement in the search field, r=mak 2015-02-26 09:14:19 -05:00
Neil Deakin
c891137718 Bug 1114707, don't close search suggestions when the caret is moved when norolluponanchor is set, r=mak 2015-02-02 15:53:55 -05:00
Magnus Melin
8144f3fdb5 Bug 1114011 - for autocomplete with for minresultsforpopup > 1: entering match doesn't work properly. r=mak 2015-01-10 13:48:24 +02:00
Magnus Melin
2c74c92e3b Bug 1043310 - AutoCompletion doesn't take capitalization from address book entry, can leave angle brackets characters >> in field, when loosing focus by clicking outside (not enter/tab). r=mak
The fix has two aspects:
 - for onblur we need to complete to the actual suggestion not to leave addresses uncapitalized or having " >> " as value
 - once we have a valid selection that should not be changed to default because EnterMatch is called again (which it is with blur if the value was confirmed by enter, or mouse selection already)
2015-01-10 13:48:23 +02:00
Gijs Kruitbosch
4a1b5156d6 Bug 1043584 - fix mouseover vs. enter issue in the urlbar, r=mak
--HG--
extra : rebase_source : a44d3e897a6ae930119fff45b6babc7a0ad8bcbb
2014-12-02 15:52:26 -08:00
Julian Viereck
702e34d250 Bug 950797 - Use result from last completion in nsAutoCompleteController to reduce autoFill UI flickering until search results come back. r=mak 2014-09-30 04:14:49 -07:00
Marco Bonardo
2cd37b93c5 Bug 1059846 - Search engine may autofill in-the-middle. r=ttaubert 2014-09-11 17:37:08 +02:00
Marco Bonardo
f4a9dae6da Bug 433788 - Crash in [@ nsAutoCompleteController::ClosePopup] due to re-entrancy. r=Enn 2014-07-30 16:55:47 +02:00
Birunthan Mohanathas
5f1fde8824 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Marco Bonardo
5ac6d5ccbe Bug 754265 - Add a dedicated API to provide a final complete value different from the matching one, r=Enn sr=gavin 2014-04-18 16:04:19 +02:00
Ehsan Akhgari
1b83407ce9 Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc
This patch was automatically generated by the following script:

#!/bin/bash
# Command to convert PRUnichar to char16_t

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*modules/libmar*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name prtypes.h \
       ! -name Char16.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRUnichar char16_t
2014-01-04 10:02:17 -05:00
Birunthan Mohanathas
9deb678652 Bug 784739 - Switch from NULL to nullptr in toolkit/components/ (2/2); r=ehsan 2013-10-10 16:38:19 -04:00
Ehsan Akhgari
5fa3a6a984 Bug 919326 - Minimize the #includes in layout/ IDL files; r=roc
--HG--
extra : rebase_source : ec8cdff9466ff75463841818537ecead2cb57e62
2013-09-22 19:24:27 -04:00
Mike Hommey
2e729aa83d Bug 881323 - Re-implement CycleCollectorParticipant with actual vtables, with constexpr to avoid static initializers. r=mccr8 2013-08-02 10:29:05 +09:00
Trevor Saunders
254bffb739 bug 407956 - make nsITreeView not take a nsISupportsArray* r=neil, bz sr=neil 2013-01-06 19:54:42 -05:00
Daniel Holbert
509d856ac8 Bug 838301: Use nsCOMArray::Length() instead of Count() in nsAutoCompleteController.cpp, where appropriate. r=mounir 2013-02-06 07:40:55 -08:00
Daniel Holbert
921b6093ca Bug 836345: Cast nsCOMArray::Count()'s result to uint32 in nsAutoCompleteController.cpp, to fix signed/unsigned comparison build warnings. r=mounir 2013-01-31 14:40:04 -08:00
Brian R. Bondy
40997b056e Bug 823990 - Autocomplete results should not disappear for no results when minResults == 0. r=mak 2013-01-30 13:17:38 -05:00
Trevor Saunders
83bcbe0d6b bug 822289 - remove NS_IMPL_CYCLE_COLLECTION_CLASS and friends r=mccr8 2013-01-12 07:40:33 -05:00